162581 2016-09-26 15:37:07 -0700 ASSERTION FAILED: result 2016-09-27 10:35:45 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad ryanhaddad ap commit-queue joepeck webkit-bug-importer oldest_to_newest 1233621 0 ryanhaddad 2016-09-26 15:37:07 -0700 OpenSource/Source/WebCore/inspector/InspectorOverlay.cpp(927) : void WebCore::evaluateCommandInOverlay(WebCore::Page *, Ref<Inspector::InspectorArray> &&) 1 0x110ef9b30 WTFCrash 2 0x117019c6b WebCore::evaluateCommandInOverlay(WebCore::Page*, WTF::Ref<Inspector::InspectorArray>&&) 3 0x117019ad4 WebCore::InspectorOverlay::evaluateInOverlay(WTF::String const&, WTF::String const&) 4 0x117016d74 WebCore::InspectorOverlay::overlayPage() 5 0x11701723b WebCore::InspectorOverlay::update() 6 0x117017575 WebCore::InspectorOverlay::highlightNode(WebCore::Node*, WebCore::HighlightConfig const&) 7 0x116fb876a WebCore::InspectorDOMAgent::highlightNode(WTF::String&, Inspector::InspectorObject const&, int const*, WTF::String const*) 8 0x116fb8922 non-virtual thunk to WebCore::InspectorDOMAgent::highlightNode(WTF::String&, Inspector::InspectorObject const&, int const*, WTF::String const*) 9 0x1107a91d4 Inspector::DOMBackendDispatcher::highlightNode(long, WTF::RefPtr<Inspector::InspectorObject>&&) 10 0x1107a3bd6 Inspector::DOMBackendDispatcher::dispatch(long, WTF::String const&, WTF::Ref<Inspector::InspectorObject>&&) 11 0x11078fcf2 Inspector::BackendDispatcher::dispatch(WTF::String const&) 12 0x116f715cf WebCore::InspectorController::dispatchMessageFromFrontend(WTF::String const&) 13 0x116fdd812 WebCore::InspectorBackendDispatchTask::timerFired() 14 0x116fdf298 void std::__1::__invoke_void_return_wrapper<void>::__call<std::__1::__bind<void (WebCore::InspectorBackendDispatchTask::*&)(), WebCore::InspectorBackendDispatchTask*>&>(std::__1::__bind<void (WebCore::InspectorBackendDispatchTask::*&)(), WebCore::InspectorBackendDispatchTask*>&&&) 15 0x116fdf16c std::__1::__function::__func<std::__1::__bind<void (WebCore::InspectorBackendDispatchTask::*&)(), WebCore::InspectorBackendDispatchTask*>, std::__1::allocator<std::__1::__bind<void (WebCore::InspectorBackendDispatchTask::*&)(), WebCore::InspectorBackendDispatchTask*> >, void ()>::operator()() 16 0x116092faa std::__1::function<void ()>::operator()() const 17 0x116092ebc WebCore::Timer::fired() 18 0x11868e85a WebCore::ThreadTimers::sharedTimerFiredInternal() 19 0x11868faa1 WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0::operator()() const 20 0x11868fa6d void std::__1::__invoke_void_return_wrapper<void>::__call<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0&>(WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0&&&) 21 0x11868fa0c std::__1::__function::__func<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0, std::__1::allocator<WebCore::ThreadTimers::setSharedTimer(WebCore::SharedTimer*)::$_0>, void ()>::operator()() 22 0x116092faa std::__1::function<void ()>::operator()() const 23 0x1179dc17f WebCore::MainThreadSharedTimer::fired() 24 0x1179dc579 WebCore::timerFired(__CFRunLoopTimer*, void*) 25 0x7fffa0eeeb94 __CFRUNLOOP_IS_CALLING_OUT_TO_A_TIMER_CALLBACK_FUNCTION__ 26 0x7fffa0eee823 __CFRunLoopDoTimer 27 0x7fffa0eee37a __CFRunLoopDoTimers 28 0x7fffa0ee5871 __CFRunLoopRun 29 0x7fffa0ee4ed8 CFRunLoopRunSpecific 30 0x10f8a15fc runTest(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) 31 0x10f89fcdd runTestingServerLoop() 1233622 1 ryanhaddad 2016-09-26 15:37:59 -0700 <rdar://problem/28076564> 1233631 2 289883 ryanhaddad 2016-09-26 16:00:23 -0700 Created attachment 289883 Patch 1233632 3 ap 2016-09-26 16:04:05 -0700 I'm concerned that we will be getting the same tests mysteriously fail instead of mysteriously crashing. Is the failure result not a sign of something having gone wrong? 1233637 4 ryanhaddad 2016-09-26 16:12:04 -0700 This fails to build anyway (thanks EWS!). Will wait for Joe to comment. 1233645 5 ap 2016-09-26 16:29:36 -0700 Yes, you should also remove the "JSC::JSValue result = " part. I talked to Joe in person, he still thinks that we should do this. 1233646 6 289890 ryanhaddad 2016-09-26 16:36:57 -0700 Created attachment 289890 Patch Take two. 1233949 7 289890 commit-queue 2016-09-27 10:35:41 -0700 Comment on attachment 289890 Patch Clearing flags on attachment: 289890 Committed r206443: <http://trac.webkit.org/changeset/206443> 1233950 8 commit-queue 2016-09-27 10:35:45 -0700 All reviewed patches have been landed. Closing bug. 289883 2016-09-26 16:00:23 -0700 2016-09-26 16:12:53 -0700 Patch bug-162581-20160926155726.patch text/plain 1711 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDgxMWRmN2NiZjI1OTM2 N2Q2YTI5OWI3ZTcwZTUyNDkwNjAzNWUxMy4uZmEwMWUxZDI5YTdiMzAyZWM4OGIxNjIwYjgyZjQ2 ODhhZmRiZjRmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA5LTI2ICBSeWFu IEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBhbiB1bm5l ZWRlZCBhc3NlcnQgaW4gSW5zcGVjdG9yT3ZlcmxheS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjU4MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYXNzZXJ0aW9uIHdhcyBhZGRlZCB0byBj YXRjaCB1bmtub3duIGlzc3VlcywgYnV0IGl0IGlzIGZpcmluZyBmcmVxdWVudGx5IGVub3VnaCBv biBjZXJ0YWluIEluc3BlY3RvcgorICAgICAgICB0ZXN0cyB0aGF0IGl0IGlzIGNhdXNpbmcgbW9y ZSBoYXJtIHRoYW4gZ29vZC4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkUXVhZE9iamVjdEZvckNTU1JlZ2lvbkNvbnRl bnRDbGlwKToKKyAgICAgICAgKFdlYkNvcmU6OmV2YWx1YXRlQ29tbWFuZEluT3ZlcmxheSk6CisK IDIwMTYtMDktMjYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgU2Vla2luZyB2aWRlbyBkb2Vzbid0IHVwZGF0ZSBzZWVrIHBvc2l0aW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKaW5kZXggODcwNTQ1NDc5 M2FlNzNhZjNlZGM5YzE2MjMyMzVmMjM4YmY0NjQ4NS4uMmNjOGI2MGZjNTllZjIxYzY3ODQ4ODMy ZmVlNzljOWFjZjI2ODNmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3Rvck92ZXJsYXkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JPdmVybGF5LmNwcApAQCAtOTI0LDcgKzkyNCw2IEBAIHZvaWQgSW5zcGVjdG9yT3ZlcmxheTo6 cmVzZXQoY29uc3QgSW50U2l6ZSYgdmlld3BvcnRTaXplLCBjb25zdCBJbnRTaXplJiBmcmFtZVZp CiBzdGF0aWMgdm9pZCBldmFsdWF0ZUNvbW1hbmRJbk92ZXJsYXkoUGFnZSogcGFnZSwgUmVmPElu c3BlY3RvckFycmF5PiYmIGNvbW1hbmQpCiB7CiAgICAgSlNDOjpKU1ZhbHVlIHJlc3VsdCA9IHBh Z2UtPm1haW5GcmFtZSgpLnNjcmlwdCgpLmV2YWx1YXRlKFNjcmlwdFNvdXJjZUNvZGUobWFrZVN0 cmluZygiZGlzcGF0Y2goIiwgY29tbWFuZC0+dG9KU09OU3RyaW5nKCksICcpJykpKTsKLSAgICBB U1NFUlRfVU5VU0VEKHJlc3VsdCwgcmVzdWx0KTsgLy8gVGhlcmUgc2hvdWxkIG5ldmVyIGJlIGV4 Y2VwdGlvbnMgd2hlbiBldmFsdWF0aW5nIGluIHRoZSBvdmVybGF5IHBhZ2UuCiB9CiAKIHZvaWQg SW5zcGVjdG9yT3ZlcmxheTo6ZXZhbHVhdGVJbk92ZXJsYXkoY29uc3QgU3RyaW5nJiBtZXRob2Qp Cg== 289890 2016-09-26 16:36:57 -0700 2016-09-27 10:35:41 -0700 Patch bug-162581-20160926163400.patch text/plain 1828 ryanhaddad U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDgxMWRmN2NiZjI1OTM2 N2Q2YTI5OWI3ZTcwZTUyNDkwNjAzNWUxMy4uZmEwMWUxZDI5YTdiMzAyZWM4OGIxNjIwYjgyZjQ2 ODhhZmRiZjRmZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE2LTA5LTI2ICBSeWFu IEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBhbiB1bm5l ZWRlZCBhc3NlcnQgaW4gSW5zcGVjdG9yT3ZlcmxheS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjU4MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgYXNzZXJ0aW9uIHdhcyBhZGRlZCB0byBj YXRjaCB1bmtub3duIGlzc3VlcywgYnV0IGl0IGlzIGZpcmluZyBmcmVxdWVudGx5IGVub3VnaCBv biBjZXJ0YWluIEluc3BlY3RvcgorICAgICAgICB0ZXN0cyB0aGF0IGl0IGlzIGNhdXNpbmcgbW9y ZSBoYXJtIHRoYW4gZ29vZC4KKworICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JPdmVybGF5 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmJ1aWxkUXVhZE9iamVjdEZvckNTU1JlZ2lvbkNvbnRl bnRDbGlwKToKKyAgICAgICAgKFdlYkNvcmU6OmV2YWx1YXRlQ29tbWFuZEluT3ZlcmxheSk6CisK IDIwMTYtMDktMjYgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAg ICAgICAgU2Vla2luZyB2aWRlbyBkb2Vzbid0IHVwZGF0ZSBzZWVrIHBvc2l0aW9uCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yT3ZlcmxheS5jcHAKaW5kZXggODcwNTQ1NDc5 M2FlNzNhZjNlZGM5YzE2MjMyMzVmMjM4YmY0NjQ4NS4uOGRjNjNiNDZmZmU1YjU2YjRiMzM4ZTcx YjZkMzlmYWQ0NWYzMzJmOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0lu c3BlY3Rvck92ZXJsYXkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JPdmVybGF5LmNwcApAQCAtOTIzLDggKzkyMyw3IEBAIHZvaWQgSW5zcGVjdG9yT3ZlcmxheTo6 cmVzZXQoY29uc3QgSW50U2l6ZSYgdmlld3BvcnRTaXplLCBjb25zdCBJbnRTaXplJiBmcmFtZVZp CiAKIHN0YXRpYyB2b2lkIGV2YWx1YXRlQ29tbWFuZEluT3ZlcmxheShQYWdlKiBwYWdlLCBSZWY8 SW5zcGVjdG9yQXJyYXk+JiYgY29tbWFuZCkKIHsKLSAgICBKU0M6OkpTVmFsdWUgcmVzdWx0ID0g cGFnZS0+bWFpbkZyYW1lKCkuc2NyaXB0KCkuZXZhbHVhdGUoU2NyaXB0U291cmNlQ29kZShtYWtl U3RyaW5nKCJkaXNwYXRjaCgiLCBjb21tYW5kLT50b0pTT05TdHJpbmcoKSwgJyknKSkpOwotICAg IEFTU0VSVF9VTlVTRUQocmVzdWx0LCByZXN1bHQpOyAvLyBUaGVyZSBzaG91bGQgbmV2ZXIgYmUg ZXhjZXB0aW9ucyB3aGVuIGV2YWx1YXRpbmcgaW4gdGhlIG92ZXJsYXkgcGFnZS4KKyAgICBwYWdl LT5tYWluRnJhbWUoKS5zY3JpcHQoKS5ldmFsdWF0ZShTY3JpcHRTb3VyY2VDb2RlKG1ha2VTdHJp bmcoImRpc3BhdGNoKCIsIGNvbW1hbmQtPnRvSlNPTlN0cmluZygpLCAnKScpKSk7CiB9CiAKIHZv aWQgSW5zcGVjdG9yT3ZlcmxheTo6ZXZhbHVhdGVJbk92ZXJsYXkoY29uc3QgU3RyaW5nJiBtZXRo b2QpCg==