162579 2016-09-26 15:06:58 -0700 Add an Option to disable the CodeCache 2016-09-26 19:57:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue ggaren keith_miller mark.lam msaboff saam oldest_to_newest 1233604 0 joepeck 2016-09-26 15:06:58 -0700 Summary: Add an Option to disable the CodeCache Useful when benchmarking to ensure we do more parsing. 1233606 1 289879 joepeck 2016-09-26 15:09:50 -0700 Created attachment 289879 [PATCH] Proposed Fix 1233607 2 289879 joepeck 2016-09-26 15:10:29 -0700 Comment on attachment 289879 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=289879&action=review > Source/JavaScriptCore/ChangeLog:8 > + * runtime/CodeCache.cpp: We could also use this in EvalCodeCache. Let me know if you think we should as well. 1233611 3 289879 ggaren 2016-09-26 15:17:07 -0700 Comment on attachment 289879 [PATCH] Proposed Fix r=me 1233627 4 289879 commit-queue 2016-09-26 15:50:38 -0700 Comment on attachment 289879 [PATCH] Proposed Fix Clearing flags on attachment: 289879 Committed r206400: <http://trac.webkit.org/changeset/206400> 1233628 5 commit-queue 2016-09-26 15:50:43 -0700 All reviewed patches have been landed. Closing bug. 1233700 6 289879 saam 2016-09-26 19:56:12 -0700 Comment on attachment 289879 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=289879&action=review > Source/JavaScriptCore/runtime/Options.h:391 > + v(bool, useCodeCache, true, Normal, "If false, the parser will not use the code cache.") \ Nit: This might be confusing with the word "parser" in it since the parser has its own cache and this cache is on top of the parser. I'd just say: "If false, we won't use the unlinked byte code cache" or something similar. 1233701 7 saam 2016-09-26 19:57:31 -0700 (In reply to comment #2) > Comment on attachment 289879 [details] > [PATCH] Proposed Fix > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289879&action=review > > > Source/JavaScriptCore/ChangeLog:8 > > + * runtime/CodeCache.cpp: > > We could also use this in EvalCodeCache. Let me know if you think we should > as well. They're two different caches. I'd say that if we find an option for the eval code cache useful we can add it in a separate patch. I think it's good to have this option just be for the unlinked code cache. 289879 2016-09-26 15:09:50 -0700 2016-09-26 15:50:38 -0700 [PATCH] Proposed Fix code-cache-1.patch text/plain 3100 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNiMzkxMjUuLmU5OGEwYTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA5LTI2ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIGFuIE9wdGlvbiB0byBkaXNh YmxlIHRoZSBDb2RlQ2FjaGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2MjU3OQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogcnVudGltZS9Db2RlQ2FjaGUuY3BwOgorICAgICAgICAoSlNDOjpDb2RlQ2Fj aGU6OmdldEdsb2JhbENvZGVCbG9jayk6CisgICAgICAgIChKU0M6OkNvZGVDYWNoZTo6Z2V0RnVu Y3Rpb25FeGVjdXRhYmxlRnJvbUdsb2JhbENvZGUpOgorICAgICAgICBEbyBub3QgdXNlIHRoZSBj YWNoZSBpZiB0aGUgT3B0aW9uIGlzIGRpc2FibGVkLgorCisgICAgICAgICogcnVudGltZS9PcHRp b25zLmg6CisgICAgICAgIE5ldyBvcHRpb24gdG8gbm90IHVzZSB0aGUgY29kZSBjYWNoZS4KKwog MjAxNi0wOS0yMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFN0ZXBwaW5nIG91dCBvZiBhIGZ1bmN0aW9uIGZpbmlzaGVzIHRo ZSBsaW5lIHRoYXQgY2FsbGVkIGl0LgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3Jl L3J1bnRpbWUvQ29kZUNhY2hlLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0Nv ZGVDYWNoZS5jcHAKaW5kZXggMGY1Mzc5YS4uNDc1ZmM3NSAxMDA2NDQKLS0tIGEvU291cmNlL0ph dmFTY3JpcHRDb3JlL3J1bnRpbWUvQ29kZUNhY2hlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9Db2RlQ2FjaGUuY3BwCkBAIC05MCw3ICs5MCw3IEBAIFVubGlua2VkQ29k ZUJsb2NrVHlwZSogQ29kZUNhY2hlOjpnZXRHbG9iYWxDb2RlQmxvY2soVk0mIHZtLCBFeGVjdXRh YmxlVHlwZSogZXhlCiAgICAgLy8gRklYTUU6IFdlIHNob3VsZCBkbyBzb21ldGhpbmcgc21hcnQg Zm9yIFREWiBpbnN0ZWFkIG9mIGp1c3QgZGlzYWJsaW5nIGNhY2hpbmcuCiAgICAgLy8gaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE1NDAxMAogICAgIGJvb2wgY2FuQ2Fj aGUgPSBkZWJ1Z2dlck1vZGUgPT0gRGVidWdnZXJPZmYgJiYgIXZtLnR5cGVQcm9maWxlcigpICYm ICF2bS5jb250cm9sRmxvd1Byb2ZpbGVyKCkgJiYgIXZhcmlhYmxlc1VuZGVyVERaLT5zaXplKCk7 Ci0gICAgaWYgKGNhY2hlICYmIGNhbkNhY2hlKSB7CisgICAgaWYgKGNhY2hlICYmIGNhbkNhY2hl ICYmIE9wdGlvbnM6OnVzZUNvZGVDYWNoZSgpKSB7CiAgICAgICAgIFVubGlua2VkQ29kZUJsb2Nr VHlwZSogdW5saW5rZWRDb2RlQmxvY2sgPSBqc0Nhc3Q8VW5saW5rZWRDb2RlQmxvY2tUeXBlKj4o Y2FjaGUtPmNlbGwuZ2V0KCkpOwogICAgICAgICB1bnNpZ25lZCBmaXJzdExpbmUgPSBzb3VyY2Uu Zmlyc3RMaW5lKCkgKyB1bmxpbmtlZENvZGVCbG9jay0+Zmlyc3RMaW5lKCk7CiAgICAgICAgIHVu c2lnbmVkIGxpbmVDb3VudCA9IHVubGlua2VkQ29kZUJsb2NrLT5saW5lQ291bnQoKTsKQEAgLTE2 Myw3ICsxNjMsNyBAQCBVbmxpbmtlZEZ1bmN0aW9uRXhlY3V0YWJsZSogQ29kZUNhY2hlOjpnZXRG dW5jdGlvbkV4ZWN1dGFibGVGcm9tR2xvYmFsQ29kZShWTSYgdgogICAgICAgICBFdmFsQ29udGV4 dFR5cGU6Ok5vbmUsCiAgICAgICAgIGlzQXJyb3dGdW5jdGlvbkNvbnRleHQpOwogICAgIFNvdXJj ZUNvZGVWYWx1ZSogY2FjaGUgPSBtX3NvdXJjZUNvZGUuZmluZENhY2hlQW5kVXBkYXRlQWdlKGtl eSk7Ci0gICAgaWYgKGNhY2hlKSB7CisgICAgaWYgKGNhY2hlICYmIE9wdGlvbnM6OnVzZUNvZGVD YWNoZSgpKSB7CiAgICAgICAgIFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlKiBleGVjdXRhYmxl ID0ganNDYXN0PFVubGlua2VkRnVuY3Rpb25FeGVjdXRhYmxlKj4oY2FjaGUtPmNlbGwuZ2V0KCkp OwogICAgICAgICBzb3VyY2UucHJvdmlkZXIoKS0+c2V0U291cmNlVVJMRGlyZWN0aXZlKGV4ZWN1 dGFibGUtPnNvdXJjZVVSTERpcmVjdGl2ZSgpKTsKICAgICAgICAgc291cmNlLnByb3ZpZGVyKCkt PnNldFNvdXJjZU1hcHBpbmdVUkxEaXJlY3RpdmUoZXhlY3V0YWJsZS0+c291cmNlTWFwcGluZ1VS TERpcmVjdGl2ZSgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L09wdGlvbnMuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAppbmRl eCAwMGYwYjQ0Li43NjRmMWNlIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zLmgKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9u cy5oCkBAIC0zODgsNiArMzg4LDcgQEAgdHlwZWRlZiBjb25zdCBjaGFyKiBvcHRpb25TdHJpbmc7 CiAgICAgdihvcHRpb25TdHJpbmcsIGxsaW50U3RhdHNGaWxlLCBudWxscHRyLCBDb25maWd1cmFi bGUsICJGaWxlIHRvIGNvbGxlY3QgTExJbnQgc3RhdGlzdGljcyBpbiIpIFwKICAgICBcCiAgICAg dihib29sLCB1c2VTb3VyY2VQcm92aWRlckNhY2hlLCB0cnVlLCBOb3JtYWwsICJJZiBmYWxzZSwg dGhlIHBhcnNlciB3aWxsIG5vdCB1c2UgdGhlIHNvdXJjZSBwcm92aWRlciBjYWNoZS4gSXQncyBn b29kIHRvIHZlcmlmeSBldmVyeXRoaW5nIHdvcmtzIHdoZW4gdGhpcyBpcyBmYWxzZS4gQmVjYXVz ZSB0aGUgY2FjaGUgaXMgc28gc3VjY2Vzc2Z1bCwgaXQgY2FuIG1hc2sgYnVncy4iKSBcCisgICAg dihib29sLCB1c2VDb2RlQ2FjaGUsIHRydWUsIE5vcm1hbCwgIklmIGZhbHNlLCB0aGUgcGFyc2Vy IHdpbGwgbm90IHVzZSB0aGUgY29kZSBjYWNoZS4iKSBcCiAKIGVudW0gT3B0aW9uRXF1aXZhbGVu Y2UgewogICAgIFNhbWVPcHRpb24sCg==