162576 2016-09-26 13:26:32 -0700 Mark Ping{Handle, Load} as final 2016-09-26 14:57:58 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build All All RESOLVED FIXED P2 Normal --- 1 dbates dbates achristensen oldest_to_newest 1233550 0 dbates 2016-09-26 13:26:32 -0700 A ping request is a special network request. We should not support subclassing a ping handle because there are security/privacy implications with respect to redirect handling and including credentials/authentication with a ping request. Such aspects should not be changed or require careful consideration if changed. For completeness, the HTML ping attribute and corresponding ping request that should be created is described in section "Hyperlink auditing" in the HTML standard: <https://html.spec.whatwg.org/multipage/semantics.html#hyperlink-auditing>. 1233554 1 289861 dbates 2016-09-26 13:36:13 -0700 Created attachment 289861 Patch 1233598 2 289861 dbates 2016-09-26 14:57:55 -0700 Comment on attachment 289861 Patch Clearing flags on attachment: 289861 Committed r206396: <http://trac.webkit.org/changeset/206396> 1233599 3 dbates 2016-09-26 14:57:58 -0700 All reviewed patches have been landed. Closing bug. 289861 2016-09-26 13:36:13 -0700 2016-09-26 14:57:55 -0700 Patch bug-162576-20160926133316.patch text/plain 6345 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdjZTJjOTIxY2RhNzU0 MzVkNWRiOTJkMjc0N2U3NmU0N2EwYmM5YS4uZjE4YTU4NTFkZTIwOGNjYjY0ZTFjY2Y1ZmEwMzUz ZWQzN2VmZmVlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTI2ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBNYXJrIFBpbmd7SGFuZGxl LCBMb2FkfSBhcyBmaW5hbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTYyNTc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgV2Ugc2hvdWxkIG5vdCBzdXBwb3J0IHN1YmNsYXNzaW5nIG9mIGEgcGluZyBoYW5k bGUgb3Igb3ZlcnJpZGluZyBpdHMgUmVzb3VyY2VIYW5kbGVDbGllbnQKKyAgICAgICAgY2FsbGJh Y2tzIGJlY2F1c2UgdGhlcmUgYXJlIHNlY3VyaXR5L3ByaXZhY3kgaW1wbGljYXRpb25zIHdpdGgg YSBwaW5nIHJlcXVlc3QuIFdlIHNob3VsZAorICAgICAgICBub3QgZW5jb3VyYWdlIHN1YmNsYXNz aW5nIHdpdGhvdXQgY2FyZWZ1bCBjb25zaWRlcmF0aW9uLgorCisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9QaW5nSGFuZGxlLmg6CisKIDIwMTYtMDktMjYgIE1pY2hhZWwgQ2F0YW56YXJvICA8 bWNhdGFuemFyb0BpZ2FsaWEuY29tPgogCiAgICAgICAgIHN0ZDo6dW5pcXVlX3B0ciBkZWxldGVy IGZ1bmN0aW9ucyBzaG91bGQgbm90IGNoZWNrIGlmIHBvaW50ZXIgaXMgbnVsbApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCmlu ZGV4IGJkZmM0NTFkOWE5NzA1MTYyYjM5Mzc3ZmI2YmY2YWIxMWYyZTMzZjMuLjFkZjBhMWNjMWI2 MGFiNzllYTYwNmQyMWE4NGNmOTc3NGVlMTk4ZTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQy L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBA QAorMjAxNi0wOS0yNiAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CisKKyAgICAg ICAgTWFyayBQaW5ne0hhbmRsZSwgTG9hZH0gYXMgZmluYWwKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjU3NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBub3Qgc3VwcG9ydCBzdWJjbGFz c2luZyBvZiBhIHBpbmcgaGFuZGxlIG9yIG92ZXJyaWRpbmcgaXRzIE5ldHdvcmtEYXRhVGFza0Ns aWVudAorICAgICAgICBjYWxsYmFja3MgYmVjYXVzZSB0aGVyZSBhcmUgc2VjdXJpdHkvcHJpdmFj eSBpbXBsaWNhdGlvbnMgd2l0aCBhIHBpbmcgcmVxdWVzdC4gV2Ugc2hvdWxkCisgICAgICAgIG5v dCBlbmNvdXJhZ2Ugc3ViY2xhc3Npbmcgd2l0aG91dCBjYXJlZnVsIGNvbnNpZGVyYXRpb24uCisK KyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9QaW5nTG9hZC5oOgorCiAyMDE2LTA5LTI2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggLVdm b3JtYXQgd2FybmluZ3MgaW4gV2ViTG9hZGVyU3RyYXRlZ3kKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUGluZ0hhbmRsZS5oIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vbmV0d29yay9QaW5nSGFuZGxlLmgKaW5kZXggMTNlYjljYzk3NDI2NTUwZGZiNDI4ZGE0 NGNlZjZlY2JlYTBmYzBjNy4uNWE3NTYyYzU0N2JhYzJjNTQzODIwMjM2YjM0MDkxMjdhMWEwOTQw ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9QaW5nSGFuZGxl LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9QaW5nSGFuZGxlLmgKQEAg LTM1LDcgKzM1LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogLy8gVGhlIG9iamVjdCBqdXN0IG5l ZWRzIHRvIGxpdmUgbG9uZyBlbm91Z2ggdG8gZW5zdXJlIHRoZSBtZXNzYWdlIHdhcyBhY3R1YWxs eSBzZW50LgogLy8gQXMgc29vbiBhcyBhbnkgY2FsbGJhY2sgaXMgcmVjZWl2ZWQgZnJvbSB0aGUg UmVzb3VyY2VIYW5kbGUsIHRoaXMgY2xhc3Mgd2lsbCBjYW5jZWwgdGhlIGxvYWQgYW5kIGRlbGV0 ZSBpdHNlbGYuCiAKLWNsYXNzIFBpbmdIYW5kbGUgOiBwcml2YXRlIFJlc291cmNlSGFuZGxlQ2xp ZW50IHsKK2NsYXNzIFBpbmdIYW5kbGUgZmluYWwgOiBwcml2YXRlIFJlc291cmNlSGFuZGxlQ2xp ZW50IHsKICAgICBXVEZfTUFLRV9OT05DT1BZQUJMRShQaW5nSGFuZGxlKTsgV1RGX01BS0VfRkFT VF9BTExPQ0FURUQ7CiBwdWJsaWM6CiAgICAgZW51bSBjbGFzcyBVc2VzQXN5bmNDYWxsYmFja3Mg ewpAQCAtNTYsMTIgKzU2LDEyIEBAIHB1YmxpYzoKICAgICB9CiAKIHByaXZhdGU6Ci0gICAgdm9p ZCBkaWRSZWNlaXZlUmVzcG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBSZXNvdXJjZVJlc3BvbnNlJiYp IG92ZXJyaWRlIHsgZGVsZXRlIHRoaXM7IH0KLSAgICB2b2lkIGRpZFJlY2VpdmVCdWZmZXIoUmVz b3VyY2VIYW5kbGUqLCBSZWY8U2hhcmVkQnVmZmVyPiYmLCBpbnQpIG92ZXJyaWRlIHsgZGVsZXRl IHRoaXM7IH07Ci0gICAgdm9pZCBkaWRGaW5pc2hMb2FkaW5nKFJlc291cmNlSGFuZGxlKiwgZG91 YmxlKSBvdmVycmlkZSB7IGRlbGV0ZSB0aGlzOyB9Ci0gICAgdm9pZCBkaWRGYWlsKFJlc291cmNl SGFuZGxlKiwgY29uc3QgUmVzb3VyY2VFcnJvciYpIG92ZXJyaWRlIHsgZGVsZXRlIHRoaXM7IH0K LSAgICBib29sIHNob3VsZFVzZUNyZWRlbnRpYWxTdG9yYWdlKFJlc291cmNlSGFuZGxlKikgIG92 ZXJyaWRlIHsgcmV0dXJuIG1fc2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2U7IH0KLSAgICBib29s IHVzZXNBc3luY0NhbGxiYWNrcygpIG92ZXJyaWRlIHsgcmV0dXJuIG1fdXNlc0FzeW5jQ2FsbGJh Y2tzID09IFVzZXNBc3luY0NhbGxiYWNrczo6WWVzOyB9CisgICAgdm9pZCBkaWRSZWNlaXZlUmVz cG9uc2UoUmVzb3VyY2VIYW5kbGUqLCBSZXNvdXJjZVJlc3BvbnNlJiYpIGZpbmFsIHsgZGVsZXRl IHRoaXM7IH0KKyAgICB2b2lkIGRpZFJlY2VpdmVCdWZmZXIoUmVzb3VyY2VIYW5kbGUqLCBSZWY8 U2hhcmVkQnVmZmVyPiYmLCBpbnQpIGZpbmFsIHsgZGVsZXRlIHRoaXM7IH07CisgICAgdm9pZCBk aWRGaW5pc2hMb2FkaW5nKFJlc291cmNlSGFuZGxlKiwgZG91YmxlKSBmaW5hbCB7IGRlbGV0ZSB0 aGlzOyB9CisgICAgdm9pZCBkaWRGYWlsKFJlc291cmNlSGFuZGxlKiwgY29uc3QgUmVzb3VyY2VF cnJvciYpIGZpbmFsIHsgZGVsZXRlIHRoaXM7IH0KKyAgICBib29sIHNob3VsZFVzZUNyZWRlbnRp YWxTdG9yYWdlKFJlc291cmNlSGFuZGxlKikgZmluYWwgeyByZXR1cm4gbV9zaG91bGRVc2VDcmVk ZW50aWFsU3RvcmFnZTsgfQorICAgIGJvb2wgdXNlc0FzeW5jQ2FsbGJhY2tzKCkgZmluYWwgeyBy ZXR1cm4gbV91c2VzQXN5bmNDYWxsYmFja3MgPT0gVXNlc0FzeW5jQ2FsbGJhY2tzOjpZZXM7IH0K ICAgICB2b2lkIHRpbWVvdXRUaW1lckZpcmVkKCkgeyBkZWxldGUgdGhpczsgfQogCiAgICAgdmly dHVhbCB+UGluZ0hhbmRsZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9QaW5nTG9hZC5oIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvUGluZ0xvYWQu aAppbmRleCAyY2NlZDgyMjExMzVjYTVhM2Q0ZGY3YmQxNzZkMzUyZWFkOWE1Njc5Li5iOWM3ZDY5 OGZlYmQ3ZWIzZmU3MWQ4NzMzZDkwNWM5YjQ1ODYxMDk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9OZXR3b3JrUHJvY2Vzcy9QaW5nTG9hZC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdv cmtQcm9jZXNzL1BpbmdMb2FkLmgKQEAgLTMxLDcgKzMxLDcgQEAKIAogbmFtZXNwYWNlIFdlYktp dCB7CiAKLWNsYXNzIFBpbmdMb2FkIDogcHVibGljIE5ldHdvcmtEYXRhVGFza0NsaWVudCB7Citj bGFzcyBQaW5nTG9hZCBmaW5hbCA6IHB1YmxpYyBOZXR3b3JrRGF0YVRhc2tDbGllbnQgewogcHVi bGljOgogICAgIFBpbmdMb2FkKGNvbnN0IE5ldHdvcmtSZXNvdXJjZUxvYWRQYXJhbWV0ZXJzJiBw YXJhbWV0ZXJzKQogICAgICAgICA6IG1fdGltZW91dFRpbWVyKCp0aGlzLCAmUGluZ0xvYWQ6OnRp bWVvdXRUaW1lckZpcmVkKQpAQCAtNDgsMjcgKzQ4LDI3IEBAIHB1YmxpYzoKICAgICB9CiAgICAg CiBwcml2YXRlOgotICAgIHZvaWQgd2lsbFBlcmZvcm1IVFRQUmVkaXJlY3Rpb24oV2ViQ29yZTo6 UmVzb3VyY2VSZXNwb25zZSYmLCBXZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiwgUmVkaXJlY3RD b21wbGV0aW9uSGFuZGxlciYmIGNvbXBsZXRpb25IYW5kbGVyKSBvdmVycmlkZQorICAgIHZvaWQg d2lsbFBlcmZvcm1IVFRQUmVkaXJlY3Rpb24oV2ViQ29yZTo6UmVzb3VyY2VSZXNwb25zZSYmLCBX ZWJDb3JlOjpSZXNvdXJjZVJlcXVlc3QmJiwgUmVkaXJlY3RDb21wbGV0aW9uSGFuZGxlciYmIGNv bXBsZXRpb25IYW5kbGVyKSBmaW5hbAogICAgIHsKICAgICAgICAgY29tcGxldGlvbkhhbmRsZXIo eyB9KTsKICAgICAgICAgZGVsZXRlIHRoaXM7CiAgICAgfQotICAgIHZvaWQgZGlkUmVjZWl2ZUNo YWxsZW5nZShjb25zdCBXZWJDb3JlOjpBdXRoZW50aWNhdGlvbkNoYWxsZW5nZSYsIENoYWxsZW5n ZUNvbXBsZXRpb25IYW5kbGVyJiYgY29tcGxldGlvbkhhbmRsZXIpIG92ZXJyaWRlCisgICAgdm9p ZCBkaWRSZWNlaXZlQ2hhbGxlbmdlKGNvbnN0IFdlYkNvcmU6OkF1dGhlbnRpY2F0aW9uQ2hhbGxl bmdlJiwgQ2hhbGxlbmdlQ29tcGxldGlvbkhhbmRsZXImJiBjb21wbGV0aW9uSGFuZGxlcikgZmlu YWwKICAgICB7CiAgICAgICAgIGNvbXBsZXRpb25IYW5kbGVyKEF1dGhlbnRpY2F0aW9uQ2hhbGxl bmdlRGlzcG9zaXRpb246OkNhbmNlbCwgeyB9KTsKICAgICAgICAgZGVsZXRlIHRoaXM7CiAgICAg fQotICAgIHZvaWQgZGlkUmVjZWl2ZVJlc3BvbnNlTmV0d29ya1Nlc3Npb24oV2ViQ29yZTo6UmVz b3VyY2VSZXNwb25zZSYmLCBSZXNwb25zZUNvbXBsZXRpb25IYW5kbGVyJiYgY29tcGxldGlvbkhh bmRsZXIpIG92ZXJyaWRlCisgICAgdm9pZCBkaWRSZWNlaXZlUmVzcG9uc2VOZXR3b3JrU2Vzc2lv bihXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlJiYsIFJlc3BvbnNlQ29tcGxldGlvbkhhbmRsZXIm JiBjb21wbGV0aW9uSGFuZGxlcikgZmluYWwKICAgICB7CiAgICAgICAgIGNvbXBsZXRpb25IYW5k bGVyKFdlYkNvcmU6OlBvbGljeUFjdGlvbjo6UG9saWN5SWdub3JlKTsKICAgICAgICAgZGVsZXRl IHRoaXM7CiAgICAgfQotICAgIHZvaWQgZGlkUmVjZWl2ZURhdGEoUmVmPFdlYkNvcmU6OlNoYXJl ZEJ1ZmZlcj4mJikgIG92ZXJyaWRlIHsgQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KLSAgICB2b2lk IGRpZENvbXBsZXRlV2l0aEVycm9yKGNvbnN0IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImKSBvdmVy cmlkZSB7IGRlbGV0ZSB0aGlzOyB9Ci0gICAgdm9pZCBkaWRCZWNvbWVEb3dubG9hZCgpIG92ZXJy aWRlIHsgQVNTRVJUX05PVF9SRUFDSEVEKCk7IH0KLSAgICB2b2lkIGRpZFNlbmREYXRhKHVpbnQ2 NF90IHRvdGFsQnl0ZXNTZW50LCB1aW50NjRfdCB0b3RhbEJ5dGVzRXhwZWN0ZWRUb1NlbmQpIG92 ZXJyaWRlIHsgfQotICAgIHZvaWQgd2FzQmxvY2tlZCgpIG92ZXJyaWRlIHsgZGVsZXRlIHRoaXM7 IH0KLSAgICB2b2lkIGNhbm5vdFNob3dVUkwoKSBvdmVycmlkZSB7IGRlbGV0ZSB0aGlzOyB9Cisg ICAgdm9pZCBkaWRSZWNlaXZlRGF0YShSZWY8V2ViQ29yZTo6U2hhcmVkQnVmZmVyPiYmKSBmaW5h bCB7IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOyB9CisgICAgdm9pZCBkaWRDb21wbGV0ZVdpdGhFcnJv cihjb25zdCBXZWJDb3JlOjpSZXNvdXJjZUVycm9yJikgZmluYWwgeyBkZWxldGUgdGhpczsgfQor ICAgIHZvaWQgZGlkQmVjb21lRG93bmxvYWQoKSBmaW5hbCB7IEFTU0VSVF9OT1RfUkVBQ0hFRCgp OyB9CisgICAgdm9pZCBkaWRTZW5kRGF0YSh1aW50NjRfdCB0b3RhbEJ5dGVzU2VudCwgdWludDY0 X3QgdG90YWxCeXRlc0V4cGVjdGVkVG9TZW5kKSBmaW5hbCB7IH0KKyAgICB2b2lkIHdhc0Jsb2Nr ZWQoKSBmaW5hbCB7IGRlbGV0ZSB0aGlzOyB9CisgICAgdm9pZCBjYW5ub3RTaG93VVJMKCkgZmlu YWwgeyBkZWxldGUgdGhpczsgfQogCiAgICAgdm9pZCB0aW1lb3V0VGltZXJGaXJlZCgpIHsgZGVs ZXRlIHRoaXM7IH0KICAgICAK