162558 2016-09-26 07:22:03 -0700 std::unique_ptr deleter functions should not check if pointer is null 2016-09-26 09:43:01 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build PC Linux RESOLVED FIXED P2 Trivial --- 1 mcatanzaro mcatanzaro bugs-noreply commit-queue mcatanzaro oldest_to_newest 1233395 0 mcatanzaro 2016-09-26 07:22:03 -0700 std::unique_ptr deleter functions should not check if pointer is null, because std::unique_ptr already does this before calling the deleter. 1233397 1 289828 mcatanzaro 2016-09-26 07:23:53 -0700 Created attachment 289828 Patch 1233412 2 289828 achristensen 2016-09-26 08:24:19 -0700 Comment on attachment 289828 Patch This is good. I feel like we could add another template parameter somewhere with the deleter function and unify all of these and the CairoUniquePtr into one template. 1233427 3 289828 mcatanzaro 2016-09-26 09:21:48 -0700 Comment on attachment 289828 Patch Hm, maybe... not in this patch though! 1233440 4 289828 commit-queue 2016-09-26 09:42:58 -0700 Comment on attachment 289828 Patch Clearing flags on attachment: 289828 Committed r206377: <http://trac.webkit.org/changeset/206377> 1233441 5 commit-queue 2016-09-26 09:43:01 -0700 All reviewed patches have been landed. Closing bug. 289828 2016-09-26 07:23:53 -0700 2016-09-26 09:42:58 -0700 Patch bug-162558-20160926162056.patch text/plain 4175 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDdmYWNhOTU4ZDRjN2IxZWIxYTUyMWJi MTA2NDA0MzFlNDg2NWM5NGQuLjJjNDkyOTZlYmY5YjMxMDlmOTJlOWYyMzgyYzM5MGY4ZjViYWEx ZjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xICsxLDEzIEBACisyMDE2LTA5LTI2ICBNaWNoYWVsIENhdGFuemFybyAgPG1j YXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICBzdGQ6OnVuaXF1ZV9wdHIgZGVsZXRlciBm dW5jdGlvbnMgc2hvdWxkIG5vdCBjaGVjayBpZiBwb2ludGVyIGlzIG51bGwKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjU1OAorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHN0ZDo6dW5pcXVlX3B0ciBhbHJl YWR5IGRvZXMgdGhpcyBiZWZvcmUgY2FsbGluZyB0aGUgZGVsZXRlci4KKworICAgICAgICAqIHd0 Zi9lZmwvVW5pcXVlUHRyRWZsLmg6CisgICAgICAgICogd3RmL2dsaWIvR1VuaXF1ZVB0ci5oOgor CiA9PSBSb2xsZWQgb3ZlciB0byBDaGFuZ2VMb2ctMjAxNi0wOS0yNiA9PQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IDdmYWNhOTU4ZDRjN2IxZWIxYTUyMWJiMTA2NDA0MzFlNDg2NWM5NGQuLmFiYmRkOTk2MTg2NThk ZjM0ZDkyOTg1Njc4NGM4ZjIxNjA1ZmVlN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEgKzEsMTYgQEAKKzIw MTYtMDktMjYgIE1pY2hhZWwgQ2F0YW56YXJvICA8bWNhdGFuemFyb0BpZ2FsaWEuY29tPgorCisg ICAgICAgIHN0ZDo6dW5pcXVlX3B0ciBkZWxldGVyIGZ1bmN0aW9ucyBzaG91bGQgbm90IGNoZWNr IGlmIHBvaW50ZXIgaXMgbnVsbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTYyNTU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgc3RkOjp1bmlxdWVfcHRyIGFscmVhZHkgZG9lcyB0aGlzIGJlZm9yZSBjYWxs aW5nIHRoZSBkZWxldGVyLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MveDExL1hVbmlx dWVQdHIuaDoKKyAgICAgICAgKFdlYkNvcmU6OlhQdHJEZWxldGVyOjpvcGVyYXRvcigpKToKKyAg ICAgICAgKFdlYkNvcmU6OlhQdHJEZWxldGVyPFhJbWFnZT46Om9wZXJhdG9yKCkpOgorICAgICAg ICAoV2ViQ29yZTo6WFB0ckRlbGV0ZXI8X1hHQz46Om9wZXJhdG9yKCkpOgorICAgICAgICAoV2Vi Q29yZTo6WFB0ckRlbGV0ZXI8X19HTFhjb250ZXh0UmVjPjo6b3BlcmF0b3IoKSk6CisKID09IFJv bGxlZCBvdmVyIHRvIENoYW5nZUxvZy0yMDE2LTA5LTI2ID09CmRpZmYgLS1naXQgYS9Tb3VyY2Uv V1RGL3d0Zi9lZmwvVW5pcXVlUHRyRWZsLmggYi9Tb3VyY2UvV1RGL3d0Zi9lZmwvVW5pcXVlUHRy RWZsLmgKaW5kZXggNWIwNzdkZjdjN2RmNzZkNWFmMzczZTBmZjI3MDkwODk4ZDc2NzMyZS4uYWVk ZWJkNzcwZDBlNDgwZjliNmM5YWI1YzU2ODZmNjUzNjU2M2ViNCAxMDA2NDQKLS0tIGEvU291cmNl L1dURi93dGYvZWZsL1VuaXF1ZVB0ckVmbC5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL2VmbC9Vbmlx dWVQdHJFZmwuaApAQCAtNTQsOCArNTQsNyBAQCB1c2luZyBFZmxVbmlxdWVQdHIgPSBzdGQ6OnVu aXF1ZV9wdHI8VCwgRWZsUHRyRGVsZXRlcjxUPj47CiAgICAgeyBcCiAgICAgICAgIHZvaWQgb3Bl cmF0b3IoKSAodHlwZU5hbWUqIHB0cikgY29uc3QgXAogICAgICAgICB7IFwKLSAgICAgICAgICAg IGlmIChwdHIpIFwKLSAgICAgICAgICAgICAgICBkZWxldGVyRnVuYyhwdHIpOyBcCisgICAgICAg ICAgICBkZWxldGVyRnVuYyhwdHIpOyBcCiAgICAgICAgIH0gXAogICAgIH07CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL2dsaWIvR1VuaXF1ZVB0ci5oIGIvU291cmNlL1dURi93dGYvZ2xp Yi9HVW5pcXVlUHRyLmgKaW5kZXggYjJkNzJkNzQzNzJjMGFkMDcyNzYzZDA0ZTBiZmJmNTg5MjA0 NDRlMi4uZTFjZmY4ZGRlYTQ0ZjZkYTcyZmRmMGYwMGYxMWNhMTg4Mzk2YTZlZCAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvZ2xpYi9HVW5pcXVlUHRyLmgKKysrIGIvU291cmNlL1dURi93dGYv Z2xpYi9HVW5pcXVlUHRyLmgKQEAgLTUyLDggKzUyLDcgQEAgdXNpbmcgR1VuaXF1ZVB0ciA9IHN0 ZDo6dW5pcXVlX3B0cjxULCBHUHRyRGVsZXRlcjxUPj47CiAgICAgeyBcCiAgICAgICAgIHZvaWQg b3BlcmF0b3IoKSAodHlwZU5hbWUqIHB0cikgY29uc3QgXAogICAgICAgICB7IFwKLSAgICAgICAg ICAgIGlmIChwdHIpIFwKLSAgICAgICAgICAgICAgICBkZWxldGVyRnVuYyhwdHIpOyBcCisgICAg ICAgICAgICBkZWxldGVyRnVuYyhwdHIpOyBcCiAgICAgICAgIH0gXAogICAgIH07CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3gxMS9YVW5pcXVlUHRyLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy94MTEvWFVuaXF1ZVB0ci5oCmluZGV4 IDI0NTA5NmY3MWI2YjYwMDgxZTY0NjhiN2FiYWVlMTkyMWYxNDEwNmQuLjM3YTE4YzI5ZDVlYjA1 OGQ5YWQ3NjkxMzllZjc2MjViYzJjMDdmNzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3gxMS9YVW5pcXVlUHRyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MveDExL1hVbmlxdWVQdHIuaApAQCAtNDEsOCArNDEsNyBAQCB0ZW1wbGF0 ZTx0eXBlbmFtZSBUPgogc3RydWN0IFhQdHJEZWxldGVyIHsKICAgICB2b2lkIG9wZXJhdG9yKCko VCogcHRyKSBjb25zdAogICAgIHsKLSAgICAgICAgaWYgKHB0cikKLSAgICAgICAgICAgIFhGcmVl KHB0cik7CisgICAgICAgIFhGcmVlKHB0cik7CiAgICAgfQogfTsKIApAQCAtNTIsMTYgKzUxLDE0 IEBAIHVzaW5nIFhVbmlxdWVQdHIgPSBzdGQ6OnVuaXF1ZV9wdHI8VCwgWFB0ckRlbGV0ZXI8VD4+ OwogdGVtcGxhdGU8PiBzdHJ1Y3QgWFB0ckRlbGV0ZXI8WEltYWdlPiB7CiAgICAgdm9pZCBvcGVy YXRvcigpIChYSW1hZ2UqIHB0cikgY29uc3QKICAgICB7Ci0gICAgICAgIGlmIChwdHIpCi0gICAg ICAgICAgICBYRGVzdHJveUltYWdlKHB0cik7CisgICAgICAgIFhEZXN0cm95SW1hZ2UocHRyKTsK ICAgICB9CiB9OwogCiB0ZW1wbGF0ZTw+IHN0cnVjdCBYUHRyRGVsZXRlcjxfWEdDPiB7CiAgICAg dm9pZCBvcGVyYXRvcigpIChfWEdDKiBwdHIpIGNvbnN0CiAgICAgewotICAgICAgICBpZiAocHRy KQotICAgICAgICAgICAgWEZyZWVHQyhkb3duY2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+KFBsYXRm b3JtRGlzcGxheTo6c2hhcmVkRGlzcGxheSgpKS5uYXRpdmUoKSwgcHRyKTsKKyAgICAgICAgWEZy ZWVHQyhkb3duY2FzdDxQbGF0Zm9ybURpc3BsYXlYMTE+KFBsYXRmb3JtRGlzcGxheTo6c2hhcmVk RGlzcGxheSgpKS5uYXRpdmUoKSwgcHRyKTsKICAgICB9CiB9OwogLy8gR2l2ZSBhIG5hbWUgdG8g dGhpcyB0byBhdm9pZCBoYXZpbmcgdG8gdXNlIHRoZSBpbnRlcm5hbCBzdHJ1Y3QgbmFtZS4KQEAg LTcxLDggKzY4LDcgQEAgdXNpbmcgWFVuaXF1ZUdDID0gWFVuaXF1ZVB0cjxfWEdDPjsKIHRlbXBs YXRlPD4gc3RydWN0IFhQdHJEZWxldGVyPF9fR0xYY29udGV4dFJlYz4gewogICAgIHZvaWQgb3Bl cmF0b3IoKSAoX19HTFhjb250ZXh0UmVjKiBwdHIpCiAgICAgewotICAgICAgICBpZiAocHRyKQot ICAgICAgICAgICAgZ2xYRGVzdHJveUNvbnRleHQoZG93bmNhc3Q8UGxhdGZvcm1EaXNwbGF5WDEx PihQbGF0Zm9ybURpc3BsYXk6OnNoYXJlZERpc3BsYXkoKSkubmF0aXZlKCksIHB0cik7CisgICAg ICAgIGdsWERlc3Ryb3lDb250ZXh0KGRvd25jYXN0PFBsYXRmb3JtRGlzcGxheVgxMT4oUGxhdGZv cm1EaXNwbGF5OjpzaGFyZWREaXNwbGF5KCkpLm5hdGl2ZSgpLCBwdHIpOwogICAgIH0KIH07CiAv LyBHaXZlIGEgbmFtZSB0byB0aGlzIHRvIGF2b2lkIGhhdmluZyB0byB1c2UgdGhlIGludGVybmFs IHN0cnVjdCBuYW1lLgo=