162552 2016-09-26 01:57:56 -0700 -Wformat warnings triggered by BitmapImage::frameImageAtIndex 2016-10-07 02:35:44 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED DUPLICATE 162596 P2 Minor --- 1 mcatanzaro mcatanzaro cgarcia commit-queue mcatanzaro oldest_to_newest 1233344 0 mcatanzaro 2016-09-26 01:57:56 -0700 Fix -Wformat warnings triggered by BitmapImage::frameImageAtIndex 1233345 1 mcatanzaro 2016-09-26 01:58:26 -0700 Should probably include the warning here: [3923/6045] Building CXX object Source...ir/platform/graphics/BitmapImage.cpp.o In file included from ../../Source/WTF/wtf/StdLibExtras.h:33:0, from ../../Source/WTF/wtf/FastMalloc.h:26, from ../../Source/WebCore/config.h:75, from ../../Source/WebCore/platform/graphics/BitmapImage.cpp:27: ../../Source/WebCore/platform/graphics/BitmapImage.cpp: In member function ‘WebCore::NativeImagePtr WebCore::BitmapImage::frameImageAtIndex(size_t, float)’: ../../Source/WTF/wtf/Assertions.h:394:68: warning: format ‘%d’ expects argument of type ‘int’, but argument 4 has type ‘WebCore::SubsamplingLevel’ [-Wformat=] #define LOG(channel, ...) WTFLog(&LOG_CHANNEL(channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/graphics/BitmapImage.cpp:351:5: note: in expansion of macro ‘LOG’ LOG(Images, "BitmapImage %p frameImageAtIndex - subsamplingLevel %d at scale %.4f", this, subsamplingLevel, presentationScaleHint); ^~~ ../../Source/WTF/wtf/Assertions.h:394:68: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘WebCore::SubsamplingLevel’ [-Wformat=] #define LOG(channel, ...) WTFLog(&LOG_CHANNEL(channel), __VA_ARGS__) ^ ../../Source/WebCore/platform/graphics/BitmapImage.cpp:356:9: note: in expansion of macro ‘LOG’ LOG(Images, " subsamplingLevel was %d, resampling", m_frames[index].subsamplingLevel()); ^~~ 1233346 2 289811 mcatanzaro 2016-09-26 02:00:53 -0700 Created attachment 289811 Patch 1233411 3 289811 achristensen 2016-09-26 08:20:28 -0700 Comment on attachment 289811 Patch Couldn't we just change the %d to %zu? 1233484 4 mcatanzaro 2016-09-26 11:43:53 -0700 (In reply to comment #3) > Comment on attachment 289811 [details] > Patch > > Couldn't we just change the %d to %zu? No that doesn't make sense, WebCore::SubsamplingLevel is an enum and it doesn't specify any particular backing data type, so it's an int and %d is the right way to print it. 1236284 5 mcatanzaro 2016-10-04 11:35:12 -0700 Ping reviewers 1237444 6 289811 commit-queue 2016-10-06 20:24:29 -0700 Comment on attachment 289811 Patch Rejecting attachment 289811 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 289811, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ]" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Parsed 2 diffs from patch file(s). patching file Source/WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/WebCore/platform/graphics/BitmapImage.cpp Hunk #1 FAILED at 348. 1 out of 1 hunk FAILED -- saving rejects to file Source/WebCore/platform/graphics/BitmapImage.cpp.rej Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.webkit.org/results/2235068 1237541 7 mcatanzaro 2016-10-07 02:35:44 -0700 It's already fixed. *** This bug has been marked as a duplicate of bug 162596 *** 289811 2016-09-26 02:00:53 -0700 2016-10-06 20:24:29 -0700 Patch bug-162552-20160926105756.patch text/plain 2180 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIyMDc5YzI3Y2YyMzQw ZWQxOTMyNGUwMmNlZTY0MDU0ODcxYzhmNS4uMjBkMDJhYTE5OTE1MWQzMmRjNzk2NGRiYzAzMzMy ODJjNzMwZWI4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV2Zvcm1h dCB3YXJuaW5ncyB0cmlnZ2VyZWQgYnkgQml0bWFwSW1hZ2U6OmZyYW1lSW1hZ2VBdEluZGV4Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjI1NTIKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgbWlzc2lu ZyBjYXN0cyB0byBhdm9pZCB3YXJuaW5nCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9C aXRtYXBJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpCaXRtYXBJbWFnZTo6ZnJhbWVJbWFn ZUF0SW5kZXgpOgorCiAyMDE2LTA5LTI1ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv bT4KIAogICAgICAgICBBdXRob3JTdHlsZVNoZWV0cyBzaG91bGRuJ3QgdHJpZ2dlciBzeW5jaHJv bm91cyBzdHlsZSByZXNvbHV0aW9ucwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvQml0bWFwSW1hZ2UuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvQml0bWFwSW1hZ2UuY3BwCmluZGV4IDMxMTI5NGEzZGNhYWNlYThlZTYyNDJlMzI4MGFj ZGVlMzI2YjJmZWEuLjU5OWMwYmNhOGQ5NjAwNjViMmRjY2NiMWU5ZTQ3OTcyOWNhNDU1MTMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0JpdG1hcEltYWdlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9CaXRtYXBJbWFnZS5jcHAK QEAgLTM0OCwxMiArMzQ4LDEyIEBAIE5hdGl2ZUltYWdlUHRyIEJpdG1hcEltYWdlOjpmcmFtZUlt YWdlQXRJbmRleChzaXplX3QgaW5kZXgsIGZsb2F0IHByZXNlbnRhdGlvblNjCiAKICAgICBTdWJz YW1wbGluZ0xldmVsIHN1YnNhbXBsaW5nTGV2ZWwgPSBtX3NvdXJjZS5zdWJzYW1wbGluZ0xldmVs Rm9yU2NhbGUocHJlc2VudGF0aW9uU2NhbGVIaW50KTsKICAgICAKLSAgICBMT0coSW1hZ2VzLCAi Qml0bWFwSW1hZ2UgJXAgZnJhbWVJbWFnZUF0SW5kZXggLSBzdWJzYW1wbGluZ0xldmVsICVkIGF0 IHNjYWxlICUuNGYiLCB0aGlzLCBzdWJzYW1wbGluZ0xldmVsLCBwcmVzZW50YXRpb25TY2FsZUhp bnQpOworICAgIExPRyhJbWFnZXMsICJCaXRtYXBJbWFnZSAlcCBmcmFtZUltYWdlQXRJbmRleCAt IHN1YnNhbXBsaW5nTGV2ZWwgJWQgYXQgc2NhbGUgJS40ZiIsIHRoaXMsIHN0YXRpY19jYXN0PGlu dD4oc3Vic2FtcGxpbmdMZXZlbCksIHByZXNlbnRhdGlvblNjYWxlSGludCk7CiAKICAgICAvLyBX ZSBtYXkgaGF2ZSBjYWNoZWQgYSBmcmFtZSB3aXRoIGEgaGlnaGVyIHN1YnNhbXBsaW5nIGxldmVs LCBpbiB3aGljaCBjYXNlIHdlIG5lZWQgdG8KICAgICAvLyByZS1kZWNvZGUgd2l0aCBhIGxvd2Vy IGxldmVsLgogICAgIGlmIChpbmRleCA8IG1fZnJhbWVzLnNpemUoKSAmJiBtX2ZyYW1lc1tpbmRl eF0uaGFzSW52YWxpZE5hdGl2ZUltYWdlKHN1YnNhbXBsaW5nTGV2ZWwpKSB7Ci0gICAgICAgIExP RyhJbWFnZXMsICIgIHN1YnNhbXBsaW5nTGV2ZWwgd2FzICVkLCByZXNhbXBsaW5nIiwgbV9mcmFt ZXNbaW5kZXhdLnN1YnNhbXBsaW5nTGV2ZWwoKSk7CisgICAgICAgIExPRyhJbWFnZXMsICIgIHN1 YnNhbXBsaW5nTGV2ZWwgd2FzICVkLCByZXNhbXBsaW5nIiwgc3RhdGljX2Nhc3Q8aW50PihtX2Zy YW1lc1tpbmRleF0uc3Vic2FtcGxpbmdMZXZlbCgpKSk7CiAKICAgICAgICAgLy8gSWYgdGhlIGlt YWdlIGlzIGFscmVhZHkgY2FjaGVkLCBidXQgYXQgdG9vIHNtYWxsIGEgc2l6ZSwgcmUtZGVjb2Rl IGEgbGFyZ2VyIHZlcnNpb24uCiAgICAgICAgIGludCBzaXplQ2hhbmdlID0gLW1fZnJhbWVzW2lu ZGV4XS5jbGVhcigpOwo=