162551 2016-09-26 01:48:55 -0700 -Wtautological-compare triggered in URLParser::internalValuesConsistent 2016-09-26 12:51:36 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build PC Linux RESOLVED FIXED P2 Minor --- 1 mcatanzaro mcatanzaro achristensen ap commit-queue ddkilzer mcatanzaro oldest_to_newest 1233342 0 mcatanzaro 2016-09-26 01:48:55 -0700 This is wrong: [3876/6045] Building CXX object Source...s/WebCore.dir/platform/URLParser.cpp.o ../../Source/WebCore/platform/URLParser.cpp: In static member function ‘static bool WebCore::URLParser::internalValuesConsistent(const WebCore::URL&)’: ../../Source/WebCore/platform/URLParser.cpp:2357:26: warning: self-comparison always evaluates to true [-Wtautological-compare] && url.m_hostEnd <= url.m_hostEnd ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~ 1233343 1 289810 mcatanzaro 2016-09-26 01:52:05 -0700 Created attachment 289810 Patch 1233402 2 ap 2016-09-26 07:44:26 -0700 Can a regression test detect this? Also, can this warning be enabled in normal build? 1233410 3 289810 achristensen 2016-09-26 08:18:26 -0700 Comment on attachment 289810 Patch We shouldn't be able to add a regression test for this because both inequalities should always be true. If either one can be false, there is a major error in the parser. There are a few such cases right now, but when I'm finished soon there won't be. We should enable the warning somewhere, if not everywhere. 1233489 4 289810 mcatanzaro 2016-09-26 11:49:06 -0700 Comment on attachment 289810 Patch With GCC it's enabled by -Wall, which is set in CMake ports by WEBKIT_SET_EXTRA_COMPILER_FLAGS, which *hopefully* is used on all targets. Definitely seems like a good idea to set it in Xcode builds as well, but you'll forgive me if I don't assist with that. ;) 1233505 5 289810 commit-queue 2016-09-26 12:11:22 -0700 Comment on attachment 289810 Patch Clearing flags on attachment: 289810 Committed r206385: <http://trac.webkit.org/changeset/206385> 1233506 6 commit-queue 2016-09-26 12:11:26 -0700 All reviewed patches have been landed. Closing bug. 289810 2016-09-26 01:52:05 -0700 2016-09-26 12:11:22 -0700 Patch bug-162551-20160926104908.patch text/plain 1481 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTIyMDc5YzI3Y2YyMzQw ZWQxOTMyNGUwMmNlZTY0MDU0ODcxYzhmNS4uYThlMzBmMjZhZGI4NDg3YmVlN2U5NjNmYTlmMjkx MjE4Y2Y1Mjg0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI2ICBNaWNo YWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KKworICAgICAgICAtV3RhdXRv bG9naWNhbC1jb21wYXJlIHRyaWdnZXJlZCBpbiBVUkxQYXJzZXI6OmludGVybmFsVmFsdWVzQ29u c2lzdGVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTYyNTUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg Rml4IGxvZ2ljIGVycm9yLgorCisgICAgICAgICogcGxhdGZvcm0vVVJMUGFyc2VyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlVSTFBhcnNlcjo6aW50ZXJuYWxWYWx1ZXNDb25zaXN0ZW50KToKKwog MjAxNi0wOS0yNSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAg QXV0aG9yU3R5bGVTaGVldHMgc2hvdWxkbid0IHRyaWdnZXIgc3luY2hyb25vdXMgc3R5bGUgcmVz b2x1dGlvbnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VSTFBhcnNlci5j cHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwCmluZGV4IDY3MDhlNGFj M2M0ODQ1MzkzMjA0ZDczNjcwZTE4YTBhOWM5NDExNGEuLjZkYjM3ZjAxNWI3NTdjOTMzNjE1NGE1 MWNhNmE5ZGQxNjk3YzlhYzMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1VS TFBhcnNlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcApA QCAtMjM1NCw3ICsyMzU0LDcgQEAgYm9vbCBVUkxQYXJzZXI6OmludGVybmFsVmFsdWVzQ29uc2lz dGVudChjb25zdCBVUkwmIHVybCkKICAgICAgICAgJiYgdXJsLm1fdXNlclN0YXJ0IDw9IHVybC5t X3VzZXJFbmQKICAgICAgICAgJiYgdXJsLm1fdXNlckVuZCA8PSB1cmwubV9wYXNzd29yZEVuZAog ICAgICAgICAmJiB1cmwubV9wYXNzd29yZEVuZCA8PSB1cmwubV9ob3N0RW5kCi0gICAgICAgICYm IHVybC5tX2hvc3RFbmQgPD0gdXJsLm1faG9zdEVuZAorICAgICAgICAmJiB1cmwubV9ob3N0RW5k IDw9IHVybC5tX3BvcnRFbmQKICAgICAgICAgJiYgdXJsLm1fcG9ydEVuZCA8PSB1cmwubV9wYXRo QWZ0ZXJMYXN0U2xhc2gKICAgICAgICAgJiYgdXJsLm1fcGF0aEFmdGVyTGFzdFNsYXNoIDw9IHVy bC5tX3BhdGhFbmQKICAgICAgICAgJiYgdXJsLm1fcGF0aEVuZCA8PSB1cmwubV9xdWVyeUVuZAo=