162550 2016-09-26 01:27:18 -0700 [Win][Debug] Compile fix. 2016-09-26 08:25:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue esprehn+autocc glenn kondapallykalyan mmaxfield webkit-bug-importer oldest_to_newest 1233340 0 pvollan 2016-09-26 01:27:18 -0700 WebCore::SimpleLineLayout::FragmentForwardIterator is missing the == operator: 1>C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\include\xutility(947): error C2678: binary '==': no operator found which takes a left-hand operand of type 'WebCore::SimpleLineLayout::FragmentForwardIterator' (or there is no acceptable conversion) 1233348 1 pvollan 2016-09-26 02:10:55 -0700 The '==' operator is needed in debug mode. From xutility: // TEMPLATE FUNCTION _Debug_range template<class _InIt> inline void _Debug_range2(_InIt _First, _InIt _Last, _Dbfile_t, _Dbline_t, input_iterator_tag) { // test iterator pair for valid range, arbitrary iterators static_cast<void>(_First == _Last); // make sure they're comparable } 1233349 2 289812 pvollan 2016-09-26 02:27:23 -0700 Created attachment 289812 Patch 1233352 3 pvollan 2016-09-26 02:33:08 -0700 rdar://problem/28448683 1233353 4 289813 pvollan 2016-09-26 02:35:44 -0700 Created attachment 289813 Patch 1233413 5 289813 commit-queue 2016-09-26 08:25:38 -0700 Comment on attachment 289813 Patch Clearing flags on attachment: 289813 Committed r206375: <http://trac.webkit.org/changeset/206375> 1233414 6 commit-queue 2016-09-26 08:25:43 -0700 All reviewed patches have been landed. Closing bug. 289812 2016-09-26 02:27:23 -0700 2016-09-26 02:35:37 -0700 Patch bug-162550-20160926022426.patch text/plain 1324 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjM2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXVtEZWJ1Z10gQ29t cGlsZSBmaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjI1NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaW5kb3dzIGhlYWRlcnMgbmVlZCB0aGUgRnJhZ21lbnRGb3J3YXJkSXRlcmF0b3IgJz09JyBv cGVyYXRvciBpbiBkZWJ1ZyBtb2RlLgorCisgICAgICAgICogcmVuZGVyaW5nL1NpbXBsZUxpbmVM YXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxlTGluZUxheW91dDo6RnJhZ21lbnRG b3J3YXJkSXRlcmF0b3I6Om9wZXJhdG9yPT0pOgorCiAyMDE2LTA5LTI1ICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBBdXRob3JTdHlsZVNoZWV0cyBzaG91bGRu J3QgdHJpZ2dlciBzeW5jaHJvbm91cyBzdHlsZSByZXNvbHV0aW9ucwpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcAkocmV2aXNpb24gMjA2MzY4 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01NjcsNiArNTY3LDcgQEAgcHVibGljOgogICAgIH0KIAogICAgIGJvb2wg b3BlcmF0b3IhPShjb25zdCBGcmFnbWVudEZvcndhcmRJdGVyYXRvciYgb3RoZXIpIGNvbnN0IHsg cmV0dXJuIG1fZnJhZ21lbnRJbmRleCAhPSBvdGhlci5tX2ZyYWdtZW50SW5kZXg7IH0KKyAgICBi b29sIG9wZXJhdG9yPT0oY29uc3QgRnJhZ21lbnRGb3J3YXJkSXRlcmF0b3ImIG90aGVyKSBjb25z dCB7IHJldHVybiBtX2ZyYWdtZW50SW5kZXggPT0gb3RoZXIubV9mcmFnbWVudEluZGV4OyB9CiAg ICAgdW5zaWduZWQgb3BlcmF0b3IqKCkgY29uc3QgeyByZXR1cm4gbV9mcmFnbWVudEluZGV4OyB9 CiAKIHByaXZhdGU6Cg== 289813 2016-09-26 02:35:44 -0700 2016-09-26 08:25:38 -0700 Patch bug-162550-20160926023248.patch text/plain 1324 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjM2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXVtEZWJ1Z10gQ29t cGlsZSBmaXguCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjI1NTAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXaW5kb3dzIGhlYWRlcnMgbmVlZCB0aGUgRnJhZ21lbnRGb3J3YXJkSXRlcmF0b3IgJz09JyBv cGVyYXRvciBpbiBkZWJ1ZyBtb2RlLgorCisgICAgICAgICogcmVuZGVyaW5nL1NpbXBsZUxpbmVM YXlvdXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U2ltcGxlTGluZUxheW91dDo6RnJhZ21lbnRG b3J3YXJkSXRlcmF0b3I6Om9wZXJhdG9yPT0pOgorCiAyMDE2LTA5LTI1ICBBbnR0aSBLb2l2aXN0 byAgPGFudHRpQGFwcGxlLmNvbT4KIAogICAgICAgICBBdXRob3JTdHlsZVNoZWV0cyBzaG91bGRu J3QgdHJpZ2dlciBzeW5jaHJvbm91cyBzdHlsZSByZXNvbHV0aW9ucwpJbmRleDogU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9TaW1wbGVMaW5lTGF5b3V0LmNwcAkocmV2aXNpb24gMjA2MzY4 KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1NpbXBsZUxpbmVMYXlvdXQuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC01NjcsNiArNTY3LDcgQEAgcHVibGljOgogICAgIH0KIAogICAgIGJvb2wg b3BlcmF0b3IhPShjb25zdCBGcmFnbWVudEZvcndhcmRJdGVyYXRvciYgb3RoZXIpIGNvbnN0IHsg cmV0dXJuIG1fZnJhZ21lbnRJbmRleCAhPSBvdGhlci5tX2ZyYWdtZW50SW5kZXg7IH0KKyAgICBi b29sIG9wZXJhdG9yPT0oY29uc3QgRnJhZ21lbnRGb3J3YXJkSXRlcmF0b3ImIG90aGVyKSBjb25z dCB7IHJldHVybiBtX2ZyYWdtZW50SW5kZXggPT0gb3RoZXIubV9mcmFnbWVudEluZGV4OyB9CiAg ICAgdW5zaWduZWQgb3BlcmF0b3IqKCkgY29uc3QgeyByZXR1cm4gbV9mcmFnbWVudEluZGV4OyB9 CiAKIHByaXZhdGU6Cg==