162547 2016-09-26 01:02:27 -0700 [GTK][EFL] imported/w3c/web-platform-tests/fetch/api/basic/accept-header.html is failing 2016-09-27 06:13:38 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf berto cgarcia clopez commit-queue danw gustavo gyuyoung.kim jfernandez mcatanzaro mrobinson ossy oldest_to_newest 1233329 0 youennf 2016-09-26 01:02:27 -0700 It seems GTK WTR is not setting Accept-Language header. 1233334 1 youennf 2016-09-26 01:05:53 -0700 Using minibrowser, the test is passing. This may be an issue with GTK WTR setup? 1233354 2 289814 youennf 2016-09-26 03:00:46 -0700 Created attachment 289814 Patch 1233355 3 youennf 2016-09-26 03:02:52 -0700 (In reply to comment #2) > Created attachment 289814 [details] > Patch The soup session accept-language is well initialized, making minibrowser work as expected. But we are creating a new soup session for testing in WRT. This patch takes the simple approach to set Accept-Language for testing session with a fixed default value. 1233373 4 cgarcia 2016-09-26 05:04:26 -0700 So, maybe the bug is that we are using SoupNetworkSession::defaultSession() directly in NetworkProcess::userPreferredLanguagesChanged() and we should use NetworkStorageSession::defaultStorageSession().soupNetworkSession()? 1233377 5 youennf 2016-09-26 05:39:17 -0700 AIUI, the default soup session gets updated after the network process is launched and properly set. When we launch tests using WTR, test controller asks to use the testing network session. At that time, we lose all soup session specific options previously set and we are back to the default values. 1233379 6 cgarcia 2016-09-26 05:42:13 -0700 (In reply to comment #5) > AIUI, the default soup session gets updated after the network process is > launched and properly set. > > When we launch tests using WTR, test controller asks to use the testing > network session. At that time, we lose all soup session specific options > previously set and we are back to the default values. Ok, there's probably more places where we are using the default soup session directly, we need to check that carefully, for now it make sense to use a sane default value for the accept-language property. 1233380 7 289814 cgarcia 2016-09-26 05:42:46 -0700 Comment on attachment 289814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289814&action=review > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:69 > + auto cookieJar = adoptGRef(createPrivateBrowsingCookieJar()); > + auto newSoupSession = std::unique_ptr<SoupNetworkSession>(new SoupNetworkSession(cookieJar.get())); > + g_object_set(newSoupSession.get(), "accept-language", "en-us", nullptr); > + return newSoupSession; Maybe we could simply add a fixme here. 1233493 8 mcatanzaro 2016-09-26 11:56:22 -0700 Please do add a FIXME 1233515 9 289842 youennf 2016-09-26 12:25:23 -0700 Created attachment 289842 Patch for landing 1233530 10 289842 commit-queue 2016-09-26 12:57:27 -0700 Comment on attachment 289842 Patch for landing Clearing flags on attachment: 289842 Committed r206387: <http://trac.webkit.org/changeset/206387> 1233531 11 commit-queue 2016-09-26 12:57:31 -0700 All reviewed patches have been landed. Closing bug. 1233800 12 youennf 2016-09-27 03:41:25 -0700 Patch is not working according bots. 1233801 13 289931 youennf 2016-09-27 03:42:42 -0700 Created attachment 289931 Patch 1233802 14 youennf 2016-09-27 03:43:01 -0700 (In reply to comment #13) > Created attachment 289931 [details] > Patch This time, it should work... 1233806 15 ossy 2016-09-27 04:06:16 -0700 (In reply to comment #10) > Comment on attachment 289842 [details] > Patch for landing > > Clearing flags on attachment: 289842 > > Committed r206387: <http://trac.webkit.org/changeset/206387> It made all perf tests fail on EFL and GTK performance bots: - https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/6718 - https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2%20%28Perf%29/builds/10018 (process:23353): GLib-GObject-CRITICAL **: g_object_set: assertion 'G_IS_OBJECT (object)' failed ... 1233834 16 289931 commit-queue 2016-09-27 06:13:33 -0700 Comment on attachment 289931 Patch Clearing flags on attachment: 289931 Committed r206431: <http://trac.webkit.org/changeset/206431> 1233835 17 commit-queue 2016-09-27 06:13:38 -0700 All reviewed patches have been landed. Closing bug. 289814 2016-09-26 03:00:46 -0700 2016-09-26 12:25:14 -0700 Patch bug-162547-20160926115749.patch text/plain 2031 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2Mjk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjI1ZDNlZGUxZWJjZjJm MzBiYTQzNmExYzNkZjUzNDdiOTFkMTY2OC4uMzBlODNlY2M1OGY2MTIyOTQxYWZlZmQ1OGNiNTNh NmFhMzFlZjc2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbR1RLXVtFRkxdIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2Jhc2ljL2FjY2VwdC1oZWFkZXIu aHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjI1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDb3ZlcmVkIGJ5IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvZmV0Y2gvYXBpL2Jhc2ljL2FjY2VwdC1oZWFkZXIuaHRtbCBub3cgcGFzc2luZy4KKwor ICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6U291cE5ldHdvcmtTZXNzaW9uOjpjcmVhdGVUZXN0aW5nU2Vzc2lv bik6IFNldHRpbmcgYSBkZWZhdWx0IEFjY2VwdC1MYW5ndWFnZSB2YWx1ZS4KKwogMjAxNi0wOS0y MyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBhIG5l dyBydW50aW1lIGZsYWcgZm9yIHdvcmsgb24gbW9kZXJuIG1lZGlhIGNvbnRyb2xzIChvZmYgYnkg ZGVmYXVsdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291 cC9Tb3VwTmV0d29ya1Nlc3Npb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAKaW5kZXggYjdlY2ZkZWZmN2UwZTNhM2MxMTFm NjBiNzdmYmQwZDg3YTdhN2I5OS4uYjE2ZmY5YzU5MWI4NTRkMTc0ZjI5NmY5MWMzNjc5OTMwMjdl YmVlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Nv dXBOZXR3b3JrU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAKQEAgLTYzLDggKzYzLDEwIEBAIHN0ZDo6dW5p cXVlX3B0cjxTb3VwTmV0d29ya1Nlc3Npb24+IFNvdXBOZXR3b3JrU2Vzc2lvbjo6Y3JlYXRlUHJp dmF0ZUJyb3dzaW5nU2VzCiAKIHN0ZDo6dW5pcXVlX3B0cjxTb3VwTmV0d29ya1Nlc3Npb24+IFNv dXBOZXR3b3JrU2Vzc2lvbjo6Y3JlYXRlVGVzdGluZ1Nlc3Npb24oKQogewotICAgIEdSZWZQdHI8 U291cENvb2tpZUphcj4gY29va2llSmFyID0gYWRvcHRHUmVmKGNyZWF0ZVByaXZhdGVCcm93c2lu Z0Nvb2tpZUphcigpKTsKLSAgICByZXR1cm4gc3RkOjp1bmlxdWVfcHRyPFNvdXBOZXR3b3JrU2Vz c2lvbj4obmV3IFNvdXBOZXR3b3JrU2Vzc2lvbihjb29raWVKYXIuZ2V0KCkpKTsKKyAgICBhdXRv IGNvb2tpZUphciA9IGFkb3B0R1JlZihjcmVhdGVQcml2YXRlQnJvd3NpbmdDb29raWVKYXIoKSk7 CisgICAgYXV0byBuZXdTb3VwU2Vzc2lvbiA9IHN0ZDo6dW5pcXVlX3B0cjxTb3VwTmV0d29ya1Nl c3Npb24+KG5ldyBTb3VwTmV0d29ya1Nlc3Npb24oY29va2llSmFyLmdldCgpKSk7CisgICAgZ19v YmplY3Rfc2V0KG5ld1NvdXBTZXNzaW9uLmdldCgpLCAiYWNjZXB0LWxhbmd1YWdlIiwgImVuLXVz IiwgbnVsbHB0cik7CisgICAgcmV0dXJuIG5ld1NvdXBTZXNzaW9uOwogfQogCiBzdGQ6OnVuaXF1 ZV9wdHI8U291cE5ldHdvcmtTZXNzaW9uPiBTb3VwTmV0d29ya1Nlc3Npb246OmNyZWF0ZUZvclNv dXBTZXNzaW9uKFNvdXBTZXNzaW9uKiBzb3VwU2Vzc2lvbikK 289842 2016-09-26 12:25:23 -0700 2016-09-27 03:42:35 -0700 Patch for landing bug-162547-20160926212225.patch text/plain 2156 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2Mzc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjdjZTJjOTIxY2RhNzU0 MzVkNWRiOTJkMjc0N2U3NmU0N2EwYmM5YS4uYmE5OWQ5YzQ5YjgwMDUzNGJjNjc1OWQ4N2E3NmFi NGEwMjZkOTRkMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI2ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbR1RLXVtFRkxdIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2Jhc2ljL2FjY2VwdC1oZWFkZXIu aHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjI1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBDYXJsb3MgR2FyY2lhIENhbXBv cy4KKworICAgICAgICBDb3ZlcmVkIGJ5IExheW91dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2Jhc2ljL2FjY2VwdC1oZWFkZXIuaHRtbCBub3cgcGFzc2lu Zy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6U291cE5ldHdvcmtTZXNzaW9uOjpjcmVhdGVUZXN0aW5n U2Vzc2lvbik6IFNldHRpbmcgYSBkZWZhdWx0IEFjY2VwdC1MYW5ndWFnZSB2YWx1ZS4KKwogMjAx Ni0wOS0yNiAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAg ICAgICAgc3RkOjp1bmlxdWVfcHRyIGRlbGV0ZXIgZnVuY3Rpb25zIHNob3VsZCBub3QgY2hlY2sg aWYgcG9pbnRlciBpcyBudWxsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24uY3BwCmluZGV4IGI3ZWNmZGVmZjdl MGUzYTNjMTExZjYwYjc3ZmJkMGQ4N2E3YTdiOTkuLjBjZmJkZjI1MDY5NjAwZjY0MzU4ZTRlMGI2 MjhhODk3ZGQ0ZTQ5MmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24uY3BwCkBAIC02Myw4ICs2MywxMSBA QCBzdGQ6OnVuaXF1ZV9wdHI8U291cE5ldHdvcmtTZXNzaW9uPiBTb3VwTmV0d29ya1Nlc3Npb246 OmNyZWF0ZVByaXZhdGVCcm93c2luZ1NlcwogCiBzdGQ6OnVuaXF1ZV9wdHI8U291cE5ldHdvcmtT ZXNzaW9uPiBTb3VwTmV0d29ya1Nlc3Npb246OmNyZWF0ZVRlc3RpbmdTZXNzaW9uKCkKIHsKLSAg ICBHUmVmUHRyPFNvdXBDb29raWVKYXI+IGNvb2tpZUphciA9IGFkb3B0R1JlZihjcmVhdGVQcml2 YXRlQnJvd3NpbmdDb29raWVKYXIoKSk7Ci0gICAgcmV0dXJuIHN0ZDo6dW5pcXVlX3B0cjxTb3Vw TmV0d29ya1Nlc3Npb24+KG5ldyBTb3VwTmV0d29ya1Nlc3Npb24oY29va2llSmFyLmdldCgpKSk7 CisgICAgYXV0byBjb29raWVKYXIgPSBhZG9wdEdSZWYoY3JlYXRlUHJpdmF0ZUJyb3dzaW5nQ29v a2llSmFyKCkpOworICAgIGF1dG8gbmV3U291cFNlc3Npb24gPSBzdGQ6OnVuaXF1ZV9wdHI8U291 cE5ldHdvcmtTZXNzaW9uPihuZXcgU291cE5ldHdvcmtTZXNzaW9uKGNvb2tpZUphci5nZXQoKSkp OworICAgIC8vIEZJWE1FOiBDcmVhdGluZyBhIHRlc3Rpbmcgc2Vzc2lvbiBpcyBsb3Npbmcgc291 cCBzZXNzaW9uIHZhbHVlcyBzZXQgd2hlbiBpbml0aWFsaXppbmcgdGhlIG5ldHdvcmsgcHJvY2Vz cy4KKyAgICBnX29iamVjdF9zZXQobmV3U291cFNlc3Npb24uZ2V0KCksICJhY2NlcHQtbGFuZ3Vh Z2UiLCAiZW4tdXMiLCBudWxscHRyKTsKKyAgICByZXR1cm4gbmV3U291cFNlc3Npb247CiB9CiAK IHN0ZDo6dW5pcXVlX3B0cjxTb3VwTmV0d29ya1Nlc3Npb24+IFNvdXBOZXR3b3JrU2Vzc2lvbjo6 Y3JlYXRlRm9yU291cFNlc3Npb24oU291cFNlc3Npb24qIHNvdXBTZXNzaW9uKQo= 289931 2016-09-27 03:42:42 -0700 2016-09-27 06:13:33 -0700 Patch bug-162547-20160927123943.patch text/plain 1770 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2NDE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNWNmNjk0MzM5MWI1YzU5 NjRmMDk4ODNlOTkxYTY4MWZlYzVhNWRlOC4uMmFlMTg5YTA5ZGM2YTg4NTliMmUwNjUzMmNhOGEz MmU2OGFkNjc4YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTI3ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBbR1RLXVtFRkxdIGltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2Jhc2ljL2FjY2VwdC1oZWFkZXIu aHRtbCBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjI1NDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpT b3VwTmV0d29ya1Nlc3Npb246OmNyZWF0ZVRlc3RpbmdTZXNzaW9uKTogU2V0dGluZyB0aGUgdW5k ZXJseWluZyBzb3VwU2Vzc2lvbi4KKwogMjAxNi0wOS0yNiAgSm9vbmdodW4gUGFyayAgPGpoNzE4 LnBhcmtAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gRml4IGRlYnVnIGJ1aWxkIGJyZWFr IHNpbmNlIHIyMDQyMDUuIFVucmV2aWV3ZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvc291cC9Tb3VwTmV0d29ya1Nlc3Npb24uY3BwIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAKaW5kZXggMGNm YmRmMjUwNjk2MDBmNjQzNThlNGUwYjYyOGE4OTdkZDRlNDkyYi4uZTdjZThlODEwZjZmNDg2MTky NjI1OWY5NzZmZGNmMmU5NzUzODZmNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAKQEAgLTY2LDcg KzY2LDcgQEAgc3RkOjp1bmlxdWVfcHRyPFNvdXBOZXR3b3JrU2Vzc2lvbj4gU291cE5ldHdvcmtT ZXNzaW9uOjpjcmVhdGVUZXN0aW5nU2Vzc2lvbigpCiAgICAgYXV0byBjb29raWVKYXIgPSBhZG9w dEdSZWYoY3JlYXRlUHJpdmF0ZUJyb3dzaW5nQ29va2llSmFyKCkpOwogICAgIGF1dG8gbmV3U291 cFNlc3Npb24gPSBzdGQ6OnVuaXF1ZV9wdHI8U291cE5ldHdvcmtTZXNzaW9uPihuZXcgU291cE5l dHdvcmtTZXNzaW9uKGNvb2tpZUphci5nZXQoKSkpOwogICAgIC8vIEZJWE1FOiBDcmVhdGluZyBh IHRlc3Rpbmcgc2Vzc2lvbiBpcyBsb3Npbmcgc291cCBzZXNzaW9uIHZhbHVlcyBzZXQgd2hlbiBp bml0aWFsaXppbmcgdGhlIG5ldHdvcmsgcHJvY2Vzcy4KLSAgICBnX29iamVjdF9zZXQobmV3U291 cFNlc3Npb24uZ2V0KCksICJhY2NlcHQtbGFuZ3VhZ2UiLCAiZW4tdXMiLCBudWxscHRyKTsKKyAg ICBnX29iamVjdF9zZXQobmV3U291cFNlc3Npb24tPnNvdXBTZXNzaW9uKCksICJhY2NlcHQtbGFu Z3VhZ2UiLCAiZW4tdXMiLCBudWxscHRyKTsKICAgICByZXR1cm4gbmV3U291cFNlc3Npb247CiB9 CiAK