162522 2016-09-23 17:08:59 -0700 Web Inspector: REGRESSION (r203437): DOM not updated when editing Box Model values (border, margin, etc) 2016-09-25 10:30:29 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1233058 0 mattbaker 2016-09-23 17:08:59 -0700 Summary; DOM not updated when editing Box Model values (border, margin, etc). Steps to Reproduce: 1. Inspect any page 2. Elements tab > Styles sidebar > Box Model 3. Double-click a border value and change the width => Box Model UI updates but the inspected DOM node does not Note: Broke when CSSStyleDeclaration.setProperty() was aligned with the spec, and "!important" was no longer considered a valid priority (https://trac.webkit.org/changeset/203437). 1233061 1 webkit-bug-importer 2016-09-23 17:09:40 -0700 <rdar://problem/28458203> 1233063 2 289723 mattbaker 2016-09-23 17:17:55 -0700 Created attachment 289723 Patch 1233236 3 289723 bburg 2016-09-25 10:08:51 -0700 Comment on attachment 289723 Patch rs=me 1233237 4 289723 commit-queue 2016-09-25 10:30:25 -0700 Comment on attachment 289723 Patch Clearing flags on attachment: 289723 Committed r206363: <http://trac.webkit.org/changeset/206363> 1233238 5 commit-queue 2016-09-25 10:30:29 -0700 All reviewed patches have been landed. Closing bug. 289723 2016-09-23 17:17:55 -0700 2016-09-25 10:30:25 -0700 Patch bug-162522-20160923171503.patch text/plain 3163 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzIzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi NDQwZGI1NTMxNGEzZDhiMDIzOGQ4MGYyNzI5OTFhNGVmNTBmZWNjLi4yNzE4ZmQyYzA2ZDhhMmJj ZDJmMTBmODA3YzIxYzE5ZTUyYmY2ZGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wOS0yMyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjIwMzQzNyk6IERPTSBub3Qg dXBkYXRlZCB3aGVuIGVkaXRpbmcgQm94IE1vZGVsIHZhbHVlcyAoYm9yZGVyLCBtYXJnaW4sIGV0 YykKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjUy MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMjg0NTgyMDM+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0JveE1v ZGVsRGV0YWlsc1NlY3Rpb25Sb3cuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuQm94TW9kZWxE ZXRhaWxzU2VjdGlvblJvdy5wcm90b3R5cGUuX3JlZnJlc2gpOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkJveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cucHJvdG90eXBlLl9oaWdobGlnaHRET01Ob2Rl KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Cb3hNb2RlbERldGFpbHNTZWN0aW9uUm93LnByb3Rv dHlwZS5fZWRpdGluZ0VuZGVkKToKKyAgICAgICAgRHJpdmUtYnkgc3R5bGUgZml4IGZvciBgZGVs ZXRlYC4gQWxzbyByZW1vdmVkIHVudXNlZCBwcm9wZXJ0aWVzLgorICAgICAgICAoV2ViSW5zcGVj dG9yLkJveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cucHJvdG90eXBlLl9hcHBseVVzZXJJbnB1dC5y ZXNvbHZlZE5vZGUudG9nZ2xlSW5saW5lU3R5bGVQcm9wZXJ0eSk6CisgICAgICAgIFVzZSBwcmlv cml0eSAiaW1wb3J0YW50IiBpbnN0ZWFkIG9mICIhaW1wb3J0YW50Ii4KKwogMjAxNi0wOS0yMSAg TWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3BlY3Rv cjogSW1wcm92ZSBvdXRwdXQgb2YgVGVzdEhhcm5lc3MuZXhwZWN0KiBmYWlsdXJlcwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQm94TW9kZWxE ZXRhaWxzU2VjdGlvblJvdy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0JveE1vZGVsRGV0YWlsc1NlY3Rpb25Sb3cuanMKaW5kZXggNmU2ODI1OWViMTJiN2Qz MmVkZjVhODQxNDBjZDIwNmIxMTczZGVkNS4uMjY0MWFiNDdmN2E0ZDgzMzFkNGMwYzEzZmNhZTc0 ZDM0ZDQ3ZTE0MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdy5qcworKysgYi9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Cb3hNb2RlbERldGFpbHNTZWN0aW9uUm93Lmpz CkBAIC01Myw3ICs1Myw3IEBAIFdlYkluc3BlY3Rvci5Cb3hNb2RlbERldGFpbHNTZWN0aW9uUm93 ID0gY2xhc3MgQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdyBleHRlbmRzCiAgICAgX3JlZnJlc2go KQogICAgIHsKICAgICAgICAgaWYgKHRoaXMuX2lnbm9yZU5leHRSZWZyZXNoKSB7Ci0gICAgICAg ICAgICBkZWxldGUgdGhpcy5faWdub3JlTmV4dFJlZnJlc2g7CisgICAgICAgICAgICB0aGlzLl9p Z25vcmVOZXh0UmVmcmVzaCA9IGZhbHNlOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9 CiAKQEAgLTg2LDcgKzg2LDcgQEAgV2ViSW5zcGVjdG9yLkJveE1vZGVsRGV0YWlsc1NlY3Rpb25S b3cgPSBjbGFzcyBCb3hNb2RlbERldGFpbHNTZWN0aW9uUm93IGV4dGVuZHMKICAgICAgICAgICAg IHRoaXMuX2hpZ2hsaWdodE1vZGUgPSBtb2RlOwogICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRv bVRyZWVNYW5hZ2VyLmhpZ2hsaWdodERPTU5vZGUobm9kZUlkLCBtb2RlKTsKICAgICAgICAgfSBl bHNlIHsKLSAgICAgICAgICAgIGRlbGV0ZSB0aGlzLl9oaWdobGlnaHRNb2RlOworICAgICAgICAg ICAgdGhpcy5faGlnaGxpZ2h0TW9kZSA9IG51bGw7CiAgICAgICAgICAgICBXZWJJbnNwZWN0b3Iu ZG9tVHJlZU1hbmFnZXIuaGlkZURPTU5vZGVIaWdobGlnaHQoKTsKICAgICAgICAgfQogCkBAIC0z NjEsMTAgKzM2MSw4IEBAIFdlYkluc3BlY3Rvci5Cb3hNb2RlbERldGFpbHNTZWN0aW9uUm93ID0g Y2xhc3MgQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdyBleHRlbmRzCiAKICAgICBfZWRpdGluZ0Vu ZGVkKGVsZW1lbnQsIGNvbnRleHQpCiAgICAgewotICAgICAgICBkZWxldGUgdGhpcy5vcmlnaW5h bFByb3BlcnR5RGF0YTsKLSAgICAgICAgZGVsZXRlIHRoaXMucHJldmlvdXNQcm9wZXJ0eURhdGFD YW5kaWRhdGU7CiAgICAgICAgIGVsZW1lbnQucmVtb3ZlRXZlbnRMaXN0ZW5lcigia2V5ZG93biIs IGNvbnRleHQua2V5RG93bkhhbmRsZXIsIGZhbHNlKTsKLSAgICAgICAgZGVsZXRlIHRoaXMuX2lz RWRpdGluZ01ldHJpY3M7CisgICAgICAgIHRoaXMuX2lzRWRpdGluZ01ldHJpY3MgPSBmYWxzZTsK ICAgICB9CiAKICAgICBfZWRpdGluZ0NhbmNlbGxlZChlbGVtZW50LCBjb250ZXh0KQpAQCAtNDIw LDcgKzQxOCw3IEBAIFdlYkluc3BlY3Rvci5Cb3hNb2RlbERldGFpbHNTZWN0aW9uUm93ID0gY2xh c3MgQm94TW9kZWxEZXRhaWxzU2VjdGlvblJvdyBleHRlbmRzCiAKICAgICAgICAgICAgIGZ1bmN0 aW9uIHRvZ2dsZUlubGluZVN0eWxlUHJvcGVydHkocHJvcGVydHksIHZhbHVlKQogICAgICAgICAg ICAgewotICAgICAgICAgICAgICAgIHRoaXMuc3R5bGUuc2V0UHJvcGVydHkocHJvcGVydHksIHZh bHVlLCAiIWltcG9ydGFudCIpOworICAgICAgICAgICAgICAgIHRoaXMuc3R5bGUuc2V0UHJvcGVy dHkocHJvcGVydHksIHZhbHVlLCAiaW1wb3J0YW50Iik7CiAgICAgICAgICAgICB9CiAKICAgICAg ICAgICAgIGZ1bmN0aW9uIGRpZFRvZ2dsZSgpCg==