162514 2016-09-23 14:49:30 -0700 [JSC] Allow fixedExecutableMemoryPoolSize to be set during build 2016-09-26 11:12:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 don.olmstead don.olmstead annulen commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1233002 0 don.olmstead 2016-09-23 14:49:30 -0700 Currently the memory pool size is set based on the CPU. The x64 version uses a 1GB pool size by default which is very large value. This value should be able to be specified by the port to allow overriding of the defaults. 1233023 1 289715 don.olmstead 2016-09-23 15:57:53 -0700 Created attachment 289715 Add macro This allows the size in MB to be specified by the port. In CMake you would use add_definitions(-DFIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB=<value>) within the Platform cmake file within JavaScriptCore. I'm open to changes to the name and also not sure if there should be any sort of static assert that ensures the validity of the value. 1233026 2 289715 mark.lam 2016-09-23 16:04:32 -0700 Comment on attachment 289715 Add macro LGTM. Did you want this reviewed? If so, please set the patch r attributes to r?. If you don't have committer privileges and want the patch committed, please set the patch cq attribute to cq?. 1233027 3 289715 mark.lam 2016-09-23 16:10:09 -0700 Comment on attachment 289715 Add macro View in context: https://bugs.webkit.org/attachment.cgi?id=289715&action=review r=me with suggestion. > Source/JavaScriptCore/jit/ExecutableAllocator.h:75 > +#if defined FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB nit: I prefer #ifdef FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB or # if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB) 1233036 4 289719 don.olmstead 2016-09-23 16:33:52 -0700 Created attachment 289719 Fix nits Fixing nits 1233466 5 289719 annulen 2016-09-26 10:57:10 -0700 Comment on attachment 289719 Fix nits View in context: https://bugs.webkit.org/attachment.cgi?id=289719&action=review > Source/JavaScriptCore/jit/ExecutableAllocator.h:75 > +#ifdef FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB I'd preferred #if defined(FIXED_EXECUTABLE_MEMORY_POOL_SIZE_IN_MB), it would be more in line with following #elif 1233473 6 annulen 2016-09-26 11:12:12 -0700 Committed r206379: <http://trac.webkit.org/changeset/206379> 289715 2016-09-23 15:57:53 -0700 2016-09-23 16:33:52 -0700 Add macro bug162514.diff text/plain 1272 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNjYWYyMTguLjgwMGQwZjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA5LTIzICBEb24gT2xtc3RlYWQg IDxkb24ub2xtc3RlYWRAYW0uc29ueS5jb20+CisKKyAgICAgICAgW0pTQ10gQWxsb3cgZml4ZWRF eGVjdXRhYmxlTWVtb3J5UG9vbFNpemUgdG8gYmUgc2V0IGR1cmluZyBidWlsZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNTE0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFs bG9jYXRvci5oOgorCiAyMDE2LTA5LTIzICBDYWl0bGluIFBvdHRlciAgPGNhaXRwQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0pTQ10gSW1wbGVtZW50IHBhcnNpbmcgb2YgQXN5bmMgRnVuY3Rpb25z CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0 b3IuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCmlu ZGV4IGIzZjU3YWMuLmY2ZThlY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv RXhlY3V0YWJsZUFsbG9jYXRvci5oCkBAIC03Miw3ICs3Miw5IEBAIGNsYXNzIERlbWFuZEV4ZWN1 dGFibGVBbGxvY2F0b3I7CiAjZW5kaWYKIAogI2lmIEVOQUJMRShFWEVDVVRBQkxFX0FMTE9DQVRP Ul9GSVhFRCkKLSNpZiBDUFUoQVJNKQorI2lmIGRlZmluZWQgRklYRURfRVhFQ1VUQUJMRV9NRU1P UllfUE9PTF9TSVpFX0lOX01CCitzdGF0aWMgY29uc3Qgc2l6ZV90IGZpeGVkRXhlY3V0YWJsZU1l bW9yeVBvb2xTaXplID0gRklYRURfRVhFQ1VUQUJMRV9NRU1PUllfUE9PTF9TSVpFX0lOX01CICog MTAyNCAqIDEwMjQ7CisjZWxpZiBDUFUoQVJNKQogc3RhdGljIGNvbnN0IHNpemVfdCBmaXhlZEV4 ZWN1dGFibGVNZW1vcnlQb29sU2l6ZSA9IDE2ICogMTAyNCAqIDEwMjQ7CiAjZWxpZiBDUFUoQVJN NjQpCiBzdGF0aWMgY29uc3Qgc2l6ZV90IGZpeGVkRXhlY3V0YWJsZU1lbW9yeVBvb2xTaXplID0g MzIgKiAxMDI0ICogMTAyNDsK 289719 2016-09-23 16:33:52 -0700 2016-09-23 16:35:19 -0700 Fix nits bug162514.diff text/plain 1267 don.olmstead ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDNjYWYyMTguLjgwMGQwZjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE2LTA5LTIzICBEb24gT2xtc3RlYWQg IDxkb24ub2xtc3RlYWRAYW0uc29ueS5jb20+CisKKyAgICAgICAgW0pTQ10gQWxsb3cgZml4ZWRF eGVjdXRhYmxlTWVtb3J5UG9vbFNpemUgdG8gYmUgc2V0IGR1cmluZyBidWlsZAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNTE0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBqaXQvRXhlY3V0YWJsZUFs bG9jYXRvci5oOgorCiAyMDE2LTA5LTIzICBDYWl0bGluIFBvdHRlciAgPGNhaXRwQGlnYWxpYS5j b20+CiAKICAgICAgICAgW0pTQ10gSW1wbGVtZW50IHBhcnNpbmcgb2YgQXN5bmMgRnVuY3Rpb25z CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0 b3IuaCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCmlu ZGV4IGIzZjU3YWMuLjkxMGU3NWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9q aXQvRXhlY3V0YWJsZUFsbG9jYXRvci5oCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9qaXQv RXhlY3V0YWJsZUFsbG9jYXRvci5oCkBAIC03Miw3ICs3Miw5IEBAIGNsYXNzIERlbWFuZEV4ZWN1 dGFibGVBbGxvY2F0b3I7CiAjZW5kaWYKIAogI2lmIEVOQUJMRShFWEVDVVRBQkxFX0FMTE9DQVRP Ul9GSVhFRCkKLSNpZiBDUFUoQVJNKQorI2lmZGVmIEZJWEVEX0VYRUNVVEFCTEVfTUVNT1JZX1BP T0xfU0laRV9JTl9NQgorc3RhdGljIGNvbnN0IHNpemVfdCBmaXhlZEV4ZWN1dGFibGVNZW1vcnlQ b29sU2l6ZSA9IEZJWEVEX0VYRUNVVEFCTEVfTUVNT1JZX1BPT0xfU0laRV9JTl9NQiAqIDEwMjQg KiAxMDI0OworI2VsaWYgQ1BVKEFSTSkKIHN0YXRpYyBjb25zdCBzaXplX3QgZml4ZWRFeGVjdXRh YmxlTWVtb3J5UG9vbFNpemUgPSAxNiAqIDEwMjQgKiAxMDI0OwogI2VsaWYgQ1BVKEFSTTY0KQog c3RhdGljIGNvbnN0IHNpemVfdCBmaXhlZEV4ZWN1dGFibGVNZW1vcnlQb29sU2l6ZSA9IDMyICog MTAyNCAqIDEwMjQ7Cg==