162498 2016-09-23 11:00:44 -0700 Allow Seeking from the now playing controls 2016-09-24 20:02:48 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson webkit-bug-importer wenson_hsieh oldest_to_newest 1232909 0 jer.noble 2016-09-23 11:00:44 -0700 Allow Seeking from the now playing controls 1232911 1 289692 jer.noble 2016-09-23 11:02:12 -0700 Created attachment 289692 Patch 1232912 2 jer.noble 2016-09-23 11:02:55 -0700 <rdar://problem/28435352> 1232913 3 wenson_hsieh 2016-09-23 11:04:43 -0700 We discussed this change, and agree that it makes sense. r=me! 1232945 4 jer.noble 2016-09-23 12:43:16 -0700 Committed r206322: <http://trac.webkit.org/changeset/206322> 1233187 5 wenson_hsieh 2016-09-24 20:02:48 -0700 Hm...I just realized looking at this change again that this change did not fix the problem. In fact, we were already marking MRMediaRemoteCommandSeekToPlaybackPosition as enabled in the code below this change. `CFArrayAppendValue(commandInfoArray.get(), seekCommandInfo.get());` The problem lies elsewhere, in MediaRemote. 289692 2016-09-23 11:02:12 -0700 2016-09-23 11:48:59 -0700 Patch bug-162498-20160923105921.patch text/plain 1666 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjg1YmMyMDI4MTc3Y2Ux NTUzZTU3YWRkZmZjODFhMzMyNmQ5ZmQwZi4uMWYzYTYwZWExYzc5N2NhNTY0NWYwODA4YmE5YWYx MTQxMzYzYmZiZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE4IEBACiAyMDE2LTA5LTIzICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIEFsbG93IFNlZWtpbmcgZnJv bSB0aGUgbm93IHBsYXlpbmcgY29udHJvbHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MjQ5OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFdlIGFscmVhZHkgaGF2ZSBhIGhhbmRsZXIgZm9yIHNlZWsgY29t bWFuZHMsIHdlIGp1c3QgbmVlZCB0byByZWdpc3RlciB0aGF0IGhhbmRsZXIKKyAgICAgICAgd2l0 aCBNZWRpYVJlbW90ZS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9SZW1vdGVDb21tYW5kTGlz dGVuZXJNYWMubW06CisgICAgICAgIChXZWJDb3JlOjpSZW1vdGVDb21tYW5kTGlzdGVuZXJNYWM6 OnVwZGF0ZVN1cHBvcnRlZENvbW1hbmRzKToKKworMjAxNi0wOS0yMyAgSmVyIE5vYmxlICA8amVy Lm5vYmxlQGFwcGxlLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeDsgTmVlZCBT dHJpbmdQcmludFN0cmVhbS5oIG9uIHBsYXRmb3JtcyB3aGljaCBkb24ndCBpbmNsdWRlIGl0IGlu CiAgICAgICAgIHRoZSBwcmVjb21waWxlZCBoZWFkZXIuCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL21hYy9SZW1vdGVDb21tYW5kTGlzdGVuZXJNYWMubW0gYi9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9tYWMvUmVtb3RlQ29tbWFuZExpc3RlbmVyTWFjLm1tCmluZGV4IDE0 MzI3MTkxNDBkMzI5NmY5YWE2MjgwMzRmMmYyZTlmOTJkYmM5OTcuLjljNmM5ZGI4NTllODZkYmE0 ZmMyMTUxOGQzYjczYjI2ZjI2OGNmMzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9SZW1vdGVDb21tYW5kTGlzdGVuZXJNYWMubW0KKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbWFjL1JlbW90ZUNvbW1hbmRMaXN0ZW5lck1hYy5tbQpAQCAtNTQsNiArNTQsNyBA QCB2b2lkIFJlbW90ZUNvbW1hbmRMaXN0ZW5lck1hYzo6dXBkYXRlU3VwcG9ydGVkQ29tbWFuZHMo KQogICAgICAgICBNUk1lZGlhUmVtb3RlQ29tbWFuZEVuZEZhc3RGb3J3YXJkLAogICAgICAgICBN Uk1lZGlhUmVtb3RlQ29tbWFuZEJlZ2luUmV3aW5kLAogICAgICAgICBNUk1lZGlhUmVtb3RlQ29t bWFuZEVuZFJld2luZCwKKyAgICAgICAgTVJNZWRpYVJlbW90ZUNvbW1hbmRTZWVrVG9QbGF5YmFj a1Bvc2l0aW9uLAogICAgIH07CiAKICAgICBhdXRvIGNvbW1hbmRJbmZvQXJyYXkgPSBhZG9wdENG KENGQXJyYXlDcmVhdGVNdXRhYmxlKGtDRkFsbG9jYXRvckRlZmF1bHQsIHNpemVvZihzdXBwb3J0 ZWRDb21tYW5kcykgLyBzaXplb2YoTVJNZWRpYVJlbW90ZUNvbW1hbmQpLCAma0NGVHlwZUFycmF5 Q2FsbEJhY2tzKSk7Cg==