162491 2016-09-23 08:57:40 -0700 [GStreamer] Support flipY for GPU-to-GPU copy of video textures to WebGL 2016-09-26 03:23:12 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 olivier.blin webkit-unassigned bugs-noreply cgarcia commit-queue magomez mcatanzaro pnormand zan oldest_to_newest 1232858 0 olivier.blin 2016-09-23 08:57:40 -0700 GPU-GPU copy of video textures to WebGL has been added for GStreamer in bug 159928. It did not handle videos with inverted Y, and thus copy of such videos is not accelerated. This occurs for example on http://flimshaw.github.io/Valiant360/ 1232863 1 olivier.blin 2016-09-23 09:05:09 -0700 This occurs with apps using THREE.js, which defaults to flipY for textures. 1232864 2 289684 olivier.blin 2016-09-23 09:06:47 -0700 Created attachment 289684 Patch 1233357 3 289684 commit-queue 2016-09-26 03:23:07 -0700 Comment on attachment 289684 Patch Clearing flags on attachment: 289684 Committed r206369: <http://trac.webkit.org/changeset/206369> 1233358 4 commit-queue 2016-09-26 03:23:12 -0700 All reviewed patches have been landed. Closing bug. 289684 2016-09-23 09:06:47 -0700 2016-09-26 03:23:07 -0700 Patch bug-162491-20160923180354.patch text/plain 5370 olivier.blin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTgzNzkzZjhkM2U0ZmQ0 ZjdiMDhlOGJiMWI0Y2I2MzRkNThjNDUzMC4uZjg4ZGRjMGZiNWRhNjc3NzYwMzJiNDIzZjBjMDM3 OTA2MDQ4YjYyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA5LTIzICBPbGl2 aWVyIEJsaW4gIDxvbGl2aWVyLmJsaW5Ac29mdGF0aG9tZS5jb20+CisKKyAgICAgICAgW0dTdHJl YW1lcl0gU3VwcG9ydCBmbGlwWSBmb3IgR1BVLXRvLUdQVSBjb3B5IG9mIHZpZGVvIHRleHR1cmVz IHRvIFdlYkdMCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNjI0OTEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBHUFUtR1BVIGNvcHkgb2YgdmlkZW8gdGV4dHVyZXMgdG8gV2ViR0wgaGFzIGJlZW4gYWRkZWQg Zm9yCisgICAgICAgIEdTdHJlYW1lciBpbiBidWcgMTU5OTI4LiBJdCBkaWQgbm90IGhhbmRsZSB0 ZXh0dXJlcyB3aXRoIGludmVydGVkCisgICAgICAgIFksIGFuZCB0aHVzIGNvcHkgdG8gc3VjaCB0 ZXh0dXJlcyB3YXMgbm90IGFjY2VsZXJhdGVkLgorCisgICAgICAgIFRoaXMgb2NjdXJzIHdpdGgg VEhSRUUuanMgd2hpY2ggZGVmYXVsdHMgdG8gZmxpcFkgZm9yIHRleHR1cmVzLgorICAgICAgICBJ dCBjYW4gYmUgdGVzdGVkIG9uIGh0dHA6Ly9mbGltc2hhdy5naXRodWIuaW8vVmFsaWFudDM2MC8K KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXJCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lckJhc2U6OnBhaW50VG9DYWlyb1N1cmZhY2UpOgorICAgICAgICAoV2ViQ29yZTo6 TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6Y29weVZpZGVvVGV4dHVyZVRvUGxhdGZv cm1UZXh0dXJlKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2U6Om5hdGl2ZUltYWdlRm9yQ3VycmVudFRpbWUpOgorICAgICAgICAqIHBsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmg6CisKIDIw MTYtMDktMjIgIE9saXZpZXIgQmxpbiAgPG9saXZpZXIuYmxpbkBzb2Z0YXRob21lLmNvbT4KIAog ICAgICAgICBbR1N0cmVhbWVyXSBTdXBwb3J0IGEgZGlyZWN0IEdQVS10by1HUFUgY29weSBvZiB2 aWRlbyB0ZXh0dXJlcyB0byBXZWJHTApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVy UHJpdmF0ZUdTdHJlYW1lckJhc2UuY3BwCmluZGV4IDkxZTdmOGEyMjI2Y2MxZGI4NjM5M2MyMGUz NjZiNDlmZmU5NWExMzEuLmVlMTJlNGZlOTcwNTcwNWE1YTIxYmRiMWMwYzU4ODEwZWVhMTlhMzcg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJCYXNlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz ZS5jcHAKQEAgLTcxNiw3ICs3MTYsNyBAQCBHTENvbnRleHQqIE1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lckJhc2U6OnByZXBhcmVDb250ZXh0Rm9yQ2Fpcm9QYWludChHc3RWaWRlbwogfQogCiAv LyBUaGlzIHNob3VsZCBiZSBjYWxsZWQgd2l0aCB0aGUgc2FtcGxlIG11dGV4IGxvY2tlZC4KLWJv b2wgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6cGFpbnRUb0NhaXJvU3VyZmFjZShj YWlyb19zdXJmYWNlX3QqIG91dHB1dFN1cmZhY2UsIGNhaXJvX2RldmljZV90KiBkZXZpY2UsIEdz dFZpZGVvSW5mbyYgdmlkZW9JbmZvLCBjb25zdCBJbnRTaXplJiBzaXplLCBjb25zdCBJbnRTaXpl JiByb3RhdGVkU2l6ZSkKK2Jvb2wgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZTo6cGFp bnRUb0NhaXJvU3VyZmFjZShjYWlyb19zdXJmYWNlX3QqIG91dHB1dFN1cmZhY2UsIGNhaXJvX2Rl dmljZV90KiBkZXZpY2UsIEdzdFZpZGVvSW5mbyYgdmlkZW9JbmZvLCBjb25zdCBJbnRTaXplJiBz aXplLCBjb25zdCBJbnRTaXplJiByb3RhdGVkU2l6ZSwgYm9vbCBmbGlwWSkKIHsKICAgICBHc3RC dWZmZXIqIGJ1ZmZlciA9IGdzdF9zYW1wbGVfZ2V0X2J1ZmZlcihtX3NhbXBsZS5nZXQoKSk7CiAg ICAgR3N0VmlkZW9GcmFtZSB2aWRlb0ZyYW1lOwpAQCAtNzQ5LDYgKzc0OSwxMiBAQCBib29sIE1l ZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2U6OnBhaW50VG9DYWlyb1N1cmZhY2UoY2Fpcm9f c3VyZmFjZV90KiBvdXRwdQogICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAg YnJlYWs7CiAgICAgfQorCisgICAgaWYgKGZsaXBZKSB7CisgICAgICAgIGNhaXJvX3NjYWxlKGNy LmdldCgpLCAxLjBmLCAtMS4wZik7CisgICAgICAgIGNhaXJvX3RyYW5zbGF0ZShjci5nZXQoKSwg MC4wZiwgLXNpemUuaGVpZ2h0KCkpOworICAgIH0KKwogICAgIGNhaXJvX3NldF9zb3VyY2Vfc3Vy ZmFjZShjci5nZXQoKSwgc3VyZmFjZS5nZXQoKSwgMCwgMCk7CiAgICAgY2Fpcm9fc2V0X29wZXJh dG9yKGNyLmdldCgpLCBDQUlST19PUEVSQVRPUl9TT1VSQ0UpOwogICAgIGNhaXJvX3BhaW50KGNy LmdldCgpKTsKQEAgLTc2Nyw3ICs3NzMsNyBAQCBib29sIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJl YW1lckJhc2U6OmNvcHlWaWRlb1RleHR1cmVUb1BsYXRmb3JtVGV4dHVyZShHcmFwaGljcwogICAg IGlmIChtX3VzaW5nRmFsbGJhY2tWaWRlb1NpbmspCiAgICAgICAgIHJldHVybiBmYWxzZTsKIAot ICAgIGlmIChmbGlwWSB8fCBwcmVtdWx0aXBseUFscGhhKQorICAgIGlmIChwcmVtdWx0aXBseUFs cGhhKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKICAgICBHc3RWaWRlb0luZm8gdmlkZW9JbmZv OwpAQCAtNzg3LDcgKzc5Myw3IEBAIGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFz ZTo6Y29weVZpZGVvVGV4dHVyZVRvUGxhdGZvcm1UZXh0dXJlKEdyYXBoaWNzCiAgICAgY29udGV4 dC0+Z2V0VGV4UGFyYW1ldGVyaXYob3V0cHV0VGFyZ2V0LCBHTF9URVhUVVJFX01BR19GSUxURVIs ICZtYWdGaWx0ZXIpOwogCiAgICAgUmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4gb3V0cHV0U3VyZmFj ZSA9IGFkb3B0UmVmKGNhaXJvX2dsX3N1cmZhY2VfY3JlYXRlX2Zvcl90ZXh0dXJlKGdsQ29udGV4 dC0+Y2Fpcm9EZXZpY2UoKSwgQ0FJUk9fQ09OVEVOVF9DT0xPUl9BTFBIQSwgb3V0cHV0VGV4dHVy ZSwgcm90YXRlZFNpemUud2lkdGgoKSwgcm90YXRlZFNpemUuaGVpZ2h0KCkpKTsKLSAgICBpZiAo IXBhaW50VG9DYWlyb1N1cmZhY2Uob3V0cHV0U3VyZmFjZS5nZXQoKSwgZ2xDb250ZXh0LT5jYWly b0RldmljZSgpLCB2aWRlb0luZm8sIHNpemUsIHJvdGF0ZWRTaXplKSkKKyAgICBpZiAoIXBhaW50 VG9DYWlyb1N1cmZhY2Uob3V0cHV0U3VyZmFjZS5nZXQoKSwgZ2xDb250ZXh0LT5jYWlyb0Rldmlj ZSgpLCB2aWRlb0luZm8sIHNpemUsIHJvdGF0ZWRTaXplLCBmbGlwWSkpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAogICAgIGNvbnRleHQtPmJpbmRUZXh0dXJlKG91dHB1dFRhcmdldCwgb3V0cHV0 VGV4dHVyZSk7CkBAIC04MTEsNyArODE3LDcgQEAgTmF0aXZlSW1hZ2VQdHIgTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyQmFzZTo6bmF0aXZlSW1hZ2VGb3JDdXJyZW50VGltZSgpCiAgICAgICAg IHJldHVybiBudWxscHRyOwogCiAgICAgUmVmUHRyPGNhaXJvX3N1cmZhY2VfdD4gcm90YXRlZFN1 cmZhY2UgPSBhZG9wdFJlZihjYWlyb19nbF9zdXJmYWNlX2NyZWF0ZShjb250ZXh0LT5jYWlyb0Rl dmljZSgpLCBDQUlST19DT05URU5UX0NPTE9SX0FMUEhBLCByb3RhdGVkU2l6ZS53aWR0aCgpLCBy b3RhdGVkU2l6ZS5oZWlnaHQoKSkpOwotICAgIGlmICghcGFpbnRUb0NhaXJvU3VyZmFjZShyb3Rh dGVkU3VyZmFjZS5nZXQoKSwgY29udGV4dC0+Y2Fpcm9EZXZpY2UoKSwgdmlkZW9JbmZvLCBzaXpl LCByb3RhdGVkU2l6ZSkpCisgICAgaWYgKCFwYWludFRvQ2Fpcm9TdXJmYWNlKHJvdGF0ZWRTdXJm YWNlLmdldCgpLCBjb250ZXh0LT5jYWlyb0RldmljZSgpLCB2aWRlb0luZm8sIHNpemUsIHJvdGF0 ZWRTaXplLCBmYWxzZSkpCiAgICAgICAgIHJldHVybiBudWxscHRyOwogCiAgICAgcmV0dXJuIHJv dGF0ZWRTdXJmYWNlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lckJhc2UuaCBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9NZWRpYVBsYXllclByaXZhdGVHU3Ry ZWFtZXJCYXNlLmgKaW5kZXggZTRhYzljODQwNzc2MjE5YjY5MTExNzkzNzBiYThjMWNkZmExYWE4 NS4uMzZiZDhhNTY0NWIxMTYzYjY3NTE2M2EyZTZlOWZkM2I1NDQyM2NhYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJp dmF0ZUdTdHJlYW1lckJhc2UuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyQmFzZS5oCkBAIC0xMzMsNyAr MTMzLDcgQEAgcHJvdGVjdGVkOgogICAgIEdzdEVsZW1lbnQqIGNyZWF0ZUdMQXBwU2luaygpOwog ICAgIEdzdEVsZW1lbnQqIGNyZWF0ZVZpZGVvU2lua0dMKCk7CiAgICAgR0xDb250ZXh0KiBwcmVw YXJlQ29udGV4dEZvckNhaXJvUGFpbnQoR3N0VmlkZW9JbmZvJiwgSW50U2l6ZSYsIEludFNpemUm KTsKLSAgICBib29sIHBhaW50VG9DYWlyb1N1cmZhY2UoY2Fpcm9fc3VyZmFjZV90KiwgY2Fpcm9f ZGV2aWNlX3QqLCBHc3RWaWRlb0luZm8mLCBjb25zdCBJbnRTaXplJiwgY29uc3QgSW50U2l6ZSYp OworICAgIGJvb2wgcGFpbnRUb0NhaXJvU3VyZmFjZShjYWlyb19zdXJmYWNlX3QqLCBjYWlyb19k ZXZpY2VfdCosIEdzdFZpZGVvSW5mbyYsIGNvbnN0IEludFNpemUmLCBjb25zdCBJbnRTaXplJiwg Ym9vbCk7CiAjZW5kaWYKIAogICAgIHZvaWQgc2V0U3RyZWFtVm9sdW1lRWxlbWVudChHc3RTdHJl YW1Wb2x1bWUqKTsK