162463 2016-09-22 14:39:01 -0700 Style Checking Error when Objective C Blocks passed as Argument 2016-10-07 08:03:31 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbedard jbedard commit-queue glenn lforschler oldest_to_newest 1232634 0 jbedard 2016-09-22 14:39:01 -0700 Bug 161450 uncovered this. The style checker flags Objective C blocks as invalid syntax when they are passed as an argument to an Objective C function. 1232638 1 289601 jbedard 2016-09-22 14:43:28 -0700 Created attachment 289601 Patch 1237595 2 289601 commit-queue 2016-10-07 08:03:28 -0700 Comment on attachment 289601 Patch Clearing flags on attachment: 289601 Committed r206911: <http://trac.webkit.org/changeset/206911> 1237596 3 commit-queue 2016-10-07 08:03:31 -0700 All reviewed patches have been landed. Closing bug. 289601 2016-09-22 14:43:28 -0700 2016-10-07 08:03:28 -0700 Patch bug-162463-20160922144037.patch text/plain 2576 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNjI3NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA5LTIyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBTdHlsZSBDaGVja2luZyBFcnJvciB3aGVuIE9iamVjdGl2ZSBDIEJsb2Nr cyBwYXNzZWQgYXMgQXJndW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE2MjQ2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHk6Cisg ICAgICAgIChyZWdleF9mb3JfbGFtYmRhc19hbmRfYmxvY2tzKTogQ29uc2lkZXIgY2FzZSB3aGVy ZSBibG9jayBpcyBwYXNzZWQgYXMgYSBmdW5jdGlvbiBhcmd1bWVudC4KKyAgICAgICAgKiBTY3Jp cHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91bml0dGVzdC5weToKKyAgICAgICAgKENw cFN0eWxlVGVzdC50ZXN0X29iamVjdGl2ZV9jX2Jsb2NrX2FzX2FyZ3VtZW50KTogVGVzdCBjYXNl IHdoZXJlIGJsb2NrIGlzIHBhc3NlZCBhcyBhIGZ1bmN0aW9uIGFyZ3VtZW50LiAKKwogMjAxNi0w OS0yMiAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgQXV0 b21hdGljIFRleHQgUmVwbGFjZW1lbnQgVGVzdGluZyBpbiBXZWJLaXQyCkluZGV4OiBUb29scy9T Y3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29s cy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcC5weQkocmV2aXNpb24gMjA2MjEx KQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHAucHkJKHdvcmtp bmcgY29weSkKQEAgLTEyODMsNyArMTI4Myw3IEBAIGNsYXNzIF9FbnVtU3RhdGUob2JqZWN0KToK IAogZGVmIHJlZ2V4X2Zvcl9sYW1iZGFzX2FuZF9ibG9ja3MobGluZSwgbGluZV9udW1iZXIsIGZp bGVfc3RhdGUsIGVycm9yKToKICAgICBjcHBfcmVzdWx0ID0gc2VhcmNoKHInXHNcWy4qP1xdXHMn LCBsaW5lKQotICAgIG9iamNfcmVzdWx0ID0gc2VhcmNoKHInKFxzXF5ccz9cKC4qP1wpXHN8XF5c cz9ceyknLCBsaW5lKQorICAgIG9iamNfcmVzdWx0ID0gc2VhcmNoKHInKFxzXF5ccz9cKC4qP1wp XHN8XF5ccz9ce3w6XF5ccz9cKC4qP1wpXHNceyknLCBsaW5lKQogICAgIGlmIGNwcF9yZXN1bHQ6 CiAgICAgICAgIGdyb3VwID0gY3BwX3Jlc3VsdC5ncm91cCgpCiAgICAgICAgIHRhcmdfZXJyb3Ig PSBOb25lCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2NoZWNrZXJzL2NwcF91 bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3N0eWxlL2No ZWNrZXJzL2NwcF91bml0dGVzdC5weQkocmV2aXNpb24gMjA2MjExKQorKysgVG9vbHMvU2NyaXB0 cy93ZWJraXRweS9zdHlsZS9jaGVja2Vycy9jcHBfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkK QEAgLTE5MDAsNiArMTkwMCwxMSBAQCBjbGFzcyBDcHBTdHlsZVRlc3QoQ3BwU3R5bGVUZXN0QmFz ZSk6CiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgXnsnLCAnTm8gc3BhY2UgYmV0 d2VlbiBeIGFuZCBibG9jayBkZWZpbml0aW9uLiAgW3doaXRlc3BhY2UvYnJhY2tldHNdIFs0XScs ICdmb28ubScpCiAgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAgICAgICAgXiAoYXJnMSwgYXJn MikgeycsICdFeHRyYSBzcGFjZSBiZXR3ZWVuIF4gYW5kIGJsb2NrIGFyZ3VtZW50cy4gIFt3aGl0 ZXNwYWNlL2JyYWNrZXRzXSBbNF0nLCAnZm9vLm0nKQogCisgICAgZGVmIHRlc3Rfb2JqZWN0aXZl X2NfYmxvY2tfYXNfYXJndW1lbnQoc2VsZik6CisgICAgICAgIHNlbGYuYXNzZXJ0X2xpbnQoJyAg ICAgICAgd2l0aExhbWJkYTpeKHZhciwgdmFyX3JlZikgeycsICcnLCAnZm9vLm1tJykKKyAgICAg ICAgc2VsZi5hc3NlcnRfbGludCgnICAgICAgICB3aXRoTGFtYmRhOl4geycsICcnLCAnZm9vLm0n KQorICAgICAgICBzZWxmLmFzc2VydF9saW50KCcgICAgICAgIHdpdGhMYW1iZGE6XnsnLCAnTm8g c3BhY2UgYmV0d2VlbiBeIGFuZCBibG9jayBkZWZpbml0aW9uLiAgW3doaXRlc3BhY2UvYnJhY2tl dHNdIFs0XScsICdmb28ubScpCisKICAgICBkZWYgdGVzdF9zcGFjaW5nX2Fyb3VuZF9lbHNlKHNl bGYpOgogICAgICAgICBzZWxmLmFzc2VydF9saW50KCd9ZWxzZSB7JywgJ01pc3Npbmcgc3BhY2Ug YmVmb3JlIGVsc2UnCiAgICAgICAgICAgICAgICAgICAgICAgICAgJyAgW3doaXRlc3BhY2UvYnJh Y2VzXSBbNV0nKQo=