<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>162462</bug_id>
          
          <creation_ts>2016-09-22 14:25:07 -0700</creation_ts>
          <short_desc>SlotVisitor::visitChildren() could be better at calling cell-&gt;visitChildren()</short_desc>
          <delta_ts>2021-02-01 23:55:39 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>REOPENED</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Filip Pizlo">fpizlo</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1232618</commentid>
    <comment_count>0</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2016-09-22 14:25:07 -0700</bug_when>
    <thetext>For starters, it shouldn&apos;t go looking for the VM every time.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1232619</commentid>
    <comment_count>1</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2016-09-22 14:25:57 -0700</bug_when>
    <thetext>What if the right solution here is to JIT the SlotVisitor?  That would be cool.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1232620</commentid>
    <comment_count>2</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2016-09-22 14:26:21 -0700</bug_when>
    <thetext>(In reply to comment #1)
&gt; What if the right solution here is to JIT the SlotVisitor?  That would be
&gt; cool.

BTW that&apos;s not insane.  That&apos;s what Jikes RVM did: we had a specialized compiler for the visiting methods.  It was a progression.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1266520</commentid>
    <comment_count>3</comment_count>
    <who name="Filip Pizlo">fpizlo</who>
    <bug_when>2017-01-13 10:47:33 -0800</bug_when>
    <thetext>But an even better solution would be to just make methodTable() not terrible.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1724542</commentid>
    <comment_count>4</comment_count>
    <who name="Mark Lam">mark.lam</who>
    <bug_when>2021-02-01 23:55:39 -0800</bug_when>
    <thetext>Sorry.  Closed the wrong bug.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>