16244 2007-12-02 04:13:25 -0800 DRT doesn't handle platform specific pixel test results correctly 2008-01-07 11:59:26 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED P2 Normal --- 1 zimmermann zimmermann dev+webkit mjs oldest_to_newest 62953 0 zimmermann 2007-12-02 04:13:25 -0800 As the topic says we have a bug with platform specific pixel test results SVG wants cross-platform *-expected.txt results, but platform specific *-expected.png files - living in platform/<yourplatform>/svg/... Currently on every pixel test run DRT recreates the png files in svg/W3C-SVG-1.1 instead of platform/.. It compares correctly though against the PNGs living in platform/. 66395 1 zimmermann 2008-01-06 14:09:55 -0800 Note: I was wrong, it does not compare correctly! It compares against the new generated pixel test results :( 66470 2 zimmermann 2008-01-07 11:47:23 -0800 Okay, I have a fix for this. It highlights that we're missing several layout test pixel results in trunk: ? svg/carto.net/frameless-svg-parse-error-expected.checksum ? svg/carto.net/frameless-svg-parse-error-expected.png ? svg/css/getComputedStyle-basic-expected.checksum ? svg/css/getComputedStyle-basic-expected.png ? svg/css/glyph-orientation-rounding-test-expected.checksum ? svg/css/glyph-orientation-rounding-test-expected.png ? svg/custom/SVGException-expected.checksum ? svg/custom/SVGException-expected.png ? svg/custom/embedded-svg-disallowed-in-dashboard-expected.checksum ? svg/custom/embedded-svg-disallowed-in-dashboard-expected.png ? svg/custom/getBBox-js-expected.checksum ? svg/custom/getBBox-js-expected.png ? svg/custom/image-with-prefix-in-webarchive-expected.checksum ? svg/custom/image-with-prefix-in-webarchive-expected.png ? svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.checksum ? svg/custom/manually-parsed-embedded-svg-disallowed-in-dashboard-expected.png ? svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.checksum ? svg/custom/manually-parsed-svg-disallowed-in-dashboard-expected.png ? svg/custom/multiple-title-elements-expected.checksum ? svg/custom/multiple-title-elements-expected.png ? svg/custom/path-getTotalLength-expected.checksum ? svg/custom/path-getTotalLength-expected.png ? svg/custom/stroke-width-click-expected.checksum ? svg/custom/stroke-width-click-expected.png ? svg/custom/svg-disallowed-in-dashboard-object-expected.checksum ? svg/custom/svg-disallowed-in-dashboard-object-expected.png ? svg/custom/svg-features-expected.checksum ? svg/custom/svg-features-expected.png ? svg/custom/svgsvgelement-ctm-expected.checksum ? svg/custom/svgsvgelement-ctm-expected.png ? svg/custom/use-dynamic-append-expected.checksum ? svg/dom/animated-tearoff-equality-expected.checksum ? svg/dom/animated-tearoff-equality-expected.png ? svg/dom/animated-tearoff-lifespan-expected.checksum ? svg/dom/animated-tearoff-lifespan-expected.png ? svg/dom/font-face-elements-expected.checksum ? svg/dom/font-face-elements-expected.png ? svg/dom/length-list-parser-expected.checksum ? svg/dom/length-list-parser-expected.png ? svg/dom/path-parser-expected.checksum ? svg/dom/path-parser-expected.png ? svg/dom/points-parser-expected.checksum ? svg/dom/points-parser-expected.png ? svg/dom/preserve-aspect-ratio-parser-expected.checksum ? svg/dom/preserve-aspect-ratio-parser-expected.png ? svg/dom/rgb-color-parser-expected.checksum ? svg/dom/rgb-color-parser-expected.png ? svg/dom/string-list-parser-expected.checksum ? svg/dom/string-list-parser-expected.png ? svg/dom/svg-element-attribute-js-null-expected.checksum ? svg/dom/svg-element-attribute-js-null-expected.png ? svg/dom/transform-parser-expected.checksum ? svg/dom/transform-parser-expected.png ? svg/hixie/dynamic/001-expected.checksum ? svg/hixie/dynamic/001-expected.png ? svg/webarchive/svg-cursor-subresources-expected.checksum ? svg/webarchive/svg-cursor-subresources-expected.png ? svg/webarchive/svg-feimage-subresources-expected.checksum ? svg/webarchive/svg-feimage-subresources-expected.png ? svg/webarchive/svg-script-subresouces-expected.checksum ? svg/webarchive/svg-script-subresouces-expected.png 66471 3 18316 zimmermann 2008-01-07 11:48:38 -0800 Created attachment 18316 Initial patch 66474 4 18316 aroben 2008-01-07 11:57:08 -0800 Comment on attachment 18316 Initial patch r=me 66475 5 zimmermann 2008-01-07 11:59:26 -0800 Landed in r29235. 18316 2008-01-07 11:48:38 -0800 2008-01-07 11:57:08 -0800 Initial patch DRTFixes.diff text/plain 5100 zimmermann SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDI5MjI5 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDgtMDEt MDcgIE5pa29sYXMgWmltbWVybWFubiAgPHppbW1lcm1hbm5Aa2RlLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXhlczogaHR0cDovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNDQKKyAgICAgICAgRFJUIGRvZXNuJ3QgaGFu ZGxlIHBsYXRmb3JtIHNwZWNpZmljIHBpeGVsIHRlc3QgcmVzdWx0cyBjb3JyZWN0bHkuCisKKyAg ICAgICAgPHRlc3Q+LWV4cGVjdGVkLnR4dCBmaWxlcyBhbmQgPHRlc3Q+LWV4cGVjdGVkLnBuZyBm aWxlcyBtYXkgbm93IGxpdmUKKyAgICAgICAgaW4gZGlmZmVyZW50IGRpcmVjdG9yaWVzIChpZS4g YSBjcm9zcy1wbGF0Zm9ybSA8dGVzdD4tZXhwZWN0ZWQudHh0IGZpbGUKKyAgICAgICAgYW5kIGEg cGxhdGZvcm0tc3BlY2lmaWMgPHRlc3Q+LWV4cGVjdGVkLnBuZyBmaWxlKS4KKworICAgICAgICAq IFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKwogMjAwOC0wMS0wNCAgS2V2aW4gTWNDdWxsb3Vn aCAgPGttY2N1bGxvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYXJpbi4K SW5kZXg6IFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTY3JpcHRzL3J1 bi13ZWJraXQtdGVzdHMJKHJldmlzaW9uIDI5MjI5KQorKysgU2NyaXB0cy9ydW4td2Via2l0LXRl c3RzCSh3b3JraW5nIGNvcHkpCkBAIC03OCw3ICs3OCw3IEBAIHN1YiBzbG93ZXN0Y21wKCQkKTsK IHN1YiBzcGxpdHBhdGgoJCk7CiBzdWIgc3RyaXBFeHRlbnNpb24oJCk7CiBzdWIgaXNUZXh0T25s eVRlc3QoJCk7Ci1zdWIgZXhwZWN0ZWREaXJlY3RvcnlGb3JUZXN0KCQ7JCk7CitzdWIgZXhwZWN0 ZWREaXJlY3RvcnlGb3JUZXN0KCQ7JDskKTsKIHN1YiBwcmludEZhaWx1cmVNZXNzYWdlRm9yVGVz dCgkJCk7CiBzdWIgdG9VUkwoJCk7CiBzdWIgdG9XaW5kb3dzUGF0aCgkKTsKQEAgLTUxNSw3ICs1 MTUsNyBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewogICAgICRkdXJhdGlvbnN7JHRlc3R9ID0g dGltZSAtICRzdGFydFRpbWUgaWYgJHJlcG9ydDEwU2xvd2VzdDsKIAogICAgIG15ICRleHBlY3Rl ZDsKLSAgICBteSAkZXhwZWN0ZWREaXIgPSBleHBlY3RlZERpcmVjdG9yeUZvclRlc3QoJGJhc2Us ICRpc1RleHQpOworICAgIG15ICRleHBlY3RlZERpciA9IGV4cGVjdGVkRGlyZWN0b3J5Rm9yVGVz dCgkYmFzZSwgJGlzVGV4dCwgMCk7CiAgICAgJGV4cGVjdGVkUmVzdWx0RGlyZWN0b3J5eyRiYXNl fSA9ICRleHBlY3RlZERpcjsKIAogICAgIGlmICghJHJlc2V0UmVzdWx0cyAmJiBvcGVuIEVYUEVD VEVELCAiPCIsICIkZXhwZWN0ZWREaXIvJGJhc2UtJGV4cGVjdGVkVGFnLnR4dCIpIHsKQEAgLTU0 Nyw2ICs1NDcsOCBAQCBmb3IgbXkgJHRlc3QgKEB0ZXN0cykgewogICAgIG15ICRkaWZmUmVzdWx0 ID0gInBhc3NlZCI7CiAgICAgCiAgICAgaWYgKCRwaXhlbFRlc3RzKSB7CisgICAgICAgIG15ICRl eHBlY3RlZFBpeGVsRGlyID0gZXhwZWN0ZWREaXJlY3RvcnlGb3JUZXN0KCRiYXNlLCAkaXNUZXh0 LCAxKTsKKwogICAgICAgICBteSAkYWN0dWFsSGFzaCA9ICIiOwogICAgICAgICBteSAkZXhwZWN0 ZWRIYXNoID0gIiI7CiAgICAgICAgIG15ICRhY3R1YWxQTkdTaXplID0gMDsKQEAgLTU2MywxMCAr NTY1LDEwIEBAIGZvciBteSAkdGVzdCAoQHRlc3RzKSB7CiAgICAgICAgICAgICB9CiAgICAgICAg IH0KIAotICAgICAgICBpZiAoJGV4cGVjdGVkSGFzaCBuZSAkYWN0dWFsSGFzaCAmJiAtZiAiJGV4 cGVjdGVkRGlyLyRiYXNlLSRleHBlY3RlZFRhZy5wbmciKSB7Ci0gICAgICAgICAgICBteSAkZXhw ZWN0ZWRQTkdTaXplID0gLXMgIiRleHBlY3RlZERpci8kYmFzZS0kZXhwZWN0ZWRUYWcucG5nIjsK KyAgICAgICAgaWYgKCRleHBlY3RlZEhhc2ggbmUgJGFjdHVhbEhhc2ggJiYgLWYgIiRleHBlY3Rl ZFBpeGVsRGlyLyRiYXNlLSRleHBlY3RlZFRhZy5wbmciKSB7CisgICAgICAgICAgICBteSAkZXhw ZWN0ZWRQTkdTaXplID0gLXMgIiRleHBlY3RlZFBpeGVsRGlyLyRiYXNlLSRleHBlY3RlZFRhZy5w bmciOwogICAgICAgICAgICAgbXkgJGV4cGVjdGVkUE5HID0gIiI7Ci0gICAgICAgICAgICBvcGVu IEVYUEVDVEVEUE5HLCAiJGV4cGVjdGVkRGlyLyRiYXNlLSRleHBlY3RlZFRhZy5wbmciOworICAg ICAgICAgICAgb3BlbiBFWFBFQ1RFRFBORywgIiRleHBlY3RlZFBpeGVsRGlyLyRiYXNlLSRleHBl Y3RlZFRhZy5wbmciOwogICAgICAgICAgICAgcmVhZChFWFBFQ1RFRFBORywgJGV4cGVjdGVkUE5H LCAkZXhwZWN0ZWRQTkdTaXplKTsKIAogICAgICAgICAgICAgcHJpbnQgRElGRk9VVCAiQ29udGVu dC1sZW5ndGg6ICRhY3R1YWxQTkdTaXplXG4iOwpAQCAtNTg5LDE2ICs1OTEsMTYgQEAgZm9yIG15 ICR0ZXN0IChAdGVzdHMpIHsKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAgIGlm ICgkYWN0dWFsUE5HU2l6ZSAmJiAoJHJlc2V0UmVzdWx0cyB8fCAhLWYgIiRleHBlY3RlZERpci8k YmFzZS0kZXhwZWN0ZWRUYWcucG5nIikpIHsKLSAgICAgICAgICAgIG1rcGF0aCBjYXRmaWxlKCRl eHBlY3RlZERpciwgZGlybmFtZSgkYmFzZSkpIGlmICR0ZXN0RGlyZWN0b3J5IG5lICRleHBlY3Rl ZERpcjsKLSAgICAgICAgICAgIG9wZW4gRVhQRUNURUQsICI+IiwgIiRleHBlY3RlZERpci8kYmFz ZS1leHBlY3RlZC5wbmciIG9yIGRpZSAiY291bGQgbm90IGNyZWF0ZSAkZXhwZWN0ZWREaXIvJGJh c2UtZXhwZWN0ZWQucG5nXG4iOworICAgICAgICBpZiAoJGFjdHVhbFBOR1NpemUgJiYgKCRyZXNl dFJlc3VsdHMgfHwgIS1mICIkZXhwZWN0ZWRQaXhlbERpci8kYmFzZS0kZXhwZWN0ZWRUYWcucG5n IikpIHsKKyAgICAgICAgICAgIG1rcGF0aCBjYXRmaWxlKCRleHBlY3RlZFBpeGVsRGlyLCBkaXJu YW1lKCRiYXNlKSkgaWYgJHRlc3REaXJlY3RvcnkgbmUgJGV4cGVjdGVkUGl4ZWxEaXI7CisgICAg ICAgICAgICBvcGVuIEVYUEVDVEVELCAiPiIsICIkZXhwZWN0ZWRQaXhlbERpci8kYmFzZS1leHBl Y3RlZC5wbmciIG9yIGRpZSAiY291bGQgbm90IGNyZWF0ZSAkZXhwZWN0ZWRQaXhlbERpci8kYmFz ZS1leHBlY3RlZC5wbmdcbiI7CiAgICAgICAgICAgICBwcmludCBFWFBFQ1RFRCAkYWN0dWFsUE5H OwogICAgICAgICAgICAgY2xvc2UgRVhQRUNURUQ7CiAgICAgICAgIH0KIAogICAgICAgICAjIHVw ZGF0ZSB0aGUgZXhwZWN0ZWQgaGFzaCBpZiB0aGUgaW1hZ2UgZGlmZiBzYWlkIHRoYXQgdGhlcmUg d2FzIG5vIGRpZmZlcmVuY2UKLSAgICAgICAgaWYgKCRhY3R1YWxIYXNoIG5lICIiICYmICgkcmVz ZXRSZXN1bHRzIHx8ICEtZiAiJGV4cGVjdGVkRGlyLyRiYXNlLSRleHBlY3RlZFRhZy5jaGVja3N1 bSIpKSB7Ci0gICAgICAgICAgICBvcGVuIEVYUEVDVEVELCAiPiIsICIkZXhwZWN0ZWREaXIvJGJh c2UtJGV4cGVjdGVkVGFnLmNoZWNrc3VtIiBvciBkaWUgImNvdWxkIG5vdCBjcmVhdGUgJGV4cGVj dGVkRGlyLyRiYXNlLSRleHBlY3RlZFRhZy5jaGVja3N1bVxuIjsKKyAgICAgICAgaWYgKCRhY3R1 YWxIYXNoIG5lICIiICYmICgkcmVzZXRSZXN1bHRzIHx8ICEtZiAiJGV4cGVjdGVkUGl4ZWxEaXIv JGJhc2UtJGV4cGVjdGVkVGFnLmNoZWNrc3VtIikpIHsKKyAgICAgICAgICAgIG9wZW4gRVhQRUNU RUQsICI+IiwgIiRleHBlY3RlZFBpeGVsRGlyLyRiYXNlLSRleHBlY3RlZFRhZy5jaGVja3N1bSIg b3IgZGllICJjb3VsZCBub3QgY3JlYXRlICRleHBlY3RlZFBpeGVsRGlyLyRiYXNlLSRleHBlY3Rl ZFRhZy5jaGVja3N1bVxuIjsKICAgICAgICAgICAgIHByaW50IEVYUEVDVEVEICRhY3R1YWxIYXNo OwogICAgICAgICAgICAgY2xvc2UgRVhQRUNURUQ7CiAgICAgICAgIH0KQEAgLTEzMzcsMTcgKzEz MzksMjMgQEAgc3ViIGlzVGV4dE9ubHlUZXN0KCQpCiAgICAgcmV0dXJuICRpc1RleHQ7CiB9CiAK LXN1YiBleHBlY3RlZERpcmVjdG9yeUZvclRlc3QoJDskKQorc3ViIGV4cGVjdGVkRGlyZWN0b3J5 Rm9yVGVzdCgkOyQ7JCkKIHsKLSAgICBteSAoJGJhc2UsICRpc1RleHQpID0gQF87CisgICAgbXkg KCRiYXNlLCAkaXNUZXh0LCAkaXNQaXhlbFRlc3QpID0gQF87CiAKICAgICBteSBAZGlyZWN0b3Jp ZXMgPSBAcGxhdGZvcm1IaWVyYXJjaHk7CiAgICAgcHVzaCBAZGlyZWN0b3JpZXMsIG1hcCB7IGNh dGRpcigkcGxhdGZvcm1CYXNlRGlyZWN0b3J5LCAkXykgfSBxdyhtYWMtbGVvcGFyZCBtYWMpIGlm IGlzQ3lnd2luKCk7CiAgICAgcHVzaCBAZGlyZWN0b3JpZXMsICRleHBlY3RlZERpcmVjdG9yeTsK IAogICAgICMgSWYgd2UgYWxyZWFkeSBoYXZlIGV4cGVjdGVkIHJlc3VsdHMsIGp1c3QgcmV0dXJu IHRoZWlyIGxvY2F0aW9uLgotICAgIGZvcmVhY2ggbXkgJGRpcmVjdG9yeSAoQGRpcmVjdG9yaWVz KSB7Ci0gICAgICAgIHJldHVybiAkZGlyZWN0b3J5IGlmICgtZiAiJGRpcmVjdG9yeS8kYmFzZS0k ZXhwZWN0ZWRUYWcudHh0Iik7CisgICAgaWYgKCRpc1BpeGVsVGVzdCkgeworICAgICAgICBmb3Jl YWNoIG15ICRkaXJlY3RvcnkgKEBkaXJlY3RvcmllcykgeworICAgICAgICAgICAgcmV0dXJuICRk aXJlY3RvcnkgaWYgKC1mICIkZGlyZWN0b3J5LyRiYXNlLSRleHBlY3RlZFRhZy5wbmciKTsKKyAg ICAgICAgfQorICAgIH0gZWxzZSB7CisgICAgICAgIGZvcmVhY2ggbXkgJGRpcmVjdG9yeSAoQGRp cmVjdG9yaWVzKSB7CisgICAgICAgICAgICByZXR1cm4gJGRpcmVjdG9yeSBpZiAoLWYgIiRkaXJl Y3RvcnkvJGJhc2UtJGV4cGVjdGVkVGFnLnR4dCIpOworICAgICAgICB9CiAgICAgfQogCiAgICAg IyBGb3IgcGxhdGZvcm0tc3BlY2lmaWMgdGVzdHMsIHRoZSByZXN1bHRzIHNob3VsZCBnbyByaWdo dCBuZXh0IHRvIHRoZSB0ZXN0IGl0c2VsZi4K