162417 2016-09-22 10:50:13 -0700 Fences on x86 should be a lot cheaper 2016-09-22 17:11:51 -0700 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 162316 1 fpizlo fpizlo ap benjamin cdumez cmarcelo commit-queue dbates ggaren jfbastien keith_miller mark.lam msaboff saam oldest_to_newest 1232502 0 fpizlo 2016-09-22 10:50:13 -0700 Patch forthcoming. 1232591 1 289592 fpizlo 2016-09-22 13:55:23 -0700 Created attachment 289592 the patch 1232599 2 289592 mark.lam 2016-09-22 14:06:11 -0700 Comment on attachment 289592 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=289592&action=review r=me > Source/JavaScriptCore/ChangeLog:22 > + compiles to Air MemoryFence, which is just MacroAssembler::memoryFene(), this also changes /Fene/Fence/. 1232601 3 ggaren 2016-09-22 14:07:01 -0700 r=me Good fences make good neighbors. 1232603 4 fpizlo 2016-09-22 14:12:46 -0700 (In reply to comment #2) > Comment on attachment 289592 [details] > the patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289592&action=review > > r=me > > > Source/JavaScriptCore/ChangeLog:22 > > + compiles to Air MemoryFence, which is just MacroAssembler::memoryFene(), this also changes > > /Fene/Fence/. Fixed. 1232608 5 fpizlo 2016-09-22 14:15:15 -0700 Landed in https://trac.webkit.org/changeset/206274 1232675 6 jfbastien 2016-09-22 15:45:43 -0700 Very cool! I forgot to say when I suggested this: AFAIK this doesn't order non-temporals. You probably want to do lfence / sfence around Its anyways, so the point is moot. You may just have happened to get fencing for Its before because of the mfence :-) 1232718 7 fpizlo 2016-09-22 17:11:51 -0700 (In reply to comment #6) > Very cool! > > I forgot to say when I suggested this: AFAIK this doesn't order > non-temporals. You probably want to do lfence / sfence around Its anyways, > so the point is moot. You may just have happened to get fencing for Its > before because of the mfence :-) Fortunately, I don't think we use non-temporals anywhere. I had some code where I tried to use them at one point for memset, but that was when I found out that rep stosl is the bomb dot com. 289592 2016-09-22 13:55:23 -0700 2016-09-22 14:06:11 -0700 the patch blah.patch text/plain 6417 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA2MjcwKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM1IEBA CisyMDE2LTA5LTIyICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg RmVuY2VzIG9uIHg4NiBzaG91bGQgYmUgYSBsb3QgY2hlYXBlcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyNDE3CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSXQgdHVybnMgb3V0IHRoYXQ6CisgICAgICAg IAorICAgICAgICAgICAgbG9jazsgb3JsICQwLCAoJXJzcCkKKyAgICAgICAgCisgICAgICAgIGRv ZXMgZXZlcnl0aGluZyB0aGF0IHdlIHdhbnRlZCBmcm9tOgorICAgICAgICAKKyAgICAgICAgICAg IG1mZW5jZQorICAgICAgICAKKyAgICAgICAgQW5kIGl0J3MgYSBsb3QgZmFzdGVyLiBXaGVuIEkg dHJpZWQgbWZlbmNlIGZvciBtYWtpbmcgb2JqZWN0IHZpc2l0aW5nIGNvbmN1cnJlbnQtR0MtVFNP LQorICAgICAgICBmcmllbmRseSwgaXQgd2FzIGEgOSUgcmVncmVzc2lvbiBvbiBPY3RhbmUvc3Bs YXkuIEJ1dCB3aGVuIEkgdHJpZWQgb3J0b3AsIGl0IHdhcyBuZXV0cmFsLgorICAgICAgICBTbywg d2Ugc2hvdWxkIHVzZSBvcnRvcCBmcm9tIG5vdyBvbi4KKyAgICAgICAgCisgICAgICAgIFRoaXMg cGFydCBvZiB0aGUgY2hhbmdlIGlzIGZvciB0aGUgSklUcy4gTWFjcm9Bc3NlbWJsZXI6Om1lbW9y eUZlbmNlKCkgYXBwZWFycyB0byBhbHdheXMKKyAgICAgICAgbWVhbiBzb21ldGhpbmcgbGlrZSBh biBhY3FyZWwgZmVuY2UsIHNvIGl0J3Mgc2FmZSB0byBtYWtlIHRoaXMgdXNlIG9ydG9wLiBTaW5j ZSBCMydzIEZlbmNlCisgICAgICAgIGNvbXBpbGVzIHRvIEFpciBNZW1vcnlGZW5jZSwgd2hpY2gg aXMganVzdCBNYWNyb0Fzc2VtYmxlcjo6bWVtb3J5RmVuZSgpLCB0aGlzIGFsc28gY2hhbmdlcwor ICAgICAgICBCMyBjb2RlZ2VuLgorCisgICAgICAgICogYXNzZW1ibGVyL01hY3JvQXNzZW1ibGVy WDg2Q29tbW9uLmg6CisgICAgICAgIChKU0M6Ok1hY3JvQXNzZW1ibGVyWDg2Q29tbW9uOjptZW1v cnlGZW5jZSk6CisgICAgICAgICogYXNzZW1ibGVyL1g4NkFzc2VtYmxlci5oOgorICAgICAgICAo SlNDOjpYODZBc3NlbWJsZXI6OmxvY2spOgorICAgICAgICAqIGIzL3Rlc3RiMy5jcHA6CisgICAg ICAgIChKU0M6OkIzOjp0ZXN0WDg2TUZlbmNlKToKKyAgICAgICAgKEpTQzo6QjM6OnRlc3RYODZD b21waWxlckZlbmNlKToKKwogMjAxNi0wOS0yMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9A YXBwbGUuY29tPgogCiAgICAgICAgIHRlc3QyNjI6IEZ1bmN0aW9uIGxlbmd0aCBzaG91bGQgYmUg bnVtYmVyIG9mIHBhcmFtZXRlcnMgYmVmb3JlIHBhcmFtZXRlcnMgd2l0aCBkZWZhdWx0IHZhbHVl cwpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4 NkNvbW1vbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIv TWFjcm9Bc3NlbWJsZXJYODZDb21tb24uaAkocmV2aXNpb24gMjA2MjYxKQorKysgU291cmNlL0ph dmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9NYWNyb0Fzc2VtYmxlclg4NkNvbW1vbi5oCSh3b3JraW5n IGNvcHkpCkBAIC0yNjI5LDkgKzI2MjksMTIgQEAgcHVibGljOgogICAgICAgICBtX2Fzc2VtYmxl ci5ub3AoKTsKICAgICB9CiAgICAgCisgICAgLy8gV2UgdGFrZSBtZW1vcnlGZW5jZSB0byBtZWFu IGFjcXJlbC4gVGhpcyBoYXMgYWNxcmVsIHNlbWFudGljcyBvbiB4ODYuCiAgICAgdm9pZCBtZW1v cnlGZW5jZSgpCiAgICAgewotICAgICAgICBtX2Fzc2VtYmxlci5tZmVuY2UoKTsKKyAgICAgICAg Ly8gbG9jazsgb3JsICQwLCAoJXJzcCkKKyAgICAgICAgbV9hc3NlbWJsZXIubG9jaygpOworICAg ICAgICBtX2Fzc2VtYmxlci5vcmxfaW0oMCwgMCwgWDg2UmVnaXN0ZXJzOjplc3ApOwogICAgIH0K IAogICAgIHN0YXRpYyB2b2lkIHJlcGxhY2VXaXRoSnVtcChDb2RlTG9jYXRpb25MYWJlbCBpbnN0 cnVjdGlvblN0YXJ0LCBDb2RlTG9jYXRpb25MYWJlbCBkZXN0aW5hdGlvbikKSW5kZXg6IFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS9hc3NlbWJsZXIvWDg2QXNzZW1ibGVyLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIuaAkocmV2aXNpb24g MjA2MjYxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2Fzc2VtYmxlci9YODZBc3NlbWJsZXIu aAkod29ya2luZyBjb3B5KQpAQCAtMjQ5LDYgKzI0OSw3IEBAIHByaXZhdGU6CiAgICAgICAgIE9Q X0VTQ0FQRV9ERCAgICAgICAgICAgICAgICAgICAgPSAweERELAogICAgICAgICBPUF9DQUxMX3Jl bDMyICAgICAgICAgICAgICAgICAgID0gMHhFOCwKICAgICAgICAgT1BfSk1QX3JlbDMyICAgICAg ICAgICAgICAgICAgICA9IDB4RTksCisgICAgICAgIFBSRV9MT0NLICAgICAgICAgICAgICAgICAg ICAgICAgPSAweEYwLAogICAgICAgICBQUkVfU1NFX0YyICAgICAgICAgICAgICAgICAgICAgID0g MHhGMiwKICAgICAgICAgUFJFX1NTRV9GMyAgICAgICAgICAgICAgICAgICAgICA9IDB4RjMsCiAg ICAgICAgIE9QX0hMVCAgICAgICAgICAgICAgICAgICAgICAgICAgPSAweEY0LApAQCAtMjY4NCw2 ICsyNjg1LDExIEBAIHB1YmxpYzoKICAgICAgICAgbV9mb3JtYXR0ZXIucHJlZml4KFBSRV9QUkVE SUNUX0JSQU5DSF9OT1RfVEFLRU4pOwogICAgIH0KICAgICAKKyAgICB2b2lkIGxvY2soKQorICAg IHsKKyAgICAgICAgbV9mb3JtYXR0ZXIucHJlZml4KFBSRV9MT0NLKTsKKyAgICB9CisgICAgCiAg ICAgdm9pZCBtZmVuY2UoKQogICAgIHsKICAgICAgICAgbV9mb3JtYXR0ZXIudGhyZWVCeXRlT3Ao T1AyXzNCWVRFX0VTQ0FQRV9BRSwgT1AzX01GRU5DRSk7CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYjMvdGVzdGIzLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUv YjMvdGVzdGIzLmNwcAkocmV2aXNpb24gMjA2MjYxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L2IzL3Rlc3RiMy5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEzMDYyLDcgKzEzMDYyLDggQEAgdm9p ZCB0ZXN0WDg2TUZlbmNlKCkKICAgICByb290LT5hcHBlbmROZXc8VmFsdWU+KHByb2MsIFJldHVy biwgT3JpZ2luKCkpOwogICAgIAogICAgIGF1dG8gY29kZSA9IGNvbXBpbGUocHJvYyk7Ci0gICAg Y2hlY2tVc2VzSW5zdHJ1Y3Rpb24oKmNvZGUsICJtZmVuY2UiKTsKKyAgICBjaGVja1VzZXNJbnN0 cnVjdGlvbigqY29kZSwgImxvY2sgb3IgJDB4MCwgKCVyc3ApIik7CisgICAgY2hlY2tEb2VzTm90 VXNlSW5zdHJ1Y3Rpb24oKmNvZGUsICJtZmVuY2UiKTsKIH0KIAogdm9pZCB0ZXN0WDg2Q29tcGls ZXJGZW5jZSgpCkBAIC0xMzA3NSw2ICsxMzA3Niw3IEBAIHZvaWQgdGVzdFg4NkNvbXBpbGVyRmVu Y2UoKQogICAgIHJvb3QtPmFwcGVuZE5ldzxWYWx1ZT4ocHJvYywgUmV0dXJuLCBPcmlnaW4oKSk7 CiAgICAgCiAgICAgYXV0byBjb2RlID0gY29tcGlsZShwcm9jKTsKKyAgICBjaGVja0RvZXNOb3RV c2VJbnN0cnVjdGlvbigqY29kZSwgImxvY2siKTsKICAgICBjaGVja0RvZXNOb3RVc2VJbnN0cnVj dGlvbigqY29kZSwgIm1mZW5jZSIpOwogfQogCkluZGV4OiBTb3VyY2UvV1RGL0NoYW5nZUxvZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMjA2MjYxKQorKysg U291cmNlL1dURi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyOSBAQAorMjAx Ni0wOS0yMiAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgorCisgICAgICAgIEZlbmNl cyBvbiB4ODYgc2hvdWxkIGJlIGEgbG90IGNoZWFwZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjQxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorICAgICAgICAKKyAgICAgICAgSXQgdHVybnMgb3V0IHRoYXQ6CisgICAg ICAgIAorICAgICAgICAgICAgbG9jazsgb3JsICQwLCAoJXJzcCkKKyAgICAgICAgCisgICAgICAg IGRvZXMgZXZlcnl0aGluZyB0aGF0IHdlIHdhbnRlZCBmcm9tOgorICAgICAgICAKKyAgICAgICAg ICAgIG1mZW5jZQorICAgICAgICAKKyAgICAgICAgQW5kIGl0J3MgYSBsb3QgZmFzdGVyLiBXaGVu IEkgdHJpZWQgbWZlbmNlIGZvciBtYWtpbmcgb2JqZWN0IHZpc2l0aW5nIGNvbmN1cnJlbnQtR0Mt VFNPLQorICAgICAgICBmcmllbmRseSwgaXQgd2FzIGEgOSUgcmVncmVzc2lvbiBvbiBPY3RhbmUv c3BsYXkuIEJ1dCB3aGVuIEkgdHJpZWQgb3J0b3AsIGl0IHdhcyBuZXV0cmFsLgorICAgICAgICBT bywgd2Ugc2hvdWxkIHVzZSBvcnRvcCBmcm9tIG5vdyBvbi4KKyAgICAgICAgCisgICAgICAgIFRo aXMgcGFydCBvZiB0aGUgY2hhbmdlIGp1c3QgYWZmZWN0cyBvdXIgQXRvbWljcy4gSSBhbHNvIGNo YW5nZWQgdGhpcyBpbiB0aGUgSklUcy4KKworICAgICAgICAqIHd0Zi9BdG9taWNzLmg6CisgICAg ICAgIChXVEY6Ong4Nl9vcnRvcCk6CisgICAgICAgIChXVEY6OnN0b3JlTG9hZEZlbmNlKToKKyAg ICAgICAgKFdURjo6eDg2X21mZW5jZSk6IERlbGV0ZWQuCisKIDIwMTYtMDktMjEgIEFsZXhleSBQ cm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUm9sbGluZyBvdXQgcjIwNjI0 NCwgYXMgaXQgY2F1c2VkIGZsYWt5IGNyYXNoZXMgb24gdGVzdHMuCkluZGV4OiBTb3VyY2UvV1RG L3d0Zi9BdG9taWNzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dURi93dGYvQXRvbWljcy5oCShy ZXZpc2lvbiAyMDYyNjEpCisrKyBTb3VyY2UvV1RGL3d0Zi9BdG9taWNzLmgJKHdvcmtpbmcgY29w eSkKQEAgLTE2Nyw3ICsxNjcsNyBAQCBpbmxpbmUgdm9pZCBtZW1vcnlCYXJyaWVyQmVmb3JlVW5s b2NrKCkgCiAKICNlbGlmIENQVShYODYpIHx8IENQVShYODZfNjQpCiAKLWlubGluZSB2b2lkIHg4 Nl9tZmVuY2UoKQoraW5saW5lIHZvaWQgeDg2X29ydG9wKCkKIHsKICNpZiBPUyhXSU5ET1dTKQog ICAgIC8vIEkgdGhpbmsgdGhhdCB0aGlzIGRvZXMgdGhlIGVxdWl2YWxlbnQgb2YgYSBkdW1teSBp bnRlcmxvY2tlZCBpbnN0cnVjdGlvbiwKQEAgLTE3NiwxMyArMTc2LDE1IEBAIGlubGluZSB2b2lk IHg4Nl9tZmVuY2UoKQogICAgIC8vIGludmVzdGlnYXRlIGlmIHRoYXQgaXMgYWN0dWFsbHkgYmV0 dGVyLgogICAgIE1lbW9yeUJhcnJpZXIoKTsKICNlbHNlCi0gICAgYXNtIHZvbGF0aWxlKCJtZmVu Y2UiIDo6OiAibWVtb3J5Iik7CisgICAgLy8gVGhpcyBoYXMgYWNxcmVsIHNlbWFudGljcyBhbmQg aXMgbXVjaCBjaGVhcGVyIHRoYW4gbWZlbmNlLiBGb3IgZXhhbXBlLCBpbiB0aGUgSlNDIEdDLCB1 c2luZworICAgIC8vIG1mZW5jZSBhcyBhIHN0b3JlLWxvYWQgZmVuY2Ugd2FzIGEgOSUgc2xvdy1k b3duIG9uIE9jdGFuZS9zcGxheSB3aGlsZSB1c2luZyB0aGlzIHdhcyBuZXV0cmFsLgorICAgIGFz bSB2b2xhdGlsZSgibG9jazsgb3JsICQwLCAoJSVyc3ApIiA6OjogIm1lbW9yeSIpOwogI2VuZGlm CiB9CiAKIGlubGluZSB2b2lkIGxvYWRMb2FkRmVuY2UoKSB7IGNvbXBpbGVyRmVuY2UoKTsgfQog aW5saW5lIHZvaWQgbG9hZFN0b3JlRmVuY2UoKSB7IGNvbXBpbGVyRmVuY2UoKTsgfQotaW5saW5l IHZvaWQgc3RvcmVMb2FkRmVuY2UoKSB7IHg4Nl9tZmVuY2UoKTsgfQoraW5saW5lIHZvaWQgc3Rv cmVMb2FkRmVuY2UoKSB7IHg4Nl9vcnRvcCgpOyB9CiBpbmxpbmUgdm9pZCBzdG9yZVN0b3JlRmVu Y2UoKSB7IGNvbXBpbGVyRmVuY2UoKTsgfQogaW5saW5lIHZvaWQgbWVtb3J5QmFycmllckFmdGVy TG9jaygpIHsgY29tcGlsZXJGZW5jZSgpOyB9CiBpbmxpbmUgdm9pZCBtZW1vcnlCYXJyaWVyQmVm b3JlVW5sb2NrKCkgeyBjb21waWxlckZlbmNlKCk7IH0K