162413 2016-09-22 10:10:35 -0700 [GTK] Improve performance when resizing a window with multiple web views in X11 2016-09-23 01:05:24 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply oldest_to_newest 1232483 0 cgarcia 2016-09-22 10:10:35 -0700 Resizing a window with a single way view performs good enough, but when adding more tabs, the performance decreases a lot. This is because resize is a sync operation, and the UI process waits for the web process to have a new update for the new size, while still draws the previous frame. This is needed for the visible web view, to avoid flickering and artifacts while resizing, but for all other hidden web views, we don't really need to block the UI process. This doesn't happen in Wayland, because in Wayland we never block the UI process while waiting for web process update after a resize. 1232485 1 289569 cgarcia 2016-09-22 10:13:47 -0700 Created attachment 289569 Patch 1232579 2 289569 mcatanzaro 2016-09-22 13:11:40 -0700 Comment on attachment 289569 Patch Works for me. 1232807 3 cgarcia 2016-09-23 01:05:24 -0700 Committed r206294: <http://trac.webkit.org/changeset/206294> 289569 2016-09-22 10:13:47 -0700 2016-09-22 13:11:40 -0700 Patch wk2-resize-x11.diff text/plain 4458 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA5ODJmZGUzLi4xNmFiNzY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjgg QEAKIDIwMTYtMDktMjIgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgogCisgICAgICAgIFtHVEtdIEltcHJvdmUgcGVyZm9ybWFuY2Ugd2hlbiByZXNpemluZyBhIHdp bmRvdyB3aXRoIG11bHRpcGxlIHdlYiB2aWV3cyBpbiBYMTEKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjQxMworCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlc2l6aW5nIGEgd2luZG93IHdpdGggYSBzaW5n bGUgd2F5IHZpZXcgcGVyZm9ybXMgZ29vZCBlbm91Z2gsIGJ1dCB3aGVuIGFkZGluZyBtb3JlIHRh YnMsIHRoZSBwZXJmb3JtYW5jZQorICAgICAgICBkZWNyZWFzZXMgYSBsb3QuIFRoaXMgaXMgYmVj YXVzZSByZXNpemUgaXMgYSBzeW5jIG9wZXJhdGlvbiwgYW5kIHRoZSBVSSBwcm9jZXNzIHdhaXRz IGZvciB0aGUgd2ViIHByb2Nlc3MgdG8KKyAgICAgICAgaGF2ZSBhIG5ldyB1cGRhdGUgZm9yIHRo ZSBuZXcgc2l6ZSwgd2hpbGUgc3RpbGwgZHJhd3MgdGhlIHByZXZpb3VzIGZyYW1lLiBUaGlzIGlz IG5lZWRlZCBmb3IgdGhlIHZpc2libGUgd2ViCisgICAgICAgIHZpZXcsIHRvIGF2b2lkIGZsaWNr ZXJpbmcgYW5kIGFydGlmYWN0cyB3aGlsZSByZXNpemluZywgYnV0IGZvciBhbGwgb3RoZXIgaGlk ZGVuIHdlYiB2aWV3cywgd2UgZG9uJ3QgcmVhbGx5IG5lZWQKKyAgICAgICAgdG8gYmxvY2sgdGhl IFVJIHByb2Nlc3MuIFRoaXMgZG9lc24ndCBoYXBwZW4gaW4gV2F5bGFuZCwgYmVjYXVzZSBpbiBX YXlsYW5kIHdlIG5ldmVyIGJsb2NrIHRoZSBVSSBwcm9jZXNzIHdoaWxlCisgICAgICAgIHdhaXRp bmcgZm9yIHdlYiBwcm9jZXNzIHVwZGF0ZSBhZnRlciBhIHJlc2l6ZS4KKworICAgICAgICAqIFVJ UHJvY2Vzcy9BY2NlbGVyYXRlZERyYXdpbmdBcmVhUHJveHkuY3BwOgorICAgICAgICAoV2ViS2l0 OjpBY2NlbGVyYXRlZERyYXdpbmdBcmVhUHJveHk6OndhaXRGb3JBbmREaXNwYXRjaERpZFVwZGF0 ZUJhY2tpbmdTdG9yZVN0YXRlKTogUmV0dXJuIGVhcmx5IGlmIHRoZSB3ZWIKKyAgICAgICAgdmll dyBpcyBub3QgdmlzaWJsZS4KKyAgICAgICAgKiBVSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFj a2luZ1N0b3JlWDExLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QWNjZWxlcmF0ZWRCYWNraW5nU3Rv cmVYMTE6OnVwZGF0ZSk6IE9ubHkgc2NoZWR1bGUgYSByZWRyYXcgb24gYSBkYW1hZ2UgZXZlbnQg d2hlbiB0aGUgdmlldyBpcyB2aXNpYmxlLgorICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9n dGsvQWNjZWxlcmF0ZWRTdXJmYWNlWDExLmNwcDoKKyAgICAgICAgKFdlYktpdDo6QWNjZWxlcmF0 ZWRTdXJmYWNlWDExOjpBY2NlbGVyYXRlZFN1cmZhY2VYMTEpOiBEbyBhIFhTeW5jIHJpZ2h0IGFm dGVyIGNyZWF0aW5nIHRoZSBuZXcgcGl4bWFwLgorICAgICAgICAoV2ViS2l0OjpBY2NlbGVyYXRl ZFN1cmZhY2VYMTE6OnJlc2l6ZSk6IERpdHRvLgorCisyMDE2LTA5LTIyICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBSRUdSRVNTSU9OKHIxOTQz ODcpOiBDcmFzaCBvbiBnaXRodWIuY29tIGluIEludGxEYXRlVGltZUZvcm1hdDo6cmVzb2x2ZWRP cHRpb25zIGluIEMgbG9jYWxlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNjIxMzkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L0FjY2VsZXJhdGVkRHJhd2luZ0FyZWFQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvQWNjZWxlcmF0ZWREcmF3aW5nQXJlYVByb3h5LmNwcAppbmRleCAwZWQ5ZmU2Li5mZGRiODc0 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQWNjZWxlcmF0ZWREcmF3aW5n QXJlYVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQWNjZWxlcmF0ZWRE cmF3aW5nQXJlYVByb3h5LmNwcApAQCAtMjIwLDYgKzIyMCw4IEBAIHZvaWQgQWNjZWxlcmF0ZWRE cmF3aW5nQXJlYVByb3h5Ojp3YWl0Rm9yQW5kRGlzcGF0Y2hEaWRVcGRhdGVCYWNraW5nU3RvcmVT dGF0ZSgpCiAgICAgICAgIHJldHVybjsKICAgICBpZiAobV93ZWJQYWdlUHJveHkucHJvY2Vzcygp LnN0YXRlKCkgPT0gV2ViUHJvY2Vzc1Byb3h5OjpTdGF0ZTo6TGF1bmNoaW5nKQogICAgICAgICBy ZXR1cm47CisgICAgaWYgKCFtX3dlYlBhZ2VQcm94eS5pc1ZpZXdWaXNpYmxlKCkpCisgICAgICAg IHJldHVybjsKIAogI2lmIFBMQVRGT1JNKFdBWUxBTkQpCiAgICAgLy8gTmV2ZXIgYmxvY2sgdGhl IFVJIHByb2Nlc3MgaW4gV2F5bGFuZCB3aGVuIHdhaXRpbmcgZm9yIERpZFVwZGF0ZUJhY2tpbmdT dG9yZVN0YXRlIGFmdGVyIGEgcmVzaXplLApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL2d0ay9BY2NlbGVyYXRlZEJhY2tpbmdTdG9yZVgxMS5jcHAgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlWDExLmNwcAppbmRleCA5MzI4 MzAxLi42NDVlN2Q3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL0Fj Y2VsZXJhdGVkQmFja2luZ1N0b3JlWDExLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvZ3RrL0FjY2VsZXJhdGVkQmFja2luZ1N0b3JlWDExLmNwcApAQCAtMTU1LDcgKzE1NSw4IEBA IHZvaWQgQWNjZWxlcmF0ZWRCYWNraW5nU3RvcmVYMTE6OnVwZGF0ZShjb25zdCBMYXllclRyZWVD b250ZXh0JiBsYXllclRyZWVDb250ZXh0CiAgICAgY2Fpcm9TdXJmYWNlU2V0RGV2aWNlU2NhbGUo bV9zdXJmYWNlLmdldCgpLCBkZXZpY2VTY2FsZUZhY3RvciwgZGV2aWNlU2NhbGVGYWN0b3IpOwog ICAgIG1fZGFtYWdlID0gWERhbWFnZUNyZWF0ZShkaXNwbGF5LCBwaXhtYXAsIFhEYW1hZ2VSZXBv cnROb25FbXB0eSk7CiAgICAgWERhbWFnZU5vdGlmaWVyOjpzaW5nbGV0b24oKS5hZGQobV9kYW1h Z2UuZ2V0KCksIFt0aGlzXSB7Ci0gICAgICAgIGd0a193aWRnZXRfcXVldWVfZHJhdyhtX3dlYlBh Z2Uudmlld1dpZGdldCgpKTsKKyAgICAgICAgaWYgKG1fd2ViUGFnZS5pc1ZpZXdWaXNpYmxlKCkp CisgICAgICAgICAgICBndGtfd2lkZ2V0X3F1ZXVlX2RyYXcobV93ZWJQYWdlLnZpZXdXaWRnZXQo KSk7CiAgICAgfSk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3Mv V2ViUGFnZS9ndGsvQWNjZWxlcmF0ZWRTdXJmYWNlWDExLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9ndGsvQWNjZWxlcmF0ZWRTdXJmYWNlWDExLmNwcAppbmRleCBhNTU1 N2Q5Li4zOTJiOWQ3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBh Z2UvZ3RrL0FjY2VsZXJhdGVkU3VyZmFjZVgxMS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvV2Vi UHJvY2Vzcy9XZWJQYWdlL2d0ay9BY2NlbGVyYXRlZFN1cmZhY2VYMTEuY3BwCkBAIC0xMDQsNiAr MTA0LDcgQEAgQWNjZWxlcmF0ZWRTdXJmYWNlWDExOjpBY2NlbGVyYXRlZFN1cmZhY2VYMTEoV2Vi UGFnZSYgd2ViUGFnZSkKICAgICBYU2VsZWN0SW5wdXQobV9kaXNwbGF5LCBtX3dpbmRvdy5nZXQo KSwgTm9FdmVudE1hc2spOwogICAgIFhDb21wb3NpdGVSZWRpcmVjdFdpbmRvdyhtX2Rpc3BsYXks IG1fd2luZG93LmdldCgpLCBDb21wb3NpdGVSZWRpcmVjdE1hbnVhbCk7CiAgICAgbV9waXhtYXAg PSBYQ29tcG9zaXRlTmFtZVdpbmRvd1BpeG1hcChtX2Rpc3BsYXksIG1fd2luZG93LmdldCgpKTsK KyAgICBYU3luYyhtX2Rpc3BsYXksIEZhbHNlKTsKIH0KIAogQWNjZWxlcmF0ZWRTdXJmYWNlWDEx Ojp+QWNjZWxlcmF0ZWRTdXJmYWNlWDExKCkKQEAgLTEyOSw2ICsxMzAsNyBAQCBib29sIEFjY2Vs ZXJhdGVkU3VyZmFjZVgxMTo6cmVzaXplKGNvbnN0IEludFNpemUmIHNpemUpCiAgICAgLy8gUmVs ZWFzZSB0aGUgcHJldmlvdXMgcGl4bWFwIGxhdGVyIHRvIGdpdmUgc29tZSB0aW1lIHRvIHRoZSBV SSBwcm9jZXNzIHRvIHVwZGF0ZS4KICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2hBZnRlcihz dGQ6OmNocm9ubzo6c2Vjb25kcyg1KSwgW3BpeG1hcCA9IFdURk1vdmUobV9waXhtYXApXSB7IH0p OwogICAgIG1fcGl4bWFwID0gWENvbXBvc2l0ZU5hbWVXaW5kb3dQaXhtYXAobV9kaXNwbGF5LCBt X3dpbmRvdy5nZXQoKSk7CisgICAgWFN5bmMobV9kaXNwbGF5LCBGYWxzZSk7CiAgICAgcmV0dXJu IHRydWU7CiB9CiAK