162386 2016-09-22 06:19:11 -0700 Skip stress/string-joining-long-strings-should-not-crash.js on memory limited devices 2016-09-26 07:29:19 -0700 1 1 1 Unclassified WebKit New Bugs Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ossy ossy commit-queue mark.lam ossy ryanhaddad saam oldest_to_newest 1232421 0 ossy 2016-09-22 06:19:11 -0700 stress/string-joining-long-strings-should-not-crash.js consumes at least 935Mb memory and then crashes on our JSCOnly bots. Let's skip it on memory limited devices. 1232425 1 289555 ossy 2016-09-22 06:42:32 -0700 Created attachment 289555 Patch 1232429 2 289555 ossy 2016-09-22 06:47:07 -0700 Comment on attachment 289555 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289555&action=review > JSTests/stress/string-joining-long-strings-should-not-crash.js:2 > -//@ runDefault > +//@largeHeap > +// @runDefault if !$memoryLimited We need this hack, because run-jsc-stress-tests processes all lines started with "//@". 1232845 3 ossy 2016-09-23 07:26:17 -0700 (In reply to comment #0) > stress/string-joining-long-strings-should-not-crash.js consumes > at least 935Mb memory and then crashes on our JSCOnly bots. > Let's skip it on memory limited devices. note: This test consumes 4.3Gb memory on X86_64 1232923 4 289555 mark.lam 2016-09-23 11:39:05 -0700 Comment on attachment 289555 Patch r=me 1232931 5 289555 commit-queue 2016-09-23 12:02:34 -0700 Comment on attachment 289555 Patch Clearing flags on attachment: 289555 Committed r206317: <http://trac.webkit.org/changeset/206317> 1232932 6 commit-queue 2016-09-23 12:02:36 -0700 All reviewed patches have been landed. Closing bug. 1232985 7 ryanhaddad 2016-09-23 14:03:59 -0700 Reverted r206317 for reason: This change caused timeouts on El Capitan Release JSC tests Committed r206330: <http://trac.webkit.org/changeset/206330> 1232987 8 ryanhaddad 2016-09-23 14:04:51 -0700 *** Bug 162508 has been marked as a duplicate of this bug. *** 1233387 9 ossy 2016-09-26 06:49:51 -0700 (In reply to comment #7) > Reverted r206317 for reason: > > This change caused timeouts on El Capitan Release JSC tests > > Committed r206330: <http://trac.webkit.org/changeset/206330> Sorry for the trouble. It was a typo in my patch, I'll land the fixed patch. 1233388 10 289825 ossy 2016-09-26 06:55:56 -0700 Created attachment 289825 Patch for landing 1233398 11 289825 commit-queue 2016-09-26 07:29:14 -0700 Comment on attachment 289825 Patch for landing Clearing flags on attachment: 289825 Committed r206374: <http://trac.webkit.org/changeset/206374> 1233399 12 commit-queue 2016-09-26 07:29:19 -0700 All reviewed patches have been landed. Closing bug. 289555 2016-09-22 06:42:32 -0700 2016-09-26 06:55:50 -0700 Patch bug-162386-20160922153942.patch text/plain 1177 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MjU3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGIzZjY4ZDJmY2VlZTVkNzAyNDJjMzI5ZmRjMDM2 OWEyY2FhMzU2MzAuLjcyOTYzMTE1MzhmNjI1ZDUzZTU0MWIwOGQzMDJlM2RlMjRlZTkzYzUgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTYtMDktMjIgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0 Lm9yZz4KKworICAgICAgICBTa2lwIHN0cmVzcy9zdHJpbmctam9pbmluZy1sb25nLXN0cmluZ3Mt c2hvdWxkLW5vdC1jcmFzaC5qcyBvbiBtZW1vcnkgbGltaXRlZCBkZXZpY2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIzODYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9zdHJpbmctam9p bmluZy1sb25nLXN0cmluZ3Mtc2hvdWxkLW5vdC1jcmFzaC5qczoKKwogMjAxNi0wOS0yMCAgQmVu amFtaW4gUG91bGFpbiAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbSlNDXSBEbyBu b3QgdXNlIEVhZ2VyUnVuIG9uIHRlc3RzIGNvdW50aW5nIHJlY29tcGlsYXRpb24KZGlmZiAtLWdp dCBhL0pTVGVzdHMvc3RyZXNzL3N0cmluZy1qb2luaW5nLWxvbmctc3RyaW5ncy1zaG91bGQtbm90 LWNyYXNoLmpzIGIvSlNUZXN0cy9zdHJlc3Mvc3RyaW5nLWpvaW5pbmctbG9uZy1zdHJpbmdzLXNo b3VsZC1ub3QtY3Jhc2guanMKaW5kZXggNjJhZmFlZDg0MTIzNzM0NTIxNDhmOTUwNWVlYjBkNmVh MDczMzNmNi4uNmNhZDFmODdmYmU2MzM4N2ZkNWMzMDI2OTEwZTgxMDYyYTNiMDkyOCAxMDA2NDQK LS0tIGEvSlNUZXN0cy9zdHJlc3Mvc3RyaW5nLWpvaW5pbmctbG9uZy1zdHJpbmdzLXNob3VsZC1u b3QtY3Jhc2guanMKKysrIGIvSlNUZXN0cy9zdHJlc3Mvc3RyaW5nLWpvaW5pbmctbG9uZy1zdHJp bmdzLXNob3VsZC1ub3QtY3Jhc2guanMKQEAgLTEsNCArMSw1IEBACi0vL0AgcnVuRGVmYXVsdAor Ly9AbGFyZ2VIZWFwCisvLyBAcnVuRGVmYXVsdCBpZiAhJG1lbW9yeUxpbWl0ZWQKIC8vIFRoaXMg dGVzdCBzaG91bGQgbm90IGNyYXNoLgogCiB2YXIgZXJyb3I7Cg== 289825 2016-09-26 06:55:56 -0700 2016-09-26 07:29:14 -0700 Patch for landing bug-162386-20160926155259.patch text/plain 1192 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MzcyCmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IGExMTM2NzQzMDBhYzRlOThkZjY5ZWZmMWU3ZTQz YmZkNTgzZTkzYTUuLjU4MzJkMmNjNGMzMWY3NTQ0ZmRhYmM4N2ZkYjNiNjY2Nzk5ZTRiM2IgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTYtMDktMjYgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zemlAaW5mLnUt c3plZ2VkLmh1PgorCisgICAgICAgIFNraXAgc3RyZXNzL3N0cmluZy1qb2luaW5nLWxvbmctc3Ry aW5ncy1zaG91bGQtbm90LWNyYXNoLmpzIG9uIG1lbW9yeSBsaW1pdGVkIGRldmljZXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjM4NgorCisgICAg ICAgIFVucmV2aWV3ZWQsIHJlbGFuZGluZyByMjA2MzE3IGFmdGVyIHR5cG8gZml4LgorCisgICAg ICAgICogc3RyZXNzL3N0cmluZy1qb2luaW5nLWxvbmctc3RyaW5ncy1zaG91bGQtbm90LWNyYXNo LmpzOgorCiAyMDE2LTA5LTI0ICBDYWl0bGluIFBvdHRlciAgPGNhaXRwQGlnYWxpYS5jb20+CiAK ICAgICAgICAgW0pTVGVzdHNdIGZpeCB0ZXN0MjYyIGV4cGVjdGF0aW9ucyBmb2xsb3dpbmcgcjIw NjMzMwpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3Mvc3RyaW5nLWpvaW5pbmctbG9uZy1zdHJp bmdzLXNob3VsZC1ub3QtY3Jhc2guanMgYi9KU1Rlc3RzL3N0cmVzcy9zdHJpbmctam9pbmluZy1s b25nLXN0cmluZ3Mtc2hvdWxkLW5vdC1jcmFzaC5qcwppbmRleCA2MmFmYWVkODQxMjM3MzQ1MjE0 OGY5NTA1ZWViMGQ2ZWEwNzMzM2Y2Li5lZDc3NmJmZmM5ZmMyZTY1MjdkNDliZDk5YTBkOGY4OWJk YjIzZWQxIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9zdHJpbmctam9pbmluZy1sb25nLXN0 cmluZ3Mtc2hvdWxkLW5vdC1jcmFzaC5qcworKysgYi9KU1Rlc3RzL3N0cmVzcy9zdHJpbmctam9p bmluZy1sb25nLXN0cmluZ3Mtc2hvdWxkLW5vdC1jcmFzaC5qcwpAQCAtMSw0ICsxLDUgQEAKLS8v QCBydW5EZWZhdWx0CisvL0AgbGFyZ2VIZWFwCisvL0AgcnVuRGVmYXVsdCBpZiAhJG1lbW9yeUxp bWl0ZWQKIC8vIFRoaXMgdGVzdCBzaG91bGQgbm90IGNyYXNoLgogCiB2YXIgZXJyb3I7Cg==