162383 2016-09-22 05:39:34 -0700 [css-grid] ASSERT when sizing tracks with percentages inside calc 2016-09-23 09:32:06 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 svillar svillar ap commit-queue darin esprehn+autocc glenn jfernandez kondapallykalyan rego svillar oldest_to_newest 1232407 0 svillar 2016-09-22 05:39:34 -0700 [css-grid] ASSERT when sizing tracks with percentages inside calc 1232411 1 289552 svillar 2016-09-22 05:55:51 -0700 Created attachment 289552 Patch 1232417 2 289552 jfernandez 2016-09-22 06:07:10 -0700 Comment on attachment 289552 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289552&action=review the change looks good to me. > LayoutTests/fast/css-grid-layout/tracks-wider-min-track-breadth-crash.html:5 > + display: grid; no need for the display property, since it's included in the "grid" style class provided in grid.css 1232877 3 svillar 2016-09-23 09:32:06 -0700 Committed r206310: <http://trac.webkit.org/changeset/206310> 289552 2016-09-22 05:55:51 -0700 2016-09-22 11:23:06 -0700 Patch bug-162383-20160922145151.patch text/plain 4983 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmNlNTEwOGI4Y2Q1ZWZi ZGRkNmJiZTYwMmZmOGNlYzFjMDM4YzE1MS4uOGNkNjE0YjFkNDhhYzhiODY2NDI5NzRmNGM3NWJj YjU1ZTU2NmYwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE2LTA5LTIyICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIFtjc3MtZ3Jp ZF0gQVNTRVJUIHdoZW4gc2l6aW5nIHRyYWNrcyB3aXRoIHBlcmNlbnRhZ2VzIGluc2lkZSBjYWxj CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIzODMK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBp cyBhbiBBU1NFUlQgdG8gY2hlY2sgdGhhdCB0cmFja3MgYXJlIGF0IGxlYXN0IGFzIHdpZGUgYXMg dGhlIGluaXRpYWwgYmFzZSBzaXplLiBUaGlzCisgICAgICAgIHdhcyBhZGRlZCB0byB2ZXJpZnkg dGhhdCB3ZSBuZXZlciBzaHJpbmsgdHJhY2tzIGJlbGxvdyB0aGF0IHZhbHVlLiBJbiBvcmRlciB0 byBjb21wdXRlIHRoZQorICAgICAgICB2YWx1ZSB1c2VkIGZvciBpbml0aWFsaXphdGlvbiB3ZSBu ZWVkIGEgbWF4IHNpemUgd2hpY2ggaXMgdGhlIHZhbHVlIHVzZWQgdG8gcmVzb2x2ZQorICAgICAg ICBwZXJjZW50YWdlcyB0by4gVGhlIHJlbWFpbmluZyBmcmVlIHNwYWNlIHdhcyB1c2VkIHRvIGNv bXB1dGUgdGhhdCB2YWx1ZSwgdGhhdCdzIHRvdGFsbHkKKyAgICAgICAgd3JvbmcgYmVjYXVzZSB0 aGUgZnJlZSBzcGFjZSBkZWNyZWFzZXMgYXMgdGhlIHRyYWNrIHNpemluZyBhbGdvcml0aG0gaXMg cnVuLiBUaGUgYXZhaWxhYmxlCisgICAgICAgIHNwYWNlIHNob3VsZCBiZSB1c2VkIGluc3RlYWQu CisKKyAgICAgICAgQW4gZXh0cmEgQVNTRVJUIHdhcyByZW1vdmVkIHRvbyBiZWNhdXNlIGl0IHdh cyByZWR1bmRhbnQsIHdlIGRvIGFsd2F5cyBjaGVjayB0aGUgc2l6ZXMgb2YKKyAgICAgICAgdGhl IHRyYWNrcyBhZnRlciBydW5uaW5nIHRoZSB0cmFjayBzaXppbmcgYWxnb3JpdGhtIGFuZCB0aGF0 J3MgcHJlY2lzZWx5IHRoZSB1bmlxdWUgcG9pbnQKKyAgICAgICAgd2VyZSB0aGV5IGNvdWxkIGJl IG1vZGlmaWVkLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzLWdyaWQtbGF5b3V0L3RyYWNrcy13 aWRlci1taW4tdHJhY2stYnJlYWR0aC1jcmFzaC5odG1sCisKKyAgICAgICAgKiByZW5kZXJpbmcv UmVuZGVyR3JpZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJHcmlkOjp0cmFja3NBcmVX aWRlclRoYW5NaW5UcmFja0JyZWFkdGgpOgorCiAyMDE2LTA5LTIyICBDYXJsb3MgR2FyY2lhIENh bXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBSZW5hbWUgRGF0YU9i amVjdEd0ayBhcyBTZWxlY3Rpb25EYXRhCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyR3JpZC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyR3Jp ZC5jcHAKaW5kZXggOWEyMmIwZTMxYWE2YzdiYjdjNWUwZjJjNGE3NmRmOTA3MWUxMzI4NS4uZDcy OTlkMTFmMTMyNjI3ZWJjMjAyODE2ODRmZTllMmFhZDUxZWEzOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckdyaWQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJHcmlkLmNwcApAQCAtNjMwLDcgKzYzMCw2IEBAIHZvaWQgUmVuZGVyR3Jp ZDo6Y29tcHV0ZUludHJpbnNpY0xvZ2ljYWxXaWR0aHMoTGF5b3V0VW5pdCYgbWluTG9naWNhbFdp ZHRoLCBMYXlvCiB2b2lkIFJlbmRlckdyaWQ6OmNvbXB1dGVJbnRyaW5zaWNMb2dpY2FsSGVpZ2h0 KEdyaWRTaXppbmdEYXRhJiBzaXppbmdEYXRhKQogewogICAgIEFTU0VSVChzaXppbmdEYXRhLmlz VmFsaWRUcmFuc2l0aW9uKEZvclJvd3MpKTsKLSAgICBBU1NFUlQodHJhY2tzQXJlV2lkZXJUaGFu TWluVHJhY2tCcmVhZHRoKEZvckNvbHVtbnMsIHNpemluZ0RhdGEpKTsKICAgICBzaXppbmdEYXRh LnNldEF2YWlsYWJsZVNwYWNlKE51bGxvcHQpOwogICAgIHNpemluZ0RhdGEuc2V0RnJlZVNwYWNl KEZvclJvd3MsIE51bGxvcHQpOwogICAgIHNpemluZ0RhdGEuc2l6aW5nT3BlcmF0aW9uID0gSW50 cmluc2ljU2l6ZUNvbXB1dGF0aW9uOwpAQCAtMTQzOSw3ICsxNDM4LDcgQEAgdm9pZCBSZW5kZXJH cmlkOjpkaXN0cmlidXRlU3BhY2VUb1RyYWNrcyhWZWN0b3I8R3JpZFRyYWNrKj4mIHRyYWNrcywg VmVjdG9yPEdyaWQKIGJvb2wgUmVuZGVyR3JpZDo6dHJhY2tzQXJlV2lkZXJUaGFuTWluVHJhY2tC cmVhZHRoKEdyaWRUcmFja1NpemluZ0RpcmVjdGlvbiBkaXJlY3Rpb24sIEdyaWRTaXppbmdEYXRh JiBzaXppbmdEYXRhKQogewogICAgIGNvbnN0IFZlY3RvcjxHcmlkVHJhY2s+JiB0cmFja3MgPSAo ZGlyZWN0aW9uID09IEZvckNvbHVtbnMpID8gc2l6aW5nRGF0YS5jb2x1bW5UcmFja3MgOiBzaXpp bmdEYXRhLnJvd1RyYWNrczsKLSAgICBjb25zdCBMYXlvdXRVbml0IG1heFNpemUgPSBzaXppbmdE YXRhLmZyZWVTcGFjZShkaXJlY3Rpb24pLnZhbHVlT3IoMCk7CisgICAgY29uc3QgTGF5b3V0VW5p dCBtYXhTaXplID0gc2l6aW5nRGF0YS5hdmFpbGFibGVTcGFjZSgpLnZhbHVlT3IoMCk7CiAgICAg Zm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IHRyYWNrcy5zaXplKCk7ICsraSkgewogICAgICAgICBj b25zdCBHcmlkVHJhY2tTaXplJiB0cmFja1NpemUgPSBncmlkVHJhY2tTaXplKGRpcmVjdGlvbiwg aSwgc2l6aW5nRGF0YS5zaXppbmdPcGVyYXRpb24pOwogICAgICAgICBpZiAoY29tcHV0ZVVzZWRC cmVhZHRoT2ZNaW5MZW5ndGgodHJhY2tTaXplLCBtYXhTaXplKSA+IHRyYWNrc1tpXS5iYXNlU2l6 ZSgpKQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IGYyM2Q1Zjg0N2VhZjE3M2NhMjUwNDM2ZjczODBiYTA4MzJjYjc4MDYuLmJh OWE4ZjUzMGNmOWJkNjk1MTViNWJhZWZiYzU4MGIzYjA5YTFhNDEgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx MyBAQAorMjAxNi0wOS0yMiAgU2VyZ2lvIFZpbGxhciBTZW5pbiAgPHN2aWxsYXJAaWdhbGlhLmNv bT4KKworICAgICAgICBbY3NzLWdyaWRdIEFTU0VSVCB3aGVuIHNpemluZyB0cmFja3Mgd2l0aCBw ZXJjZW50YWdlcyBpbnNpZGUgY2FsYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTYyMzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBmYXN0L2Nzcy1ncmlkLWxheW91dC90cmFja3Mtd2lkZXItbWluLXRy YWNrLWJyZWFkdGgtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nz cy1ncmlkLWxheW91dC90cmFja3Mtd2lkZXItbWluLXRyYWNrLWJyZWFkdGgtY3Jhc2guaHRtbDog QWRkZWQuCisKIDIwMTYtMDktMjIgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgog CiAgICAgICAgIENhY2hlZFJlc291cmNlUmVxdWVzdCBzaG91bGQgc3RvcmUgYSBTZWN1cml0eU9y aWdpbgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvdHJhY2tz LXdpZGVyLW1pbi10cmFjay1icmVhZHRoLWNyYXNoLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3Rz L2Zhc3QvY3NzLWdyaWQtbGF5b3V0L3RyYWNrcy13aWRlci1taW4tdHJhY2stYnJlYWR0aC1jcmFz aC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uMTZlZDc2OTM0ZmI2MjQzNTYwYmZlOTUyYTZiN2Iw YTM4NzRiOTQzMgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQt bGF5b3V0L3RyYWNrcy13aWRlci1taW4tdHJhY2stYnJlYWR0aC1jcmFzaC1leHBlY3RlZC50eHQK QEAgLTAsMCArMSwzIEBACitUaGUgdGVzdCBQQVNTIGlmIGl0IGRvZXMgbm90IHRyaWdnZXIgYW4g QVNTRVJUIG9uIERlYnVnIGJ1aWxkcy4KKworCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy1ncmlkLWxheW91dC90cmFja3Mtd2lkZXItbWluLXRyYWNrLWJyZWFkdGgtY3Jhc2guaHRt bCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L3RyYWNrcy13aWRlci1taW4tdHJh Y2stYnJlYWR0aC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmMzYTM2ZjFlNTk5ZGJkOTYxYTY1NTg3 MTFmOTAxZGY4Y2Y1MjJiZmIKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nz cy1ncmlkLWxheW91dC90cmFja3Mtd2lkZXItbWluLXRyYWNrLWJyZWFkdGgtY3Jhc2guaHRtbApA QCAtMCwwICsxLDE2IEBACis8IURPQ1RZUEUgSFRNTD4KKzxsaW5rIGhyZWY9J3Jlc291cmNlcy9n cmlkLmNzcycgcmVsPSdzdHlsZXNoZWV0Jz4KKzxzdHlsZT4KKy5ncmlkIHsKKyAgZGlzcGxheTog Z3JpZDsKKyAgaGVpZ2h0OiAxMDBweDsKKyAgZ3JpZC10ZW1wbGF0ZS1yb3dzOiBjYWxjKDEwcHgg LSA1JSk7Cit9Cis8L3N0eWxlPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAg ICB0ZXN0UnVubmVyLmR1bXBBc1RleHQoKTsKKzwvc2NyaXB0PgorCis8cD5UaGUgdGVzdCBQQVNT IGlmIGl0IGRvZXMgbm90IHRyaWdnZXIgYW4gQVNTRVJUIG9uIERlYnVnIGJ1aWxkcy48L3A+Cis8 ZGl2IGNsYXNzPSJncmlkIj48L2Rpdj4K