162363 2016-09-21 15:18:38 -0700 Inline function only used in one place 2016-09-21 15:54:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1232197 0 joepeck 2016-09-21 15:18:38 -0700 Summary: Inline function only used in one place ForInNode::emitMultiLoopBytecode is only called by ForInNode::emitBytecode with no differences. It should just be ForInNode::emitBytecode. 1232198 1 289481 joepeck 2016-09-21 15:19:57 -0700 Created attachment 289481 [PATCH] Proposed Fix 1232215 2 289481 commit-queue 2016-09-21 15:54:52 -0700 Comment on attachment 289481 [PATCH] Proposed Fix Clearing flags on attachment: 289481 Committed r206239: <http://trac.webkit.org/changeset/206239> 1232216 3 commit-queue 2016-09-21 15:54:55 -0700 All reviewed patches have been landed. Closing bug. 289481 2016-09-21 15:19:57 -0700 2016-09-21 15:54:52 -0700 [PATCH] Proposed Fix emit-bytecode-1.patch text/plain 2529 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDc4ZWEwYzYuLjY1ZThjYjggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTIxICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgSW5saW5lIGZ1bmN0aW9uIG9ubHkg dXNlZCBpbiBvbmUgcGxhY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE2MjM2MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgICogYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHA6CisgICAgICAgIChKU0M6 OkZvckluTm9kZTo6ZW1pdEJ5dGVjb2RlKToKKyAgICAgICAgKEpTQzo6Rm9ySW5Ob2RlOjplbWl0 TXVsdGlMb29wQnl0ZWNvZGUpOgorICAgICAgICAqIHBhcnNlci9Ob2Rlcy5oOgorICAgICAgICBO byBuZWVkIGZvciB0aGUgZXh0cmEgZnVuY3Rpb24sIGl0IGFkZHMgbm8gY2xhcmlmaWNhdGlvbi4K KwogMjAxNi0wOS0yMCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAg ICAgICAgIFJFR1JFU1NJT04ocjIwNTY5Mik6IE1pbmlmaWVkIGJ1aWxkcyBoYXZlIGJyb2tlbiBp bnNwZWN0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIv Tm9kZXNDb2RlZ2VuLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvTm9k ZXNDb2RlZ2VuLmNwcAppbmRleCA5ZmM5Njk1Li4yZWRlYThjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvYnl0ZWNvbXBpbGVyL05vZGVzQ29kZWdlbi5jcHAKKysrIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9Ob2Rlc0NvZGVnZW4uY3BwCkBAIC0yNjg1LDcg KzI2ODUsNyBAQCB2b2lkIEZvckluTm9kZTo6ZW1pdExvb3BIZWFkZXIoQnl0ZWNvZGVHZW5lcmF0 b3ImIGdlbmVyYXRvciwgUmVnaXN0ZXJJRCogcHJvcGVydAogICAgIFJFTEVBU0VfQVNTRVJUX05P VF9SRUFDSEVEKCk7CiB9CiAKLXZvaWQgRm9ySW5Ob2RlOjplbWl0TXVsdGlMb29wQnl0ZWNvZGUo Qnl0ZWNvZGVHZW5lcmF0b3ImIGdlbmVyYXRvciwgUmVnaXN0ZXJJRCogZHN0KQordm9pZCBGb3JJ bk5vZGU6OmVtaXRCeXRlY29kZShCeXRlY29kZUdlbmVyYXRvciYgZ2VuZXJhdG9yLCBSZWdpc3Rl cklEKiBkc3QpCiB7CiAgICAgaWYgKCFtX2xleHByLT5pc0Fzc2lnblJlc29sdmVOb2RlKCkgJiYg IW1fbGV4cHItPmlzQXNzaWdubWVudExvY2F0aW9uKCkpIHsKICAgICAgICAgZW1pdFRocm93UmVm ZXJlbmNlRXJyb3IoZ2VuZXJhdG9yLCBBU0NJSUxpdGVyYWwoIkxlZnQgc2lkZSBvZiBmb3ItaW4g c3RhdGVtZW50IGlzIG5vdCBhIHJlZmVyZW5jZS4iKSk7CkBAIC0yODM1LDExICsyODM1LDYgQEAg dm9pZCBGb3JJbk5vZGU6OmVtaXRNdWx0aUxvb3BCeXRlY29kZShCeXRlY29kZUdlbmVyYXRvciYg Z2VuZXJhdG9yLCBSZWdpc3RlcklEKgogICAgIGdlbmVyYXRvci5lbWl0UHJvZmlsZUNvbnRyb2xG bG93KHByb2ZpbGVyRW5kT2Zmc2V0KTsKIH0KIAotdm9pZCBGb3JJbk5vZGU6OmVtaXRCeXRlY29k ZShCeXRlY29kZUdlbmVyYXRvciYgZ2VuZXJhdG9yLCBSZWdpc3RlcklEKiBkc3QpCi17Ci0gICAg dGhpcy0+ZW1pdE11bHRpTG9vcEJ5dGVjb2RlKGdlbmVyYXRvciwgZHN0KTsKLX0KLQogLy8gLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tIEZvck9mTm9kZSAtLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KIHZvaWQgRm9yT2ZOb2RlOjplbWl0Qnl0ZWNvZGUoQnl0ZWNvZGVH ZW5lcmF0b3ImIGdlbmVyYXRvciwgUmVnaXN0ZXJJRCogZHN0KQogewpkaWZmIC0tZ2l0IGEvU291 cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9Ob2Rlcy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3Jl L3BhcnNlci9Ob2Rlcy5oCmluZGV4IDU4ZTI3NDUuLmUyZWFhZTEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTm9kZXMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvcGFyc2VyL05vZGVzLmgKQEAgLTE0NzUsNyArMTQ3NSw2IEBAIG5hbWVzcGFjZSBKU0Mgewog ICAgIHByaXZhdGU6CiAgICAgICAgIFJlZ2lzdGVySUQqIHRyeUdldEJvdW5kTG9jYWwoQnl0ZWNv ZGVHZW5lcmF0b3ImKTsKICAgICAgICAgdm9pZCBlbWl0TG9vcEhlYWRlcihCeXRlY29kZUdlbmVy YXRvciYsIFJlZ2lzdGVySUQqIHByb3BlcnR5TmFtZSk7Ci0gICAgICAgIHZvaWQgZW1pdE11bHRp TG9vcEJ5dGVjb2RlKEJ5dGVjb2RlR2VuZXJhdG9yJiwgUmVnaXN0ZXJJRCogZHN0KTsKIAogICAg ICAgICB2b2lkIGVtaXRCeXRlY29kZShCeXRlY29kZUdlbmVyYXRvciYsIFJlZ2lzdGVySUQqID0g MCkgb3ZlcnJpZGU7CiAgICAgfTsK