162348 2016-09-21 10:29:41 -0700 New DocumentLoader logging causes crashes 2016-09-21 11:43:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin cdumez koivisto webkit-bug-importer oldest_to_newest 1232106 0 krollin 2016-09-21 10:29:41 -0700 <rdar://problem/28404744> Application Specific Information: CRASHING TEST: contentfiltering/block-after-will-send-request-then-allow-unblock.html Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x0000000110340967 WebCore::DocumentLoader::startLoadingMainResource() + 1159 1 com.apple.WebCore 0x00000001108fd0b0 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(...) + 1312 ... Likely due to accessing m_frame without checking to see if it's nullptr. For instance, this seems particularly ill-advised: if (!m_frame || m_request.isNull()) { RELEASE_LOG_IF_ALLOWED("startLoadingMainResource: Load canceled after willSendRequest (frame = %p, main = %d)", m_frame, m_frame->isMainFrame()); return; } If this is the case, this is a regression caused by Bug 162237. 1232133 1 289470 krollin 2016-09-21 11:37:42 -0700 Created attachment 289470 Patch 1232134 2 289470 cdumez 2016-09-21 11:43:22 -0700 Comment on attachment 289470 Patch Clearing flags on attachment: 289470 Committed r206224: <http://trac.webkit.org/changeset/206224> 1232135 3 cdumez 2016-09-21 11:43:25 -0700 All reviewed patches have been landed. Closing bug. 289470 2016-09-21 11:37:42 -0700 2016-09-21 11:37:42 -0700 Patch bug-162348-20160921113454.patch text/plain 2255 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MjEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjljMDM2YzgwN2E5MDhh YWJjNGNkNDk5NmU0YmU4NTcwNmNhNDc5OS4uOTJlYmQ4YTlkY2VhMTE0MWIxMTk3MjNjZGUyZDI1 YmYwNjIwYzU1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA5LTIxICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBOZXcgRG9jdW1lbnRMb2Fk ZXIgbG9nZ2luZyBjYXVzZXMgY3Jhc2hlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMzQ4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODQwNDc0 ND4KKworICAgICAgICBSZXZpZXdlZCBieSBDaHJpcyBEdW1legorCisgICAgICAgIENoZWNrIGZv ciBOVUxMIG1fZnJhbWUgYmVmb3JlIHVzaW5nIGl0LgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAt LSBubyB0ZXN0cyBmb3IgbG9nZ2luZywgdGhvdWdoIHRoaXMgaXNzdWUgd2FzIGZvdW5kIGJ5Cisg ICAgICAgIGNvbnRlbnRmaWx0ZXJpbmcvYmxvY2stYWZ0ZXItd2lsbC1zZW5kLXJlcXVlc3QtdGhl bi1hbGxvdy11bmJsb2NrLmh0bWwKKworICAgICAgICAqIGxvYWRlci9Eb2N1bWVudExvYWRlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudExvYWRlcjo6c3RhcnRMb2FkaW5nTWFpblJl c291cmNlKToKKwogMjAxNi0wOS0yMSAgTWlndWVsIEdvbWV6ICA8bWFnb21lekBpZ2FsaWEuY29t PgogCiAgICAgICAgIFtHVEtdIEJ1aWxkIGZhaWxzIHdpdGggR1NUUkVBTUVSX0dMIGVuYWJsZWQK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVudExvYWRlci5jcHAgYi9T b3VyY2UvV2ViQ29yZS9sb2FkZXIvRG9jdW1lbnRMb2FkZXIuY3BwCmluZGV4IGQ3NDhkMDg4NTYz Y2VmOWYwNjc3NzA2ZjQzYzEzN2MyODA4ZWI4MDIuLjk3ZDg3NTU4MjY4OWU2YzJlYmIxNTQ1N2Ux YTE1YWRlMDdkZWYxMTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9Eb2N1bWVu dExvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0RvY3VtZW50TG9hZGVyLmNw cApAQCAtMTQ3NCw3ICsxNDc0LDcgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6c3RhcnRMb2FkaW5n TWFpblJlc291cmNlKCkKICAgICBtX2xvYWRpbmdNYWluUmVzb3VyY2UgPSB0cnVlOwogCiAgICAg aWYgKG1heWJlTG9hZEVtcHR5KCkpIHsKLSAgICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgi c3RhcnRMb2FkaW5nTWFpblJlc291cmNlOiBSZXR1cm5pbmcgZW1wdHkgZG9jdW1lbnQgKGZyYW1l ID0gJXAsIG1haW4gPSAlZCkiLCBtX2ZyYW1lLCBtX2ZyYW1lLT5pc01haW5GcmFtZSgpKTsKKyAg ICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgic3RhcnRMb2FkaW5nTWFpblJlc291cmNlOiBS ZXR1cm5pbmcgZW1wdHkgZG9jdW1lbnQgKGZyYW1lID0gJXAsIG1haW4gPSAlZCkiLCBtX2ZyYW1l LCBtX2ZyYW1lID8gbV9mcmFtZS0+aXNNYWluRnJhbWUoKSA6IGZhbHNlKTsKICAgICAgICAgcmV0 dXJuOwogICAgIH0KIApAQCAtMTQ5Niw3ICsxNDk2LDcgQEAgdm9pZCBEb2N1bWVudExvYWRlcjo6 c3RhcnRMb2FkaW5nTWFpblJlc291cmNlKCkKIAogICAgIC8vIHdpbGxTZW5kUmVxdWVzdCgpIG1h eSBsZWFkIHRvIG91ciBGcmFtZSBiZWluZyBkZXRhY2hlZCBvciBjYW5jZWxsaW5nIHRoZSBsb2Fk IHZpYSBudWxsaW5nIHRoZSBSZXNvdXJjZVJlcXVlc3QuCiAgICAgaWYgKCFtX2ZyYW1lIHx8IG1f cmVxdWVzdC5pc051bGwoKSkgewotICAgICAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJzdGFy dExvYWRpbmdNYWluUmVzb3VyY2U6IExvYWQgY2FuY2VsZWQgYWZ0ZXIgd2lsbFNlbmRSZXF1ZXN0 IChmcmFtZSA9ICVwLCBtYWluID0gJWQpIiwgbV9mcmFtZSwgbV9mcmFtZS0+aXNNYWluRnJhbWUo KSk7CisgICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoInN0YXJ0TG9hZGluZ01haW5SZXNv dXJjZTogTG9hZCBjYW5jZWxlZCBhZnRlciB3aWxsU2VuZFJlcXVlc3QgKGZyYW1lID0gJXAsIG1h aW4gPSAlZCkiLCBtX2ZyYW1lLCBtX2ZyYW1lID8gbV9mcmFtZS0+aXNNYWluRnJhbWUoKSA6IGZh bHNlKTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAo=