162347 2016-09-21 10:19:44 -0700 Document::styleResolverChanged simplification 2016-09-21 13:02:58 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned cdumez commit-queue dbates esprehn+autocc kangil.han oldest_to_newest 1232104 0 koivisto 2016-09-21 10:19:44 -0700 It does unnecessary things. 1232105 1 289466 koivisto 2016-09-21 10:24:00 -0700 Created attachment 289466 patch 1232160 2 koivisto 2016-09-21 13:02:58 -0700 https://trac.webkit.org/r206230 289466 2016-09-21 10:24:00 -0700 2016-09-21 12:40:24 -0700 patch styleresolverchanged-cleanup.patch text/plain 4455 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjIxNCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA5LTIxICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBEb2N1bWVudDo6c3R5bGVSZXNv bHZlckNoYW5nZWQgc2ltcGxpZmljYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE2MjM0NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZG9tL0RvY3VtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkRvY3VtZW50OjppbXBsaWNpdENsb3NlKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojpz ZXRQYXJzaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OkRvY3VtZW50Ojp3cml0ZSk6CisgICAgICAg IChXZWJDb3JlOjpEb2N1bWVudDo6c3R5bGVSZXNvbHZlckNoYW5nZWQpOgorCisgICAgICAgICAg ICAtIFJlbW92ZSB1bm5jZXNzYXJ5IEFuaW1hdGlvblVwZGF0ZUJsb2NrLCBpdCBpcyBjcmVhdGVk IGJ5IHJlY2FsY1N0eWxlLgorICAgICAgICAgICAgLSBSZW1vdmUgZXhwbGljaXQgc2V0TmVlZHNM YXlvdXRBbmRQcmVmV2lkdGhzUmVjYWxjL3NjaGVkdWxlUmVsYXlvdXQgY2FsbHMsIHN0eWxlIHJl c29sdXRpb24KKyAgICAgICAgICAgICAgaW52YWxpZGF0ZXMgdGhvc2UgYXMgbmVlZGVkLgorICAg ICAgICAgICAgLSBSZW1vdmUgZXZhbHVhdGVNZWRpYVF1ZXJ5TGlzdCBjYWxsLCB0aGF0IGlzIGRv bmUgb24gbGF5b3V0IGFzIG5lZWRlZC4KKyAgICAgICAgICAgIC0gUmVtb3ZlIHRoZSBhbmNpZW50 IElOU1RSVU1FTlRfTEFZT1VUX1NDSEVEVUxJTkcgYW5kIHRoZSByZWxhdGVkIHByaW50ZnMuCisK IDIwMTYtMDktMjEgIE1pZ3VlbCBHb21leiAgPG1hZ29tZXpAaWdhbGlhLmNvbT4KIAogICAgICAg ICBbR1RLXSBCdWlsZCBmYWlscyB3aXRoIEdTVFJFQU1FUl9HTCBlbmFibGVkCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAJKHJldmlzaW9uIDIwNjExOCkKKysrIFNvdXJjZS9XZWJDb3JlL2Rv bS9Eb2N1bWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI3OCw4ICsyNzgsNiBAQCBuYW1lc3Bh Y2UgV2ViQ29yZSB7CiAKIHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CiAKLS8vICNkZWZpbmUg SU5TVFJVTUVOVF9MQVlPVVRfU0NIRURVTElORyAxCi0KIHN0YXRpYyBjb25zdCB1bnNpZ25lZCBj TWF4V3JpdGVSZWN1cnNpb25EZXB0aCA9IDIxOwogCiAvLyBET00gTGV2ZWwgMiBzYXlzIChsZXR0 ZXJzIGFkZGVkKToKQEAgLTI3NTksMTAgKzI3NTcsNiBAQCB2b2lkIERvY3VtZW50OjppbXBsaWNp dENsb3NlKCkKIAogICAgIGlmIChmKQogICAgICAgICBmLT5sb2FkZXIoKS5kaXNwYXRjaE9ubG9h ZEV2ZW50cygpOwotI2lmZGVmIElOU1RSVU1FTlRfTEFZT1VUX1NDSEVEVUxJTkcKLSAgICBpZiAo IW93bmVyRWxlbWVudCgpKQotICAgICAgICBwcmludGYoIm9ubG9hZCBmaXJlZCBhdCAlbGxkXG4i LCBlbGFwc2VkVGltZSgpLmNvdW50KCkpOwotI2VuZGlmCiAKICAgICAvLyBBbiBldmVudCBoYW5k bGVyIG1heSBoYXZlIHJlbW92ZWQgdGhlIGZyYW1lCiAgICAgaWYgKCFmcmFtZSgpKSB7CkBAIC0y ODMyLDExICsyODI2LDYgQEAgdm9pZCBEb2N1bWVudDo6c2V0UGFyc2luZyhib29sIGIpCiAKICAg ICBpZiAoIW1fYlBhcnNpbmcgJiYgdmlldygpICYmICF2aWV3KCktPm5lZWRzTGF5b3V0KCkpCiAg ICAgICAgIHZpZXcoKS0+ZmlyZUxheW91dFJlbGF0ZWRNaWxlc3RvbmVzSWZOZWVkZWQoKTsKLQot I2lmZGVmIElOU1RSVU1FTlRfTEFZT1VUX1NDSEVEVUxJTkcKLSAgICBpZiAoIW93bmVyRWxlbWVu dCgpICYmICFtX2JQYXJzaW5nKQotICAgICAgICBwcmludGYoIlBhcnNpbmcgZmluaXNoZWQgYXQg JWxsZFxuIiwgZWxhcHNlZFRpbWUoKS5jb3VudCgpKTsKLSNlbmRpZgogfQogCiBib29sIERvY3Vt ZW50OjpzaG91bGRTY2hlZHVsZUxheW91dCgpCkBAIC0yODg1LDExICsyODc0LDYgQEAgdm9pZCBE b2N1bWVudDo6d3JpdGUoY29uc3QgU2VnbWVudGVkU3RyaQogICAgIGlmIChtX3dyaXRlUmVjdXJz aW9uSXNUb29EZWVwKQogICAgICAgIHJldHVybjsKIAotI2lmZGVmIElOU1RSVU1FTlRfTEFZT1VU X1NDSEVEVUxJTkcKLSAgICBpZiAoIW93bmVyRWxlbWVudCgpKQotICAgICAgICBwcmludGYoIkJl Z2lubmluZyBhIGRvY3VtZW50LndyaXRlIGF0ICVsbGRcbiIsIGVsYXBzZWRUaW1lKCkuY291bnQo KSk7Ci0jZW5kaWYKLQogICAgIGJvb2wgaGFzSW5zZXJ0aW9uUG9pbnQgPSBtX3BhcnNlciAmJiBt X3BhcnNlci0+aGFzSW5zZXJ0aW9uUG9pbnQoKTsKICAgICBpZiAoIWhhc0luc2VydGlvblBvaW50 ICYmIChtX2lnbm9yZU9wZW5zRHVyaW5nVW5sb2FkQ291bnQgfHwgbV9pZ25vcmVEZXN0cnVjdGl2 ZVdyaXRlQ291bnQpKQogICAgICAgICByZXR1cm47CkBAIC0yODk5LDExICsyODgzLDYgQEAgdm9p ZCBEb2N1bWVudDo6d3JpdGUoY29uc3QgU2VnbWVudGVkU3RyaQogCiAgICAgQVNTRVJUKG1fcGFy c2VyKTsKICAgICBtX3BhcnNlci0+aW5zZXJ0KHRleHQpOwotCi0jaWZkZWYgSU5TVFJVTUVOVF9M QVlPVVRfU0NIRURVTElORwotICAgIGlmICghb3duZXJFbGVtZW50KCkpCi0gICAgICAgIHByaW50 ZigiRW5kaW5nIGEgZG9jdW1lbnQud3JpdGUgYXQgJWxsZFxuIiwgZWxhcHNlZFRpbWUoKS5jb3Vu dCgpKTsKLSNlbmRpZiAgICAKIH0KIAogdm9pZCBEb2N1bWVudDo6d3JpdGUoY29uc3QgU3RyaW5n JiB0ZXh0LCBEb2N1bWVudCogb3duZXJEb2N1bWVudCkKQEAgLTM2NjYsMTEgKzM2NDUsNiBAQCB2 b2lkIERvY3VtZW50OjpzdHlsZVJlc29sdmVyQ2hhbmdlZChTdHlsCiAgICAgfQogICAgIG1fZGlk Q2FsY3VsYXRlU3R5bGVSZXNvbHZlciA9IHRydWU7CiAKLSNpZmRlZiBJTlNUUlVNRU5UX0xBWU9V VF9TQ0hFRFVMSU5HCi0gICAgaWYgKCFvd25lckVsZW1lbnQoKSkKLSAgICAgICAgcHJpbnRmKCJC ZWdpbm5pbmcgdXBkYXRlIG9mIHN0eWxlIHNlbGVjdG9yIGF0IHRpbWUgJWxsZC5cbiIsIGVsYXBz ZWRUaW1lKCkuY291bnQoKSk7Ci0jZW5kaWYKLQogICAgIGF1dG8gc3R5bGVTaGVldFVwZGF0ZSA9 ICh1cGRhdGVGbGFnID09IFJlY2FsY1N0eWxlSWZOZWVkZWQgfHwgdXBkYXRlRmxhZyA9PSBEZWZl clJlY2FsY1N0eWxlSWZOZWVkZWQpCiAgICAgICAgID8gQXV0aG9yU3R5bGVTaGVldHM6Ok9wdGlt aXplZFVwZGF0ZQogICAgICAgICA6IEF1dGhvclN0eWxlU2hlZXRzOjpGdWxsVXBkYXRlOwpAQCAt MzY4NywyOCArMzY2MSw4IEBAIHZvaWQgRG9jdW1lbnQ6OnN0eWxlUmVzb2x2ZXJDaGFuZ2VkKFN0 eWwKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAgIGlmICghc3R5bGVzaGVldENoYW5nZVJl cXVpcmVzU3R5bGVSZWNhbGMpCi0gICAgICAgIHJldHVybjsKLQotICAgIC8vIFRoaXMgcmVjYWxj U3R5bGUgaW5pdGlhdGVzIGEgbmV3IHJlY2FsYyBjeWNsZS4gV2UgbmVlZCB0byBicmFja2V0IGl0 IHRvCi0gICAgLy8gbWFrZSBzdXJlIGFuaW1hdGlvbnMgZ2V0IHRoZSBjb3JyZWN0IHVwZGF0ZSB0 aW1lCi0gICAgewotICAgICAgICBBbmltYXRpb25VcGRhdGVCbG9jayBhbmltYXRpb25VcGRhdGVC bG9jayhtX2ZyYW1lID8gJm1fZnJhbWUtPmFuaW1hdGlvbigpIDogbnVsbHB0cik7CisgICAgaWYg KHN0eWxlc2hlZXRDaGFuZ2VSZXF1aXJlc1N0eWxlUmVjYWxjKQogICAgICAgICByZWNhbGNTdHls ZShTdHlsZTo6Rm9yY2UpOwotICAgIH0KLQotI2lmZGVmIElOU1RSVU1FTlRfTEFZT1VUX1NDSEVE VUxJTkcKLSAgICBpZiAoIW93bmVyRWxlbWVudCgpKQotICAgICAgICBwcmludGYoIkZpbmlzaGVk IHVwZGF0ZSBvZiBzdHlsZSBzZWxlY3RvciBhdCB0aW1lICVsbGRcbiIsIGVsYXBzZWRUaW1lKCku Y291bnQoKSk7Ci0jZW5kaWYKLQotICAgIGlmIChyZW5kZXJWaWV3KCkpIHsKLSAgICAgICAgcmVu ZGVyVmlldygpLT5zZXROZWVkc0xheW91dEFuZFByZWZXaWR0aHNSZWNhbGMoKTsKLSAgICAgICAg aWYgKHZpZXcoKSkKLSAgICAgICAgICAgIHZpZXcoKS0+c2NoZWR1bGVSZWxheW91dCgpOwotICAg IH0KLQotICAgIGV2YWx1YXRlTWVkaWFRdWVyeUxpc3QoKTsKIH0KIAogc3RhdGljIGJvb2wgaXNO b2RlSW5TdWJ0cmVlKE5vZGUqIG5vZGUsIE5vZGUqIGNvbnRhaW5lciwgYm9vbCBhbW9uZ0NoaWxk cmVuT25seSkK