162344 2016-09-21 09:41:55 -0700 URLParser: correctly parse relative URLs that are just one character 2016-09-21 11:02:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen oldest_to_newest 1232093 0 achristensen 2016-09-21 09:41:55 -0700 URLParser: correctly parse relative URLs that are just one character 1232094 1 289461 achristensen 2016-09-21 09:42:45 -0700 Created attachment 289461 Patch 1232112 2 289461 thorton 2016-09-21 10:59:44 -0700 Comment on attachment 289461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289461&action=review > Source/WebCore/platform/URLParser.cpp:1001 > - ++c; > + incrementIteratorSkippingTabAndNewLine<serialized>(c); There's another additional behavior change here besides the single-character thing: the tab/new line skipping. Should you test that too? 1232113 3 289461 achristensen 2016-09-21 11:01:09 -0700 Comment on attachment 289461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289461&action=review >> Source/WebCore/platform/URLParser.cpp:1001 >> + incrementIteratorSkippingTabAndNewLine<serialized>(c); > > There's another additional behavior change here besides the single-character thing: the tab/new line skipping. Should you test that too? That is tested. I added a test with \t\n after the one character. 1232115 4 achristensen 2016-09-21 11:02:44 -0700 http://trac.webkit.org/changeset/206218 289461 2016-09-21 09:42:45 -0700 2016-09-21 10:59:44 -0700 Patch bug-162344-20160921093958.patch text/plain 3482 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjIwNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTIxICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgVVJMUGFyc2Vy OiBjb3JyZWN0bHkgcGFyc2UgcmVsYXRpdmUgVVJMcyB0aGF0IGFyZSBqdXN0IG9uZSBjaGFyYWN0 ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjM0 NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENvdmVy ZWQgYnkgbmV3IEFQSSB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL1VSTFBhcnNlci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpVUkxQYXJzZXI6OnBhcnNlKToKKwogMjAxNi0wOS0yMSAgWW91 ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW0ZldGNoXSBBbGlnbiBB Y2NlcHQgaGVhZGVyIGRlZmF1bHQgdmFsdWVzIHdpdGggZmV0Y2ggc3BlYwpJbmRleDogU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vVVJMUGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwCShyZXZpc2lvbiAyMDYxOTgpCisrKyBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9VUkxQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05OTgsNyAr OTk4LDEyIEBAIFVSTCBVUkxQYXJzZXI6OnBhcnNlKGNvbnN0IENoYXJhY3RlclR5cGUKICAgICAg ICAgICAgIExPR19TVEFURSgiU2NoZW1lU3RhcnQiKTsKICAgICAgICAgICAgIGlmIChpc0FTQ0lJ QWxwaGEoKmMpKSB7CiAgICAgICAgICAgICAgICAgbV9hc2NpaUJ1ZmZlci51bmNoZWNrZWRBcHBl bmQodG9BU0NJSUxvd2VyKCpjKSk7Ci0gICAgICAgICAgICAgICAgKytjOworICAgICAgICAgICAg ICAgIGluY3JlbWVudEl0ZXJhdG9yU2tpcHBpbmdUYWJBbmROZXdMaW5lPHNlcmlhbGl6ZWQ+KGMp OworICAgICAgICAgICAgICAgIGlmIChjLmF0RW5kKCkpIHsKKyAgICAgICAgICAgICAgICAgICAg bV9hc2NpaUJ1ZmZlci5jbGVhcigpOworICAgICAgICAgICAgICAgICAgICBzdGF0ZSA9IFN0YXRl OjpOb1NjaGVtZTsKKyAgICAgICAgICAgICAgICAgICAgYyA9IGJlZ2luQWZ0ZXJDb250cm9sQW5k U3BhY2U7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIHN0YXRlID0gU3RhdGU6 OlNjaGVtZTsKICAgICAgICAgICAgIH0gZWxzZQogICAgICAgICAgICAgICAgIHN0YXRlID0gU3Rh dGU6Ok5vU2NoZW1lOwpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L0NoYW5nZUxvZwkocmV2aXNpb24gMjA2MjEzKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5n IGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTYtMDktMjEgIEFsZXggQ2hyaXN0ZW5zZW4gIDxh Y2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KKworICAgICAgICBVUkxQYXJzZXI6IGNvcnJlY3RseSBw YXJzZSByZWxhdGl2ZSBVUkxzIHRoYXQgYXJlIGp1c3Qgb25lIGNoYXJhY3RlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMzQ0CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rl c3RzL1dlYkNvcmUvVVJMUGFyc2VyLmNwcDoKKyAgICAgICAgKFRlc3RXZWJLaXRBUEk6OlRFU1Rf Rik6CisKIDIwMTYtMDktMjAgIEFsZXggQ2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBPcHRpbWl6ZSBVUkxQYXJzZXIKSW5kZXg6IFRvb2xzL1Rlc3RXZWJL aXRBUEkvVGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rl c3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIuY3BwCShyZXZpc2lvbiAyMDYxOTgp CisrKyBUb29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVVJMUGFyc2VyLmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjk2LDYgKzI5NiwxMiBAQCBURVNUX0YoVVJMUGFyc2VyVGVzdCwgUGFy c2VSZWxhdGl2ZSkKICAgICBjaGVja1JlbGF0aXZlVVJMKCJub3RzcGVjaWFsOiIsICJhYm91dDpi bGFuayIsIHsibm90c3BlY2lhbCIsICIiLCAiIiwgIiIsIDAsICIiLCAiIiwgIiIsICJub3RzcGVj aWFsOiJ9KTsKICAgICBjaGVja1JlbGF0aXZlVVJMKCJub3RzcGVjaWFsOiIsICJodHRwOi8vaG9z dCIsIHsibm90c3BlY2lhbCIsICIiLCAiIiwgIiIsIDAsICIiLCAiIiwgIiIsICJub3RzcGVjaWFs OiJ9KTsKICAgICBjaGVja1JlbGF0aXZlVVJMKCJodHRwOiIsICJodHRwOi8vaG9zdCIsIHsiaHR0 cCIsICIiLCAiIiwgImhvc3QiLCAwLCAiLyIsICIiLCAiIiwgImh0dHA6Ly9ob3N0LyJ9KTsKKyAg ICBjaGVja1JlbGF0aXZlVVJMKCJpIiwgInNjOi9wYS9wbyIsIHsic2MiLCAiIiwgIiIsICIiLCAw LCAiL3BhL2kiLCAiIiwgIiIsICJzYzovcGEvaSJ9KTsKKyAgICBjaGVja1JlbGF0aXZlVVJMKCJp ICAgICIsICJzYzovcGEvcG8iLCB7InNjIiwgIiIsICIiLCAiIiwgMCwgIi9wYS9pIiwgIiIsICIi LCAic2M6L3BhL2kifSk7CisgICAgY2hlY2tSZWxhdGl2ZVVSTCgiaVx0XG4gICIsICJzYzovcGEv cG8iLCB7InNjIiwgIiIsICIiLCAiIiwgMCwgIi9wYS9pIiwgIiIsICIiLCAic2M6L3BhL2kifSk7 CisgICAgY2hlY2tSZWxhdGl2ZVVSTCgiaSIsICJzYzovL2hvL3BhIiwgeyJzYyIsICIiLCAiIiwg ImhvIiwgMCwgIi9pIiwgIiIsICIiLCAic2M6Ly9oby9pIn0pOworICAgIGNoZWNrUmVsYXRpdmVV UkwoIiEiLCAic2M6Ly9oby9wYSIsIHsic2MiLCAiIiwgIiIsICJobyIsIDAsICIvISIsICIiLCAi IiwgInNjOi8vaG8vISJ9KTsKKyAgICBjaGVja1JlbGF0aXZlVVJMKCIhIiwgInNjOi9oby9wYSIs IHsic2MiLCAiIiwgIiIsICIiLCAwLCAiL2hvLyEiLCAiIiwgIiIsICJzYzovaG8vISJ9KTsKICAg ICAKICAgICAvLyBUaGUgY2hlY2tpbmcgb2Ygc2xhc2hlcyBpbiBTcGVjaWFsQXV0aG9yaXR5U2xh c2hlcyBuZWVkZWQgdG8gZ2V0IHRoaXMgdG8gcGFzcyBjb250cmFkaWN0cyB3aGF0IGlzIGluIHRo ZSBzcGVjLAogICAgIC8vIGJ1dCBpdCBpcyBpbmNsdWRlZCBpbiB0aGUgd2ViIHBsYXRmb3JtIHRl c3RzLgo=