162333 2016-09-21 02:02:54 -0700 [WebRTC][OpenWebRTC] RTP bundling support 2016-11-21 01:29:51 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 164817 1 pnormand webkit-unassigned adam.bergkvist alex pnormand oldest_to_newest 1232018 0 pnormand 2016-09-21 02:02:54 -0700 This will depend on the RTP bundling support feature in OpenWebRTC. In WebKit we will then need to enable bundling in the transport agent. 1251846 1 294932 pnormand 2016-11-16 04:09:45 -0800 Created attachment 294932 EndPoint: RTP bundling support 1251847 2 294932 alex 2016-11-16 04:16:54 -0800 Comment on attachment 294932 EndPoint: RTP bundling support View in context: https://bugs.webkit.org/attachment.cgi?id=294932&action=review > Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:318 > Let's add a FIXME here saying that we have to add support for group-ssrc line in the sdp. > Source/WebCore/platform/mediastream/openwebrtc/MediaEndpointOwr.cpp:571 > + OwrBundlePolicyType bundlePolicy = OWR_BUNDLE_POLICY_TYPE_BALANCED; Also we want a FIXME here for handling BUNDLE sdp line from the remote source when deciding what policy we are going to request owr. 1253198 3 294932 alex 2016-11-21 01:26:47 -0800 Comment on attachment 294932 EndPoint: RTP bundling support Consider adding the FIXMEs 1253201 4 pnormand 2016-11-21 01:29:51 -0800 Committed r208942: <http://trac.webkit.org/changeset/208942> 294932 2016-11-16 04:09:45 -0800 2016-11-21 01:26:47 -0800 EndPoint: RTP bundling support EndPoint-RTP-bundling-support.patch text/plain 4061 pnormand RnJvbSAzNzk5OTI0NDI4MGQ4OTNjZTA4MWU0YjJhNTQyMjc1ZDk5ZDc3ZTAxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDIxIFNlcCAyMDE2IDE2OjM4OjM3ICswMjAwClN1YmplY3Q6IFtQQVRDSF0g RW5kUG9pbnQ6IFJUUCBidW5kbGluZyBzdXBwb3J0CgotLS0KIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMTcgKysrKysrKysrKysrKysKIC4uLi9t ZWRpYXN0cmVhbS9vcGVud2VicnRjL01lZGlhRW5kcG9pbnRPd3IuY3BwICAgIHwgMjcgKysrKysr KysrKysrKysrKysrKysrLQogMiBmaWxlcyBjaGFuZ2VkLCA0MyBpbnNlcnRpb25zKCspLCAxIGRl bGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nIGIvU291cmNl L1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGZkZjQzN2FhLi5iMTJkOTNjIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTYtMTEtMTYgIEFsZWphbmRybyBHLiBDYXN0cm8gIDxhbGV4QGln YWxpYS5jb20+IGFuZCBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKwor ICAgICAgICBbV2ViUlRDXVtPcGVuV2ViUlRDXSBSVFAgYnVuZGxpbmcgc3VwcG9ydAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMzMzCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ29uZmlndXJlIHRoZSBP cGVuV2ViUlRDIHRyYW5zcG9ydCBhZ2VudCBidW5kbGUgcG9saWN5IGFjY29yZGluZworICAgICAg ICB0byB0aGUgUlRDQ29uZmlndXJhdGlvbiBhbmQgcGFzcyB0aGUgcmVjZWl2ZSBTU1JDcyBvdmVy IHRvCisgICAgICAgIE9wZW5XZWJSVEMgYXMgd2VsbC4gVGhvc2UgYXJlIG5lZWRlZCBzbyB0aGUg YWdlbnQgaXMgYXdhcmUgb2YgdGhlCisgICAgICAgIGJ1bmRsZSBsYXlvdXQuCisKKyAgICAgICAg KiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9vcGVud2VicnRjL01lZGlhRW5kcG9pbnRPd3IuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbmRwb2ludE93cjo6dXBkYXRlUmVjZWl2ZUNvbmZpZ3Vy YXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbmRwb2ludE93cjo6dXBkYXRlU2VuZENv bmZpZ3VyYXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFFbmRwb2ludE93cjo6ZW5zdXJl VHJhbnNwb3J0QWdlbnRBbmRUcmFuc2NlaXZlcnMpOgorCiAyMDE2LTExLTE2ICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXVtHTF0g YnVpbGQgYnJva2VuIHdoZW4gdXNpbmcgZ3N0LXBsdWdpbnMtYmFkIGZyb20gZ2l0CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9vcGVud2VicnRjL01lZGlh RW5kcG9pbnRPd3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3Bl bndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcAppbmRleCBhNzI1Mzk4Li41MmM4NjJhIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9vcGVud2VicnRjL01l ZGlhRW5kcG9pbnRPd3IuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93ci5jcHAKQEAgLTM3LDYgKzM3LDcgQEAKICNp bmNsdWRlICJNZWRpYVBheWxvYWQuaCIKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2lu Y2x1ZGUgIk9wZW5XZWJSVENVdGlsaXRpZXMuaCIKKyNpbmNsdWRlICJQZWVyQ29ubmVjdGlvblN0 YXRlcy5oIgogI2luY2x1ZGUgIlJUQ0RhdGFDaGFubmVsSGFuZGxlci5oIgogI2luY2x1ZGUgIlJl YWx0aW1lTWVkaWFTb3VyY2VPd3IuaCIKICNpbmNsdWRlIDxvd3Ivb3dyLmg+CkBAIC0yMzksNiAr MjQwLDcgQEAgTWVkaWFFbmRwb2ludDo6VXBkYXRlUmVzdWx0IE1lZGlhRW5kcG9pbnRPd3I6OnVw ZGF0ZVJlY2VpdmVDb25maWd1cmF0aW9uKE1lZGlhRW4KICAgICAgICAgb3dyX3RyYW5zcG9ydF9h Z2VudF9hZGRfc2Vzc2lvbihtX3RyYW5zcG9ydEFnZW50LCBzZXNzaW9uKTsKICAgICB9CiAKKyAg ICBvd3JfdHJhbnNwb3J0X2FnZW50X3N0YXJ0KG1fdHJhbnNwb3J0QWdlbnQpOwogICAgIG1fbnVt YmVyT2ZSZWNlaXZlUHJlcGFyZWRTZXNzaW9ucyA9IG1fdHJhbnNjZWl2ZXJzLnNpemUoKTsKIAog ICAgIHJldHVybiBVcGRhdGVSZXN1bHQ6OlN1Y2Nlc3M7CkBAIC0zMTQsNiArMzE2LDEzIEBAIE1l ZGlhRW5kcG9pbnQ6OlVwZGF0ZVJlc3VsdCBNZWRpYUVuZHBvaW50T3dyOjp1cGRhdGVTZW5kQ29u ZmlndXJhdGlvbihNZWRpYUVuZHBvCiAgICAgICAgIG93cl9tZWRpYV9zZXNzaW9uX3NldF9zZW5k X3BheWxvYWQoT1dSX01FRElBX1NFU1NJT04oc2Vzc2lvbiksIHNlbmRQYXlsb2FkKTsKICAgICAg ICAgb3dyX21lZGlhX3Nlc3Npb25fc2V0X3NlbmRfc291cmNlKE9XUl9NRURJQV9TRVNTSU9OKHNl c3Npb24pLCBzb3VyY2UtPm1lZGlhU291cmNlKCkpOwogCisgICAgICAgIGNvbnN0IFZlY3Rvcjx1 bnNpZ25lZD4gcmVjZWl2ZVNzcmNzID0gbWRlc2Muc3NyY3M7CisgICAgICAgIGlmIChyZWNlaXZl U3NyY3Muc2l6ZSgpKSB7CisgICAgICAgICAgICBnX29iamVjdF9zZXQoc2Vzc2lvbiwgInJlY2Vp dmUtc3NyYyIsIHJlY2VpdmVTc3Jjc1swXSwgbnVsbHB0cik7CisgICAgICAgICAgICBpZiAocmVj ZWl2ZVNzcmNzLnNpemUoKSA9PSAyKQorICAgICAgICAgICAgICAgIGdfb2JqZWN0X3NldChzZXNz aW9uLCAicmVjZWl2ZS1ydHgtc3NyYyIsIHJlY2VpdmVTc3Jjc1sxXSwgbnVsbHB0cik7CisgICAg ICAgIH0KKwogICAgICAgICBtX251bWJlck9mU2VuZFByZXBhcmVkU2Vzc2lvbnMgPSBpICsgMTsK ICAgICB9CiAKQEAgLTU1OSw3ICs1NjgsMjMgQEAgdm9pZCBNZWRpYUVuZHBvaW50T3dyOjplbnN1 cmVUcmFuc3BvcnRBZ2VudEFuZFRyYW5zY2VpdmVycyhib29sIGlzSW5pdGlhdG9yLCBjb24KICAg ICBBU1NFUlQobV9kdGxzQ2VydGlmaWNhdGUpOwogCiAgICAgaWYgKCFtX3RyYW5zcG9ydEFnZW50 KSB7Ci0gICAgICAgIG1fdHJhbnNwb3J0QWdlbnQgPSBvd3JfdHJhbnNwb3J0X2FnZW50X25ldyhm YWxzZSk7CisgICAgICAgIE93ckJ1bmRsZVBvbGljeVR5cGUgYnVuZGxlUG9saWN5ID0gT1dSX0JV TkRMRV9QT0xJQ1lfVFlQRV9CQUxBTkNFRDsKKworICAgICAgICBzd2l0Y2ggKG1fY29uZmlndXJh dGlvbi0+YnVuZGxlUG9saWN5KSB7CisgICAgICAgIGNhc2UgUGVlckNvbm5lY3Rpb25TdGF0ZXM6 OkJ1bmRsZVBvbGljeTo6QmFsYW5jZWQ6CisgICAgICAgICAgICBidW5kbGVQb2xpY3kgPSBPV1Jf QlVORExFX1BPTElDWV9UWVBFX0JBTEFOQ0VEOworICAgICAgICAgICAgYnJlYWs7CisgICAgICAg IGNhc2UgUGVlckNvbm5lY3Rpb25TdGF0ZXM6OkJ1bmRsZVBvbGljeTo6TWF4Q29tcGF0OgorICAg ICAgICAgICAgYnVuZGxlUG9saWN5ID0gT1dSX0JVTkRMRV9QT0xJQ1lfVFlQRV9NQVhfQ09NUEFU OworICAgICAgICAgICAgYnJlYWs7CisgICAgICAgIGNhc2UgUGVlckNvbm5lY3Rpb25TdGF0ZXM6 OkJ1bmRsZVBvbGljeTo6TWF4QnVuZGxlOgorICAgICAgICAgICAgYnVuZGxlUG9saWN5ID0gT1dS X0JVTkRMRV9QT0xJQ1lfVFlQRV9NQVhfQlVORExFOworICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgIGRlZmF1bHQ6CisgICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAg fTsKKworICAgICAgICBtX3RyYW5zcG9ydEFnZW50ID0gb3dyX3RyYW5zcG9ydF9hZ2VudF9uZXco ZmFsc2UsIGJ1bmRsZVBvbGljeSk7CiAKICAgICAgICAgQVNTRVJUKG1fY29uZmlndXJhdGlvbik7 CiAgICAgICAgIGZvciAoYXV0byYgc2VydmVyIDogbV9jb25maWd1cmF0aW9uLT5pY2VTZXJ2ZXJz KSB7Ci0tIAoyLjEwLjI=