162332 2016-09-21 01:53:59 -0700 [OpenWebRTC] Miscellaneous fixes 2016-09-21 02:46:49 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned alex pnormand oldest_to_newest 1232016 0 pnormand 2016-09-21 01:53:59 -0700 Improved logging in the player, better audio sink support and a copy-paste error fix. 1232017 1 289437 pnormand 2016-09-21 01:58:05 -0700 Created attachment 289437 patch 1232021 2 289437 alex 2016-09-21 02:30:22 -0700 Comment on attachment 289437 patch LGTM 1232027 3 pnormand 2016-09-21 02:46:49 -0700 Committed r206204: <http://trac.webkit.org/changeset/206204> 289437 2016-09-21 01:58:05 -0700 2016-09-21 02:30:22 -0700 patch patch.patch text/plain 6386 pnormand RnJvbSBjMjk4MTdjYjE5YzM0YzdmMDU5OTVkZjIwOGRhM2U0YTIzODkyMDQ3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDIxIFNlcCAyMDE2IDEwOjU0OjUwICswMjAwClN1YmplY3Q6IFtQQVRDSF0g cGF0Y2gKCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgIHwgMTkgKysrKysrKysrKysrKysrKysrKwogLi4uL2dzdHJlYW1lci9NZWRpYVBsYXll clByaXZhdGVHU3RyZWFtZXJPd3IuY3BwICAgIHwgMjEgKysrKysrKysrKysrKysrKy0tLS0tCiAu Li4vb3BlbndlYnJ0Yy9SZWFsdGltZU1lZGlhU291cmNlQ2VudGVyT3dyLmNwcCAgICAgfCAgMiAr LQogMyBmaWxlcyBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspLCA2IGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCBlOGNmMjJhLi45YWNhNTk5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAK KzIwMTYtMDktMjEgIFBoaWxpcHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisg ICAgICAgIFtPcGVuV2ViUlRDXSBNaXNjZWxsYW5lb3VzIGZpeGVzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIzMzIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJl YW1lci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJPd3IuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6TWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpjdXJyZW50VGltZSk6IEltcHJvdmVk IGxvZ2dpbmcuCisgICAgICAgIChXZWJDb3JlOjpNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXJP d3I6OmxvYWQpOiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdT dHJlYW1lck93cjo6bG9hZGluZ0ZhaWxlZCk6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpjcmVhdGVHU1RBdWRpb1NpbmtCaW4pOgorICAg ICAgICBQcmUtcm9sbCB0aGUgYXV0b2F1ZGlvc2luaywgZmV0Y2ggdGhlIHVuZGVybHlpbmcgcGxh dGZvcm0gYXVkaW8KKyAgICAgICAgc2luayBhbmQgcGFzcyBpdCB0byB0aGUgT3BlbldlYlJUQyBy ZW5kZXJlci4KKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93 cjo6bWF5YmVIYW5kbGVDaGFuZ2VNdXRlZFN0YXRlKTogSW1wcm92ZWQgbG9nZ2luZy4KKyAgICAg ICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93cjo6c2V0U2l6ZSk6IERv bid0IGNvbmZpZ3VyZSBpbnZhbGlkIHZpZGVvIHJlbmRlcmVyLgorICAgICAgICAqIHBsYXRmb3Jt L21lZGlhc3RyZWFtL29wZW53ZWJydGMvUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlck93ci5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpSZWFsdGltZU1lZGlhU291cmNlQ2VudGVyT3dyOjpjcmVhdGVN ZWRpYVN0cmVhbSk6IEZpeCBjb3B5LXBhc3RlIGVycm9yLgorCiAyMDE2LTA5LTIxICBZb3Vlbm4g RmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWZhY3RvciBDYWNoZWRSZXNv dXJjZUxvYWRlcjo6Y2FuUmVxdWVzdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93ci5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyT3dyLmNwcAppbmRleCA4Y2I1Yjk2Li5kZWIwZmU1IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyT3dyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyLmNwcApAQCAtMTE1 LDcgKzExNSw3IEBAIGZsb2F0IE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93cjo6Y3VycmVu dFRpbWUoKSBjb25zdAogICAgIGlmIChzdGF0aWNfY2FzdDxHc3RDbG9ja1RpbWU+KHBvc2l0aW9u KSAhPSBHU1RfQ0xPQ0tfVElNRV9OT05FKQogICAgICAgICByZXN1bHQgPSBzdGF0aWNfY2FzdDxk b3VibGU+KHBvc2l0aW9uKSAvIEdTVF9TRUNPTkQ7CiAKLSAgICBHU1RfREVCVUcoIlBvc2l0aW9u ICUiIEdTVF9USU1FX0ZPUk1BVCwgR1NUX1RJTUVfQVJHUyhwb3NpdGlvbikpOworICAgIEdTVF9M T0coIlBvc2l0aW9uICUiIEdTVF9USU1FX0ZPUk1BVCwgR1NUX1RJTUVfQVJHUyhwb3NpdGlvbikp OwogICAgIGdzdF9xdWVyeV91bnJlZihxdWVyeSk7CiAKICAgICByZXR1cm4gcmVzdWx0OwpAQCAt MTQ4LDcgKzE0OCw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpsb2Fk KE1lZGlhU3RyZWFtUHJpdmF0ZSYgc3RyZWFtUHJpdmF0ZSkKICAgICBpZiAoc3RyZWFtUHJpdmF0 ZS5oYXNBdWRpbygpICYmICFtX2F1ZGlvU2luaykKICAgICAgICAgY3JlYXRlR1NUQXVkaW9TaW5r QmluKCk7CiAKLSAgICBHU1RfREVCVUcoIkxvYWRpbmcgTWVkaWFTdHJlYW1Qcml2YXRlICVwIiwg JnN0cmVhbVByaXZhdGUpOworICAgIEdTVF9ERUJVRygiTG9hZGluZyBNZWRpYVN0cmVhbVByaXZh dGUgJXAgdmlkZW86ICVzLCBhdWRpbzogJXMiLCAmc3RyZWFtUHJpdmF0ZSwgc3RyZWFtUHJpdmF0 ZS5oYXNWaWRlbygpID8gInllcyI6Im5vIiwgc3RyZWFtUHJpdmF0ZS5oYXNBdWRpbygpID8gInll cyI6Im5vIik7CiAKICAgICBtX3N0cmVhbVByaXZhdGUgPSAmc3RyZWFtUHJpdmF0ZTsKICAgICBp ZiAoIW1fc3RyZWFtUHJpdmF0ZS0+YWN0aXZlKCkpIHsKQEAgLTE4OCw2ICsxODgsNyBAQCB2b2lk IE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93cjo6bG9hZChNZWRpYVN0cmVhbVByaXZhdGUm IHN0cmVhbVByaXZhdGUpCiB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93cjo6bG9h ZGluZ0ZhaWxlZChNZWRpYVBsYXllcjo6TmV0d29ya1N0YXRlIGVycm9yKQogewogICAgIGlmICht X25ldHdvcmtTdGF0ZSAhPSBlcnJvcikgeworICAgICAgICBHU1RfV0FSTklORygiTG9hZGluZyBm YWlsZWQsIGVycm9yOiAlZCIsIGVycm9yKTsKICAgICAgICAgbV9uZXR3b3JrU3RhdGUgPSBlcnJv cjsKICAgICAgICAgbV9wbGF5ZXItPm5ldHdvcmtTdGF0ZUNoYW5nZWQoKTsKICAgICB9CkBAIC0y NTksMTEgKzI2MCwxOSBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lck93cjo6Y3Jl YXRlR1NUQXVkaW9TaW5rQmluKCkKICAgICBHU1RfREVCVUcoIkNyZWF0aW5nIGF1ZGlvIHNpbmsi KTsKICAgICAvLyBGSVhNRTogdm9sdW1lL211dGUgc3VwcG9ydDogaHR0cHM6Ly93ZWJraXQub3Jn L2IvMTUzODI4LgogCi0gICAgR1JlZlB0cjxHc3RFbGVtZW50PiBzaW5rID0gZ3N0X2VsZW1lbnRf ZmFjdG9yeV9tYWtlKCJhdXRvYXVkaW9zaW5rIiwgMCk7CisgICAgLy8gUHJlLXJvbGwgYW4gYXV0 b2F1ZGlvc2luayBzbyB0aGF0IHRoZSBwbGF0Zm9ybSBhdWRpbyBzaW5rIGlzIGNyZWF0ZWQgYW5k CisgICAgLy8gY2FuIGJlIHJldHJpZXZlZCBmcm9tIHRoZSBhdXRvYXVkaW9zaW5rIGJpbi4KKyAg ICBHUmVmUHRyPEdzdEVsZW1lbnQ+IHNpbmsgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoImF1 dG9hdWRpb3NpbmsiLCBudWxscHRyKTsKICAgICBHc3RDaGlsZFByb3h5KiBjaGlsZFByb3h5ID0g R1NUX0NISUxEX1BST1hZKHNpbmsuZ2V0KCkpOwotICAgIG1fYXVkaW9TaW5rID0gYWRvcHRHUmVm KEdTVF9FTEVNRU5UKGdzdF9jaGlsZF9wcm94eV9nZXRfY2hpbGRfYnlfaW5kZXgoY2hpbGRQcm94 eSwgMCkpKTsKKyAgICBnc3RfZWxlbWVudF9zZXRfc3RhdGUoc2luay5nZXQoKSwgR1NUX1NUQVRF X1JFQURZKTsKKyAgICBHUmVmUHRyPEdzdEVsZW1lbnQ+IHBsYXRmb3JtU2luayA9IGFkb3B0R1Jl ZihHU1RfRUxFTUVOVChnc3RfY2hpbGRfcHJveHlfZ2V0X2NoaWxkX2J5X2luZGV4KGNoaWxkUHJv eHksIDApKSk7CisgICAgR3N0RWxlbWVudEZhY3RvcnkqIGZhY3RvcnkgPSBnc3RfZWxlbWVudF9n ZXRfZmFjdG9yeShwbGF0Zm9ybVNpbmsuZ2V0KCkpOworCisgICAgLy8gRGlzcG9zZSBub3cgdW4t bmVlZGVkIGF1dG9hdWRpb3NpbmsuCiAgICAgZ3N0X2VsZW1lbnRfc2V0X3N0YXRlKHNpbmsuZ2V0 KCksIEdTVF9TVEFURV9OVUxMKTsKIAorICAgIC8vIENyZWF0ZSBhIGZyZXNoIG5ldyBhdWRpbyBz aW5rIGNvbXBhdGlibGUgd2l0aCB0aGUgcGxhdGZvcm0uCisgICAgbV9hdWRpb1NpbmsgPSBnc3Rf ZWxlbWVudF9mYWN0b3J5X2NyZWF0ZShmYWN0b3J5LCBudWxscHRyKTsKICAgICBtX2F1ZGlvUmVu ZGVyZXIgPSBhZG9wdEdSZWYob3dyX2dzdF9hdWRpb19yZW5kZXJlcl9uZXcobV9hdWRpb1Npbmsu Z2V0KCkpKTsKIH0KIApAQCAtMjk0LDYgKzMwMyw3IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2YXRl R1N0cmVhbWVyT3dyOjptYXliZUhhbmRsZUNoYW5nZU11dGVkU3RhdGUoTWVkaWFTdHJlYW1UcmFj CiAgICAgYXV0byByZWFsVGltZU1lZGlhU291cmNlID0gcmVpbnRlcnByZXRfY2FzdDxSZWFsdGlt ZU1lZGlhU291cmNlT3dyKj4oJnRyYWNrLnNvdXJjZSgpKTsKICAgICBhdXRvIG1lZGlhU291cmNl ID0gT1dSX01FRElBX1NPVVJDRShyZWFsVGltZU1lZGlhU291cmNlLT5tZWRpYVNvdXJjZSgpKTsK IAorICAgIEdTVF9ERUJVRygiJXMgdHJhY2sgbm93ICVzIiwgdHJhY2sudHlwZSgpID09IFJlYWx0 aW1lTWVkaWFTb3VyY2U6OkF1ZGlvID8gImF1ZGlvIjoidmlkZW8iLCByZWFsVGltZU1lZGlhU291 cmNlLT5tdXRlZCgpID8gIm11dGVkIjoidW4tbXV0ZWQiKTsKICAgICBzd2l0Y2ggKHRyYWNrLnR5 cGUoKSkgewogICAgIGNhc2UgUmVhbHRpbWVNZWRpYVNvdXJjZTo6QXVkaW86CiAgICAgICAgIGlm ICghcmVhbFRpbWVNZWRpYVNvdXJjZS0+bXV0ZWQoKSkgewpAQCAtMzU2LDcgKzM2Niw4IEBAIHZv aWQgTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyT3dyOjpzZXRTaXplKGNvbnN0IEludFNpemUm IHNpemUpCiAgICAgICAgIHJldHVybjsKIAogICAgIE1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1l ckJhc2U6OnNldFNpemUoc2l6ZSk7Ci0gICAgZ19vYmplY3Rfc2V0KG1fdmlkZW9SZW5kZXJlci5n ZXQoKSwgIndpZHRoIiwgc2l6ZS53aWR0aCgpLCAiaGVpZ2h0Iiwgc2l6ZS5oZWlnaHQoKSwgbnVs bHB0cik7CisgICAgaWYgKG1fdmlkZW9SZW5kZXJlcikKKyAgICAgICAgZ19vYmplY3Rfc2V0KG1f dmlkZW9SZW5kZXJlci5nZXQoKSwgIndpZHRoIiwgc2l6ZS53aWR0aCgpLCAiaGVpZ2h0Iiwgc2l6 ZS5oZWlnaHQoKSwgbnVsbHB0cik7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53ZWJydGMvUmVh bHRpbWVNZWRpYVNvdXJjZUNlbnRlck93ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9vcGVud2VicnRjL1JlYWx0aW1lTWVkaWFTb3VyY2VDZW50ZXJPd3IuY3BwCmlu ZGV4IDBlY2RiNjAuLmM5NTVhZDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL29wZW53ZWJydGMvUmVhbHRpbWVNZWRpYVNvdXJjZUNlbnRlck93ci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9SZWFs dGltZU1lZGlhU291cmNlQ2VudGVyT3dyLmNwcApAQCAtMTQ2LDcgKzE0Niw3IEBAIHZvaWQgUmVh bHRpbWVNZWRpYVNvdXJjZUNlbnRlck93cjo6Y3JlYXRlTWVkaWFTdHJlYW0oTWVkaWFTdHJlYW1D cmVhdGlvbkNsaWVudCoKICAgICAgICAgaWYgKHNvdXJjZUl0ZXJhdG9yICE9IG1fc291cmNlTWFw LmVuZCgpKSB7CiAgICAgICAgICAgICBSZWZQdHI8UmVhbHRpbWVNZWRpYVNvdXJjZT4gc291cmNl ID0gc291cmNlSXRlcmF0b3ItPnZhbHVlOwogICAgICAgICAgICAgaWYgKHNvdXJjZS0+dHlwZSgp ID09IFJlYWx0aW1lTWVkaWFTb3VyY2U6OlZpZGVvKQotICAgICAgICAgICAgICAgIGF1ZGlvU291 cmNlcy5hcHBlbmQoc291cmNlLnJlbGVhc2UoKSk7CisgICAgICAgICAgICAgICAgdmlkZW9Tb3Vy Y2VzLmFwcGVuZChzb3VyY2UucmVsZWFzZSgpKTsKICAgICAgICAgfQogICAgIH0KIAotLSAKMi45 LjM=