162328 2016-09-20 18:46:32 -0700 Fix enumeration of properties cross origin 2016-09-21 13:49:21 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED WebExposed P2 Normal --- 162311 1 cdumez cdumez achristensen barraclough cdumez commit-queue ggaren mark.lam rniwa saam oldest_to_newest 1231949 0 cdumez 2016-09-20 18:46:32 -0700 All cross origin properties for Window / Location are supposed to be not enumerable: - https://html.spec.whatwg.org/#crossorigingetownpropertyhelper-(-o,-p-) Therefore, there should be no properties to iterate on for cross origin Window / Location objects. W3C test: - http://w3c-test.org/html/browsers/origin/cross-origin-objects/cross-origin-objects.html ([[Enumerate]] subtest) 1231950 1 289423 cdumez 2016-09-20 18:51:09 -0700 Created attachment 289423 Patch 1232156 2 289423 achristensen 2016-09-21 12:52:57 -0700 Comment on attachment 289423 Patch Are both of the changes covered by the one test? 1232157 3 cdumez 2016-09-21 12:53:58 -0700 (In reply to comment #2) > Comment on attachment 289423 [details] > Patch > > Are both of the changes covered by the one test? Yes, this test iterates both on Window and Location. 1232169 4 289423 cdumez 2016-09-21 13:49:15 -0700 Comment on attachment 289423 Patch Clearing flags on attachment: 289423 Committed r206233: <http://trac.webkit.org/changeset/206233> 1232170 5 cdumez 2016-09-21 13:49:21 -0700 All reviewed patches have been landed. Closing bug. 289423 2016-09-20 18:51:09 -0700 2016-09-21 13:49:15 -0700 Patch bug-162328-20160920184822.patch text/plain 5159 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWIyYmFjZjk1OGU3YWYx Yjg4ODJlMTBiZmEyYTk2NjQ0YmU0YWNmNC4uMTE5ZGFlYjFkMGU0YWI2NDJjMWIzODE2ZjQ1NDYy OThkOTk4MTc0ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI1IEBACiAyMDE2LTA5LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IGVudW1lcmF0aW9uIG9m IHByb3BlcnRpZXMgY3Jvc3Mgb3JpZ2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjIzMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBbGwgY3Jvc3Mgb3JpZ2luIHByb3BlcnRpZXMgZm9yIFdpbmRvdyAv IExvY2F0aW9uIGFyZSBzdXBwb3NlZCB0byBiZSBub3QgZW51bWVyYWJsZToKKyAgICAgICAgLSBo dHRwczovL2h0bWwuc3BlYy53aGF0d2cub3JnLyNjcm9zc29yaWdpbmdldG93bnByb3BlcnR5aGVs cGVyLSgtbywtcC0pCisKKyAgICAgICAgVGhlcmVmb3JlLCB0aGVyZSBzaG91bGQgYmUgbm8gcHJv cGVydGllcyB0byBpdGVyYXRlIG9uIGZvciBjcm9zcyBvcmlnaW4gV2luZG93IC8KKyAgICAgICAg TG9jYXRpb24gb2JqZWN0cy4KKworICAgICAgICBObyBuZXcgdGVzdHMsIHJlYmFzZWxpbmVkIGV4 aXN0aW5nIHRlc3QuCisKKyAgICAgICAgKiBiaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5j cHA6CisgICAgICAgIChXZWJDb3JlOjpKU0RPTVdpbmRvdzo6Z2V0T3duUHJvcGVydHlOYW1lcyk6 CisgICAgICAgICogYmluZGluZ3MvanMvSlNMb2NhdGlvbkN1c3RvbS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpKU0xvY2F0aW9uOjpnZXRPd25Qcm9wZXJ0eU5hbWVzKToKKworMjAxNi0wOS0yMCAg Q2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgorCiAgICAgICAgIE9iamVjdC5nZXRPd25Q cm9wZXJ0eURlc2NyaXB0b3IoKSBkb2VzIG5vdCB3b3JrIGNvcnJlY3RseSBjcm9zcyBvcmlnaW4K ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjMxMQog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3Rv bS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0RPTVdpbmRvd0N1c3RvbS5jcHAK aW5kZXggODI4Mzk3NWZmZWYyNTk0Mjc0ODBkYjcwMzRiOWY3YzczZmIwODFiMS4uMGFiZTA4ZjM1 MGQxMzRkNzNjOTQwMGNlN2M4NjQ4OTlkOTYwODY3ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNET01XaW5kb3dDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2JpbmRpbmdzL2pzL0pTRE9NV2luZG93Q3VzdG9tLmNwcApAQCAtMzM5LDcgKzMzOSw4IEBAIHZv aWQgSlNET01XaW5kb3c6OmdldE93blByb3BlcnR5TmFtZXMoSlNPYmplY3QqIG9iamVjdCwgRXhl Y1N0YXRlKiBleGVjLCBQcm9wZXJ0CiB7CiAgICAgSlNET01XaW5kb3cqIHRoaXNPYmplY3QgPSBq c0Nhc3Q8SlNET01XaW5kb3cqPihvYmplY3QpOwogICAgIGlmICghQmluZGluZ1NlY3VyaXR5Ojpz aG91bGRBbGxvd0FjY2Vzc1RvRE9NV2luZG93KGV4ZWMsIHRoaXNPYmplY3QtPndyYXBwZWQoKSwg RG9Ob3RSZXBvcnRTZWN1cml0eUVycm9yKSkgewotICAgICAgICBhZGRDcm9zc09yaWdpbldpbmRv d1Byb3BlcnR5TmFtZXMoKmV4ZWMsIHByb3BlcnR5TmFtZXMpOworICAgICAgICBpZiAobW9kZS5p bmNsdWRlRG9udEVudW1Qcm9wZXJ0aWVzKCkpCisgICAgICAgICAgICBhZGRDcm9zc09yaWdpbldp bmRvd1Byb3BlcnR5TmFtZXMoKmV4ZWMsIHByb3BlcnR5TmFtZXMpOwogICAgICAgICByZXR1cm47 CiAgICAgfQogICAgIEJhc2U6OmdldE93blByb3BlcnR5TmFtZXModGhpc09iamVjdCwgZXhlYywg cHJvcGVydHlOYW1lcywgbW9kZSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU0xvY2F0aW9uQ3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT TG9jYXRpb25DdXN0b20uY3BwCmluZGV4IGFmYjQzODViNDE0OTlhMTJkNTg3YTNkZGI0ZDBhYWIw NmQxM2Q2NzAuLjUxMjBiZDM0NDAzYjllZjQ4NDBkN2ZlZDk3YmM2YTIyYTU2MmNlODggMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTG9jYXRpb25DdXN0b20uY3BwCisr KyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTTG9jYXRpb25DdXN0b20uY3BwCkBAIC0x MjgsNyArMTI4LDggQEAgdm9pZCBKU0xvY2F0aW9uOjpnZXRPd25Qcm9wZXJ0eU5hbWVzKEpTT2Jq ZWN0KiBvYmplY3QsIEV4ZWNTdGF0ZSogZXhlYywgUHJvcGVydHkKIHsKICAgICBKU0xvY2F0aW9u KiB0aGlzT2JqZWN0ID0ganNDYXN0PEpTTG9jYXRpb24qPihvYmplY3QpOwogICAgIGlmICghQmlu ZGluZ1NlY3VyaXR5OjpzaG91bGRBbGxvd0FjY2Vzc1RvRnJhbWUoZXhlYywgdGhpc09iamVjdC0+ d3JhcHBlZCgpLmZyYW1lKCksIERvTm90UmVwb3J0U2VjdXJpdHlFcnJvcikpIHsKLSAgICAgICAg YWRkQ3Jvc3NPcmlnaW5Mb2NhdGlvblByb3BlcnR5TmFtZXMoKmV4ZWMsIHByb3BlcnR5TmFtZXMp OworICAgICAgICBpZiAobW9kZS5pbmNsdWRlRG9udEVudW1Qcm9wZXJ0aWVzKCkpCisgICAgICAg ICAgICBhZGRDcm9zc09yaWdpbkxvY2F0aW9uUHJvcGVydHlOYW1lcygqZXhlYywgcHJvcGVydHlO YW1lcyk7CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgQmFzZTo6Z2V0T3duUHJvcGVydHlO YW1lcyh0aGlzT2JqZWN0LCBleGVjLCBwcm9wZXJ0eU5hbWVzLCBtb2RlKTsKZGlmZiAtLWdpdCBh L0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9pbXBvcnRl ZC93M2MvQ2hhbmdlTG9nCmluZGV4IDQ2YzQ2MjA5OWIwZGJiM2JmZDQ5YzBmOTliYzdmMDQxOTRi YzJlMmIuLjcxNWM3NGQ5YmY2YTA2MTFmZDgzODFkMWNiMGM2M2FjOTA5NDAwMzQgMTAwNjQ0Ci0t LSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMv aW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE2IEBACiAyMDE2LTA5LTIwICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKKyAgICAgICAgRml4IGVudW1lcmF0aW9uIG9m IHByb3BlcnRpZXMgY3Jvc3Mgb3JpZ2luCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNjIzMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBSZWJhc2VsaW5lIFczQyB0ZXN0IG5vdyB0aGF0IG9uZSBtb3JlIGNo ZWNrIGlzIHBhc3NpbmcuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9icm93 c2Vycy9vcmlnaW4vY3Jvc3Mtb3JpZ2luLW9iamVjdHMvY3Jvc3Mtb3JpZ2luLW9iamVjdHMtZXhw ZWN0ZWQudHh0OgorCisyMDE2LTA5LTIwICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CisKICAgICAgICAgT2JqZWN0LmdldE93blByb3BlcnR5RGVzY3JpcHRvcigpIGRvZXMgbm90IHdv cmsgY29ycmVjdGx5IGNyb3NzIG9yaWdpbgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMzExCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9y dGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9icm93c2Vycy9vcmlnaW4vY3Jvc3Mtb3Jp Z2luLW9iamVjdHMvY3Jvc3Mtb3JpZ2luLW9iamVjdHMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVz dHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2Jyb3dzZXJzL29yaWdpbi9j cm9zcy1vcmlnaW4tb2JqZWN0cy9jcm9zcy1vcmlnaW4tb2JqZWN0cy1leHBlY3RlZC50eHQKaW5k ZXggNmY5MzY0Y2I5NjIyNjkwNmQ2YTcwYjhmMzI3YTJmNzJjN2U5MmU2MC4uYzYwM2Y5M2E3ODBl MTY3MGIwMGE2MmFmNDRhZWVjZjJiNzdmNTg2ZCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW1w b3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2Jyb3dzZXJzL29yaWdpbi9jcm9zcy1v cmlnaW4tb2JqZWN0cy9jcm9zcy1vcmlnaW4tb2JqZWN0cy1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2Jyb3dzZXJzL29y aWdpbi9jcm9zcy1vcmlnaW4tb2JqZWN0cy9jcm9zcy1vcmlnaW4tb2JqZWN0cy1leHBlY3RlZC50 eHQKQEAgLTExLDcgKzExLDcgQEAgUEFTUyBbW0dldE93blByb3BlcnR5XV0gLSBQcm9wZXJ0aWVz IG9uIGNyb3NzLW9yaWdpbiBvYmplY3RzIHNob3VsZCBiZSByZXBvcnRlZAogUEFTUyBbW0dldE93 blByb3BlcnR5XV0gLSBQcm9wZXJ0eSBkZXNjcmlwdG9ycyBmb3IgY3Jvc3Mtb3JpZ2luIHByb3Bl cnRpZXMgc2hvdWxkIGJlIHNldCB1cCBjb3JyZWN0bHkgCiBQQVNTIFtbRGVsZXRlXV0gU2hvdWxk IHRocm93IG9uIGNyb3NzLW9yaWdpbiBvYmplY3RzIAogUEFTUyBbW0RlZmluZU93blByb3BlcnR5 XV0gU2hvdWxkIHRocm93IGZvciBjcm9zcy1vcmlnaW4gb2JqZWN0cyAKLUZBSUwgW1tFbnVtZXJh dGVdXSBzaG91bGQgcmV0dXJuIGFuIGVtcHR5IGl0ZXJhdG9yIGFzc2VydF91bnJlYWNoZWQ6IFNo b3VsZG4ndCBoYXZlIGJlZW4gYWJsZSB0byBlbnVtZXJhdGUgaHJlZiBvbiBjcm9zcy1vcmlnaW4g TG9jYXRpb24gUmVhY2hlZCB1bnJlYWNoYWJsZSBjb2RlCitQQVNTIFtbRW51bWVyYXRlXV0gc2hv dWxkIHJldHVybiBhbiBlbXB0eSBpdGVyYXRvciAKIFBBU1MgW1tPd25Qcm9wZXJ0eUtleXNdXSBz aG91bGQgcmV0dXJuIGFsbCBwcm9wZXJ0aWVzIGZyb20gY3Jvc3Mtb3JpZ2luIG9iamVjdHMgCiBQ QVNTIEEgYW5kIEIgam9pbnRseSBvYnNlcnZlIHRoZSBzYW1lIGlkZW50aXR5IGZvciBjcm9zcy1v cmlnaW4gV2luZG93IGFuZCBMb2NhdGlvbiAKIFBBU1MgQ3Jvc3Mtb3JpZ2luIGZ1bmN0aW9ucyBn ZXQgbG9jYWwgRnVuY3Rpb24ucHJvdG90eXBlIAo=