162327 2016-09-20 18:01:15 -0700 REGRESSION(r205692): Minified builds have broken inspector 2016-09-20 18:05:56 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned bburg commit-queue joepeck keith_miller mark.lam mattbaker msaboff nvasilyev saam timothy webkit-bug-importer oldest_to_newest 1231932 0 joepeck 2016-09-20 18:01:15 -0700 Summary: Minified builds have broken inspector http://trac.webkit.org/changeset/205692 Seems the JavaScriptCore cssmin.py was older then the WebInspector one we dropped. The jsmin.py files were equivalent. Bring back the proper cssmin. 1231933 1 joepeck 2016-09-20 18:01:23 -0700 <rdar://problem/28370137> 1231934 2 289417 joepeck 2016-09-20 18:02:45 -0700 Created attachment 289417 [PATCH] Proposed Fix 1231935 3 commit-queue 2016-09-20 18:04:48 -0700 Attachment 289417 did not pass style-queue: ERROR: Source/JavaScriptCore/Scripts/cssmin.py:33: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1231938 4 joepeck 2016-09-20 18:05:56 -0700 <https://trac.webkit.org/changeset/206192> 289417 2016-09-20 18:02:45 -0700 2016-09-20 18:04:29 -0700 [PATCH] Proposed Fix fix-production-1.patch text/plain 2217 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGU0Mjc5YmYuLjQ1M2U0OTcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTIwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjA1NjkyKTog TWluaWZpZWQgYnVpbGRzIGhhdmUgYnJva2VuIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMzI3CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yODM3MDEzNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFNjcmlwdHMvY3NzbWluLnB5OgorICAgICAgICAoY3NzbWluaWZ5KToKKyAgICAg ICAgQ29udmVyZ2Ugb24gdGhlIG5ld2VyIGNzc21pbiB0aGF0IHdlIG1pc3Rha2VubHkgZHJvcHBl ZCBpbiByMjA1NjkyLgorICAgICAgICBUaGlzIGtub3dzIGhvdyB0byBoYW5kbGUgbW9yZSBjYXNl cy4KKwogMjAxNi0wOS0yMCAgRmlsaXAgUGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbmFtZSBNYXJrZWRTcGFjZTo6dmVyc2lvbi9NYXJrZWRCbG9jazo6dmVyc2lvbiB0byBN YXJrZWRTcGFjZTo6bWFya2luZ1ZlcnNpb24vTWFya2VkQmxvY2s6Om1hcmtpbmdWZXJzaW9uCmRp ZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvU2NyaXB0cy9jc3NtaW4ucHkgYi9Tb3Vy Y2UvSmF2YVNjcmlwdENvcmUvU2NyaXB0cy9jc3NtaW4ucHkKaW5kZXggYTA2NDBlYi4uMTg2MzI3 YSAxMDA2NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL1NjcmlwdHMvY3NzbWluLnB5Cisr KyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9TY3JpcHRzL2Nzc21pbi5weQpAQCAtMzAsNyArMzAs OSBAQCBkZWYgY3NzbWluaWZ5KGNzcyk6CiAgICAgICAgIChyIlwvXCouKj9cKlwvIiwgIiIpLCAg ICAgICAgICAjIGRlbGV0ZSBjb21tZW50cwogICAgICAgICAociJcbiIsICIiKSwgICAgICAgICAg ICAgICAgICAgIyBkZWxldGUgbmV3IGxpbmVzCiAgICAgICAgIChyIlxzKyIsICIgIiksICAgICAg ICAgICAgICAgICAjIGNoYW5nZSBtdWx0aXBsZSBzcGFjZXMgdG8gb25lIHNwYWNlCi0gICAgICAg IChyIlxzPyhbOzp7fSwrPl0pXHM/IiwgciJcMSIpLCAjIGRlbGV0ZSBzcGFjZSB3aGVyZSBpdCBp cyBub3QgbmVlZGVkCisgICAgICAgIChyIlxzPyhbO3t9LH4+IV0pXHM/IiwgciJcMSIpLCAjIGRl bGV0ZSBzcGFjZSB3aGVyZSBpdCBpcyBub3QgbmVlZGVkCisgICAgICAgIChyIjpccyIsICI6Iiks ICAgICAgICAgICAgICAgICAjIGRlbGV0ZSBzcGFjZXMgYWZ0ZXIgY29sb25zLCBidXQgbm90IGJl Zm9yZS4gRS5nLiBkbyBub3QgYnJlYWsgc2VsZWN0b3JzICJhIDpmb2N1cyIsICJiIDptYXRjaGVz KC4uLikiLCAiYyA6bm90KC4uLikiIHdoZXJlIHRoZSBsZWFkaW5nIHNwYWNlIGlzIHNpZ25pZmlj YW50CisgICAgICAgIChyIlxzPyhbLStdKSg/OlxzKD8hWzAtOShdKSg/IXZhcikpIiwgciJcMSIp LCAjIGRlbGV0ZSB3aGl0ZXNwYWNlIGFyb3VuZCArIGFuZCAtIHdoZW4gbm90IGZvbGxvd2VkIGJ5 IGEgbnVtYmVyLCBwYXJlbiwgb3IgdmFyKCkuIEUuZy4gc3RyaXAgZm9yIHNlbGVjdG9yICJhICsg YiIgYnV0IG5vdCAiY2FsYyhhICsgYikiIHdoaWNoIHJlcXVpcmVzIHNwYWNlcy4KICAgICAgICAg KHIiO30iLCAifSIpICAgICAgICAgICAgICAgICAgICMgY2hhbmdlICc7fScgdG8gJ30nIGJlY2F1 c2UgdGhlIHNlbWljb2xvbiBpcyBub3QgbmVlZGVkCiAgICAgKQogCkBAIC00MSw0ICs0Myw3IEBA IGRlZiBjc3NtaW5pZnkoY3NzKToKIAogaWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoKICAgICBp bXBvcnQgc3lzCisgICAgaWYgc3lzLnZlcnNpb25faW5mb1swXSA9PSAzIGFuZCBzeXMuc3RkaW4u ZW5jb2RpbmcgIT0gJ1VURi04JzoKKyAgICAgICAgaW1wb3J0IGlvCisgICAgICAgIHN5cy5zdGRp biA9IGlvLlRleHRJT1dyYXBwZXIoc3lzLnN0ZGluLmJ1ZmZlciwgZW5jb2Rpbmc9J1VURi04JykK ICAgICBzeXMuc3Rkb3V0LndyaXRlKGNzc21pbmlmeShzeXMuc3RkaW4ucmVhZCgpKSkK