162323 2016-09-20 16:37:24 -0700 Web Inspector: Reload unexpectedly switches to Storage Tab 2016-09-20 19:48:34 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1231899 0 joepeck 2016-09-20 16:37:24 -0700 Summary: Reload unexpectedly switches to Storage Tab Test: <script> localStorage.x = 1; </script> Steps to Reproduce: 1. Start a web server for the simple test page (python -m SimpleHTTPServer) 2. Launch Safari and open test page (http://0.0.0.0:8000) 3. Select Storage Tab 4. Select LocalStorage 5. Select Console Tab 6. Reload => Storage Tab suddenly becomes foreground Notes: - The StorageTab is forcing itself forward because when removing tree elements from the StorageNavigationSidebar one by one we re-select the next available. Selecting is what forces the tab to the foreground. This is unnecessary since they will all be removed anyways. - After all is said and done, selecting the StorageTab should restore properly (re-select the appropriate LocalStorage, etc) and it isn't. 1231900 1 joepeck 2016-09-20 16:37:33 -0700 <rdar://problem/28393954> 1231902 2 289407 joepeck 2016-09-20 16:40:39 -0700 Created attachment 289407 [PATCH] Proposed Fix 1231954 3 289407 mattbaker 2016-09-20 19:27:28 -0700 Comment on attachment 289407 [PATCH] Proposed Fix r=me 1231958 4 289407 commit-queue 2016-09-20 19:48:30 -0700 Comment on attachment 289407 [PATCH] Proposed Fix Clearing flags on attachment: 289407 Committed r206195: <http://trac.webkit.org/changeset/206195> 1231959 5 commit-queue 2016-09-20 19:48:34 -0700 All reviewed patches have been landed. Closing bug. 289407 2016-09-20 16:40:39 -0700 2016-09-20 19:48:30 -0700 [PATCH] Proposed Fix storage-fix-1.patch text/plain 6061 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDA5NmM4OGEuLmNkNWU2NWYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDE2LTA5LTIwICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVsb2Fk IHVuZXhwZWN0ZWRseSBzd2l0Y2hlcyB0byBTdG9yYWdlIFRhYgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMzIzCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8yODM5Mzk1ND4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3RvdHlwZS5z aG93RGVmYXVsdENvbnRlbnRWaWV3Rm9yVHJlZUVsZW1lbnQpOgorICAgICAgICBXZSBhcmVuJ3Qg c3RlYWxpbmcgaWYgdGhlIENvbnRlbnRWaWV3IGRvZXNuJ3QgeWV0IGhhdmUgYSBwYXJlbnQhCisg ICAgICAgIFRoaXMgZml4ZXMgcmVzdG9yYXRpb24gd2hlbiBzd2l0Y2hpbmcgdG8gdGhlIFN0b3Jh Z2UgdGFiIGF0IGEKKyAgICAgICAgbGF0ZXIgdGltZSBhZnRlciBhIHJlbG9hZC4KKworICAgICAg ICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVNpZGViYXJQYW5lbC5qczoKKyAgICAgICAg KFdlYkluc3BlY3Rvci5TdG9yYWdlU2lkZWJhclBhbmVsLl90cmVlU2VsZWN0aW9uRGlkQ2hhbmdl KToKKyAgICAgICAgRG9uJ3Qgc2hvd1JlcHJlc2VudGVkT2JqZWN0IGlmIHdlIGFyZW4ndCB2aXNp YmxlLiBUaGF0IHdvdWxkIGZvcmNlIHRoaXMKKyAgICAgICAgdGFiIHRvIHRoZSBmb3JlZ3JvdW5k IGFuZCB3ZSBkb24ndCB3YW50IHRoYXQuIFRoaXMgb25seSBoYXBwZW5zIHdoZW4KKyAgICAgICAg dHJlZSBlbGVtZW50cyBhcmUgcmVtb3ZlZCAobWFpbiBmcmFtZSBuYXZpZ2F0aW9uKSBhbmQgVHJl ZU91dGxpbmUKKyAgICAgICAgc2VsZWN0cyB0aGUgbmV4dCBhdmFpbGFibGUgdHJlZSBlbGVtZW50 LgorCisgICAgICAgIChXZWJJbnNwZWN0b3IuU3RvcmFnZVNpZGViYXJQYW5lbC5wcm90b3R5cGUu X3N0b3JhZ2VDbGVhcmVkKToKKyAgICAgICAgU2ltcGxpZnkgYW5kIGNsb3NlIGFsbCBjb250ZW50 IHZpZXdzLiBXZSB3ZXJlIG1pc3NpbmcgSW5kZXhlZERCIGNvbnRlbnQgdmlld3MuCisKIDIwMTYt MDktMTkgIE1hdHQgQmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIHJldmVydGluZyBjaGFuZ2VzZXQgaHR0cHM6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdl c2V0LzIwNjEwMS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCmluZGV4IDM0 YTdlNDQuLjU1NGNmYWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcwpA QCAtMjExLDcgKzIxMSw3IEBAIFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsID0g Y2xhc3MgTmF2aWdhdGlvblNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluCiAgICAgICAgIC8vIERv IG5vdCBzdGVhbCBhIGNvbnRlbnQgdmlldyBpZiB3ZSBhcmUgbm90IHRoZSBhY3RpdmUgdGFiL3Np ZGViYXIuCiAgICAgICAgIGlmICghdGhpcy5zZWxlY3RlZCkgewogICAgICAgICAgICAgbGV0IGNv bnRlbnRWaWV3ID0gdGhpcy5jb250ZW50QnJvd3Nlci5jb250ZW50Vmlld0ZvclJlcHJlc2VudGVk T2JqZWN0KHRyZWVFbGVtZW50LnJlcHJlc2VudGVkT2JqZWN0KTsKLSAgICAgICAgICAgIGlmIChj b250ZW50VmlldyAmJiBjb250ZW50Vmlldy5wYXJlbnRDb250YWluZXIgIT09IHRoaXMuY29udGVu dEJyb3dzZXIuY29udGVudFZpZXdDb250YWluZXIpCisgICAgICAgICAgICBpZiAoY29udGVudFZp ZXcgJiYgY29udGVudFZpZXcucGFyZW50Q29udGFpbmVyICYmIGNvbnRlbnRWaWV3LnBhcmVudENv bnRhaW5lciAhPT0gdGhpcy5jb250ZW50QnJvd3Nlci5jb250ZW50Vmlld0NvbnRhaW5lcikKICAg ICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgICAgIH0KIApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVNpZGViYXJQYW5l bC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1N0b3JhZ2VT aWRlYmFyUGFuZWwuanMKaW5kZXggMmJlZmU5Zi4uNTVmOTgwMCAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU3RvcmFnZVNpZGViYXJQYW5lbC5q cworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TdG9yYWdl U2lkZWJhclBhbmVsLmpzCkBAIC00MSwxMiArNDEsMTQgQEAgV2ViSW5zcGVjdG9yLlN0b3JhZ2VT aWRlYmFyUGFuZWwgPSBjbGFzcyBTdG9yYWdlU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVj dG8KIAogICAgICAgICBzY29wZUJhckl0ZW1zLnB1c2gobmV3IFdlYkluc3BlY3Rvci5TY29wZUJh ckl0ZW0oc2NvcGVJdGVtUHJlZml4ICsgInR5cGUtYWxsIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5n KCJBbGwgU3RvcmFnZSIpLCB0cnVlKSk7CiAKLSAgICAgICAgdmFyIHN0b3JhZ2VUeXBlcyA9IFt7 aWRlbnRpZmllcjogImFwcGxpY2F0aW9uLWNhY2hlIiwgdGl0bGU6IFdlYkluc3BlY3Rvci5VSVN0 cmluZygiQXBwbGljYXRpb24gQ2FjaGUiKSwgY2xhc3NlczogW1dlYkluc3BlY3Rvci5BcHBsaWNh dGlvbkNhY2hlRnJhbWVUcmVlRWxlbWVudCwgV2ViSW5zcGVjdG9yLkFwcGxpY2F0aW9uQ2FjaGVN YW5pZmVzdFRyZWVFbGVtZW50XX0sCisgICAgICAgIHZhciBzdG9yYWdlVHlwZXMgPSBbCisgICAg ICAgICAgICB7aWRlbnRpZmllcjogImFwcGxpY2F0aW9uLWNhY2hlIiwgdGl0bGU6IFdlYkluc3Bl Y3Rvci5VSVN0cmluZygiQXBwbGljYXRpb24gQ2FjaGUiKSwgY2xhc3NlczogW1dlYkluc3BlY3Rv ci5BcHBsaWNhdGlvbkNhY2hlRnJhbWVUcmVlRWxlbWVudCwgV2ViSW5zcGVjdG9yLkFwcGxpY2F0 aW9uQ2FjaGVNYW5pZmVzdFRyZWVFbGVtZW50XX0sCiAgICAgICAgICAgICB7aWRlbnRpZmllcjog ImNvb2tpZXMiLCB0aXRsZTogV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJDb29raWVzIiksIGNsYXNz ZXM6IFtXZWJJbnNwZWN0b3IuQ29va2llU3RvcmFnZVRyZWVFbGVtZW50XX0sCiAgICAgICAgICAg ICB7aWRlbnRpZmllcjogImRhdGFiYXNlIiwgdGl0bGU6IFdlYkluc3BlY3Rvci5VSVN0cmluZygi RGF0YWJhc2VzIiksIGNsYXNzZXM6IFtXZWJJbnNwZWN0b3IuRGF0YWJhc2VIb3N0VHJlZUVsZW1l bnQsIFdlYkluc3BlY3Rvci5EYXRhYmFzZVRhYmxlVHJlZUVsZW1lbnQsIFdlYkluc3BlY3Rvci5E YXRhYmFzZVRyZWVFbGVtZW50XX0sCiAgICAgICAgICAgICB7aWRlbnRpZmllcjogImluZGV4ZWQt ZGF0YWJhc2UiLCB0aXRsZTogV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJJbmRleGVkIERhdGFiYXNl cyIpLCBjbGFzc2VzOiBbV2ViSW5zcGVjdG9yLkluZGV4ZWREYXRhYmFzZUhvc3RUcmVlRWxlbWVu dCwgV2ViSW5zcGVjdG9yLkluZGV4ZWREYXRhYmFzZU9iamVjdFN0b3JlVHJlZUVsZW1lbnQsIFdl Ykluc3BlY3Rvci5JbmRleGVkRGF0YWJhc2VUcmVlRWxlbWVudF19LAogICAgICAgICAgICAge2lk ZW50aWZpZXI6ICJsb2NhbC1zdG9yYWdlIiwgdGl0bGU6IFdlYkluc3BlY3Rvci5VSVN0cmluZygi TG9jYWwgU3RvcmFnZSIpLCBjbGFzc2VzOiBbV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VUcmVlRWxl bWVudF0sIGxvY2FsU3RvcmFnZTogdHJ1ZX0sCi0gICAgICAgICAgICB7aWRlbnRpZmllcjogInNl c3Npb24tc3RvcmFnZSIsIHRpdGxlOiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNlc3Npb24gU3Rv cmFnZSIpLCBjbGFzc2VzOiBbV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VUcmVlRWxlbWVudF0sIGxv Y2FsU3RvcmFnZTogZmFsc2V9XTsKKyAgICAgICAgICAgIHtpZGVudGlmaWVyOiAic2Vzc2lvbi1z dG9yYWdlIiwgdGl0bGU6IFdlYkluc3BlY3Rvci5VSVN0cmluZygiU2Vzc2lvbiBTdG9yYWdlIiks IGNsYXNzZXM6IFtXZWJJbnNwZWN0b3IuRE9NU3RvcmFnZVRyZWVFbGVtZW50XSwgbG9jYWxTdG9y YWdlOiBmYWxzZX0KKyAgICAgICAgXTsKIAogICAgICAgICBzdG9yYWdlVHlwZXMuc29ydChmdW5j dGlvbihhLCBiKSB7IHJldHVybiBhLnRpdGxlLmxvY2FsZUNvbXBhcmUoYi50aXRsZSk7IH0pOwog CkBAIC0xNjgsNiArMTcwLDkgQEAgV2ViSW5zcGVjdG9yLlN0b3JhZ2VTaWRlYmFyUGFuZWwgPSBj bGFzcyBTdG9yYWdlU2lkZWJhclBhbmVsIGV4dGVuZHMgV2ViSW5zcGVjdG8KIAogICAgIF90cmVl U2VsZWN0aW9uRGlkQ2hhbmdlKGV2ZW50KQogICAgIHsKKyAgICAgICAgaWYgKCF0aGlzLnZpc2li bGUpCisgICAgICAgICAgICByZXR1cm47CisKICAgICAgICAgbGV0IHRyZWVFbGVtZW50ID0gZXZl bnQuZGF0YS5zZWxlY3RlZEVsZW1lbnQ7CiAgICAgICAgIGlmICghdHJlZUVsZW1lbnQpCiAgICAg ICAgICAgICByZXR1cm47CkBAIC0zMzgsMTIgKzM0Myw3IEBAIFdlYkluc3BlY3Rvci5TdG9yYWdl U2lkZWJhclBhbmVsID0gY2xhc3MgU3RvcmFnZVNpZGViYXJQYW5lbCBleHRlbmRzIFdlYkluc3Bl Y3RvCiAKICAgICBfc3RvcmFnZUNsZWFyZWQoZXZlbnQpCiAgICAgewotICAgICAgICAvLyBDbG9z ZSBhbGwgRE9NIGFuZCBjb29raWUgc3RvcmFnZSBjb250ZW50IHZpZXdzIHNpbmNlIHRoZSBtYWlu IGZyYW1lIGhhcyBuYXZpZ2F0ZWQgYW5kIGFsbCBzdG9yYWdlcyBhcmUgY2xlYXJlZC4KLSAgICAg ICAgdGhpcy5jb250ZW50QnJvd3Nlci5jb250ZW50Vmlld0NvbnRhaW5lci5jbG9zZUFsbENvbnRl bnRWaWV3c09mUHJvdG90eXBlKFdlYkluc3BlY3Rvci5Db29raWVTdG9yYWdlQ29udGVudFZpZXcp OwotICAgICAgICB0aGlzLmNvbnRlbnRCcm93c2VyLmNvbnRlbnRWaWV3Q29udGFpbmVyLmNsb3Nl QWxsQ29udGVudFZpZXdzT2ZQcm90b3R5cGUoV2ViSW5zcGVjdG9yLkRPTVN0b3JhZ2VDb250ZW50 Vmlldyk7Ci0gICAgICAgIHRoaXMuY29udGVudEJyb3dzZXIuY29udGVudFZpZXdDb250YWluZXIu Y2xvc2VBbGxDb250ZW50Vmlld3NPZlByb3RvdHlwZShXZWJJbnNwZWN0b3IuRGF0YWJhc2VUYWJs ZUNvbnRlbnRWaWV3KTsKLSAgICAgICAgdGhpcy5jb250ZW50QnJvd3Nlci5jb250ZW50Vmlld0Nv bnRhaW5lci5jbG9zZUFsbENvbnRlbnRWaWV3c09mUHJvdG90eXBlKFdlYkluc3BlY3Rvci5EYXRh YmFzZUNvbnRlbnRWaWV3KTsKLSAgICAgICAgdGhpcy5jb250ZW50QnJvd3Nlci5jb250ZW50Vmll d0NvbnRhaW5lci5jbG9zZUFsbENvbnRlbnRWaWV3c09mUHJvdG90eXBlKFdlYkluc3BlY3Rvci5B cHBsaWNhdGlvbkNhY2hlRnJhbWVDb250ZW50Vmlldyk7CisgICAgICAgIHRoaXMuY29udGVudEJy b3dzZXIuY29udGVudFZpZXdDb250YWluZXIuY2xvc2VBbGxDb250ZW50Vmlld3MoKTsKIAogICAg ICAgICBpZiAodGhpcy5fbG9jYWxTdG9yYWdlUm9vdFRyZWVFbGVtZW50ICYmIHRoaXMuX2xvY2Fs U3RvcmFnZVJvb3RUcmVlRWxlbWVudC5wYXJlbnQpCiAgICAgICAgICAgICB0aGlzLl9sb2NhbFN0 b3JhZ2VSb290VHJlZUVsZW1lbnQucGFyZW50LnJlbW92ZUNoaWxkKHRoaXMuX2xvY2FsU3RvcmFn ZVJvb3RUcmVlRWxlbWVudCk7Cg==