162319 2016-09-20 14:24:40 -0700 DFG::StoreBarrierInsertionPhase should assume that any epoch increment may make objects older 2016-09-20 15:59:47 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 149432 1 fpizlo fpizlo commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1231863 0 fpizlo 2016-09-20 14:24:40 -0700 If you just allocated an object, then it's true that the object must be white. But as soon as you do anything to it, it will become black. The insertion phase needs to be smart about this. 1231893 1 289406 fpizlo 2016-09-20 15:46:32 -0700 Created attachment 289406 the patch 1231894 2 fpizlo 2016-09-20 15:59:47 -0700 Landed in http://trac.webkit.org/changeset/206183 289406 2016-09-20 15:46:32 -0700 2016-09-20 15:56:22 -0700 the patch blah.patch text/plain 5745 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjA2MTgyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE2LTA5LTIwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg REZHOjpTdG9yZUJhcnJpZXJJbnNlcnRpb25QaGFzZSBzaG91bGQgYXNzdW1lIHRoYXQgYW55IGVw b2NoIGluY3JlbWVudCBtYXkgbWFrZSBvYmplY3RzIG9sZGVyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIzMTkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAgICAgIFRoZSBzdG9yZSBiYXJyaWVyIHBo YXNlIG5lZWRzIHRvIGJlIGF3YXJlIG9mIHRoZSBmYWN0IHRoYXQgYW4gb2JqZWN0IHRoYXQgaXMg bm90IGluIHRoZQorICAgICAgICBPbGRCbGFjayBzdGF0ZSBtYXkgYmUgY29uY3VycmVudGx5IGJy b3VnaHQgaW50byB0aGF0IHN0YXRlLiBUaGF0IG1lYW5zIHRoYXQ6CisgICAgICAgIAorICAgICAg ICAtIFdlIGNhbm5vdCByZWFzb24gYWJvdXQgdGhlIHJlbGF0aXZlIGFnZXMgb2Ygb2JqZWN0cy4g QW4gb2JqZWN0IGlzIGVpdGhlciBuZXcsIGluIHdoaWNoCisgICAgICAgICAgY2FzZSB3ZSBjYW4g c3RvcmUgdG8gaXQgd2l0aG91dCBiYXJyaWVycywgb3IgaXQncyBub3QgaW4gd2hpY2ggY2FzZSBp dCBuZWVkcyBhIGJhcnJpZXIuCisgICAgICAgIAorICAgICAgICAtIEFmdGVyIHdlIGluc2VydCBh IGJhcnJpZXIgb24gYW4gb2JqZWN0LCB0aGUgb2JqZWN0IGlzIG5vIGxvbmdlciBuZXcsIGJlY2F1 c2Ugbm93IHRoZSBHQworICAgICAgICAgIGtub3dzIGFib3V0IGl0IGFuZCB0aGUgR0MgbWF5IGRv IHRoaW5ncyB0byBpdCwgbGlrZSBtYWtlIGl0IE9sZEJsYWNrLgorICAgICAgICAKKyAgICAgICAg VGhpcyBpcyBhIHBlcmYtbmV1dHJhbCBjaGFuZ2UuIFRoZXNlIG9wdGltaXphdGlvbnMgd2VyZSBu ZXZlciBwYXJ0aWN1bGFybHkgcHJvZml0YWJsZS4KKworICAgICAgICAqIGRmZy9ERkdTdG9yZUJh cnJpZXJJbnNlcnRpb25QaGFzZS5jcHA6CisKIDIwMTYtMDktMjAgIEZpbGlwIFBpemxvICA8ZnBp emxvQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW5hbWUgTWFya2VkU3BhY2U6OnZlcnNpb24vTWFy a2VkQmxvY2s6OnZlcnNpb24gdG8gTWFya2VkU3BhY2U6Om1hcmtpbmdWZXJzaW9uL01hcmtlZEJs b2NrOjptYXJraW5nVmVyc2lvbgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdT dG9yZUJhcnJpZXJJbnNlcnRpb25QaGFzZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2RmZy9ERkdTdG9yZUJhcnJpZXJJbnNlcnRpb25QaGFzZS5jcHAJKHJldmlzaW9u IDIwNjE4MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3RvcmVCYXJyaWVySW5z ZXJ0aW9uUGhhc2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MTAsNjEgKzQxMCw2IEBAIHByaXZh dGU6CiAgICAgICAgICAgICBicmVhazsKICAgICAgICAgfSB9CiAgICAgICAgIAotICAgICAgICAv LyBXZSBkb24ndCBuZWVkIGEgc3RvcmUgYmFycmllciBpZiB0aGUgYmFzZSBpcyBhdCBsZWFzdCBh cyBuZXcgYXMgdGhlIGNoaWxkLiBGb3IKLSAgICAgICAgLy8gZXhhbXBsZSB0aGlzIHdvbid0IG5l ZWQgYSBiYXJyaWVyOgotICAgICAgICAvLwotICAgICAgICAvLyB2YXIgbyA9IHt9Ci0gICAgICAg IC8vIHZhciBwID0ge30KLSAgICAgICAgLy8gcC5mID0gbwotICAgICAgICAvLwotICAgICAgICAv LyBUaGlzIGlzIHN0cm9uZ2VyIHRoYW4gdGhlIGN1cnJlbnRFcG9jaCBydWxlIGluIGNvbnNpZGVy QmFycmllcihFZGdlKSwgYmVjYXVzZSBpdCB3aWxsCi0gICAgICAgIC8vIGFsc28gZWxpbWluYXRl IGJhcnJpZXJzIGluIGNhc2VzIGxpa2UgdGhpczoKLSAgICAgICAgLy8KLSAgICAgICAgLy8gdmFy IG8gPSB7fSAvLyBvLmVwb2NoID0gMSwgY3VycmVudEVwb2NoID0gMQotICAgICAgICAvLyB2YXIg cCA9IHt9IC8vIG8uZXBvY2ggPSAxLCBwLmVwb2NoID0gMiwgY3VycmVudEVwb2NoID0gMgotICAg ICAgICAvLyB2YXIgcSA9IHt9IC8vIG8uZXBvY2ggPSAxLCBwLmVwb2NoID0gMiwgcS5lcG9jaCA9 IDMsIGN1cnJlbnRFcG9jaCA9IDMKLSAgICAgICAgLy8gcC5mID0gbyAvLyBwLmVwb2NoID49IG8u ZXBvY2gKLSAgICAgICAgLy8KLSAgICAgICAgLy8gVGhpcyByZWxhdGlvbnNoaXAgd29ya3MgYmVj YXVzZSBpZiBpdCBob2xkcyB0aGVuIHdlIGFyZSBpbiBvbmUgb2YgdGhlIGZvbGxvd2luZwotICAg ICAgICAvLyBzY2VuYXJpb3MuIE5vdGUgdGhhdCB3ZSBkb24ndCBrbm93ICp3aGljaCogb2YgdGhl c2Ugc2NlbmFyaW9zIHdlIGFyZSBpbiwgYnV0IGl0J3MKLSAgICAgICAgLy8gb25lIG9mIHRoZW0g KHRob3VnaCB3aXRob3V0IGxvc3Mgb2YgZ2VuZXJhbGl0eSwgeW91IGNhbiByZXBsYWNlICJhIEdD IGhhcHBlbmVkIiB3aXRoCi0gICAgICAgIC8vICJtYW55IEdDcyBoYXBwZW5lZCIpLgotICAgICAg ICAvLwotICAgICAgICAvLyAxKSBUaGVyZSBpcyBubyBHQyBiZXR3ZWVuIHRoZSBhbGxvY2F0aW9u L2xhc3QtYmFycmllciBvZiBiYXNlLCBjaGlsZCBhbmQgbm93LiBUaGVuCi0gICAgICAgIC8vICAg IHdlIGRlZmluaXRlbHkgZG9uJ3QgbmVlZCBhIGJhcnJpZXIuCi0gICAgICAgIC8vCi0gICAgICAg IC8vIDIpIFRoZXJlIHdhcyBhIEdDIGFmdGVyIGNoaWxkIHdhcyBhbGxvY2F0ZWQgYnV0IGJlZm9y ZSBiYXNlIHdhcyBhbGxvY2F0ZWQuIFRoZW4gd2UKLSAgICAgICAgLy8gICAgZG9uJ3QgbmVlZCBh IGJhcnJpZXIsIGJlY2F1c2UgYmFzZSBpcyBzdGlsbCBhIG5ldyBvYmplY3QuCi0gICAgICAgIC8v Ci0gICAgICAgIC8vIDMpIFRoZXJlIHdhcyBhIEdDIGFmdGVyIGJvdGggY2hpbGQgYW5kIGJhc2Ug d2VyZSBhbGxvY2F0ZWQuIFRoZW4gdGhleSBhcmUgYm90aCBvbGQuCi0gICAgICAgIC8vICAgIFdl IGRvbid0IG5lZWQgYmFycmllcnMgb24gc3RvcmVzIG9mIG9sZCBpbnRvIG9sZC4gTm90ZSB0aGF0 IGluIHRoaXMgY2FzZSBpdAotICAgICAgICAvLyAgICBkb2Vzbid0IG1hdHRlciBpZiB0aGVyZSB3 YXMgYWxzbyBhIEdDIGJldHdlZW4gdGhlIGFsbG9jYXRpb24gb2YgY2hpbGQgYW5kIGJhc2UuCi0g ICAgICAgIC8vCi0gICAgICAgIC8vIE5vdGUgdGhhdCBiYXJyaWVycyB3aWxsIGxpZnQgYW4gb2Jq ZWN0IGludG8gdGhlIGN1cnJlbnQgZXBvY2guIFRoaXMgaXMgc29ydCBvZiB3ZWlyZC4KLSAgICAg ICAgLy8gSXQgbWVhbnMgdGhhdCBsYXRlciBpZiB5b3Ugc3RvcmUgdGhhdCBvYmplY3QgaW50byBz b21lIG90aGVyIG9iamVjdCwgYW5kIHRoYXQgb3RoZXIKLSAgICAgICAgLy8gb2JqZWN0IHdhcyBw cmV2aW91c2x5IG5ld2VyIG9iamVjdCwgeW91J2xsIHRoaW5rIHRoYXQgeW91IG5lZWQgYSBiYXJy aWVyLiBXZSBjb3VsZAotICAgICAgICAvLyBhdm9pZCB0aGlzIGJ5IHRyYWNraW5nIGFsbG9jYXRp b24gZXBvY2ggYW5kIGJhcnJpZXIgZXBvY2ggc2VwYXJhdGVseS4gRm9yIG5vdyBJIHRoaW5rCi0g ICAgICAgIC8vIHRoYXQgdGhpcyB3b3VsZCBiZSBvdmVya2lsbC4gQnV0IHRoaXMgZG9lcyBtZWFu IHRoYXQgdGhlcmUgYXJlIHRoZSBmb2xsb3dpbmcKLSAgICAgICAgLy8gcG9zc2liaWxpdGllcyB3 aGVuIHRoaXMgcmVsYXRpb25zaGlwIGhvbGRzOgotICAgICAgICAvLwotICAgICAgICAvLyA0KSBC YXNlIGlzIGFsbG9jYXRlZCBmaXJzdC4gQSBHQyBoYXBwZW5zIGFuZCBiYXNlIGJlY29tZXMgb2xk LiBUaGVuIHdlIGFsbG9jYXRlCi0gICAgICAgIC8vICAgIGNoaWxkLiAoTm90ZSB0aGF0IGFsdGVy bmF0aXZlbHkgdGhlIEdDIGNvdWxkIGhhcHBlbiBkdXJpbmcgdGhlIGFsbG9jYXRpb24gb2YKLSAg ICAgICAgLy8gICAgY2hpbGQuKSBUaGVuIHdlIHJ1biBhIGJhcnJpZXIgb24gYmFzZS4gQmFzZSB3 aWxsIGFwcGVhciB0byBiZSBhcyBuZXcgYXMgY2hpbGQKLSAgICAgICAgLy8gICAgKHNhbWUgZXBv Y2gpLiBBdCB0aGlzIHBvaW50LCB3ZSBkb24ndCBuZWVkIGFub3RoZXIgYmFycmllciBvbiBiYXNl LgotICAgICAgICAvLwotICAgICAgICAvLyA1KSBCYXNlIGlzIGFsbG9jYXRlZCBmaXJzdC4gVGhl biB3ZSBhbGxvY2F0ZSBjaGlsZC4gVGhlbiB3ZSBydW4gYSBHQy4gVGhlbiB3ZSBydW4gYQotICAg ICAgICAvLyAgICBiYXJyaWVyIG9uIGJhc2UuIEJhc2Ugd2lsbCBhcHBlYXIgbmV3ZXIgdGhhbiBj aGlsZC4gV2UgZG9uJ3QgbmVlZCBhIGJhcnJpZXIKLSAgICAgICAgLy8gICAgYmVjYXVzZSBib3Ro IG9iamVjdHMgYXJlIG9sZC4KLSAgICAgICAgLy8KLSAgICAgICAgLy8gU29tZXRoaW5nIHdlIHdh dGNoIG91dCBmb3IgaGVyZSBpcyB0aGF0IHRoZSBudWxsIGVwb2NoIGlzIGEgY2F0Y2gtYWxsIGZv ciBvYmplY3RzCi0gICAgICAgIC8vIGFsbG9jYXRlZCBiZWZvcmUgd2UgZGlkIGFueSBlcG9jaCB0 cmFja2luZy4gVHdvIG9iamVjdHMgYmVpbmcgaW4gdGhlIG51bGwgZXBvY2gKLSAgICAgICAgLy8g bWVhbnMgdGhhdCB3ZSBkb24ndCBrbm93IHRoZWlyIGVwb2NoIHJlbGF0aW9uc2hpcC4KLSAgICAg ICAgaWYgKCEhYmFzZS0+ZXBvY2goKSAmJiAhIWNoaWxkLT5lcG9jaCgpICYmIGJhc2UtPmVwb2No KCkgPj0gY2hpbGQtPmVwb2NoKCkpIHsKLSAgICAgICAgICAgIGlmICh2ZXJib3NlKQotICAgICAg ICAgICAgICAgIGRhdGFMb2coIiAgICAgICAgICAgIFJlamVjdGluZyBiZWNhdXNlIG9mIGVwb2No IG9yZGVyaW5nLlxuIik7Ci0gICAgICAgICAgICByZXR1cm47Ci0gICAgICAgIH0KLQogICAgICAg ICBjb25zaWRlckJhcnJpZXIoYmFzZSk7CiAgICAgfQogICAgIApAQCAtNDkwLDYgKzQzNSwxMCBA QCBwcml2YXRlOgogCiAgICAgdm9pZCBpbnNlcnRCYXJyaWVyKHVuc2lnbmVkIG5vZGVJbmRleCwg RWRnZSBiYXNlLCBib29sIGV4aXRPSyA9IHRydWUpCiAgICAgeworICAgICAgICAvLyBJbnNlcnRp bmcgYSBiYXJyaWVyIG1lYW5zIHRoYXQgdGhlIG9iamVjdCBtYXkgYmVjb21lIG1hcmtlZCBieSB0 aGUgR0MsIHdoaWNoIHdpbGwgbWFrZQorICAgICAgICAvLyB0aGUgb2JqZWN0IGJsYWNrLgorICAg ICAgICBiYXNlLT5zZXRFcG9jaChFcG9jaCgpKTsKKwogICAgICAgICAvLyBJZiB3ZSdyZSBpbiBn bG9iYWwgbW9kZSwgd2Ugc2hvdWxkIG9ubHkgaW5zZXJ0IHRoZSBiYXJyaWVycyBvbmNlIHdlIGhh dmUgY29udmVyZ2VkLgogICAgICAgICBpZiAoIXJlYWxseUluc2VydEJhcnJpZXJzKCkpCiAgICAg ICAgICAgICByZXR1cm47CkBAIC01MDgsOCArNDU3LDYgQEAgcHJpdmF0ZToKICAgICAgICAgCiAg ICAgICAgIG1faW5zZXJ0aW9uU2V0Lmluc2VydE5vZGUoCiAgICAgICAgICAgICBub2RlSW5kZXgs IFNwZWNOb25lLCBTdG9yZUJhcnJpZXIsIG1fbm9kZS0+b3JpZ2luLnRha2VWYWxpZEV4aXQoZXhp dE9LKSwgYmFzZSk7Ci0KLSAgICAgICAgYmFzZS0+c2V0RXBvY2gobV9jdXJyZW50RXBvY2gpOwog ICAgIH0KICAgICAKICAgICBib29sIHJlYWxseUluc2VydEJhcnJpZXJzKCkK