162312 2016-09-20 11:59:54 -0700 Remove AuthorStyleSheets::m_hadActiveLoadingStylesheet bit 2016-09-20 14:09:14 -0700 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 koivisto webkit-unassigned cdumez commit-queue dbates esprehn+autocc kangil.han oldest_to_newest 1231823 0 koivisto 2016-09-20 11:59:54 -0700 Simplify the logic. 1231824 1 289391 koivisto 2016-09-20 12:07:31 -0700 Created attachment 289391 patch 1231825 2 289391 cdumez 2016-09-20 12:11:31 -0700 Comment on attachment 289391 patch View in context: https://bugs.webkit.org/attachment.cgi?id=289391&action=review r=me if the tests are happy. > Source/WebCore/ChangeLog:11 > + We can handle loading sheet this with normal stylesheet change logic. Remove the special case. typo? "handle loading sheet this" 1231855 3 koivisto 2016-09-20 14:09:14 -0700 https://trac.webkit.org/changeset/206167 289391 2016-09-20 12:07:31 -0700 2016-09-20 12:11:31 -0700 patch loading-stylesheet-no-full-recalc-2.patch text/plain 2843 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjE2MikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE2LTA5LTIwICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1vdmUgQXV0aG9yU3R5bGVT aGVldHM6Om1faGFkQWN0aXZlTG9hZGluZ1N0eWxlc2hlZXQgYml0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIzMTIKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGRvbS9BdXRob3JTdHlsZVNoZWV0cy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpBdXRob3JTdHlsZVNoZWV0czo6YW5hbHl6ZVN0eWxlU2hl ZXRDaGFuZ2UpOgorCisgICAgICAgICAgICBXZSBjYW4gaGFuZGxlIGxvYWRpbmcgc2hlZXQgdGhp cyB3aXRoIG5vcm1hbCBzdHlsZXNoZWV0IGNoYW5nZSBsb2dpYy4gUmVtb3ZlIHRoZSBzcGVjaWFs IGNhc2UuCisKKyAgICAgICAgKFdlYkNvcmU6OmZpbHRlckVuYWJsZWROb25lbXB0eUNTU1N0eWxl U2hlZXRzKToKKworICAgICAgICAgICAgRmlsdGVyIG91dCBsb2FkaW5nIHN0eWxlc2hlZXRzLgor CisgICAgICAgICogZG9tL0F1dGhvclN0eWxlU2hlZXRzLmg6CisKIDIwMTYtMDktMjAgIEFsZXgg Q2hyaXN0ZW5zZW4gIDxhY2hyaXN0ZW5zZW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBBbGlnbiBV UkxQYXJzZXIgd2l0aCB3ZWIgcGxhdGZvcm0gdGVzdHMgd2hlbiBwYXJzaW5nIG5vbi1zcGVjaWFs IHJlbGF0aXZlIFVSTHMgZW5kaW5nIGluIEF1dGhvcml0eU9ySG9zdCBzdGF0ZQpJbmRleDogU291 cmNlL1dlYkNvcmUvZG9tL0F1dGhvclN0eWxlU2hlZXRzLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViQ29yZS9kb20vQXV0aG9yU3R5bGVTaGVldHMuY3BwCShyZXZpc2lvbiAyMDYxMTgpCisr KyBTb3VyY2UvV2ViQ29yZS9kb20vQXV0aG9yU3R5bGVTaGVldHMuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMTUsMTggKzIxNSw3IEBAIEF1dGhvclN0eWxlU2hlZXRzOjpTdHlsZVJlc29sdmVyVXBk YXRlVHkKIHsKICAgICByZXF1aXJlc0Z1bGxTdHlsZVJlY2FsYyA9IHRydWU7CiAgICAgCi0gICAg Ly8gU3R5bGVzaGVldHMgb2YgPHN0eWxlPiBlbGVtZW50cyB0aGF0IEBpbXBvcnQgc3R5bGVzaGVl dHMgYXJlIGFjdGl2ZSBidXQgbG9hZGluZy4gV2UgbmVlZCB0byB0cmlnZ2VyIGEgZnVsbCByZWNh bGMgd2hlbiBzdWNoIGxvYWRzIGFyZSBkb25lLgotICAgIGJvb2wgaGFzQWN0aXZlTG9hZGluZ1N0 eWxlc2hlZXQgPSBmYWxzZTsKICAgICB1bnNpZ25lZCBuZXdTdHlsZXNoZWV0Q291bnQgPSBuZXdT dHlsZXNoZWV0cy5zaXplKCk7Ci0gICAgZm9yIChhdXRvJiBzaGVldCA6IG5ld1N0eWxlc2hlZXRz KSB7Ci0gICAgICAgIGlmIChzaGVldC0+aXNMb2FkaW5nKCkpCi0gICAgICAgICAgICBoYXNBY3Rp dmVMb2FkaW5nU3R5bGVzaGVldCA9IHRydWU7Ci0gICAgfQotICAgIGlmIChtX2hhZEFjdGl2ZUxv YWRpbmdTdHlsZXNoZWV0ICYmICFoYXNBY3RpdmVMb2FkaW5nU3R5bGVzaGVldCkgewotICAgICAg ICBtX2hhZEFjdGl2ZUxvYWRpbmdTdHlsZXNoZWV0ID0gZmFsc2U7Ci0gICAgICAgIHJldHVybiBS ZWNvbnN0cnVjdDsKLSAgICB9Ci0gICAgbV9oYWRBY3RpdmVMb2FkaW5nU3R5bGVzaGVldCA9IGhh c0FjdGl2ZUxvYWRpbmdTdHlsZXNoZWV0OwogCiAgICAgaWYgKHVwZGF0ZUZsYWcgIT0gT3B0aW1p emVkVXBkYXRlKQogICAgICAgICByZXR1cm4gUmVjb25zdHJ1Y3Q7CkBAIC0yODEsNiArMjcwLDgg QEAgc3RhdGljIHZvaWQgZmlsdGVyRW5hYmxlZE5vbmVtcHR5Q1NTU3R5bAogICAgICAgICBpZiAo IWlzPENTU1N0eWxlU2hlZXQ+KCpzaGVldCkpCiAgICAgICAgICAgICBjb250aW51ZTsKICAgICAg ICAgQ1NTU3R5bGVTaGVldCYgc3R5bGVTaGVldCA9IGRvd25jYXN0PENTU1N0eWxlU2hlZXQ+KCpz aGVldCk7CisgICAgICAgIGlmIChzdHlsZVNoZWV0LmlzTG9hZGluZygpKQorICAgICAgICAgICAg Y29udGludWU7CiAgICAgICAgIGlmIChzdHlsZVNoZWV0LmRpc2FibGVkKCkpCiAgICAgICAgICAg ICBjb250aW51ZTsKICAgICAgICAgaWYgKCFzdHlsZVNoZWV0Lmxlbmd0aCgpKQpJbmRleDogU291 cmNlL1dlYkNvcmUvZG9tL0F1dGhvclN0eWxlU2hlZXRzLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L1dlYkNvcmUvZG9tL0F1dGhvclN0eWxlU2hlZXRzLmgJKHJldmlzaW9uIDIwNjExOCkKKysrIFNv dXJjZS9XZWJDb3JlL2RvbS9BdXRob3JTdHlsZVNoZWV0cy5oCSh3b3JraW5nIGNvcHkpCkBAIC0x MjQsNyArMTI0LDYgQEAgcHJpdmF0ZToKICAgICAvLyBlbGVtZW50cyBhbmQgd2hlbiBpdCBpcyBz YWZlIHRvIGV4ZWN1dGUgc2NyaXB0cy4KICAgICBpbnQgbV9wZW5kaW5nU3R5bGVTaGVldENvdW50 IHsgMCB9OwogCi0gICAgYm9vbCBtX2hhZEFjdGl2ZUxvYWRpbmdTdHlsZXNoZWV0IHsgZmFsc2Ug fTsKICAgICBVcGRhdGVGbGFnIG1fcGVuZGluZ1VwZGF0ZVR5cGUgeyBOb1VwZGF0ZSB9OwogCiAg ICAgTGlzdEhhc2hTZXQ8Tm9kZSo+IG1fc3R5bGVTaGVldENhbmRpZGF0ZU5vZGVzOwo=