162307 2016-09-20 11:00:20 -0700 REGRESSION(r206127): ASSERTION FAILED: !isClosed() in WebCore::MediaSource::detachFromElement 2016-09-21 09:27:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryanhaddad jer.noble eric.carlson jer.noble oldest_to_newest 1231783 0 ryanhaddad 2016-09-20 11:00:20 -0700 Crash is attributed to LayoutTest fast/history/page-cache-notification-non-suspendable.html, but the crashlog points to fast/history/page-cache-media-source-opened.html https://build.webkit.org/results/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/r206148%20(8282)/results.html ASSERTION FAILED: !isClosed() /Volumes/Data/slave/elcapitan-debug/build/Source/WebCore/Modules/mediasource/MediaSource.cpp(894) : void WebCore::MediaSource::detachFromElement(WebCore::HTMLMediaElement &) 1 0x10a3e0330 WTFCrash 2 0x10e2ed635 WebCore::MediaSource::detachFromElement(WebCore::HTMLMediaElement&) 3 0x10d4dc3d5 WebCore::HTMLMediaElement::detachMediaSource() 4 0x10e2eda0a WebCore::MediaSource::stop() 5 0x10e2eda4c non-virtual thunk to WebCore::MediaSource::stop() 6 0x10e9b95e2 WebCore::ScriptExecutionContext::stopActiveDOMObjects() 7 0x10cf4c425 WebCore::Document::stopActiveDOMObjects() 8 0x10cf4129e WebCore::Document::prepareForDestruction() 9 0x10d2bedd0 WebCore::Frame::setView(WTF::RefPtr<WebCore::FrameView>&&) 10 0x10d2c1088 WebCore::Frame::createView(WebCore::IntSize const&, WebCore::Color const&, bool, WebCore::IntSize const&, WebCore::IntRect const&, bool, WebCore::ScrollbarMode, bool, WebCore::ScrollbarMode, bool) 11 0x106138802 WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage() 12 0x10d2d3a91 WebCore::FrameLoader::transitionToCommitted(WebCore::CachedPage*) 13 0x10d2d2ab2 WebCore::FrameLoader::commitProvisionalLoad() 14 0x10cfca8bc WebCore::DocumentLoader::commitIfReady() 15 0x10cfcabdd WebCore::DocumentLoader::finishedLoading(double) 16 0x10cfd088d WebCore::DocumentLoader::maybeLoadEmpty() 17 0x10cfd0a1f WebCore::DocumentLoader::startLoadingMainResource() 18 0x10d2d5359 WebCore::FrameLoader::continueLoadAfterWillSubmitForm() 19 0x10d2d0ee2 WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool, WebCore::AllowNavigationToInvalidURL) 20 0x10d2df4fe WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::FormState>, WebCore::AllowNavigationToInvalidURL)::$_4::operator()(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) const 21 0x10d2df480 void std::__1::__invoke_void_return_wrapper<void>::__call<WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::FormState>, WebCore::AllowNavigationToInvalidURL)::$_4&, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool>(WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::FormState>, WebCore::AllowNavigationToInvalidURL)::$_4&&&, WebCore::ResourceRequest const&&&, WTF::PassRefPtr<WebCore::FormState>&&, bool&&) 22 0x10d2df37c std::__1::__function::__func<WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::FormState>, WebCore::AllowNavigationToInvalidURL)::$_4, std::__1::allocator<WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::PassRefPtr<WebCore::FormState>, WebCore::AllowNavigationToInvalidURL)::$_4>, void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>::operator()(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>&&, bool&&) 23 0x10e4f0357 std::__1::function<void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>::operator()(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) const 24 0x10e4ef8d9 WebCore::PolicyCallback::call(bool) 25 0x10e4f11ec WebCore::PolicyChecker::continueAfterNavigationPolicy(WebCore::PolicyAction) 26 0x10e4f47de WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest const&, bool, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, std::__1::function<void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>)::$_1::operator()(WebCore::PolicyAction) const 27 0x10e4f47af void std::__1::__invoke_void_return_wrapper<void>::__call<WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest const&, bool, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, std::__1::function<void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>)::$_1&, WebCore::PolicyAction>(WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest const&, bool, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, std::__1::function<void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>)::$_1&&&, WebCore::PolicyAction&&) 28 0x10e4f472c std::__1::__function::__func<WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest const&, bool, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, std::__1::function<void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>)::$_1, std::__1::allocator<WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest const&, bool, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, std::__1::function<void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>)::$_1>, void (WebCore::PolicyAction)>::operator()(WebCore::PolicyAction&&) 29 0x10612e82c std::__1::function<void (WebCore::PolicyAction)>::operator()(WebCore::PolicyAction) const 30 0x106135856 WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction(WebCore::NavigationAction const&, WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, std::__1::function<void (WebCore::PolicyAction)>) 31 0x10e4f0dac WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest const&, bool, WebCore::DocumentLoader*, WTF::PassRefPtr<WebCore::FormState>, std::__1::function<void (WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool)>) 1231785 1 ryanhaddad 2016-09-20 11:02:38 -0700 Started after https://trac.webkit.org/changeset/206127 1232069 2 jer.noble 2016-09-21 08:37:13 -0700 Looks like this can happen if the MediaSource object is attached to a HTMLMediaElement, but hasn't yet been opened by a MediaSourcePrivate, which is a valid state. I'll just remove this ASSERT(). 1232083 3 289459 jer.noble 2016-09-21 09:24:50 -0700 Created attachment 289459 Patch 1232085 4 jer.noble 2016-09-21 09:27:49 -0700 Committed r206211: <http://trac.webkit.org/changeset/206211> 289459 2016-09-21 09:24:50 -0700 2016-09-21 09:26:06 -0700 Patch bug-162307-20160921092202.patch text/plain 1695 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDZhN2E5MmYwZDg4NzI4 ODgzYWI2OTkzNmQ0ZThkZDNmZGFjZDBiYi4uYzBiZTIxM2ZkOWJkNGNmN2UwZGNkZWNlNzljNmRh MjJkMWMxYzFjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTIxICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04ocjIwNjEy Nyk6IEFTU0VSVElPTiBGQUlMRUQ6ICFpc0Nsb3NlZCgpIGluIFdlYkNvcmU6Ok1lZGlhU291cmNl OjpkZXRhY2hGcm9tRWxlbWVudAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTYyMzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGhlIHRlc3QgaXMgY3Jhc2hpbmcgd2hlbiB0aGUgU2NyaXB0RXhlY3V0aW9u Q29udGV4dCBpcyBjYWxsaW5nIHN0b3AoKSBvbiB0aGUgbWVkaWEgZWxlbWVudCBiZWZvcmUKKyAg ICAgICAgaXQncyBhdHRhY2hlZCBNZWRpYVNvdXJjZSBoYXMgYmVlbiBvcGVuKCllZCwgd2hpY2gg aXMgYSB2YWxpZCBzdGF0ZS4gUmVtb3ZpbmcgdGhpcyBBU1NFUlQoKS4KKworICAgICAgICAqIE1v ZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2UuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TWVk aWFTb3VyY2U6OmRldGFjaEZyb21FbGVtZW50KToKKwogMjAxNi0wOS0xOSAgSmVyIE5vYmxlICA8 amVyLm5vYmxlQGFwcGxlLmNvbT4KIAogICAgICAgICBbbWVkaWEtc291cmNlXSBGaXggaW1wb3J0 ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9tZWRpYS1zb3VyY2UvbWVkaWFzb3VyY2UtYWN0aXZl c291cmNlYnVmZmVycy5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21l ZGlhc291cmNlL01lZGlhU291cmNlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz b3VyY2UvTWVkaWFTb3VyY2UuY3BwCmluZGV4IDY2ZjllZGI0ZDJiZjZkYWFiZTFkZmFjMzFkZGNi YTE1NTgwNWU1OWMuLjk3ZWNjODYyNzMyMzU3NmM3ZTU0N2Q1MTAzNmRlYmZmMTU0ZDQzODcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2Uu Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFzb3VyY2UvTWVkaWFTb3VyY2Uu Y3BwCkBAIC04OTEsNyArODkxLDYgQEAgYm9vbCBNZWRpYVNvdXJjZTo6aXNFbmRlZCgpIGNvbnN0 CiB2b2lkIE1lZGlhU291cmNlOjpkZXRhY2hGcm9tRWxlbWVudChIVE1MTWVkaWFFbGVtZW50JiBl bGVtZW50KQogewogICAgIEFTU0VSVF9VTlVTRUQoZWxlbWVudCwgbV9tZWRpYUVsZW1lbnQgPT0g JmVsZW1lbnQpOwotICAgIEFTU0VSVCghaXNDbG9zZWQoKSk7CiAKICAgICAvLyAyLjQuMiBEZXRh Y2hpbmcgZnJvbSBhIG1lZGlhIGVsZW1lbnQKICAgICAvLyBodHRwczovL3Jhd2dpdC5jb20vdzNj L21lZGlhLXNvdXJjZS80NTYyNzY0NjM0NGVlYTAxNzBkZDFjYmM1YTNkNTA4Y2E3NTFhYmI4L21l ZGlhLXNvdXJjZS1yZXNwZWMuaHRtbCNtZWRpYXNvdXJjZS1kZXRhY2gK