162305 2016-09-20 10:52:08 -0700 REGRESSION(r206133): LayoutTest inspector/css/manager-preferredInspectorStyleSheetForFrame.html is a flaky failure 2017-01-11 21:57:53 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ryanhaddad joepeck ap commit-queue hi inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1231773 0 ryanhaddad 2016-09-20 10:52:08 -0700 LayoutTest inspector/css/manager-preferredInspectorStyleSheetForFrame.html is a flaky failure This test has started frequently failing after http://trac.webkit.org/changeset/206133 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=inspector%2Fcss%2Fmanager-preferredInspectorStyleSheetForFrame.html --- /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/css/manager-preferredInspectorStyleSheetForFrame-expected.txt +++ /Volumes/Data/slave/elcapitan-debug-tests-wk2/build/layout-test-results/inspector/css/manager-preferredInspectorStyleSheetForFrame-actual.txt @@ -20,12 +20,12 @@ PASS: StyleSheet.isInspectorStyleSheet() should be true. -- Running test case: CreateSubFrameInspectorStyleSheet +PASS: Added StyleSheet origin should be 'inspector'. +PASS: StyleSheet.isInspectorStyleSheet() should be true. +PASS: Added StyleSheet frame should be a child frame. PASS: Should be two stylesheets. PASS: StyleSheet origin should be 'inspector'. PASS: StyleSheet.isInspectorStyleSheet() should be true. -PASS: Added StyleSheet origin should be 'inspector'. -PASS: StyleSheet.isInspectorStyleSheet() should be true. -PASS: Added StyleSheet frame should be a child frame. -- Running test case: AnotherSubFrameRequestDoesNothing PASS: Should be two stylesheets. 1231774 1 ryanhaddad 2016-09-20 10:52:18 -0700 https://build.webkit.org/builders/Apple%20El%20Capitan%20Debug%20WK2%20(Tests)/builds/8283 1231775 2 webkit-bug-importer 2016-09-20 10:52:51 -0700 <rdar://problem/28389364> 1232167 3 ryanhaddad 2016-09-21 13:45:48 -0700 Marked test as flaky in https://trac.webkit.org/r206232 1233244 4 ap 2016-09-25 12:09:55 -0700 Is there some reason why this change hasn't been rolled out? 1248502 5 ap 2016-11-05 10:12:07 -0700 Seriously, a test change that broke the test, and we are keeping it in the tree? 1265944 6 joepeck 2017-01-11 16:16:30 -0800 I'll take a look. Reverting the original change, scoped to just this test, seems fine to me. I don't find the new awaitEvent clearer in these tests at all anyways, and they add an extra turn of the runloop which (in cases like we see in this test) may cause flakiness. 1265951 7 298627 joepeck 2017-01-11 16:23:04 -0800 Created attachment 298627 [PATCH] Proposed Fix Before this change this test failed 30 out of 100 times when run with --iterations=100. After this change I saw 0 failures. 1266080 8 298627 commit-queue 2017-01-11 21:57:50 -0800 Comment on attachment 298627 [PATCH] Proposed Fix Clearing flags on attachment: 298627 Committed r210622: <http://trac.webkit.org/changeset/210622> 1266081 9 commit-queue 2017-01-11 21:57:53 -0800 All reviewed patches have been landed. Closing bug. 298627 2017-01-11 16:23:04 -0800 2017-01-11 21:57:50 -0800 [PATCH] Proposed Fix stylesheet-1.patch text/plain 6195 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMDJiYjdkLi45YWE3NWRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMTctMDEt MTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBSRUdS RVNTSU9OKHIyMDYxMzMpOiBMYXlvdXRUZXN0IGluc3BlY3Rvci9jc3MvbWFuYWdlci1wcmVmZXJy ZWRJbnNwZWN0b3JTdHlsZVNoZWV0Rm9yRnJhbWUuaHRtbCBpcyBhIGZsYWt5IGZhaWx1cmUKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjMwNQorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMjgzODkzNjQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvY3NzL21hbmFnZXItcHJlZmVycmVk SW5zcGVjdG9yU3R5bGVTaGVldEZvckZyYW1lLWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBpbnNw ZWN0b3IvY3NzL21hbmFnZXItcHJlZmVycmVkSW5zcGVjdG9yU3R5bGVTaGVldEZvckZyYW1lLmh0 bWw6CisgICAgICAgIFJldmVydCB0aGUgY2hhbmdlIHRoYXQgYnJva2UgdGhpcyBhbmQgbW92ZSB0 byBtb3JlIGRldGVybWluaXN0aWMgY2FsbGJhY2tzCisgICAgICAgIHRoYXQgZG9uJ3QgaW5jbHVk ZSB0aGUgZXh0cmEgdmFyaWFuY2UgaW4gcHJvZHVjaW5nIG91dHB1dC4KKworMjAxNy0wMS0xMSAg Sm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFJFR1JFU1NJ T046IExheW91dFRlc3QgaW5zcGVjdG9yL2RlYnVnZ2VyL2NzcC1leGNlcHRpb25zLmh0bWwgaXMg YSBmbGFreSBmYWlsdXJlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjUyOTIKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI5NDcxODkyPgpkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9tYW5hZ2VyLXByZWZlcnJlZEluc3BlY3Rv clN0eWxlU2hlZXRGb3JGcmFtZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3Iv Y3NzL21hbmFnZXItcHJlZmVycmVkSW5zcGVjdG9yU3R5bGVTaGVldEZvckZyYW1lLWV4cGVjdGVk LnR4dAppbmRleCA2MGE0NzFlLi5mZjUzY2QzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9pbnNw ZWN0b3IvY3NzL21hbmFnZXItcHJlZmVycmVkSW5zcGVjdG9yU3R5bGVTaGVldEZvckZyYW1lLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY3NzL21hbmFnZXItcHJlZmVy cmVkSW5zcGVjdG9yU3R5bGVTaGVldEZvckZyYW1lLWV4cGVjdGVkLnR4dApAQCAtOCwxMiArOCwx MiBAQCBQQVNTOiBQYWdlIHNob3VsZCBoYXZlIGEgc3ViZnJhbWUuCiBQQVNTOiBTaG91bGQgYmUg bm8gc3R5bGVzaGVldHMuCiAKIC0tIFJ1bm5pbmcgdGVzdCBjYXNlOiBDcmVhdGVNYWluRnJhbWVJ bnNwZWN0b3JTdHlsZVNoZWV0CitQQVNTOiBBZGRlZCBTdHlsZVNoZWV0IG9yaWdpbiBzaG91bGQg YmUgJ2luc3BlY3RvcicuCitQQVNTOiBTdHlsZVNoZWV0LmlzSW5zcGVjdG9yU3R5bGVTaGVldCgp IHNob3VsZCBiZSB0cnVlLgorUEFTUzogQWRkZWQgU3R5bGVTaGVldCBmcmFtZSBzaG91bGQgYmUg dGhlIG1haW4gZnJhbWUuCiBQQVNTOiBTaG91bGQgYmUgb25lIHN0eWxlc2hlZXQuCiBQQVNTOiBT dHlsZVNoZWV0IG9yaWdpbiBpcyBpbnNwZWN0b3IuCiBQQVNTOiBTdHlsZVNoZWV0LmlzSW5zcGVj dG9yU3R5bGVTaGVldCgpIHNob3VsZCBiZSB0cnVlLgotUEFTUzogQWRkZWQgU3R5bGVTaGVldCBv cmlnaW4gc2hvdWxkIGJlICdpbnNwZWN0b3InLgotUEFTUzogU3R5bGVTaGVldC5pc0luc3BlY3Rv clN0eWxlU2hlZXQoKSBzaG91bGQgYmUgdHJ1ZS4KLVBBU1M6IEFkZGVkIFN0eWxlU2hlZXQgZnJh bWUgc2hvdWxkIGJlIHRoZSBtYWluIGZyYW1lLgogCiAtLSBSdW5uaW5nIHRlc3QgY2FzZTogQW5v dGhlck1haW5GcmFtZVJlcXVlc3REb2VzTm90aGluZwogUEFTUzogU2hvdWxkIHN0aWxsIGJlIG9u ZSBzdHlsZXNoZWV0LgpAQCAtMjEsMTIgKzIxLDEyIEBAIFBBU1M6IFN0eWxlU2hlZXQgb3JpZ2lu IHNob3VsZCBiZSAnaW5zcGVjdG9yJy4KIFBBU1M6IFN0eWxlU2hlZXQuaXNJbnNwZWN0b3JTdHls ZVNoZWV0KCkgc2hvdWxkIGJlIHRydWUuCiAKIC0tIFJ1bm5pbmcgdGVzdCBjYXNlOiBDcmVhdGVT dWJGcmFtZUluc3BlY3RvclN0eWxlU2hlZXQKLVBBU1M6IFNob3VsZCBiZSB0d28gc3R5bGVzaGVl dHMuCi1QQVNTOiBTdHlsZVNoZWV0IG9yaWdpbiBzaG91bGQgYmUgJ2luc3BlY3RvcicuCi1QQVNT OiBTdHlsZVNoZWV0LmlzSW5zcGVjdG9yU3R5bGVTaGVldCgpIHNob3VsZCBiZSB0cnVlLgogUEFT UzogQWRkZWQgU3R5bGVTaGVldCBvcmlnaW4gc2hvdWxkIGJlICdpbnNwZWN0b3InLgogUEFTUzog U3R5bGVTaGVldC5pc0luc3BlY3RvclN0eWxlU2hlZXQoKSBzaG91bGQgYmUgdHJ1ZS4KIFBBU1M6 IEFkZGVkIFN0eWxlU2hlZXQgZnJhbWUgc2hvdWxkIGJlIGEgY2hpbGQgZnJhbWUuCitQQVNTOiBT aG91bGQgYmUgdHdvIHN0eWxlc2hlZXRzLgorUEFTUzogU3R5bGVTaGVldCBvcmlnaW4gc2hvdWxk IGJlICdpbnNwZWN0b3InLgorUEFTUzogU3R5bGVTaGVldC5pc0luc3BlY3RvclN0eWxlU2hlZXQo KSBzaG91bGQgYmUgdHJ1ZS4KIAogLS0gUnVubmluZyB0ZXN0IGNhc2U6IEFub3RoZXJTdWJGcmFt ZVJlcXVlc3REb2VzTm90aGluZwogUEFTUzogU2hvdWxkIGJlIHR3byBzdHlsZXNoZWV0cy4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2luc3BlY3Rvci9jc3MvbWFuYWdlci1wcmVmZXJyZWRJbnNw ZWN0b3JTdHlsZVNoZWV0Rm9yRnJhbWUuaHRtbCBiL0xheW91dFRlc3RzL2luc3BlY3Rvci9jc3Mv bWFuYWdlci1wcmVmZXJyZWRJbnNwZWN0b3JTdHlsZVNoZWV0Rm9yRnJhbWUuaHRtbAppbmRleCBl ODBiZjdhNi4uZGUzYTJmNCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2Nzcy9t YW5hZ2VyLXByZWZlcnJlZEluc3BlY3RvclN0eWxlU2hlZXRGb3JGcmFtZS5odG1sCisrKyBiL0xh eW91dFRlc3RzL2luc3BlY3Rvci9jc3MvbWFuYWdlci1wcmVmZXJyZWRJbnNwZWN0b3JTdHlsZVNo ZWV0Rm9yRnJhbWUuaHRtbApAQCAtMjQsOCArMjQsNyBAQCBmdW5jdGlvbiB0ZXN0KCkKICAgICAg ICAgbmFtZTogIkNyZWF0ZU1haW5GcmFtZUluc3BlY3RvclN0eWxlU2hlZXQiLAogICAgICAgICBk ZXNjcmlwdGlvbjogIkZpcnN0IHJlcXVlc3QgZm9yIG1haW4gZnJhbWUgc2hvdWxkIGNyZWF0ZSBp bnNwZWN0b3Igc3R5bGVzaGVldC4iLAogICAgICAgICB0ZXN0KHJlc29sdmUsIHJlamVjdCkgewot ICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmNzc1N0eWxlTWFuYWdlci5hd2FpdEV2ZW50KFdlYklu c3BlY3Rvci5DU1NTdHlsZU1hbmFnZXIuRXZlbnQuU3R5bGVTaGVldEFkZGVkKQotICAgICAgICAg ICAgLnRoZW4oKGV2ZW50KSA9PiB7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3IuY3NzU3R5bGVN YW5hZ2VyLnNpbmdsZUZpcmVFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5DU1NTdHlsZU1hbmFn ZXIuRXZlbnQuU3R5bGVTaGVldEFkZGVkLCAoZXZlbnQpID0+IHsKICAgICAgICAgICAgICAgICBJ bnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQoZXZlbnQuZGF0YS5zdHlsZVNoZWV0Lm9yaWdpbiA9PT0g V2ViSW5zcGVjdG9yLkNTU1N0eWxlU2hlZXQuVHlwZS5JbnNwZWN0b3IsICJBZGRlZCBTdHlsZVNo ZWV0IG9yaWdpbiBzaG91bGQgYmUgJ2luc3BlY3RvcicuIik7CiAgICAgICAgICAgICAgICAgSW5z cGVjdG9yVGVzdC5leHBlY3RUaGF0KGV2ZW50LmRhdGEuc3R5bGVTaGVldC5pc0luc3BlY3RvclN0 eWxlU2hlZXQoKSwgIlN0eWxlU2hlZXQuaXNJbnNwZWN0b3JTdHlsZVNoZWV0KCkgc2hvdWxkIGJl IHRydWUuIik7CiAgICAgICAgICAgICAgICAgSW5zcGVjdG9yVGVzdC5leHBlY3RUaGF0KGV2ZW50 LmRhdGEuc3R5bGVTaGVldC5wYXJlbnRGcmFtZSA9PT0gbWFpbkZyYW1lLCAiQWRkZWQgU3R5bGVT aGVldCBmcmFtZSBzaG91bGQgYmUgdGhlIG1haW4gZnJhbWUuIik7CkBAIC02MSw4ICs2MCw3IEBA IGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICBuYW1lOiAiQ3JlYXRlU3ViRnJhbWVJbnNwZWN0b3JT dHlsZVNoZWV0IiwKICAgICAgICAgZGVzY3JpcHRpb246ICJGaXJzdCByZXF1ZXN0IGZvciBzdWJm cmFtZSBzaG91bGQgY3JlYXRlIGluc3BlY3RvciBzdHlsZXNoZWV0LiIsCiAgICAgICAgIHRlc3Qo cmVzb2x2ZSwgcmVqZWN0KSB7Ci0gICAgICAgICAgICBXZWJJbnNwZWN0b3IuY3NzU3R5bGVNYW5h Z2VyLmF3YWl0RXZlbnQoV2ViSW5zcGVjdG9yLkNTU1N0eWxlTWFuYWdlci5FdmVudC5TdHlsZVNo ZWV0QWRkZWQpCi0gICAgICAgICAgICAudGhlbigoZXZlbnQpID0+IHsKKyAgICAgICAgICAgIFdl Ykluc3BlY3Rvci5jc3NTdHlsZU1hbmFnZXIuc2luZ2xlRmlyZUV2ZW50TGlzdGVuZXIoV2ViSW5z cGVjdG9yLkNTU1N0eWxlTWFuYWdlci5FdmVudC5TdHlsZVNoZWV0QWRkZWQsIChldmVudCkgPT4g ewogICAgICAgICAgICAgICAgIEluc3BlY3RvclRlc3QuZXhwZWN0VGhhdChldmVudC5kYXRhLnN0 eWxlU2hlZXQub3JpZ2luID09PSBXZWJJbnNwZWN0b3IuQ1NTU3R5bGVTaGVldC5UeXBlLkluc3Bl Y3RvciwgIkFkZGVkIFN0eWxlU2hlZXQgb3JpZ2luIHNob3VsZCBiZSAnaW5zcGVjdG9yJy4iKTsK ICAgICAgICAgICAgICAgICBJbnNwZWN0b3JUZXN0LmV4cGVjdFRoYXQoZXZlbnQuZGF0YS5zdHls ZVNoZWV0LmlzSW5zcGVjdG9yU3R5bGVTaGVldCgpLCAiU3R5bGVTaGVldC5pc0luc3BlY3RvclN0 eWxlU2hlZXQoKSBzaG91bGQgYmUgdHJ1ZS4iKTsKICAgICAgICAgICAgICAgICBJbnNwZWN0b3JU ZXN0LmV4cGVjdFRoYXQoZXZlbnQuZGF0YS5zdHlsZVNoZWV0LnBhcmVudEZyYW1lID09PSBjaGls ZEZyYW1lc1swXSwgIkFkZGVkIFN0eWxlU2hlZXQgZnJhbWUgc2hvdWxkIGJlIGEgY2hpbGQgZnJh bWUuIik7CkBAIC05NCw4ICs5Miw3IEBAIGZ1bmN0aW9uIHRlc3QoKQogICAgICAgICB9CiAgICAg fSk7CiAKLSAgICBXZWJJbnNwZWN0b3IuY3NzU3R5bGVNYW5hZ2VyLmF3YWl0RXZlbnQoV2ViSW5z cGVjdG9yLkNTU1N0eWxlTWFuYWdlci5FdmVudC5TdHlsZVNoZWV0UmVtb3ZlZCkKLSAgICAudGhl bigoZXZlbnQpID0+IHsKKyAgICBXZWJJbnNwZWN0b3IuY3NzU3R5bGVNYW5hZ2VyLnNpbmdsZUZp cmVFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5DU1NTdHlsZU1hbmFnZXIuRXZlbnQuU3R5bGVT aGVldFJlbW92ZWQsIGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAgICAgIEluc3BlY3RvclRlc3QuYXNz ZXJ0KGZhbHNlLCAiU2hvdWxkIG5vdCBiZSByZW1vdmluZyBhbnkgU3R5bGVTaGVldHMgaW4gdGhp cyB0ZXN0LiIpOwogICAgIH0pOwogCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9t YWMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy9UZXN0RXhwZWN0 YXRpb25zCmluZGV4IGNlYjM1ZDMuLmYxODExMGYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3Bs YXRmb3JtL21hYy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9UZXN0RXhwZWN0YXRpb25zCkBAIC0xMjEwLDggKzEyMTAsNiBAQCB3ZWJraXQub3JnL2IvMTU4 MDA2IGluc3BlY3Rvci9jb25zb2xlL2NvbnNvbGUtdGltZS5odG1sIFsgUGFzcyBUaW1lb3V0IF0K IHdlYmtpdC5vcmcvYi8xNTY2MzQgaW5zcGVjdG9yL2Zvcm1hdHRpbmcvZm9ybWF0dGluZy1qYXZh c2NyaXB0Lmh0bWwgWyBQYXNzIFRpbWVvdXQgXQogd2Via2l0Lm9yZy9iLzE1ODk0OCBpbnNwZWN0 b3IvdGltZWxpbmUgWyBQYXNzIFRpbWVvdXQgXQogCi13ZWJraXQub3JnL2IvMTYyMzA1IGluc3Bl Y3Rvci9jc3MvbWFuYWdlci1wcmVmZXJyZWRJbnNwZWN0b3JTdHlsZVNoZWV0Rm9yRnJhbWUuaHRt bCBbIFBhc3MgRmFpbHVyZSBdCi0KICMgQ29sb3JzcGFjZXMgb24gQ0EgT3BlbkdMIGxheWVycyBu b3QgYXZhaWxhYmxlIGluIFlvc2VtaXRlCiBbIFlvc2VtaXRlIF0gZmFzdC9jYW52YXMvd2ViZ2wv bWF0Y2gtcGFnZS1jb2xvci1zcGFjZS5odG1sIFsgU2tpcCBdCiAK