16228 2007-12-01 16:37:36 -0800 kJSClassDefinitionEmpty is not exported with JS_EXPORT 2007-12-01 21:24:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 alp webkit-unassigned mrowe oldest_to_newest 62919 0 alp 2007-12-01 16:37:36 -0800 When fixing http://bugs.webkit.org/show_bug.cgi?id=15569 we neglected to export the kJSClassDefinitionEmpty global. Its actual definition is in JSClassRef.cpp kJSClassDefinitionEmpty is the only part of the API that is not defined statically and is not an entry point. This was noticed when attempting to build minidom.c out-of-tree. 62921 1 17634 alp 2007-12-01 18:18:25 -0800 Created attachment 17634 Proposed fix Tested with gcc-linux-gtk+ 62924 2 17634 aroben 2007-12-01 21:14:09 -0800 Comment on attachment 17634 Proposed fix r=me 62927 3 alp 2007-12-01 21:24:47 -0800 Landed in r28311. 17634 2007-12-01 18:18:25 -0800 2007-12-01 21:14:09 -0800 Proposed fix kjsclass-export.patch text/plain 2448 alp SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI4MzEwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMDctMTItMDEgIEFscCBUb2tl ciAgPGFscEBhdG9rZXIuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjI4 CisgICAgICAgIGtKU0NsYXNzRGVmaW5pdGlvbkVtcHR5IGlzIG5vdCBleHBvcnRlZCB3aXRoIEpT X0VYUE9SVAorCisgICAgICAgIEFkZCBKU19FWFBPUlQgdG8ga0pTQ2xhc3NEZWZpbml0aW9uRW1w dHkuCisKKyAgICAgICAgTWFrZSB0aGUgZ2NjIGNvbXBpbGVyIGNoZWNrIHRha2UgcHJlY2VkZW5j ZSBvdmVyIHRoZSBXSU4zMnx8X1dJTjMyCisgICAgICAgIGNoZWNrIHRvIGVuc3VyZSB0aGF0IHN5 bWJvbHMgYXJlIGV4cG9ydGVkIG9uIFdpbmRvd3Mgd2hlbiB1c2luZyBnY2MuCisKKyAgICAgICAg QWRkIGEgVE9ETyByZWZlcmVuY2luZyB0aGUgYnVnIGFib3V0IEpTX0VYUE9SVCBpbiB0aGUgV2lu IGJ1aWxkCisgICAgICAgIChodHRwOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x NjIyNykKKworICAgICAgICBEb24ndCBkZWZpbmUgSlNfRVhQT1JUIGFzICdleHRlcm4nIHdoZW4g dGhlIGNvbXBpbGVyIGlzIHVua25vd24gc2luY2UKKyAgICAgICAgaXQgd291bGQgcmVzdWx0IGlu IHRoZSBpbmNvcnJlY3QgZXhwYW5zaW9uOgorCisgICAgICAgICAgZXh0ZXJuIGV4dGVybiBjb25z dCBKU0NsYXNzRGVmaW5pdGlvbiBrSlNDbGFzc0RlZmluaXRpb25FbXB0eTsKKworICAgICAgICAo VGhpcyB3YXMgc29tZXRoaW5nIHdlIGluaGVyaXRlZCBmcm9tIENGQmFzZS5oIHRoYXQgZG9lc24n dCBtYWtlIHNlbnNlCisgICAgICAgIGZvciBKU0Jhc2UuaCkKKworICAgICAgICAqIEFQSS9KU0Jh c2UuaDoKKyAgICAgICAgKiBBUEkvSlNPYmplY3RSZWYuaDoKKwogMjAwNy0xMS0zMCAgR2VvZmZy ZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGgg RGFraW4uCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9BUEkvSlNCYXNlLmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvQVBJL0pTQmFzZS5oCShyZXZpc2lvbiAyODMxMCkKKysrIEphdmFTY3Jp cHRDb3JlL0FQSS9KU0Jhc2UuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsMTIgKzYxLDE0IEBAIHR5 cGVkZWYgc3RydWN0IE9wYXF1ZUpTVmFsdWUqIEpTT2JqZWN0UmUKIC8qIEphdmFTY3JpcHQgc3lt Ym9sIGV4cG9ydHMgKi8KIAogI3VuZGVmIEpTX0VYUE9SVAotI2lmIGRlZmluZWQoV0lOMzIpIHx8 IGRlZmluZWQoX1dJTjMyKQotICAgICNkZWZpbmUgSlNfRVhQT1JUCi0jZWxpZiBkZWZpbmVkKF9f R05VQ19fKQorI2lmIGRlZmluZWQoX19HTlVDX18pCiAgICAgI2RlZmluZSBKU19FWFBPUlQgX19h dHRyaWJ1dGVfXygodmlzaWJpbGl0eSgiZGVmYXVsdCIpKSkKKyNlbGlmIGRlZmluZWQoV0lOMzIp IHx8IGRlZmluZWQoX1dJTjMyKQorICAgIC8vIFRPRE86IEV4cG9ydCBzeW1ib2xzIHdpdGggSlNf RVhQT1JUIHdoZW4gdXNpbmcgTVNWQy4KKyAgICAvLyBTZWUgaHR0cDovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMjcKKyAgICAjZGVmaW5lIEpTX0VYUE9SVAogI2Vsc2UKLSAg ICAjZGVmaW5lIEpTX0VYUE9SVCBleHRlcm4KKyAgICAjZGVmaW5lIEpTX0VYUE9SVAogI2VuZGlm CiAKICNpZmRlZiBfX2NwbHVzcGx1cwpJbmRleDogSmF2YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0 UmVmLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0UmVmLmgJKHJl dmlzaW9uIDI4MzEwKQorKysgSmF2YVNjcmlwdENvcmUvQVBJL0pTT2JqZWN0UmVmLmgJKHdvcmtp bmcgY29weSkKQEAgLTM2OCw3ICszNjgsNyBAQCB0eXBlZGVmIHN0cnVjdCB7CiBKU0NsYXNzRGVm aW5pdGlvbiBkZWZpbml0aW9uID0ga0pTQ2xhc3NEZWZpbml0aW9uRW1wdHk7CiBkZWZpbml0aW9u LmZpbmFsaXplID0gRmluYWxpemU7CiAqLwotZXh0ZXJuIGNvbnN0IEpTQ2xhc3NEZWZpbml0aW9u IGtKU0NsYXNzRGVmaW5pdGlvbkVtcHR5OworSlNfRVhQT1JUIGV4dGVybiBjb25zdCBKU0NsYXNz RGVmaW5pdGlvbiBrSlNDbGFzc0RlZmluaXRpb25FbXB0eTsKIAogLyohCiBAZnVuY3Rpb24K