16227 2007-12-01 16:09:20 -0800 [WIN] JavaScriptCore should export API using JS_EXPORT 2009-07-06 10:48:55 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows XP RESOLVED FIXED PlatformOnly P2 Normal --- 1 alp webkit-unassigned aroben darin ggaren hausmann sfalken oldest_to_newest 62915 0 alp 2007-12-01 16:09:20 -0800 The patch in http://bugs.webkit.org/show_bug.cgi?id=15569 introduced JS_EXPORT to export public API without defs file entries in r28097. It was backed out in r28100 because we couldn't figure out how to define JS_BUILDING_JS in the windows build system (which is required by MSVC to decide between dllimport and dllexport). Once this is done, r28100 should be re-introduced and redundant entries removed from the Win defs file. 118196 1 sfalken 2009-04-20 17:21:16 -0700 This is fixed in r42680 for the Windows build. The change requires proper definition of a BUILDING_{projectname} preprocessor def. We have this defined in win/tools/vsprops/common.vsprops. 129965 2 darin 2009-07-06 10:39:49 -0700 There’s still a comment with this bug number in it in JSBase.h. What should we do about that? 129967 3 sfalken 2009-07-06 10:48:55 -0700 I'll remove the comment.