162266 2016-09-20 05:39:55 -0700 [Win] Null pointer crash under WebCore::CACFLayerTreeHost::create(). 2016-09-21 13:59:26 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1231597 0 pvollan 2016-09-20 05:39:55 -0700 Stack from crash dump: WebKit!WebCore::CACFLayerTreeHost::initialize+0x6 WebKit!WebCore::CACFLayerTreeHost::create+0x6e WebKit!WebCore::CACFLayerTreeHost::acceleratedCompositingAvailable+0xfb WebKit!WebPreferences::acceleratedCompositingEnabled+0x2a WebKit!WebView::notifyPreferencesChanged+0xddd WebKit!WebView::onNotify+0xb5 WebKit!WebNotificationCenter::postNotificationInternal+0x10f WebKit!WebNotificationCenter::postNotificationName+0x3f WebKit!WebPreferences::postPreferencesChangesNotification+0x31 WebKit!WebView::initWithFrame+0x763 1231598 1 289341 pvollan 2016-09-20 05:43:25 -0700 Created attachment 289341 Patch 1231599 2 pvollan 2016-09-20 05:44:19 -0700 rdar://problem/28345073 1231607 3 289341 bfulgham 2016-09-20 06:54:39 -0700 Comment on attachment 289341 Patch R=me 1231631 4 289341 simon.fraser 2016-09-20 08:28:13 -0700 Comment on attachment 289341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289341&action=review > Source/WebCore/ChangeLog:4 > + [Win] Null pointer crash under WebCore::CACFLayerTreeHost::create(). > + https://bugs.webkit.org/show_bug.cgi?id=162266 The radar number should be here too. 1231680 5 289341 bfulgham 2016-09-20 09:12:42 -0700 Comment on attachment 289341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289341&action=review > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:121 > + return nullptr; Thinking about this more, I wonder if we should add a WTFLog here to document that we couldn't get a valid CACFLayerTreeHost. This is unusual, and would be a key clue in diagnosing weird behavior if we could see it in console output. 1232174 6 pvollan 2016-09-21 13:57:30 -0700 (In reply to comment #5) > Comment on attachment 289341 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289341&action=review > > > Source/WebCore/platform/graphics/ca/win/CACFLayerTreeHost.cpp:121 > > + return nullptr; > > Thinking about this more, I wonder if we should add a WTFLog here to > document that we couldn't get a valid CACFLayerTreeHost. This is unusual, > and would be a key clue in diagnosing weird behavior if we could see it in > console output. Thanks for reviewing! I will add the radar number and log statement before landing. 1232175 7 pvollan 2016-09-21 13:59:26 -0700 Committed r206234: <https://trac.webkit.org/changeset/206234> 289341 2016-09-20 05:43:25 -0700 2016-09-20 06:54:39 -0700 Patch bug-162266-20160920054351.patch text/plain 1272 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjE0NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTIwICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbV2luXSBOdWxsIHBvaW50 ZXIgY3Jhc2ggdW5kZXIgV2ViQ29yZTo6Q0FDRkxheWVyVHJlZUhvc3Q6OmNyZWF0ZSgpLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMjY2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIG51bGwgcG9p bnRlciBjaGVjay4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9DQUNGTGF5 ZXJUcmVlSG9zdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQUNGTGF5ZXJUcmVlSG9zdDo6Y3Jl YXRlKToKKwogMjAxNi0wOS0yMCAgUGVyIEFybmUgVm9sbGFuICA8cHZvbGxhbkBhcHBsZS5jb20+ CiAKICAgICAgICAgW1dpbl0gVW5yZXZpZXdlZCB3YXJuaW5nIGZpeC4KSW5kZXg6IFNvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhL3dpbi9DQUNGTGF5ZXJUcmVlSG9zdC5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2Evd2luL0NBQ0ZM YXllclRyZWVIb3N0LmNwcAkocmV2aXNpb24gMjA2MDkwKQorKysgU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Evd2luL0NBQ0ZMYXllclRyZWVIb3N0LmNwcAkod29ya2luZyBjb3B5 KQpAQCAtMTE3LDYgKzExNyw4IEBAIFBhc3NSZWZQdHI8Q0FDRkxheWVyVHJlZUhvc3Q+IENBQ0ZM YXllclQKICAgICBpZiAoIWFjY2VsZXJhdGVkQ29tcG9zaXRpbmdBdmFpbGFibGUoKSkKICAgICAg ICAgcmV0dXJuIG51bGxwdHI7CiAgICAgUmVmUHRyPENBQ0ZMYXllclRyZWVIb3N0PiBob3N0ID0g V0tDQUNGVmlld0xheWVyVHJlZUhvc3Q6OmNyZWF0ZSgpOworICAgIGlmICghaG9zdCkKKyAgICAg ICAgcmV0dXJuIG51bGxwdHI7CiAgICAgaG9zdC0+aW5pdGlhbGl6ZSgpOwogICAgIHJldHVybiBo b3N0LnJlbGVhc2UoKTsKIH0K