162253 2016-09-19 21:41:27 -0700 [JSC] Add `typeof value === "symbol"` handling to bytecode compiler 2016-09-20 08:48:00 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ysuzuki ysuzuki commit-queue keith_miller mark.lam msaboff saam oldest_to_newest 1231511 0 ysuzuki 2016-09-19 21:41:27 -0700 We can easily implement it by using is_cell_with_type. 1231513 1 ysuzuki 2016-09-19 21:47:48 -0700 Benefit is super tiny, but it is consistent to the current implementation that have the similar path for "string" case. 1231514 2 ysuzuki 2016-09-19 21:48:09 -0700 baseline patched is-symbol 1.5291+-0.0149 ^ 1.4763+-0.0160 ^ definitely 1.0358x faster is-symbol-mixed 4.7242+-0.1301 4.5916+-0.1242 might be 1.0289x faster 1231516 3 289310 ysuzuki 2016-09-19 21:50:17 -0700 Created attachment 289310 Patch 1231627 4 289310 ysuzuki 2016-09-20 08:24:40 -0700 Comment on attachment 289310 Patch Thanks! 1231647 5 289310 commit-queue 2016-09-20 08:47:56 -0700 Comment on attachment 289310 Patch Clearing flags on attachment: 289310 Committed r206147: <http://trac.webkit.org/changeset/206147> 1231648 6 commit-queue 2016-09-20 08:48:00 -0700 All reviewed patches have been landed. Closing bug. 289310 2016-09-19 21:50:17 -0700 2016-09-20 08:47:56 -0700 Patch bug-162253-20160920134731.patch text/plain 4546 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA2 ZWUwMWFlNDM0OGRmMjNlMjAwMTVmMTUyYjQ1YzA2NzhkY2MyZDg2Li43ZjY3NTA2OTg5YTk0YjI3 NmJhZjA3N2NhNjA5YTc4NjA4OWU0M2FhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNi0wOS0xOSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBBZGQgYHR5cGVvZiB2YWx1ZSA9PT0gInN5bWJvbCJgIGhh bmRsaW5nIHRvIGJ5dGVjb2RlIGNvbXBpbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIyNTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBBZGQgYHR5cGVvZiB2YWx1ZSA9PT0gInN5bWJvbCJgIGhhbmRs aW5nIHRvIHRoZSBieXRlY29kZSBjb21waWxlci4KKyAgICAgICAgVGhlIGVmZmVjdCBpcyB0aW55 LCBidXQgaXQga2VlcHMgY29uc2lzdGVuY3kgc2luY2UgdGhlIGJ5dGVjb2RlIGNvbXBpbGVyCisg ICAgICAgIGFscmVhZHkgaGFzIHRoZSBzaW1pbGFyIG9wdGltaXphdGlvbiBmb3IgInN0cmluZyIg Y2FzZS4KKworICAgICAgICAqIGJ5dGVjb2RlL1NwZWN1bGF0ZWRUeXBlLmNwcDoKKyAgICAgICAg KEpTQzo6c3BlY3VsYXRpb25Gcm9tSlNUeXBlKToKKyAgICAgICAgKiBieXRlY29tcGlsZXIvQnl0 ZWNvZGVHZW5lcmF0b3IuY3BwOgorICAgICAgICAoSlNDOjpCeXRlY29kZUdlbmVyYXRvcjo6ZW1p dEVxdWFsaXR5T3ApOgorCiAyMDE2LTA5LTE5ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgogCiAgICAgICAgIE1ha2UgSGFzT3duUHJvcGVydHkgZmFzdGVyCmRpZmYgLS1naXQgYS9T b3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0ZWNvZGUvU3BlY3VsYXRlZFR5cGUuY3BwIGIvU291cmNl L0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL1NwZWN1bGF0ZWRUeXBlLmNwcAppbmRleCAxMzc4ODBj YTBlN2E0YTdkMzdjMTU2MmRkZGFhMDlmM2NkMjZhYzNmLi5hZTc3NTE5MGZiZTU3MjJhYTJhMTBi NTY0OTY5NWY4YWIyMzg2ZGUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvYnl0 ZWNvZGUvU3BlY3VsYXRlZFR5cGUuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRl Y29kZS9TcGVjdWxhdGVkVHlwZS5jcHAKQEAgLTQ3Niw2ICs0NzYsOCBAQCBTcGVjdWxhdGVkVHlw ZSBzcGVjdWxhdGlvbkZyb21KU1R5cGUoSlNUeXBlIHR5cGUpCiAgICAgc3dpdGNoICh0eXBlKSB7 CiAgICAgY2FzZSBTdHJpbmdUeXBlOgogICAgICAgICByZXR1cm4gU3BlY1N0cmluZzsKKyAgICBj YXNlIFN5bWJvbFR5cGU6CisgICAgICAgIHJldHVybiBTcGVjU3ltYm9sOwogICAgIGNhc2UgQXJy YXlUeXBlOgogICAgICAgICByZXR1cm4gU3BlY0FycmF5OwogICAgIGNhc2UgRGVyaXZlZEFycmF5 VHlwZToKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29tcGlsZXIvQnl0 ZWNvZGVHZW5lcmF0b3IuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9C eXRlY29kZUdlbmVyYXRvci5jcHAKaW5kZXggZWU5MmMzMmFjMjk2NmUzZGVlNGUzMzc5Y2Q5MjU4 YzJkNzg5MmE2ZC4uMDc1ZjVjZDk2YWI5ZTJkNmZhMmE4YmUwNzAwMDYxZmUxYTUwMzk2ZCAxMDA2 NDQKLS0tIGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29kZUdlbmVy YXRvci5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb21waWxlci9CeXRlY29k ZUdlbmVyYXRvci5jcHAKQEAgLTE2NjUsNiArMTY2NSwxNCBAQCBSZWdpc3RlcklEKiBCeXRlY29k ZUdlbmVyYXRvcjo6ZW1pdEVxdWFsaXR5T3AoT3Bjb2RlSUQgb3Bjb2RlSUQsIFJlZ2lzdGVySUQq IGRzdAogICAgICAgICAgICAgICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChTdHJpbmdUeXBlKTsK ICAgICAgICAgICAgICAgICByZXR1cm4gZHN0OwogICAgICAgICAgICAgfQorICAgICAgICAgICAg aWYgKHZhbHVlID09ICJzeW1ib2wiKSB7CisgICAgICAgICAgICAgICAgcmV3aW5kVW5hcnlPcCgp OworICAgICAgICAgICAgICAgIGVtaXRPcGNvZGUob3BfaXNfY2VsbF93aXRoX3R5cGUpOworICAg ICAgICAgICAgICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChkc3QtPmluZGV4KCkpOworICAgICAg ICAgICAgICAgIGluc3RydWN0aW9ucygpLmFwcGVuZChzcmNJbmRleCk7CisgICAgICAgICAgICAg ICAgaW5zdHJ1Y3Rpb25zKCkuYXBwZW5kKFN5bWJvbFR5cGUpOworICAgICAgICAgICAgICAgIHJl dHVybiBkc3Q7CisgICAgICAgICAgICB9CiAgICAgICAgICAgICBpZiAodmFsdWUgPT0gIm9iamVj dCIpIHsKICAgICAgICAgICAgICAgICByZXdpbmRVbmFyeU9wKCk7CiAgICAgICAgICAgICAgICAg ZW1pdE9wY29kZShvcF9pc19vYmplY3Rfb3JfbnVsbCk7CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0No YW5nZUxvZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDQ4YmZjYWEzYzk2N2I1NTc3OTQ3ZDU0 ZWNjYjZiZmMzZmM2ZGMxMGYuLjgxN2ExNjAzNzM1NjgyNDViMDI1MjEwZWRhYzk1NzBjMzkwNWM2 ZGMgMTAwNjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTYtMDktMTkgIFl1c3VrZSBTdXp1a2kgIDx1dGF0YW5lLnRl YUBnbWFpbC5jb20+CisKKyAgICAgICAgW0pTQ10gQWRkIGB0eXBlb2YgdmFsdWUgPT09ICJzeW1i b2wiYCBoYW5kbGluZyB0byBieXRlY29kZSBjb21waWxlcgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMjUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBtaWNyb2JlbmNobWFya3MvaXMtc3ltYm9sLW1p eGVkLmpzOiBBZGRlZC4KKyAgICAgICAgKGlzU3ltYm9sKToKKyAgICAgICAgKGkubGV0LnBhaXIu b2YubGlzdC5TdHJpbmcpOgorICAgICAgICAqIG1pY3JvYmVuY2htYXJrcy9pcy1zeW1ib2wuanM6 IEFkZGVkLgorICAgICAgICAoaXNTeW1ib2wpOgorCiAyMDE2LTA5LTE5ICBTYWFtIEJhcmF0aSAg PHNiYXJhdGlAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgSGFzT3duUHJvcGVydHkgZmFzdGVy CmRpZmYgLS1naXQgYS9KU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9pcy1zeW1ib2wtbWl4ZWQuanMg Yi9KU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9pcy1zeW1ib2wtbWl4ZWQuanMKbmV3IGZpbGUgbW9k ZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4u ZWNlZDk5ZmE4NTQ1NGUyMDM1ZWI5YWNkN2I5MzBkZTI2OTRkYTFhNQotLS0gL2Rldi9udWxsCisr KyBiL0pTVGVzdHMvbWljcm9iZW5jaG1hcmtzL2lzLXN5bWJvbC1taXhlZC5qcwpAQCAtMCwwICsx LDIyIEBACitmdW5jdGlvbiBpc1N5bWJvbCh2YWx1ZSkKK3sKKyAgICByZXR1cm4gdHlwZW9mIHZh bHVlID09PSAnc3ltYm9sJzsKK30KK25vSW5saW5lKGlzU3ltYm9sKTsKKwordmFyIGxpc3QgPSBb CisgICAgWyB7fSwgZmFsc2UgXSwKKyAgICBbIFtdICwgZmFsc2UgXSwKKyAgICBbICJDYXBwdWNj aW5vIiwgZmFsc2UgXSwKKyAgICBbIFN5bWJvbCgnQ29jb2EnKSwgdHJ1ZSBdLAorICAgIFsgbnVs bCwgZmFsc2UgXSwKKyAgICBbIHVuZGVmaW5lZCwgZmFsc2UgXSwKKyAgICBbIDQyLCBmYWxzZSBd LAorXQorCitmb3IgKHZhciBpID0gMDsgaSA8IDFlNDsgKytpKSB7CisgICAgZm9yIChsZXQgcGFp ciBvZiBsaXN0KSB7CisgICAgICAgIGlmIChpc1N5bWJvbChwYWlyWzBdKSAhPSBwYWlyWzFdKQor ICAgICAgICAgICAgdGhyb3cgbmV3IEVycm9yKGBiYWQgdmFsdWU6JHtTdHJpbmcocGFpclswXSl9 LCAke3BhaXJbMV19YCk7CisgICAgfQorfQpkaWZmIC0tZ2l0IGEvSlNUZXN0cy9taWNyb2JlbmNo bWFya3MvaXMtc3ltYm9sLmpzIGIvSlNUZXN0cy9taWNyb2JlbmNobWFya3MvaXMtc3ltYm9sLmpz Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjIxM2I1YTM0YzQ0Y2I5YzhkYjRmMDNlMTZmMzI3NGQ4MGJmOThhOWEKLS0t IC9kZXYvbnVsbAorKysgYi9KU1Rlc3RzL21pY3JvYmVuY2htYXJrcy9pcy1zeW1ib2wuanMKQEAg LTAsMCArMSwxMCBAQAorZnVuY3Rpb24gaXNTeW1ib2wodmFsdWUpCit7CisgICAgcmV0dXJuIHR5 cGVvZiB2YWx1ZSA9PT0gJ3N5bWJvbCc7Cit9Citub0lubGluZShpc1N5bWJvbCk7CisKK2ZvciAo dmFyIGkgPSAwOyBpIDwgMWU0OyArK2kpIHsKKyAgICBpZiAoIWlzU3ltYm9sKFN5bWJvbCgnQ29j b2EnKSkpCisgICAgICAgIHRocm93IG5ldyBFcnJvcigib3V0Iik7Cit9Cg==