162246 2016-09-19 17:07:25 -0700 [WinCairo] Not building since 206044 2016-09-20 12:13:55 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 chris.reid webkit-unassigned commit-queue dino fujii galpeter graouts kondapallykalyan oldest_to_newest 1231443 0 chris.reid 2016-09-19 17:07:25 -0700 CookieJarCurl.cpp was failing to compile due to some string builder changes. Also JSWebGLRenderingContextCustom.cpp was failing to link due to this error: WebCore.lib(JSWebGLRenderingContextCustom.obj) : error LNK2001: unresolved external symbol "private: void * __cdecl JSC ::Heap::allocateObjectOfType<class JSC::Structure>(unsigned __int64)" (??$allocateObjectOfType@VStructure@JSC@@@Heap@JS C@@AEAAPEAX_K@Z) 1231446 1 289288 chris.reid 2016-09-19 17:13:10 -0700 Created attachment 289288 Patch 1231448 2 commit-queue 2016-09-19 17:15:39 -0700 Attachment 289288 did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSWebGLRenderingContextCustom.cpp:34: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1231453 3 289290 chris.reid 2016-09-19 17:31:52 -0700 Created attachment 289290 Patch 1231475 4 289290 achristensen 2016-09-19 18:28:15 -0700 Comment on attachment 289290 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289290&action=review > Source/WebCore/platform/network/curl/CookieJarCurl.cpp:226 > - cookieStr.append(cookieName + "\t"); > + cookieStr.append(String(domain + "\t")); What's this? If this is necessary, we should call append twice instead of appending the result of allocating a string, copying two strings, then appending it. 1231802 5 289389 chris.reid 2016-09-20 11:19:32 -0700 Created attachment 289389 New patch to remove temporary strings as suggested 1231803 6 chris.reid 2016-09-20 11:19:49 -0700 For reference the error we're seeing with CookieJarCurl is: Source\WebCore\platform\network\curl\CookieJarCurl.cpp(226): error C2668: 'WTF::StringBuilder::append': amb iguous call to overloaded function The ambiguous calls are WTF::StringBuilder::append(const WTF::AtomicString&) and WTF::StringBuilder::append(const WTF::String&) 1231826 7 289389 commit-queue 2016-09-20 12:13:51 -0700 Comment on attachment 289389 New patch to remove temporary strings as suggested Clearing flags on attachment: 289389 Committed r206163: <http://trac.webkit.org/changeset/206163> 1231827 8 commit-queue 2016-09-20 12:13:55 -0700 All reviewed patches have been landed. Closing bug. 289288 2016-09-19 17:13:10 -0700 2016-09-19 17:31:52 -0700 Patch patch.diff text/plain 2213 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZjMxY2JiLi4zZWM5YzQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTYtMDktMTkgIENocmlzdG9waGVyIFJlaWQgIDxDaHJpc3RvcGhlci5SZWlkQGFtLnNv bnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gIE5vdCBidWlsZGluZyBzaW5jZSAyMDYwNDQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjI0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cyAoT09QUyEpLgorCisgICAgICAgICogYmluZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0Nv bnRleHRDdXN0b20uY3BwOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVK YXJDdXJsLmNwcDoKKwogMjAxNi0wOS0xOSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBw bGUuY29tPgogCiAgICAgICAgIFN1cHByZXNzIEphdmFTY3JpcHQgcHJvbXB0cyBlYXJseSBvbiBp biBjZXJ0YWluIGNhc2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9K U1dlYkdMUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5n cy9qcy9KU1dlYkdMUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHAKaW5kZXggZWRlNWJiOS4uMzAz MTFmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJHTFJlbmRl cmluZ0NvbnRleHRDdXN0b20uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pT V2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9tLmNwcApAQCAtMzEsNiArMzEsNyBAQAogI2luY2x1 ZGUgPEphdmFTY3JpcHRDb3JlL0pTQ2VsbElubGluZXMuaD4KICNpbmNsdWRlIDxKYXZhU2NyaXB0 Q29yZS9TdHJ1Y3R1cmVJbmxpbmVzLmg+CiAjaW5jbHVkZSA8aGVhcC9TbG90VmlzaXRvcklubGlu ZXMuaD4KKyNpbmNsdWRlIDxoZWFwL0hlYXBJbmxpbmVzLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBK U0M7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9D b29raWVKYXJDdXJsLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9D b29raWVKYXJDdXJsLmNwcAppbmRleCA4MDg2OTE0Li44YWRiMzY4IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyQ3VybC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwuY3BwCkBA IC0yMjMsMTIgKzIyMywxMiBAQCBzdGF0aWMgU3RyaW5nIGdldE5ldHNjYXBlQ29va2llRm9ybWF0 KGNvbnN0IFVSTCYgdXJsLCBjb25zdCBTdHJpbmcmIHZhbHVlKQogICAgIAogICAgIFN0cmluZ0J1 aWxkZXIgY29va2llU3RyOwogICAgIGNvb2tpZVN0ci5yZXNlcnZlQ2FwYWNpdHkoZmluYWxTdHJp bmdMZW5ndGgpOwotICAgIGNvb2tpZVN0ci5hcHBlbmQoZG9tYWluICsgIlx0Iik7Ci0gICAgY29v a2llU3RyLmFwcGVuZChhbGxvd1N1YmRvbWFpbnMgKyAiXHQiKTsKLSAgICBjb29raWVTdHIuYXBw ZW5kKHBhdGggKyAiXHQiKTsKLSAgICBjb29raWVTdHIuYXBwZW5kKHNlY3VyZSArICJcdCIpOwot ICAgIGNvb2tpZVN0ci5hcHBlbmQoZXhwaXJlc1N0ciArICJcdCIpOwotICAgIGNvb2tpZVN0ci5h cHBlbmQoY29va2llTmFtZSArICJcdCIpOworICAgIGNvb2tpZVN0ci5hcHBlbmQoU3RyaW5nKGRv bWFpbiArICJcdCIpKTsKKyAgICBjb29raWVTdHIuYXBwZW5kKFN0cmluZyhhbGxvd1N1YmRvbWFp bnMgKyAiXHQiKSk7CisgICAgY29va2llU3RyLmFwcGVuZChTdHJpbmcocGF0aCArICJcdCIpKTsK KyAgICBjb29raWVTdHIuYXBwZW5kKFN0cmluZyhzZWN1cmUgKyAiXHQiKSk7CisgICAgY29va2ll U3RyLmFwcGVuZChTdHJpbmcoZXhwaXJlc1N0ciArICJcdCIpKTsKKyAgICBjb29raWVTdHIuYXBw ZW5kKFN0cmluZyhjb29raWVOYW1lICsgIlx0IikpOwogICAgIGNvb2tpZVN0ci5hcHBlbmQoY29v a2llVmFsdWUpOwogCiAgICAgcmV0dXJuIGNvb2tpZVN0ci50b1N0cmluZygpOwo= 289290 2016-09-19 17:31:52 -0700 2016-09-20 11:19:32 -0700 Patch patch.diff text/plain 2257 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZjMxY2JiLi5mMmE2NzcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTYtMDktMTkgIENocmlzdG9waGVyIFJlaWQgIDxDaHJpc3RvcGhlci5SZWlkQGFtLnNv bnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gIE5vdCBidWlsZGluZyBzaW5jZSAyMDYwNDQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjI0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW91ci4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pT V2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9tLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL2N1cmwvQ29va2llSmFyQ3VybC5jcHA6CisKIDIwMTYtMDktMTkgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwcmVzcyBKYXZhU2NyaXB0IHBy b21wdHMgZWFybHkgb24gaW4gY2VydGFpbiBjYXNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwCmlu ZGV4IGVkZTViYjkuLjY1YWJjZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTV2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU1dlYkdMUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHAKQEAgLTMwLDYg KzMwLDcgQEAKICNpbmNsdWRlICJET01XcmFwcGVyV29ybGQuaCIKICNpbmNsdWRlIDxKYXZhU2Ny aXB0Q29yZS9KU0NlbGxJbmxpbmVzLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvU3RydWN0 dXJlSW5saW5lcy5oPgorI2luY2x1ZGUgPGhlYXAvSGVhcElubGluZXMuaD4KICNpbmNsdWRlIDxo ZWFwL1Nsb3RWaXNpdG9ySW5saW5lcy5oPgogCiB1c2luZyBuYW1lc3BhY2UgSlNDOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwu Y3BwCmluZGV4IDgwODY5MTQuLjhhZGIzNjggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJDdXJsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyQ3VybC5jcHAKQEAgLTIyMywxMiArMjIz LDEyIEBAIHN0YXRpYyBTdHJpbmcgZ2V0TmV0c2NhcGVDb29raWVGb3JtYXQoY29uc3QgVVJMJiB1 cmwsIGNvbnN0IFN0cmluZyYgdmFsdWUpCiAgICAgCiAgICAgU3RyaW5nQnVpbGRlciBjb29raWVT dHI7CiAgICAgY29va2llU3RyLnJlc2VydmVDYXBhY2l0eShmaW5hbFN0cmluZ0xlbmd0aCk7Ci0g ICAgY29va2llU3RyLmFwcGVuZChkb21haW4gKyAiXHQiKTsKLSAgICBjb29raWVTdHIuYXBwZW5k KGFsbG93U3ViZG9tYWlucyArICJcdCIpOwotICAgIGNvb2tpZVN0ci5hcHBlbmQocGF0aCArICJc dCIpOwotICAgIGNvb2tpZVN0ci5hcHBlbmQoc2VjdXJlICsgIlx0Iik7Ci0gICAgY29va2llU3Ry LmFwcGVuZChleHBpcmVzU3RyICsgIlx0Iik7Ci0gICAgY29va2llU3RyLmFwcGVuZChjb29raWVO YW1lICsgIlx0Iik7CisgICAgY29va2llU3RyLmFwcGVuZChTdHJpbmcoZG9tYWluICsgIlx0Iikp OworICAgIGNvb2tpZVN0ci5hcHBlbmQoU3RyaW5nKGFsbG93U3ViZG9tYWlucyArICJcdCIpKTsK KyAgICBjb29raWVTdHIuYXBwZW5kKFN0cmluZyhwYXRoICsgIlx0IikpOworICAgIGNvb2tpZVN0 ci5hcHBlbmQoU3RyaW5nKHNlY3VyZSArICJcdCIpKTsKKyAgICBjb29raWVTdHIuYXBwZW5kKFN0 cmluZyhleHBpcmVzU3RyICsgIlx0IikpOworICAgIGNvb2tpZVN0ci5hcHBlbmQoU3RyaW5nKGNv b2tpZU5hbWUgKyAiXHQiKSk7CiAgICAgY29va2llU3RyLmFwcGVuZChjb29raWVWYWx1ZSk7CiAK ICAgICByZXR1cm4gY29va2llU3RyLnRvU3RyaW5nKCk7Cg== 289389 2016-09-20 11:19:32 -0700 2016-09-20 12:13:51 -0700 New patch to remove temporary strings as suggested patch.diff text/plain 2341 chris.reid ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBiZjMxY2JiLi42MGI1NThiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTYtMDktMjAgIENocmlzdG9waGVyIFJlaWQgIDxDaHJpc3RvcGhlci5SZWlkQGFtLnNv bnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gIE5vdCBidWlsZGluZyBzaW5jZSAyMDYwNDQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjI0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIG5ldyB0 ZXN0cy4gTm8gY2hhbmdlIGluIGJlaGF2aW91ci4KKworICAgICAgICAqIGJpbmRpbmdzL2pzL0pT V2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9tLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL2N1cmwvQ29va2llSmFyQ3VybC5jcHA6CisKIDIwMTYtMDktMTkgIEFuZGVycyBDYXJsc3Nv biAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAogICAgICAgICBTdXBwcmVzcyBKYXZhU2NyaXB0IHBy b21wdHMgZWFybHkgb24gaW4gY2VydGFpbiBjYXNlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvYmluZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwIGIvU291cmNl L1dlYkNvcmUvYmluZGluZ3MvanMvSlNXZWJHTFJlbmRlcmluZ0NvbnRleHRDdXN0b20uY3BwCmlu ZGV4IGVkZTViYjkuLjY1YWJjZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdz L2pzL0pTV2ViR0xSZW5kZXJpbmdDb250ZXh0Q3VzdG9tLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9iaW5kaW5ncy9qcy9KU1dlYkdMUmVuZGVyaW5nQ29udGV4dEN1c3RvbS5jcHAKQEAgLTMwLDYg KzMwLDcgQEAKICNpbmNsdWRlICJET01XcmFwcGVyV29ybGQuaCIKICNpbmNsdWRlIDxKYXZhU2Ny aXB0Q29yZS9KU0NlbGxJbmxpbmVzLmg+CiAjaW5jbHVkZSA8SmF2YVNjcmlwdENvcmUvU3RydWN0 dXJlSW5saW5lcy5oPgorI2luY2x1ZGUgPGhlYXAvSGVhcElubGluZXMuaD4KICNpbmNsdWRlIDxo ZWFwL1Nsb3RWaXNpdG9ySW5saW5lcy5oPgogCiB1c2luZyBuYW1lc3BhY2UgSlNDOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwu Y3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL0Nvb2tpZUphckN1cmwu Y3BwCmluZGV4IDgwODY5MTQuLjI0YTJjNzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL25ldHdvcmsvY3VybC9Db29raWVKYXJDdXJsLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL2N1cmwvQ29va2llSmFyQ3VybC5jcHAKQEAgLTIyMywxMiArMjIz LDE4IEBAIHN0YXRpYyBTdHJpbmcgZ2V0TmV0c2NhcGVDb29raWVGb3JtYXQoY29uc3QgVVJMJiB1 cmwsIGNvbnN0IFN0cmluZyYgdmFsdWUpCiAgICAgCiAgICAgU3RyaW5nQnVpbGRlciBjb29raWVT dHI7CiAgICAgY29va2llU3RyLnJlc2VydmVDYXBhY2l0eShmaW5hbFN0cmluZ0xlbmd0aCk7Ci0g ICAgY29va2llU3RyLmFwcGVuZChkb21haW4gKyAiXHQiKTsKLSAgICBjb29raWVTdHIuYXBwZW5k KGFsbG93U3ViZG9tYWlucyArICJcdCIpOwotICAgIGNvb2tpZVN0ci5hcHBlbmQocGF0aCArICJc dCIpOwotICAgIGNvb2tpZVN0ci5hcHBlbmQoc2VjdXJlICsgIlx0Iik7Ci0gICAgY29va2llU3Ry LmFwcGVuZChleHBpcmVzU3RyICsgIlx0Iik7Ci0gICAgY29va2llU3RyLmFwcGVuZChjb29raWVO YW1lICsgIlx0Iik7CisgICAgY29va2llU3RyLmFwcGVuZChkb21haW4pOworICAgIGNvb2tpZVN0 ci5hcHBlbmQoIlx0Iik7CisgICAgY29va2llU3RyLmFwcGVuZChhbGxvd1N1YmRvbWFpbnMpOwor ICAgIGNvb2tpZVN0ci5hcHBlbmQoIlx0Iik7CisgICAgY29va2llU3RyLmFwcGVuZChwYXRoKTsK KyAgICBjb29raWVTdHIuYXBwZW5kKCJcdCIpOworICAgIGNvb2tpZVN0ci5hcHBlbmQoc2VjdXJl KTsKKyAgICBjb29raWVTdHIuYXBwZW5kKCJcdCIpOworICAgIGNvb2tpZVN0ci5hcHBlbmQoZXhw aXJlc1N0cik7CisgICAgY29va2llU3RyLmFwcGVuZCgiXHQiKTsKKyAgICBjb29raWVTdHIuYXBw ZW5kKGNvb2tpZU5hbWUpOworICAgIGNvb2tpZVN0ci5hcHBlbmQoIlx0Iik7CiAgICAgY29va2ll U3RyLmFwcGVuZChjb29raWVWYWx1ZSk7CiAKICAgICByZXR1cm4gY29va2llU3RyLnRvU3RyaW5n KCk7Cg==