162244 2016-09-19 16:24:44 -0700 Add support for HTMLSourceElement.prototype.sizes / HTMLSourceElement.prototype.srcset 2016-09-19 21:24:49 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://html.spec.whatwg.org/#the-source-element WebExposed P2 Normal --- 1 cdumez cdumez achristensen cdumez commit-queue darin esprehn+autocc gyuyoung.kim kondapallykalyan rniwa sam oldest_to_newest 1231394 0 cdumez 2016-09-19 16:24:44 -0700 Add support for HTMLPrototype.prototype.sizes / HTMLPrototype.prototype.srcset: - https://html.spec.whatwg.org/#the-source-element We already support the corresponding content attributes internally. However, we are missing the corresponding IDL attributes that are supposed to reflect them. Chrome and Firefox support them. We already have those IDL attributes on HTMLImageElement. 1231485 1 289301 cdumez 2016-09-19 19:20:08 -0700 Created attachment 289301 Patch 1231505 2 289301 commit-queue 2016-09-19 21:24:44 -0700 Comment on attachment 289301 Patch Clearing flags on attachment: 289301 Committed r206140: <http://trac.webkit.org/changeset/206140> 1231506 3 commit-queue 2016-09-19 21:24:49 -0700 All reviewed patches have been landed. Closing bug. 289301 2016-09-19 19:20:08 -0700 2016-09-19 21:24:44 -0700 Patch bug-162244-20160919191722.patch text/plain 6625 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDNkZjNjMjI4MjAzZDJh OTYzMTA1ZGFjN2VhMGQxMmIxODAyZTcwOS4uMzQ1MTNmZmY3ZTE4YjY0YmYwMDlmN2JjOGU4ZDA5 OGE3OGRkMzFiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA5LTE5ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHN1cHBvcnQgZm9yIEhU TUxTb3VyY2VFbGVtZW50LnByb3RvdHlwZS5zaXplcyAvIEhUTUxTb3VyY2VFbGVtZW50LnByb3Rv dHlwZS5zcmNzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE2MjI0NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEFkZCBzdXBwb3J0IGZvciBIVE1MUHJvdG90eXBlLnByb3RvdHlwZS5zaXplcyAvIEhUTUxQ cm90b3R5cGUucHJvdG90eXBlLnNyY3NldDoKKyAgICAgICAgLSBodHRwczovL2h0bWwuc3BlYy53 aGF0d2cub3JnLyN0aGUtc291cmNlLWVsZW1lbnQKKworICAgICAgICBXZSBhbHJlYWR5IHN1cHBv cnQgdGhlIGNvcnJlc3BvbmRpbmcgY29udGVudCBhdHRyaWJ1dGVzIGludGVybmFsbHkuIEhvd2V2 ZXIsIHdlCisgICAgICAgIGFyZSBtaXNzaW5nIHRoZSBjb3JyZXNwb25kaW5nIElETCBhdHRyaWJ1 dGVzIHRoYXQgYXJlIHN1cHBvc2VkIHRvIHJlZmxlY3QgdGhlbS4KKworICAgICAgICBDaHJvbWUg YW5kIEZpcmVmb3ggc3VwcG9ydCB0aGVtLiBXZSBhbHJlYWR5IGhhZCB0aG9zZSBJREwgYXR0cmli dXRlcyBvbgorICAgICAgICBIVE1MSW1hZ2VFbGVtZW50LgorCisgICAgICAgIE5vIG5ldyB0ZXN0 cywgcmViYXNlbGluZWQgZXhpc3RpbmcgdGVzdC4KKworICAgICAgICAqIGh0bWwvSFRNTFNvdXJj ZUVsZW1lbnQuaWRsOgorCiAyMDE2LTA5LTE5ICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVu c2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVVJMUGFyc2VyIGNhbiByZWFkIG1lbW9yeSBvdXQg b2YgYm91bmRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxTb3VyY2VFbGVt ZW50LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNvdXJjZUVsZW1lbnQuaWRsCmluZGV4 IDNmYjZjNmZhMWUwOWU1MmI0NDkyYzUwZmE0YWI5YzYyZDk1MGUxMGMuLjg4ZDc5ODFhNjdmNDVl Nzk2YTZiMWYzZjBmYTU0N2U5OGU4ZGZmMzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0 bWwvSFRNTFNvdXJjZUVsZW1lbnQuaWRsCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFNv dXJjZUVsZW1lbnQuaWRsCkBAIC0yNCw3ICsyNCw5IEBACiAgKi8KIAogaW50ZXJmYWNlIEhUTUxT b3VyY2VFbGVtZW50IDogSFRNTEVsZW1lbnQgewotW1JlZmxlY3QsIFVSTF0gYXR0cmlidXRlIFVT VlN0cmluZyBzcmM7Ci1hdHRyaWJ1dGUgRE9NU3RyaW5nIHR5cGU7Ci1hdHRyaWJ1dGUgRE9NU3Ry aW5nIG1lZGlhOworICAgIFtSZWZsZWN0LCBVUkxdIGF0dHJpYnV0ZSBVU1ZTdHJpbmcgc3JjOwor ICAgIGF0dHJpYnV0ZSBET01TdHJpbmcgdHlwZTsKKyAgICBbUmVmbGVjdF0gYXR0cmlidXRlIFVT VlN0cmluZyBzcmNzZXQ7CisgICAgW1JlZmxlY3RdIGF0dHJpYnV0ZSBET01TdHJpbmcgc2l6ZXM7 CisgICAgYXR0cmlidXRlIERPTVN0cmluZyBtZWRpYTsKIH07CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0No YW5nZUxvZwppbmRleCAzMDM4MzQxYjVhYWI1MzgxZGRhZTY2NGJlNGE4NWU0OGMyZDZjYzZiLi42 MmE3YjVkNThmMjhkM2I3YTAzZjc1Y2IxZGRhZGQ5Nzc3NzAyZTEwIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL2ltcG9ydGVk L3czYy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAogMjAxNi0wOS0xOSAgQ2hyaXMgRHVtZXog IDxjZHVtZXpAYXBwbGUuY29tPgogCisgICAgICAgIEFkZCBzdXBwb3J0IGZvciBIVE1MU291cmNl RWxlbWVudC5wcm90b3R5cGUuc2l6ZXMgLyBIVE1MU291cmNlRWxlbWVudC5wcm90b3R5cGUuc3Jj c2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIy NDQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWJh c2VsaW5lIG5vdyB0aGF0IG1vcmUgY2hlY2tzIGFyZSBwYXNzaW5nLgorCisgICAgICAgICogd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9tL2ludGVyZmFjZXMtZXhwZWN0ZWQudHh0OgorCisyMDE2 LTA5LTE5ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKICAgICAgICAgVXBkYXRl IFhIVE1MUGFyc2VyIHRvIHJlY29nbml6ZSAiLS8vVzNDLy9EVEQgTWF0aE1MIDIuMC8vRU4iIHB1 YmxpYyBpZGVudGlmaWVyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNjIxNjYKIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9pbnRlcmZhY2VzLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2ltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvaHRtbC9kb20vaW50ZXJmYWNl cy1leHBlY3RlZC50eHQKaW5kZXggNDkxOWNhOTZjOWU2N2E2YzJjN2JmZTBlYzhkNGIzMWU2N2Zi MWIyMS4uYjMzMjI2NzgxMTJkZGJkOThmNjg5OTMwNWZhNjE3OWJkOTc1ZmNmNiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy9odG1sL2RvbS9p bnRlcmZhY2VzLWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvZG9tL2ludGVyZmFjZXMtZXhwZWN0ZWQudHh0CkBAIC0xNDA1 LDE0ICsxNDA1LDE0IEBAIFBBU1MgSFRNTEhSRWxlbWVudCBpbnRlcmZhY2Ugb2JqZWN0IG5hbWUK IFBBU1MgSFRNTEhSRWxlbWVudCBpbnRlcmZhY2U6IGV4aXN0ZW5jZSBhbmQgcHJvcGVydGllcyBv ZiBpbnRlcmZhY2UgcHJvdG90eXBlIG9iamVjdCAKIFBBU1MgSFRNTEhSRWxlbWVudCBpbnRlcmZh Y2U6IGV4aXN0ZW5jZSBhbmQgcHJvcGVydGllcyBvZiBpbnRlcmZhY2UgcHJvdG90eXBlIG9iamVj dCdzICJjb25zdHJ1Y3RvciIgcHJvcGVydHkgCiBQQVNTIEhUTUxIUkVsZW1lbnQgaW50ZXJmYWNl OiBhdHRyaWJ1dGUgYWxpZ24gCi1GQUlMIEhUTUxIUkVsZW1lbnQgaW50ZXJmYWNlOiBhdHRyaWJ1 dGUgY29sb3IgYXNzZXJ0X3RydWU6IFRoZSBwcm90b3R5cGUgb2JqZWN0IG11c3QgaGF2ZSBhIHBy b3BlcnR5ICJjb2xvciIgZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKK1BBU1MgSFRNTEhSRWxlbWVu dCBpbnRlcmZhY2U6IGF0dHJpYnV0ZSBjb2xvciAKIFBBU1MgSFRNTEhSRWxlbWVudCBpbnRlcmZh Y2U6IGF0dHJpYnV0ZSBub1NoYWRlIAogUEFTUyBIVE1MSFJFbGVtZW50IGludGVyZmFjZTogYXR0 cmlidXRlIHNpemUgCiBQQVNTIEhUTUxIUkVsZW1lbnQgaW50ZXJmYWNlOiBhdHRyaWJ1dGUgd2lk dGggCiBQQVNTIEhUTUxIUkVsZW1lbnQgbXVzdCBiZSBwcmltYXJ5IGludGVyZmFjZSBvZiBkb2N1 bWVudC5jcmVhdGVFbGVtZW50KCJociIpIAogUEFTUyBTdHJpbmdpZmljYXRpb24gb2YgZG9jdW1l bnQuY3JlYXRlRWxlbWVudCgiaHIiKSAKIFBBU1MgSFRNTEhSRWxlbWVudCBpbnRlcmZhY2U6IGRv Y3VtZW50LmNyZWF0ZUVsZW1lbnQoImhyIikgbXVzdCBpbmhlcml0IHByb3BlcnR5ICJhbGlnbiIg d2l0aCB0aGUgcHJvcGVyIHR5cGUgKDApIAotRkFJTCBIVE1MSFJFbGVtZW50IGludGVyZmFjZTog ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaHIiKSBtdXN0IGluaGVyaXQgcHJvcGVydHkgImNvbG9y IiB3aXRoIHRoZSBwcm9wZXIgdHlwZSAoMSkgYXNzZXJ0X2luaGVyaXRzOiBwcm9wZXJ0eSAiY29s b3IiIG5vdCBmb3VuZCBpbiBwcm90b3R5cGUgY2hhaW4KK1BBU1MgSFRNTEhSRWxlbWVudCBpbnRl cmZhY2U6IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImhyIikgbXVzdCBpbmhlcml0IHByb3BlcnR5 ICJjb2xvciIgd2l0aCB0aGUgcHJvcGVyIHR5cGUgKDEpIAogUEFTUyBIVE1MSFJFbGVtZW50IGlu dGVyZmFjZTogZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiaHIiKSBtdXN0IGluaGVyaXQgcHJvcGVy dHkgIm5vU2hhZGUiIHdpdGggdGhlIHByb3BlciB0eXBlICgyKSAKIFBBU1MgSFRNTEhSRWxlbWVu dCBpbnRlcmZhY2U6IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImhyIikgbXVzdCBpbmhlcml0IHBy b3BlcnR5ICJzaXplIiB3aXRoIHRoZSBwcm9wZXIgdHlwZSAoMykgCiBQQVNTIEhUTUxIUkVsZW1l bnQgaW50ZXJmYWNlOiBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJociIpIG11c3QgaW5oZXJpdCBw cm9wZXJ0eSAid2lkdGgiIHdpdGggdGhlIHByb3BlciB0eXBlICg0KSAKQEAgLTE5NTAsMTUgKzE5 NTAsMTUgQEAgUEFTUyBIVE1MU291cmNlRWxlbWVudCBpbnRlcmZhY2U6IGV4aXN0ZW5jZSBhbmQg cHJvcGVydGllcyBvZiBpbnRlcmZhY2UgcHJvdG90eXAKIFBBU1MgSFRNTFNvdXJjZUVsZW1lbnQg aW50ZXJmYWNlOiBleGlzdGVuY2UgYW5kIHByb3BlcnRpZXMgb2YgaW50ZXJmYWNlIHByb3RvdHlw ZSBvYmplY3QncyAiY29uc3RydWN0b3IiIHByb3BlcnR5IAogUEFTUyBIVE1MU291cmNlRWxlbWVu dCBpbnRlcmZhY2U6IGF0dHJpYnV0ZSBzcmMgCiBQQVNTIEhUTUxTb3VyY2VFbGVtZW50IGludGVy ZmFjZTogYXR0cmlidXRlIHR5cGUgCi1GQUlMIEhUTUxTb3VyY2VFbGVtZW50IGludGVyZmFjZTog YXR0cmlidXRlIHNyY3NldCBhc3NlcnRfdHJ1ZTogVGhlIHByb3RvdHlwZSBvYmplY3QgbXVzdCBo YXZlIGEgcHJvcGVydHkgInNyY3NldCIgZXhwZWN0ZWQgdHJ1ZSBnb3QgZmFsc2UKLUZBSUwgSFRN TFNvdXJjZUVsZW1lbnQgaW50ZXJmYWNlOiBhdHRyaWJ1dGUgc2l6ZXMgYXNzZXJ0X3RydWU6IFRo ZSBwcm90b3R5cGUgb2JqZWN0IG11c3QgaGF2ZSBhIHByb3BlcnR5ICJzaXplcyIgZXhwZWN0ZWQg dHJ1ZSBnb3QgZmFsc2UKK1BBU1MgSFRNTFNvdXJjZUVsZW1lbnQgaW50ZXJmYWNlOiBhdHRyaWJ1 dGUgc3Jjc2V0IAorUEFTUyBIVE1MU291cmNlRWxlbWVudCBpbnRlcmZhY2U6IGF0dHJpYnV0ZSBz aXplcyAKIFBBU1MgSFRNTFNvdXJjZUVsZW1lbnQgaW50ZXJmYWNlOiBhdHRyaWJ1dGUgbWVkaWEg CiBQQVNTIEhUTUxTb3VyY2VFbGVtZW50IG11c3QgYmUgcHJpbWFyeSBpbnRlcmZhY2Ugb2YgZG9j dW1lbnQuY3JlYXRlRWxlbWVudCgic291cmNlIikgCiBQQVNTIFN0cmluZ2lmaWNhdGlvbiBvZiBk b2N1bWVudC5jcmVhdGVFbGVtZW50KCJzb3VyY2UiKSAKIFBBU1MgSFRNTFNvdXJjZUVsZW1lbnQg aW50ZXJmYWNlOiBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzb3VyY2UiKSBtdXN0IGluaGVyaXQg cHJvcGVydHkgInNyYyIgd2l0aCB0aGUgcHJvcGVyIHR5cGUgKDApIAogUEFTUyBIVE1MU291cmNl RWxlbWVudCBpbnRlcmZhY2U6IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNvdXJjZSIpIG11c3Qg aW5oZXJpdCBwcm9wZXJ0eSAidHlwZSIgd2l0aCB0aGUgcHJvcGVyIHR5cGUgKDEpIAotRkFJTCBI VE1MU291cmNlRWxlbWVudCBpbnRlcmZhY2U6IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoInNvdXJj ZSIpIG11c3QgaW5oZXJpdCBwcm9wZXJ0eSAic3Jjc2V0IiB3aXRoIHRoZSBwcm9wZXIgdHlwZSAo MikgYXNzZXJ0X2luaGVyaXRzOiBwcm9wZXJ0eSAic3Jjc2V0IiBub3QgZm91bmQgaW4gcHJvdG90 eXBlIGNoYWluCi1GQUlMIEhUTUxTb3VyY2VFbGVtZW50IGludGVyZmFjZTogZG9jdW1lbnQuY3Jl YXRlRWxlbWVudCgic291cmNlIikgbXVzdCBpbmhlcml0IHByb3BlcnR5ICJzaXplcyIgd2l0aCB0 aGUgcHJvcGVyIHR5cGUgKDMpIGFzc2VydF9pbmhlcml0czogcHJvcGVydHkgInNpemVzIiBub3Qg Zm91bmQgaW4gcHJvdG90eXBlIGNoYWluCitQQVNTIEhUTUxTb3VyY2VFbGVtZW50IGludGVyZmFj ZTogZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic291cmNlIikgbXVzdCBpbmhlcml0IHByb3BlcnR5 ICJzcmNzZXQiIHdpdGggdGhlIHByb3BlciB0eXBlICgyKSAKK1BBU1MgSFRNTFNvdXJjZUVsZW1l bnQgaW50ZXJmYWNlOiBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJzb3VyY2UiKSBtdXN0IGluaGVy aXQgcHJvcGVydHkgInNpemVzIiB3aXRoIHRoZSBwcm9wZXIgdHlwZSAoMykgCiBQQVNTIEhUTUxT b3VyY2VFbGVtZW50IGludGVyZmFjZTogZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic291cmNlIikg bXVzdCBpbmhlcml0IHByb3BlcnR5ICJtZWRpYSIgd2l0aCB0aGUgcHJvcGVyIHR5cGUgKDQpIAog UEFTUyBIVE1MVHJhY2tFbGVtZW50IGludGVyZmFjZTogZXhpc3RlbmNlIGFuZCBwcm9wZXJ0aWVz IG9mIGludGVyZmFjZSBvYmplY3QgCiBQQVNTIEhUTUxUcmFja0VsZW1lbnQgaW50ZXJmYWNlIG9i amVjdCBsZW5ndGggCg==