162233 2016-09-19 14:16:56 -0700 Reduce logging from WebResourceLoader::didReceiveData 2016-09-19 15:55:29 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162235 1 krollin krollin commit-queue koivisto oldest_to_newest 1231312 0 krollin 2016-09-19 14:16:56 -0700 Reduce the amount of logging performed by WebResourceLoader::didReceiveData when downloading resources -- only log once even if called multiple times for a single resource. 1231333 1 289259 krollin 2016-09-19 14:38:05 -0700 Created attachment 289259 Patch 1231339 2 289262 krollin 2016-09-19 14:52:59 -0700 Created attachment 289262 Patch 1231369 3 289262 koivisto 2016-09-19 15:29:06 -0700 Comment on attachment 289262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289262&action=review > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:138 > + RELEASE_LOG_IF_ALLOWED("didReceiveData: (size = %lu)", data.size()); Should the message indicate that this was the first data received? It might be confusing if it appears that there was nothing more. 1231371 4 krollin 2016-09-19 15:33:20 -0700 (In reply to comment #3) > Comment on attachment 289262 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289262&action=review > > > Source/WebKit2/WebProcess/Network/WebResourceLoader.cpp:138 > > + RELEASE_LOG_IF_ALLOWED("didReceiveData: (size = %lu)", data.size()); > > Should the message indicate that this was the first data received? It might > be confusing if it appears that there was nothing more. This will be addressed in Bug 162235. 1231378 5 289262 commit-queue 2016-09-19 15:55:24 -0700 Comment on attachment 289262 Patch Clearing flags on attachment: 289262 Committed r206123: <http://trac.webkit.org/changeset/206123> 1231379 6 commit-queue 2016-09-19 15:55:29 -0700 All reviewed patches have been landed. Closing bug. 289259 2016-09-19 14:38:05 -0700 2016-09-19 14:50:42 -0700 Patch bug-162233-20160919143520.patch text/plain 1844 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjE1ZTM3MTIzZjgxNzA3 N2NhNzYyOTg2NDZmMDE4YmUwMTkxMDE5NC4uYzIyZWZjMWYwNmI1Mzk3ZjliNDMwMDU2MjEwZjhj NTdhNGE5MDYwYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE2LTA5LTE5ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZWR1Y2UgbG9nZ2luZyBm cm9tIFdlYlJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0YQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMjMzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSBsb2cgb25jZSBldmVuIGlmIGNhbGxl ZCBtdWx0aXBsZSB0aW1lcyBmb3IgYSBzaW5nbGUgcmVzb3VyY2UuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZURhdGEpOgorCiAyMDE2LTA5LTE5ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgT25seSBvdmVy cmlkZSBVUkxQYXJzZXI6OmVuYWJsZWQgaWYgTlNVc2VyRGVmYXVsdHMgb2JqZWN0IGV4aXN0cwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNl TG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJj ZUxvYWRlci5jcHAKaW5kZXggMzY1ZDU5ODhjNGM1NTBkOTc1NDgwYzA0YTAzN2RmZTNkMzcyNmYx Ny4uMjNiNjkyODZjMDhjMTQ4ZWFjNGI4MTIzMzliZWEyNDJiYmZjMzlkMiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcAor KysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIu Y3BwCkBAIC0xMzMsNyArMTMzLDExIEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2Vp dmVSZXNwb25zZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSwgYm9vCiB2b2lkIFdl YlJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0YShjb25zdCBJUEM6OkRhdGFSZWZlcmVuY2Um IGRhdGEsIGludDY0X3QgZW5jb2RlZERhdGFMZW5ndGgpCiB7CiAgICAgTE9HKE5ldHdvcmssICIo V2ViUHJvY2VzcykgV2ViUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVEYXRhIG9mIHNpemUgJWx1 IGZvciAnJXMnIiwgZGF0YS5zaXplKCksIG1fY29yZUxvYWRlci0+dXJsKCkuc3RyaW5nKCkubGF0 aW4xKCkuZGF0YSgpKTsKLSAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJkaWRSZWNlaXZlRGF0 YTogKHNpemUgPSAlbHUpIiwgZGF0YS5zaXplKCkpOworCisgICAgaWYgKCFtX2hhc1JlY2VpdmVk RGF0YSkgeworICAgICAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJkaWRSZWNlaXZlRGF0YTog KHNpemUgPSAlbHUpIiwgZGF0YS5zaXplKCkpOworICAgICAgICBtX2hhc1JlY2VpdmVkRGF0YSA9 IHRydWU7CisgICAgfQogCiAjaWYgVVNFKFFVSUNLX0xPT0spCiAgICAgaWYgKFF1aWNrTG9va0hh bmRsZSogcXVpY2tMb29rSGFuZGxlID0gbV9jb3JlTG9hZGVyLT5kb2N1bWVudExvYWRlcigpLT5x dWlja0xvb2tIYW5kbGUoKSkgewo= 289262 2016-09-19 14:52:59 -0700 2016-09-19 15:55:24 -0700 Patch bug-162233-20160919145014.patch text/plain 2390 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MTA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNjE1ZTM3MTIzZjgxNzA3 N2NhNzYyOTg2NDZmMDE4YmUwMTkxMDE5NC4uNDY0ZjYwNDY1MTA1YThhNWIwNzkxMjI4NWE2ODMx OWVhMDQzYTgzMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTE5ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBSZWR1Y2UgbG9nZ2luZyBm cm9tIFdlYlJlc291cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0YQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMjMzCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgT25seSBsb2cgb25jZSBldmVuIGlmIGNhbGxl ZCBtdWx0aXBsZSB0aW1lcyBmb3IgYSBzaW5nbGUgcmVzb3VyY2UuCisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpX ZWJSZXNvdXJjZUxvYWRlcjo6ZGlkUmVjZWl2ZURhdGEpOgorICAgICAgICAqIFdlYlByb2Nlc3Mv TmV0d29yay9XZWJSZXNvdXJjZUxvYWRlci5oOgorCiAyMDE2LTA5LTE5ICBBbGV4IENocmlzdGVu c2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgT25seSBvdmVycmlkZSBV UkxQYXJzZXI6OmVuYWJsZWQgaWYgTlNVc2VyRGVmYXVsdHMgb2JqZWN0IGV4aXN0cwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVy LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvTmV0d29yay9XZWJSZXNvdXJjZUxvYWRl ci5jcHAKaW5kZXggMzY1ZDU5ODhjNGM1NTBkOTc1NDgwYzA0YTAzN2RmZTNkMzcyNmYxNy4uMjNi NjkyODZjMDhjMTQ4ZWFjNGI4MTIzMzliZWEyNDJiYmZjMzlkMiAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3b3JrL1dlYlJlc291cmNlTG9hZGVyLmNwcAorKysgYi9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VMb2FkZXIuY3BwCkBA IC0xMzMsNyArMTMzLDExIEBAIHZvaWQgV2ViUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVSZXNw b25zZShjb25zdCBSZXNvdXJjZVJlc3BvbnNlJiByZXNwb25zZSwgYm9vCiB2b2lkIFdlYlJlc291 cmNlTG9hZGVyOjpkaWRSZWNlaXZlRGF0YShjb25zdCBJUEM6OkRhdGFSZWZlcmVuY2UmIGRhdGEs IGludDY0X3QgZW5jb2RlZERhdGFMZW5ndGgpCiB7CiAgICAgTE9HKE5ldHdvcmssICIoV2ViUHJv Y2VzcykgV2ViUmVzb3VyY2VMb2FkZXI6OmRpZFJlY2VpdmVEYXRhIG9mIHNpemUgJWx1IGZvciAn JXMnIiwgZGF0YS5zaXplKCksIG1fY29yZUxvYWRlci0+dXJsKCkuc3RyaW5nKCkubGF0aW4xKCku ZGF0YSgpKTsKLSAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJkaWRSZWNlaXZlRGF0YTogKHNp emUgPSAlbHUpIiwgZGF0YS5zaXplKCkpOworCisgICAgaWYgKCFtX2hhc1JlY2VpdmVkRGF0YSkg eworICAgICAgICBSRUxFQVNFX0xPR19JRl9BTExPV0VEKCJkaWRSZWNlaXZlRGF0YTogKHNpemUg PSAlbHUpIiwgZGF0YS5zaXplKCkpOworICAgICAgICBtX2hhc1JlY2VpdmVkRGF0YSA9IHRydWU7 CisgICAgfQogCiAjaWYgVVNFKFFVSUNLX0xPT0spCiAgICAgaWYgKFF1aWNrTG9va0hhbmRsZSog cXVpY2tMb29rSGFuZGxlID0gbV9jb3JlTG9hZGVyLT5kb2N1bWVudExvYWRlcigpLT5xdWlja0xv b2tIYW5kbGUoKSkgewpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9OZXR3 b3JrL1dlYlJlc291cmNlTG9hZGVyLmggYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdv cmsvV2ViUmVzb3VyY2VMb2FkZXIuaAppbmRleCBkZWFlM2Q0YzYzNGE2NDU0MGQzMDczNTM2N2Ji NTg3NWYwYmU0YTc2Li5mODZkMDM5NWRiMjIwOGZmNWQxYjViYzhmMDkzMTUxYjYzZDk5MWFhIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3VyY2VM b2FkZXIuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL05ldHdvcmsvV2ViUmVzb3Vy Y2VMb2FkZXIuaApAQCAtODUsNiArODUsNyBAQCBwcml2YXRlOgogI2VuZGlmCiAKICAgICBSZWZQ dHI8V2ViQ29yZTo6UmVzb3VyY2VMb2FkZXI+IG1fY29yZUxvYWRlcjsKKyAgICBib29sIG1faGFz UmVjZWl2ZWREYXRhIHsgZmFsc2UgfTsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdAo=