162231 2016-09-19 13:51:31 -0700 Web Inspector: [Meta] Visualize code hotness using execution duration data from Timelines 2016-12-16 11:20:28 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All ASSIGNED InRadar P2 Normal --- 163344 1 nvasilyev nvasilyev bburg inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1231300 0 nvasilyev 2016-09-19 13:51:31 -0700 This is similar to "Bug 146115: Web Inspector: [Meta] Visualize code hotness using basic block execution counts", with exception of code being highlighted based a basic block execution *duration*. 1231303 1 webkit-bug-importer 2016-09-19 13:51:56 -0700 <rdar://problem/28370977> 1234144 2 290027 nvasilyev 2016-09-27 17:05:46 -0700 Created attachment 290027 WIP This is a very early stage WIP. All method names are likely to change. I'm trying to gauge how useful a heatmap visualization is (say, as opposed to "perf gutter" in Chrome DevTools). How to see the heatmap: 1. Record a Timeline. 2. Open a JS resource (that has function calls captured in the timeline recording). Once timeline is recorded, there's currently no way to hide the heatmap. I'll add a button before to the resource toolbar (before the [T] icon) to hide the heatmap. 1260662 3 bburg 2016-12-16 11:20:28 -0800 <rdar://problem/12869714> 290027 2016-09-27 17:05:46 -0700 2016-09-27 17:05:46 -0700 WIP WIP.txt text/plain 5377 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9D YWxsaW5nQ29udGV4dFRyZWVOb2RlLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0NhbGxpbmdDb250ZXh0VHJlZU5vZGUuanMKaW5kZXggZGI4MTY1Ni4uZmYw NWZmNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9k ZWxzL0NhbGxpbmdDb250ZXh0VHJlZU5vZGUuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvTW9kZWxzL0NhbGxpbmdDb250ZXh0VHJlZU5vZGUuanMKQEAgLTYzLDYg KzYzLDE2IEBAIFdlYkluc3BlY3Rvci5DYWxsaW5nQ29udGV4dFRyZWVOb2RlID0gY2xhc3MgQ2Fs bGluZ0NvbnRleHRUcmVlTm9kZSBleHRlbmRzIFdlYkluCiAgICAgZ2V0IHVybCgpIHsgcmV0dXJu IHRoaXMuX3VybDsgfQogICAgIGdldCBoYXNoKCkgeyByZXR1cm4gdGhpcy5faGFzaDsgfQogCisg ICAgZ2V0IHRvdGFsRHVyYXRpb24oKQorICAgIHsKKyAgICAgICAgbGV0IHRvdGFsID0gMDsKKyAg ICAgICAgbGV0IGkgPSB0aGlzLl9kdXJhdGlvbnMubGVuZ3RoOworICAgICAgICB3aGlsZSAoaS0t KQorICAgICAgICAgICAgdG90YWwgKz0gdGhpcy5fZHVyYXRpb25zW2ldOworCisgICAgICAgIHJl dHVybiB0b3RhbDsKKyAgICB9CisKICAgICBoYXNDaGlsZHJlbkluVGltZVJhbmdlKHN0YXJ0VGlt ZSwgZW5kVGltZSkKICAgICB7CiAgICAgICAgIGZvciAobGV0IHByb3BlcnR5TmFtZSBvZiBPYmpl Y3QuZ2V0T3duUHJvcGVydHlOYW1lcyh0aGlzLl9jaGlsZHJlbikpIHsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01vZGVscy9TY3JpcHRTeW50YXhUcmVl LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFN5 bnRheFRyZWUuanMKaW5kZXggZTI2NmE2OC4uYjQ1YzQ5ZCAxMDA2NDQKLS0tIGEvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFN5bnRheFRyZWUuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxzL1NjcmlwdFN5bnRh eFRyZWUuanMKQEAgLTUxLDYgKzUxLDIxIEBAIFdlYkluc3BlY3Rvci5TY3JpcHRTeW50YXhUcmVl ID0gY2xhc3MgU2NyaXB0U3ludGF4VHJlZSBleHRlbmRzIFdlYkluc3BlY3Rvci5PYmplCiAgICAg ICAgIHJldHVybiB0aGlzLl9wYXJzZWRTdWNjZXNzZnVsbHk7CiAgICAgfQogCisgICAgZmluZFRv a2VuQXRPZmZzZXQob2Zmc2V0KQorICAgIHsKKyAgICAgICAgbGV0IGJvZHkgPSB0aGlzLl9zeW50 YXhUcmVlLmJvZHk7CisgICAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgYm9keS5sZW5ndGg7IGkr KykgeworICAgICAgICAgICAgbGV0IHRva2VuID0gYm9keVtpXTsKKyAgICAgICAgICAgIGxldCBy YW5nZSA9IHRva2VuLnJhbmdlOworICAgICAgICAgICAgaWYgKG9mZnNldCA8IHJhbmdlWzBdIHx8 IG9mZnNldCA+IHJhbmdlWzFdKQorICAgICAgICAgICAgICAgIGNvbnRpbnVlOworCisgICAgICAg ICAgICByZXR1cm4gdG9rZW47CisgICAgICAgIH0KKyAgICAgICAgY29uc29sZS5lcnJvcigiQ291 bGQgbm90IGZpbmQgYSB0b2tlbiBmb3Igb2Zmc2V0ICVpIiwgb2Zmc2V0KTsKKyAgICAgICAgcmV0 dXJuIG51bGw7CisgICAgfQorCiAgICAgZm9yRWFjaE5vZGUoY2FsbGJhY2spCiAgICAgewogICAg ICAgICBjb25zb2xlLmFzc2VydCh0aGlzLl9wYXJzZWRTdWNjZXNzZnVsbHkpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRl eHRFZGl0b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9T b3VyY2VDb2RlVGV4dEVkaXRvci5qcwppbmRleCA4NTU3Mjc1Li4wODE2OTIyIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Tb3VyY2VDb2RlVGV4 dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9Tb3VyY2VDb2RlVGV4dEVkaXRvci5qcwpAQCAtMTE3LDYgKzExNyw2MiBAQCBXZWJJbnNwZWN0 b3IuU291cmNlQ29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2RlVGV4dEVkaXRvciBleHRl bmRzIFdlYkluc3BlYwogICAgICAgICB9IGVsc2UgewogICAgICAgICAgICAgdGhpcy5fYmFzaWNC bG9ja0Fubm90YXRvckVuYWJsZWQgPSBmYWxzZTsKICAgICAgICAgfQorCisgICAgICAgIGlmIChX ZWJJbnNwZWN0b3IudGltZWxpbmVNYW5hZ2VyICYmIFdlYkluc3BlY3Rvci50aW1lbGluZU1hbmFn ZXIuYWN0aXZlUmVjb3JkaW5nKSB7CisgICAgICAgICAgICAvLyBGSVhNRTogQ3JlYXRlIGEgY2xh c3Mgc2ltaWxhciB0byBCYXNpY0Jsb2NrQW5ub3RhdG9yLgorICAgICAgICAgICAgbGV0IHNjcmlw dCA9IHRoaXMuX2dldEFzc29jaWF0ZWRTY3JpcHQoKTsKKworICAgICAgICAgICAgaWYgKCFzY3Jp cHQpCisgICAgICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgICAgICBzY3JpcHQucmVxdWVz dFNjcmlwdFN5bnRheFRyZWUoKGFzdCkgPT4geworICAgICAgICAgICAgICAgIC8vIEZJWE1FOiBP bmx5IGhpZ2hsaWdodCByYW5nZXMgdGhhdCBhcmUgaW4gdGhlIHZpZXdwb3J0LgorCisgICAgICAg ICAgICAgICAgbGV0IG5vZGVzID0gW107CisKKyAgICAgICAgICAgICAgICBXZWJJbnNwZWN0b3Iu dGltZWxpbmVNYW5hZ2VyLmFjdGl2ZVJlY29yZGluZy5ib3R0b21VcENhbGxpbmdDb250ZXh0VHJl ZS5mb3JFYWNoTm9kZSgobm9kZSkgPT4geworICAgICAgICAgICAgICAgICAgICBpZiAobm9kZS51 cmwgIT09IHRoaXMuc291cmNlQ29kZS51cmwpCisgICAgICAgICAgICAgICAgICAgICAgICByZXR1 cm47CisKKyAgICAgICAgICAgICAgICAgICAgbGV0IG9mZnNldCA9IHRoaXMuY3VycmVudFBvc2l0 aW9uVG9DdXJyZW50T2Zmc2V0KHtsaW5lOiBub2RlLmxpbmUsIGNoOiBub2RlLmNvbHVtbn0pOwor ICAgICAgICAgICAgICAgICAgICBsZXQgdG9rZW4gPSBhc3QuZmluZFRva2VuQXRPZmZzZXQob2Zm c2V0KTsKKworICAgICAgICAgICAgICAgICAgICBpZiAodG9rZW4pIHsKKyAgICAgICAgICAgICAg ICAgICAgICAgIC8vIEZJWE1FOiBDdXJyZW50bHksIG9ubHkgZnVuY3Rpb24gc2NvcGUgcmFuZ2Vz IGFyZSBpbmNsdWRlZC4gVXNlIF9leHByZXNzaW9uTG9jYXRpb25zLCB0b28uCisgICAgICAgICAg ICAgICAgICAgICAgICBsZXQgc3RhcnRQb3NpdGlvbiA9IHRoaXMuY3VycmVudE9mZnNldFRvQ3Vy cmVudFBvc2l0aW9uKHRva2VuLnJhbmdlWzBdKTsKKyAgICAgICAgICAgICAgICAgICAgICAgIGxl dCBlbmRQb3NpdGlvbiA9IHRoaXMuY3VycmVudE9mZnNldFRvQ3VycmVudFBvc2l0aW9uKHRva2Vu LnJhbmdlWzFdKTsKKworICAgICAgICAgICAgICAgICAgICAgICAgLy8gVGhlcmUgaXMgY3VycmVu dGx5IG5vIGluZGljYXRpb24gb2YgaG93IG1hbnkgc2FtcGxlcyB3ZXJlIHRha2VuLgorICAgICAg ICAgICAgICAgICAgICAgICAgLy8gRm9yIGluc3RhbmNlLCB0ZW4gMC4xcyBzYW1wbGVzIGxvb2sg ZXhhY3RseSB0aGUgc2FtZSBhcyBvbmUgMXMgc2FtcGxlLgorICAgICAgICAgICAgICAgICAgICAg ICAgbGV0IHRvdGFsRHVyYXRpb24gPSBub2RlLnRvdGFsRHVyYXRpb247CisKKyAgICAgICAgICAg ICAgICAgICAgICAgIC8vIEZJWE1FOiBIaWdobGlnaHQgY29sb3Igc2hvdWxkIGJlIHJlbGF0aXZl IHRvIHRoZSBzbG93ZXN0IGV4cHJlc3Npb24gaW4gdGhlIHNlbGVjdGVkIHJlc291cmNlIGFuZCBu b3QgdGhpcyBtYWdpYyBudW1iZXIuCisgICAgICAgICAgICAgICAgICAgICAgICAvLyAtIEdldCBm bGF0IGxpc3Qgb2Ygbm9kZXMgZm9yIHNlbGVjdGVkIHJlc291cmNlLgorICAgICAgICAgICAgICAg ICAgICAgICAgLy8gLSBGaW5kIHNsb3dlc3QuCisgICAgICAgICAgICAgICAgICAgICAgICAvLyAt IE1ha2UgZ3JhZGllbnQgcmVsYXRpdmUgdG8gdGhlIHNsb3dlc3QuCisgICAgICAgICAgICAgICAg ICAgICAgICBjb25zdCBzbG93ZXN0RXhwcmVzc2lvbiA9IDEwMDsKKworICAgICAgICAgICAgICAg ICAgICAgICAgLy8gRklYTUU6IEV4cGVyaW1lbnQgd2l0aCB1c2luZyBhIGxvZ2FyaXRobWljIGZ1 bmN0aW9uLgorICAgICAgICAgICAgICAgICAgICAgICAgbGV0IGNzc0NvbG9yVmFsdWUgPSB0aGlz Ll9oaWdobGlnaHRDb2xvcihNYXRoLm1pbih0b3RhbER1cmF0aW9uLCBzbG93ZXN0RXhwcmVzc2lv bikgLyBzbG93ZXN0RXhwcmVzc2lvbik7CisKKyAgICAgICAgICAgICAgICAgICAgICAgIHRoaXMu X2NvZGVNaXJyb3IuZ2V0RG9jKCkubWFya1RleHQoc3RhcnRQb3NpdGlvbiwgZW5kUG9zaXRpb24s IHtjc3M6ICJiYWNrZ3JvdW5kOiAiICsgY3NzQ29sb3JWYWx1ZSwgaW5jbHVzaXZlTGVmdDogdHJ1 ZSwgaW5jbHVzaXZlUmlnaHQ6IHRydWV9KQorCisgICAgICAgICAgICAgICAgICAgIH0KKworICAg ICAgICAgICAgICAgICAgICBub2Rlcy5wdXNoKG5vZGUpOworICAgICAgICAgICAgICAgIH0pOwor CisgICAgICAgICAgICAgICAgY29uc29sZS5pbmZvKCJOb2RlcyIsIG5vZGVzKTsKKyAgICAgICAg ICAgIH0pOworICAgICAgICB9CisgICAgfQorCisgICAgX2hpZ2hsaWdodENvbG9yKHZhbHVlKQor ICAgIHsKKyAgICAgICAgLy8gRklYTUU6IFVzZSBMY2ggY29sb3Igc2NoZW1lIHRvIGdlbmVyYXRl IG1vcmUgaHVtYW4gZnJpZW5kbHkgZ3JhZGllbnRzLgorICAgICAgICBsZXQgaHVlID0gNTQgLSA0 OCAqIHZhbHVlOworICAgICAgICBsZXQgbGlnaHRuZXNzID0gOTUgLSAyMCAqIHZhbHVlOworICAg ICAgICByZXR1cm4gYGhzbCgke2h1ZX0sIDEwMCUsICR7bGlnaHRuZXNzfSUpYDsKICAgICB9CiAK ICAgICBoaWRkZW4oKQpAQCAtMTgxMiw2ICsxODY4LDExIEBAIFdlYkluc3BlY3Rvci5Tb3VyY2VD b2RlVGV4dEVkaXRvciA9IGNsYXNzIFNvdXJjZUNvZGVUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5z cGVjCiAgICAgICAgIHRoaXMuX2Jhc2ljQmxvY2tBbm5vdGF0b3IgPSBuZXcgV2ViSW5zcGVjdG9y LkJhc2ljQmxvY2tBbm5vdGF0b3IodGhpcywgc2NyaXB0KTsKICAgICB9CiAKKyAgICBfY3JlYXRl Q29kZUhvdG5lc3NBbm5vdGF0b3IoKQorICAgIHsKKyAgICAgICAgLy8gRklYTUUKKyAgICB9CisK ICAgICBfZW5hYmxlU2Nyb2xsRXZlbnRzRm9yVHlwZVRva2VuQW5ub3RhdG9yKCkKICAgICB7CiAg ICAgICAgIC8vIFBhdXNlIHVwZGF0aW5nIHR5cGUgdG9rZW5zIHdoaWxlIHNjcm9sbGluZyB0byBw cmV2ZW50IGZyYW1lIGxvc3MuCg==