162180 2016-09-19 11:05:42 -0700 REGRESSION (r205275): LOG_WITH_STREAM() macros are all compiled in release builds now 2016-09-19 15:01:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 krollin krollin commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1231174 0 krollin 2016-09-19 11:05:42 -0700 After https://trac.webkit.org/changeset/205275, all LOG_WITH_STREAM macros are now enabled in release builds, because LogMacros.h has: #if LOG_DISABLED && RELEASE_LOG_DISABLED ... #else #define LOG_WITH_STREAM(.....) #endif LOG() is OK, so we should make them match. <rdar://problem/28347599> 1231211 1 krollin 2016-09-19 11:45:04 -0700 Disable those macros in RELEASE_LOG_DISABLED mode. With that disabled, there were a couple of downstream effects. First, GraphicsContextCG.cpp would no longer access a local variable in release mode, so that variable needed to be conditionally defined. Second, the inclusion of logFunctionResult also needed to be fiddled with. 1231290 2 289253 krollin 2016-09-19 13:44:49 -0700 Created attachment 289253 Patch 1231342 3 289253 commit-queue 2016-09-19 15:01:41 -0700 Comment on attachment 289253 Patch Clearing flags on attachment: 289253 Committed r206120: <http://trac.webkit.org/changeset/206120> 1231343 4 commit-queue 2016-09-19 15:01:45 -0700 All reviewed patches have been landed. Closing bug. 289253 2016-09-19 13:44:49 -0700 2016-09-19 15:01:41 -0700 Patch bug-162180-20160919134204.patch text/plain 3546 krollin U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNjliMGQ1N2RlOWI4MGJm ZmYyMzhjMzkxZmE0NTk0OTk4NGQzYTI0MC4uNDIyZDdlNTlmODU0ZjNhOGM2OTNjZTRlY2M1YTQx YWUwNTY4NTIzNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDE2LTA5LTE5ICBLZWl0 aCBSb2xsaW4gIDxrcm9sbGluQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjA1 Mjc1KTogTE9HX1dJVEhfU1RSRUFNKCkgbWFjcm9zIGFyZSBhbGwgY29tcGlsZWQgaW4gcmVsZWFz ZSBidWlsZHMgbm93CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNjIxODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBEaXNhYmxlIExPR19XSVRIX1NUUkVBTSBpbiByZWxlYXNlIG1vZGUuIEFsb25nIHdpdGgg dGhpcywgcmVtb3ZlIGEKKyAgICAgICAgbG9jYWwgdmFyaWFibGUgaW4gR3JhcGhjc0NvbnRleHRD Ry5jcHAgaW4gcmVsZWFzZSBtb2RlIHRoYXQncyBubworICAgICAgICBsb25nZXIgcmVmZXJlbmNl ZC4gQW5kIGFkanVzdCBsb2dGdW5jdGlvblJlc3VsdCBzbyB0aGF0IGl0IGdldHMKKyAgICAgICAg ZGVmaW5lZCBvbmx5IGluIGRlYnVnIG1vZGUsIHRvbywgdG8gbWF0Y2ggaXRzIGRlY2xhcmF0aW9u IGluCisgICAgICAgIExvZ01hY3Jvcy5oLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cyAtLSB0aGVy ZSBhcmUgbm8gdGVzdHMgZm9yIGxvZ2dpbmcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2dNYWNy b3MuaDoKKyAgICAgICAgKiBwbGF0Zm9ybS9Mb2dnaW5nLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9jZy9HcmFwaGljc0NvbnRleHRDRy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpH cmFwaGljc0NvbnRleHQ6OmRyYXdOYXRpdmVJbWFnZSk6CisKIDIwMTYtMDktMTkgIE5hbiBXYW5n ICA8bl93YW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBBWDogQWRkIGFjY2Vzc2liaWxpdHkgc3Vw cG9ydCBmb3IgZGV0YWlscyBlbGVtZW50IG9uIGlPUwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vTG9nTWFjcm9zLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9Mb2dNYWNy b3MuaAppbmRleCA0NWZjMGIwYWFmMzNmMjNlYjZiNWYxMmMwOWNlN2IxNzUwY2I3OTgwLi45Zjdl ZmM5OTRiNmE4ODcwMjAxNjhmOGU3MDM4ZTI1ZjQzZDdlZTM3IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9Mb2dNYWNyb3MuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9Mb2dNYWNyb3MuaApAQCAtMjcsNyArMjcsNyBAQAogCiAjaW5jbHVkZSA8ZnVuY3Rpb25hbD4K IAotI2lmIExPR19ESVNBQkxFRCAmJiBSRUxFQVNFX0xPR19ESVNBQkxFRAorI2lmIExPR19ESVNB QkxFRAogCiAjZGVmaW5lIExPR19SRVNVTFQoY2hhbm5lbCwgZnVuY3Rpb24pICgodm9pZCkwKQog I2RlZmluZSBMT0dfV0lUSF9TVFJFQU0oY2hhbm5lbCwgY29tbWFuZHMpICgodm9pZCkwKQpAQCAt NDcsNCArNDcsNCBAQCBXRUJDT1JFX0VYUE9SVCB2b2lkIGxvZ0Z1bmN0aW9uUmVzdWx0KFdURkxv Z0NoYW5uZWwqLCBzdGQ6OmZ1bmN0aW9uPGNvbnN0IGNoYXIqKAogICAgICAgICByZXR1cm4gc3Ry ZWFtLnJlbGVhc2UoKS51dGY4KCkuZGF0YSgpOyBcCiAgICAgfSk7CiAKLSNlbmRpZiAvLyAhTE9H X0RJU0FCTEVEIHx8ICFSRUxFQVNFX0xPR19ESVNBQkxFRAorI2VuZGlmIC8vICFMT0dfRElTQUJM RUQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL0xvZ2dpbmcuY3BwIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAKaW5kZXggZmU0Y2M4NWVlNzkwYTY1Yjhh ZmZlZmJjN2IxMTA5YzA5YWQ5OWFiNC4uOWVlOTRmMWJkYjFkMzY1MzU2MGUzMDk1NGFjZGMxODll NjVlYzFiOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vTG9nZ2luZy5jcHAKQEAgLTM1LDEwICszNSwx MCBAQAogI2luY2x1ZGUgPG5vdGlmeS5oPgogI2VuZGlmCiAKLSNpZiAhTE9HX0RJU0FCTEVEIHx8 ICFSRUxFQVNFX0xPR19ESVNBQkxFRAotCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKKyNpZiAhTE9H X0RJU0FCTEVEIHx8ICFSRUxFQVNFX0xPR19ESVNBQkxFRAorCiAjZGVmaW5lIERFRklORV9XRUJD T1JFX0xPR19DSEFOTkVMKG5hbWUpIERFRklORV9MT0dfQ0hBTk5FTChuYW1lLCBMT0dfQ0hBTk5F TF9XRUJLSVRfU1VCU1lTVEVNKQogV0VCQ09SRV9MT0dfQ0hBTk5FTFMoREVGSU5FX1dFQkNPUkVf TE9HX0NIQU5ORUwpCiAKQEAgLTkzLDExICs5MywxNCBAQCB2b2lkIHJlZ2lzdGVyTm90aWZ5Q2Fs bGJhY2soY29uc3QgU3RyaW5nJiBub3RpZnlJRCwgc3RkOjpmdW5jdGlvbjx2b2lkKCk+IGNhbGxi YQogfQogI2VuZGlmCiAKKyNlbmRpZiAvLyAhTE9HX0RJU0FCTEVEIHx8ICFSRUxFQVNFX0xPR19E SVNBQkxFRAorCisjaWYgIUxPR19ESVNBQkxFRAogdm9pZCBsb2dGdW5jdGlvblJlc3VsdChXVEZM b2dDaGFubmVsKiBjaGFubmVsLCBzdGQ6OmZ1bmN0aW9uPGNvbnN0IGNoYXIqKCk+IGZ1bmN0aW9u KQogewogICAgIFdURkxvZyhjaGFubmVsLCAiJXMiLCBmdW5jdGlvbigpKTsKIH0KIAotfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQorI2VuZGlmIC8vICFMT0dfRElTQUJMRUQKIAotI2VuZGlmIC8vICFM T0dfRElTQUJMRUQgfHwgIVJFTEVBU0VfTE9HX0RJU0FCTEVECit9IC8vIG5hbWVzcGFjZSBXZWJD b3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9HcmFw aGljc0NvbnRleHRDRy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jZy9H cmFwaGljc0NvbnRleHRDRy5jcHAKaW5kZXggNGY0ZTZiM2IyMjY2NzMzNTk1MGZjYjUxNGM1Y2Fj YmQwM2UwZTFiZS4uY2M3NDM2NWYzM2VjZjc0ZTMwZmM3OGZmMTY3MDQwMDQ5NzE2NzViOCAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2cvR3JhcGhpY3NDb250 ZXh0Q0cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NnL0dyYXBo aWNzQ29udGV4dENHLmNwcApAQCAtMTc1LDcgKzE3NSw3IEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0 OjpkcmF3TmF0aXZlSW1hZ2UoY29uc3QgUmV0YWluUHRyPENHSW1hZ2VSZWY+JiBpbWFnZSwgY29u c3QKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotI2lmICFMT0dfRElTQUJMRUQgfHwgIVJFTEVB U0VfTE9HX0RJU0FCTEVECisjaWYgIUxPR19ESVNBQkxFRAogICAgIGRvdWJsZSBzdGFydFRpbWUg PSBjdXJyZW50VGltZSgpOwogI2VuZGlmCiAgICAgUmV0YWluUHRyPENHSW1hZ2VSZWY+IHN1Yklt YWdlKGltYWdlKTsK