162165 2016-09-19 10:08:46 -0700 Web Inspector: Make it easier to create a view from an existing DOM element 2016-09-19 11:49:52 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1231135 0 mattbaker 2016-09-19 10:08:46 -0700 Instead of the optional `element` parameter, the View constructor should take an `elementOrIdentifier` which can be an HTMLElement or id attribute value. 1231136 1 webkit-bug-importer 2016-09-19 10:09:09 -0700 <rdar://problem/28365848> 1231143 2 289236 mattbaker 2016-09-19 10:24:00 -0700 Created attachment 289236 Patch 1231154 3 289236 commit-queue 2016-09-19 10:55:49 -0700 Comment on attachment 289236 Patch Clearing flags on attachment: 289236 Committed r206101: <http://trac.webkit.org/changeset/206101> 1231155 4 commit-queue 2016-09-19 10:55:52 -0700 All reviewed patches have been landed. Closing bug. 1231201 5 289236 joepeck 2016-09-19 11:35:55 -0700 Comment on attachment 289236 Patch This doesn't feel like an improvement to me. Previously we were guaranteed a single type element || null. Now it can be two different types with even less clarity at the call site. Was there a particular driver for this change? 1231207 6 mattbaker 2016-09-19 11:42:13 -0700 (In reply to comment #5) > Comment on attachment 289236 [details] > Patch > > This doesn't feel like an improvement to me. Previously we were guaranteed a > single type element || null. Now it can be two different types with even > less clarity at the call site. Was there a particular driver for this change? It was done as a drive-by simplification why working on another patch. The parameter overloading idiom is used elsewhere, but I'm fine with rolling back if you think its less clear. 1231220 7 joepeck 2016-09-19 11:49:52 -0700 (In reply to comment #6) > (In reply to comment #5) > > Comment on attachment 289236 [details] > > Patch > > > > This doesn't feel like an improvement to me. Previously we were guaranteed a > > single type element || null. Now it can be two different types with even > > less clarity at the call site. Was there a particular driver for this change? > > It was done as a drive-by simplification why working on another patch. The > parameter overloading idiom is used elsewhere, but I'm fine with rolling > back if you think its less clear. Yeah, I don't see this as a simplification. We should optimize for making the call site as clear as possible. And this makes it more difficult to read. Specifically, I see this and go "is that an identifier, or a class name?". 289236 2016-09-19 10:24:00 -0700 2016-09-19 10:55:49 -0700 Patch bug-162165-20160919102115.patch text/plain 6659 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjA2MDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA0 OGFmZWJlODRiN2E1ZTRlMTc1MDQ3MTJkNjM3YzJlNTFiOTMzNWJhLi5hNTA1YTRjM2UzNDg1YWJi NWFmYTAwZDJkMTg0Y2FmN2IwZTU5OGU3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxNi0wOS0xOSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogTWFrZSBpdCBlYXNpZXIgdG8gY3JlYXRlIGEgdmll dyBmcm9tIGFuIGV4aXN0aW5nIERPTSBlbGVtZW50CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIxNjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzI4 MzY1ODQ4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg ICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuY29u dGVudExvYWRlZCk6CisgICAgICAgIFBhc3MgaWQgc3RyaW5nIGZvciB2aWV3cyBjcmVhdGVkIGZy b20gZXhpc3RpbmcgRE9NIGVsZW1lbnRzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9WaWV3LmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlZpZXcpOgorICAgICAgICBDaGFuZ2Ug YGVsZW1lbnRgIHRvIGBlbGVtZW50T3JJZGVudGlmaWVyYC4gSWYgdGhlIHZhbHVlIGlzIGEgc3Ry aW5nLAorICAgICAgICB0cmVhdCBpdCBhcyBhbiBlbGVtZW50IGlkZW50aWZpZXIuIElmIHRoZSBp ZGVudGlmaWVyIGlzIGludmFsaWQsIGNyZWF0ZQorICAgICAgICBhIGRlZmF1bHQgZWxlbWVudC4K KwogMjAxNi0wOS0xOSAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IENvbG9yIHBpY2tlciBpbiBTdHlsZSBzaWRlYmFyIHN0b3Bz IHdvcmtpbmcgYWZ0ZXIgMXN0IGNvbG9yIGNoYW5nZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCmluZGV4IGVjMWFlODgzODA1ODhiODI5NmY2 OTU5ZjBjYmY4N2QzMmNmZjAzYWQuLjUzZjk0MWFiMjQ0ZGIxZjU4M2QwM2Y3OGM2OGU2ZmIxODYw YTBmN2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jh c2UvTWFpbi5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNl L01haW4uanMKQEAgLTIyNywxMSArMjI3LDExIEBAIFdlYkluc3BlY3Rvci5jb250ZW50TG9hZGVk ID0gZnVuY3Rpb24oKQogICAgIGRvY3VtZW50LmJvZHkuY2xhc3NMaXN0LmFkZCh0aGlzLmRlYnVn Z2FibGVUeXBlKTsKIAogICAgIC8vIENyZWF0ZSB0aGUgdXNlciBpbnRlcmZhY2UgZWxlbWVudHMu Ci0gICAgdGhpcy50b29sYmFyID0gbmV3IFdlYkluc3BlY3Rvci5Ub29sYmFyKGRvY3VtZW50Lmdl dEVsZW1lbnRCeUlkKCJ0b29sYmFyIiksIG51bGwsIHRydWUpOworICAgIHRoaXMudG9vbGJhciA9 IG5ldyBXZWJJbnNwZWN0b3IuVG9vbGJhcigidG9vbGJhciIsIG51bGwsIHRydWUpOwogICAgIHRo aXMudG9vbGJhci5kaXNwbGF5TW9kZSA9IFdlYkluc3BlY3Rvci5Ub29sYmFyLkRpc3BsYXlNb2Rl Lkljb25Pbmx5OwogICAgIHRoaXMudG9vbGJhci5zaXplTW9kZSA9IFdlYkluc3BlY3Rvci5Ub29s YmFyLlNpemVNb2RlLlNtYWxsOwogCi0gICAgdGhpcy50YWJCYXIgPSBuZXcgV2ViSW5zcGVjdG9y LlRhYkJhcihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGFiLWJhciIpKTsKKyAgICB0aGlzLnRh YkJhciA9IG5ldyBXZWJJbnNwZWN0b3IuVGFiQmFyKCJ0YWItYmFyIik7CiAgICAgdGhpcy50YWJC YXIuYWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGFiQmFyLkV2ZW50Lk5ld1RhYkl0ZW1D bGlja2VkLCB0aGlzLl9uZXdUYWJJdGVtQ2xpY2tlZCwgdGhpcyk7CiAgICAgdGhpcy50YWJCYXIu YWRkRXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGFiQmFyLkV2ZW50Lk9wZW5EZWZhdWx0VGFi LCB0aGlzLl9vcGVuRGVmYXVsdFRhYiwgdGhpcyk7CiAKQEAgLTIzOSwxMCArMjM5LDEwIEBAIFdl Ykluc3BlY3Rvci5jb250ZW50TG9hZGVkID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX2NvbnRlbnRF bGVtZW50LnNldEF0dHJpYnV0ZSgicm9sZSIsICJtYWluIik7CiAgICAgdGhpcy5fY29udGVudEVs ZW1lbnQuc2V0QXR0cmlidXRlKCJhcmlhLWxhYmVsIiwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJD b250ZW50IikpOwogCi0gICAgdGhpcy5zcGxpdENvbnRlbnRCcm93c2VyID0gbmV3IFdlYkluc3Bl Y3Rvci5Db250ZW50QnJvd3Nlcihkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgic3BsaXQtY29udGVu dC1icm93c2VyIiksIHRoaXMsIHRydWUsIHRydWUpOworICAgIHRoaXMuc3BsaXRDb250ZW50QnJv d3NlciA9IG5ldyBXZWJJbnNwZWN0b3IuQ29udGVudEJyb3dzZXIoInNwbGl0LWNvbnRlbnQtYnJv d3NlciIsIHRoaXMsIHRydWUsIHRydWUpOwogICAgIHRoaXMuc3BsaXRDb250ZW50QnJvd3Nlci5u YXZpZ2F0aW9uQmFyLmVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigibW91c2Vkb3duIiwgdGhpcy5f Y29uc29sZVJlc2l6ZXJNb3VzZURvd24uYmluZCh0aGlzKSk7CiAKLSAgICB0aGlzLnF1aWNrQ29u c29sZSA9IG5ldyBXZWJJbnNwZWN0b3IuUXVpY2tDb25zb2xlKGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJxdWljay1jb25zb2xlIikpOworICAgIHRoaXMucXVpY2tDb25zb2xlID0gbmV3IFdlYklu c3BlY3Rvci5RdWlja0NvbnNvbGUoInF1aWNrLWNvbnNvbGUiKTsKICAgICB0aGlzLnF1aWNrQ29u c29sZS5hZGRFdmVudExpc3RlbmVyKFdlYkluc3BlY3Rvci5RdWlja0NvbnNvbGUuRXZlbnQuRGlk UmVzaXplLCB0aGlzLl9xdWlja0NvbnNvbGVEaWRSZXNpemUsIHRoaXMpOwogCiAgICAgdGhpcy5f Y29uc29sZVJlcHJlc2VudGVkT2JqZWN0ID0gbmV3IFdlYkluc3BlY3Rvci5Mb2dPYmplY3Q7CkBA IC0yNTIsMTAgKzI1MiwxMCBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCA9IGZ1bmN0aW9u KCkKICAgICB0aGlzLmJyZWFrcG9pbnRQb3BvdmVyQ29udHJvbGxlciA9IG5ldyBXZWJJbnNwZWN0 b3IuQnJlYWtwb2ludFBvcG92ZXJDb250cm9sbGVyOwogCiAgICAgLy8gRklYTUU6IFRoZSBzaWRl YmFycyBzaG91bGQgYmUgZmxpcHBlZCBpbiBSVEwgbGFuZ3VhZ2VzLgotICAgIHRoaXMubmF2aWdh dGlvblNpZGViYXIgPSBuZXcgV2ViSW5zcGVjdG9yLlNpZGViYXIoZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoIm5hdmlnYXRpb24tc2lkZWJhciIpLCBXZWJJbnNwZWN0b3IuU2lkZWJhci5TaWRlcy5M ZWZ0KTsKKyAgICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyID0gbmV3IFdlYkluc3BlY3Rvci5TaWRl YmFyKCJuYXZpZ2F0aW9uLXNpZGViYXIiLCBXZWJJbnNwZWN0b3IuU2lkZWJhci5TaWRlcy5MZWZ0 KTsKICAgICB0aGlzLm5hdmlnYXRpb25TaWRlYmFyLmFkZEV2ZW50TGlzdGVuZXIoV2ViSW5zcGVj dG9yLlNpZGViYXIuRXZlbnQuV2lkdGhEaWRDaGFuZ2UsIHRoaXMuX3NpZGViYXJXaWR0aERpZENo YW5nZSwgdGhpcyk7CiAKLSAgICB0aGlzLmRldGFpbHNTaWRlYmFyID0gbmV3IFdlYkluc3BlY3Rv ci5TaWRlYmFyKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJkZXRhaWxzLXNpZGViYXIiKSwgV2Vi SW5zcGVjdG9yLlNpZGViYXIuU2lkZXMuUmlnaHQsIG51bGwsIG51bGwsIFdlYkluc3BlY3Rvci5V SVN0cmluZygiRGV0YWlscyIpLCB0cnVlKTsKKyAgICB0aGlzLmRldGFpbHNTaWRlYmFyID0gbmV3 IFdlYkluc3BlY3Rvci5TaWRlYmFyKCJkZXRhaWxzLXNpZGViYXIiLCBXZWJJbnNwZWN0b3IuU2lk ZWJhci5TaWRlcy5SaWdodCwgbnVsbCwgbnVsbCwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJEZXRh aWxzIiksIHRydWUpOwogICAgIHRoaXMuZGV0YWlsc1NpZGViYXIuYWRkRXZlbnRMaXN0ZW5lcihX ZWJJbnNwZWN0b3IuU2lkZWJhci5FdmVudC5XaWR0aERpZENoYW5nZSwgdGhpcy5fc2lkZWJhcldp ZHRoRGlkQ2hhbmdlLCB0aGlzKTsKIAogICAgIHRoaXMuc2VhcmNoS2V5Ym9hcmRTaG9ydGN1dCA9 IG5ldyBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dChXZWJJbnNwZWN0b3IuS2V5Ym9hcmRT aG9ydGN1dC5Nb2RpZmllci5Db21tYW5kT3JDb250cm9sIHwgV2ViSW5zcGVjdG9yLktleWJvYXJk U2hvcnRjdXQuTW9kaWZpZXIuU2hpZnQsICJGIiwgdGhpcy5fZm9jdXNTZWFyY2hGaWVsZC5iaW5k KHRoaXMpKTsKQEAgLTI3Niw3ICsyNzYsNyBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRlZCA9 IGZ1bmN0aW9uKCkKICAgICB0aGlzLl9zaG93VGFiQXRJbmRleEtleWJvYXJkU2hvcnRjdXRzID0g WzEsIDIsIDMsIDQsIDUsIDYsIDcsIDgsIDldLm1hcCgoaSkgPT4gbmV3IFdlYkluc3BlY3Rvci5L ZXlib2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNv bW1hbmRPckNvbnRyb2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5P cHRpb24sIGAke2l9YCwgdGhpcy5fc2hvd1RhYkF0SW5kZXguYmluZCh0aGlzLCBpKSkpOwogICAg IHRoaXMuX29wZW5OZXdUYWJLZXlib2FyZFNob3J0Y3V0ID0gbmV3IFdlYkluc3BlY3Rvci5LZXli b2FyZFNob3J0Y3V0KFdlYkluc3BlY3Rvci5LZXlib2FyZFNob3J0Y3V0Lk1vZGlmaWVyLkNvbW1h bmRPckNvbnRyb2wgfCBXZWJJbnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5Nb2RpZmllci5PcHRp b24sICJUIiwgdGhpcy5zaG93TmV3VGFiVGFiLmJpbmQodGhpcykpOwogCi0gICAgdGhpcy50YWJC cm93c2VyID0gbmV3IFdlYkluc3BlY3Rvci5UYWJCcm93c2VyKGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCJ0YWItYnJvd3NlciIpLCB0aGlzLnRhYkJhciwgdGhpcy5uYXZpZ2F0aW9uU2lkZWJhciwg dGhpcy5kZXRhaWxzU2lkZWJhcik7CisgICAgdGhpcy50YWJCcm93c2VyID0gbmV3IFdlYkluc3Bl Y3Rvci5UYWJCcm93c2VyKCJ0YWItYnJvd3NlciIsIHRoaXMudGFiQmFyLCB0aGlzLm5hdmlnYXRp b25TaWRlYmFyLCB0aGlzLmRldGFpbHNTaWRlYmFyKTsKICAgICB0aGlzLnRhYkJyb3dzZXIuYWRk RXZlbnRMaXN0ZW5lcihXZWJJbnNwZWN0b3IuVGFiQnJvd3Nlci5FdmVudC5TZWxlY3RlZFRhYkNv bnRlbnRWaWV3RGlkQ2hhbmdlLCB0aGlzLl90YWJCcm93c2VyU2VsZWN0ZWRUYWJDb250ZW50Vmll d0RpZENoYW5nZSwgdGhpcyk7CiAKICAgICB0aGlzLnRhYkJhci5hZGRFdmVudExpc3RlbmVyKFdl Ykluc3BlY3Rvci5UYWJCYXIuRXZlbnQuVGFiQmFySXRlbUFkZGVkLCB0aGlzLl91cGRhdGVOZXdU YWJCdXR0b25TdGF0ZSwgdGhpcyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9WaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvVmlldy5qcwppbmRleCBhY2UwNGI5NmI2NzNiZDI1MjkwZWNkNWZjYWZj MTQ2NmM1ODBjZTFhLi40N2Y5MmU3ZjViZTAyNDhjMTA4M2E1NTllZTdjYzllZTI5MzlhZTVlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9WaWV3 LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1ZpZXcu anMKQEAgLTI1LDExICsyNSwxOCBAQAogCiBXZWJJbnNwZWN0b3IuVmlldyA9IGNsYXNzIFZpZXcg ZXh0ZW5kcyBXZWJJbnNwZWN0b3IuT2JqZWN0CiB7Ci0gICAgY29uc3RydWN0b3IoZWxlbWVudCkK KyAgICBjb25zdHJ1Y3RvcihlbGVtZW50T3JJZGVudGlmaWVyKQogICAgIHsKICAgICAgICAgc3Vw ZXIoKTsKIAotICAgICAgICB0aGlzLl9lbGVtZW50ID0gZWxlbWVudCB8fCBkb2N1bWVudC5jcmVh dGVFbGVtZW50KCJkaXYiKTsKKyAgICAgICAgaWYgKGVsZW1lbnRPcklkZW50aWZpZXIgaW5zdGFu Y2VvZiBIVE1MRWxlbWVudCkKKyAgICAgICAgICAgIHRoaXMuX2VsZW1lbnQgPSBlbGVtZW50T3JJ ZGVudGlmaWVyOworICAgICAgICBlbHNlIGlmICh0eXBlb2YgZWxlbWVudE9ySWRlbnRpZmllciA9 PT0gInN0cmluZyIpIHsKKyAgICAgICAgICAgIHRoaXMuX2VsZW1lbnQgPSBkb2N1bWVudC5nZXRF bGVtZW50QnlJZChlbGVtZW50T3JJZGVudGlmaWVyKTsKKyAgICAgICAgICAgIGNvbnNvbGUuYXNz ZXJ0KHRoaXMuX2VsZW1lbnQsICJDb3VsZG4ndCBjcmVhdGUgdmlldyBmb3IgdW5rbm93biBlbGVt ZW50ICIgKyBlbGVtZW50T3JJZGVudGlmaWVyKTsKKyAgICAgICAgfQorCisgICAgICAgIHRoaXMu X2VsZW1lbnQgPSB0aGlzLl9lbGVtZW50IHx8IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIp OwogICAgICAgICB0aGlzLl9lbGVtZW50Ll9fdmlldyA9IHRoaXM7CiAgICAgICAgIHRoaXMuX3Bh cmVudFZpZXcgPSBudWxsOwogICAgICAgICB0aGlzLl9zdWJ2aWV3cyA9IFtdOwo=