162143 2016-09-19 01:35:45 -0700 [EFL] ewk_context_menu_item_select test have been failed 2016-09-20 19:36:32 -0700 1 1 1 Unclassified WebKit WebKit EFL WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 hs85.jeong hs85.jeong commit-queue gyuyoung.kim lucas.de.marchi oldest_to_newest 1231035 0 hs85.jeong 2016-09-19 01:35:45 -0700 https://build.webkit.org/builders/EFL%20Linux%2064-bit%20Release%20WK2/builds/29782/steps/API%20tests/logs/stdio [----------] 2 tests from EWK2ContextMenuTest [ RUN ] EWK2ContextMenuTest.ewk_context_menu_item_select ERR<17602>:ecore_evas modules/ecore_evas/engines/x/ecore_evas_x.c:4584 ecore_evas_gl_x11_options_new_internal() evas_engine_info_set() init engine 'opengl_x11' failed. ERR<17602>:evas_main lib/evas/canvas/evas_gl.c:151 evas_gl_new() Evas GL engine not available. ../../Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:202: Failure Value of: waitUntilLoadFinished() Actual: false Expected: true [ FAILED ] EWK2ContextMenuTest.ewk_context_menu_item_select (10152 ms) [ RUN ] EWK2ContextMenuTest.ewk_context_menu_custom_items ERR<17602>:ecore_evas modules/ecore_evas/engines/x/ecore_evas_x.c:4584 ecore_evas_gl_x11_options_new_internal() evas_engine_info_set() init engine 'opengl_x11' failed. ERR<17602>:evas_main lib/evas/canvas/evas_gl.c:151 evas_gl_new() Evas GL engine not available. [ OK ] EWK2ContextMenuTest.ewk_context_menu_custom_items (228 ms) [----------] 2 tests from EWK2ContextMenuTest (10380 ms total) [----------] Global test environment tear-down [==========] 2 tests from 1 test case ran. (10380 ms total) [ PASSED ] 1 test. [ FAILED ] 1 test, listed below: [ FAILED ] EWK2ContextMenuTest.ewk_context_menu_item_select 1231479 1 289298 hs85.jeong 2016-09-19 18:57:22 -0700 Created attachment 289298 Patch 1231579 2 289298 gyuyoung.kim 2016-09-20 02:21:10 -0700 Comment on attachment 289298 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=289298&action=review LGTM with my comment. > Source/WebKit2/ChangeLog:9 > + to wait to finish the loading. I change the codes to finish the test when "testFinished" is true. It seems to me that this description is unclear to me. I revise it as below, ewk_context_menu_item_select has been waited until test page loading is finished, but it is unnecessary to wait the loading is finished. It would be good to pass if *testFinished* flag is true. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:200 > + ewkViewClass()->context_menu_hide = finishTest; Nice catch. We have missed to do it. > Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_context_menu.cpp:205 > + testFinished = false; ditto. 1231924 3 289413 hs85.jeong 2016-09-20 17:37:30 -0700 Created attachment 289413 Patch 1231926 4 hs85.jeong 2016-09-20 17:40:16 -0700 (In reply to comment #2) > Comment on attachment 289298 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=289298&action=review > > LGTM with my comment. > > > Source/WebKit2/ChangeLog:9 > > + to wait to finish the loading. I change the codes to finish the test when "testFinished" is true. > > It seems to me that this description is unclear to me. I revise it as below, > > ewk_context_menu_item_select has been waited until test page loading is > finished, but it is unnecessary > to wait the loading is finished. It would be good to pass if *testFinished* > flag is true. Thanks Gyuyoung, I will try to write down a clear description. 1231956 5 289413 commit-queue 2016-09-20 19:36:28 -0700 Comment on attachment 289413 Patch Clearing flags on attachment: 289413 Committed r206194: <http://trac.webkit.org/changeset/206194> 1231957 6 commit-queue 2016-09-20 19:36:32 -0700 All reviewed patches have been landed. Closing bug. 289298 2016-09-19 18:57:22 -0700 2016-09-20 17:37:22 -0700 Patch bug-162143-20160920105435.patch text/plain 2612 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjA4OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE2LTA5LTE5ICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBld2tfY29u dGV4dF9tZW51X2l0ZW1fc2VsZWN0IHRlc3QgaGF2ZSBiZWVuIGZhaWxlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMTQzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ3VycmVudGx5LCBld2tfY29udGV4 dF9tZW51X2l0ZW1fc2VsZWN0IHRlc3Qgd2FpdHMgdW50aWwgbG9hZCBpcyBmaW5pc2hlZCBidXQg d2UgZG9uJ3QgbmVlZAorICAgICAgICB0byB3YWl0IHRvIGZpbmlzaCB0aGUgbG9hZGluZy4gSSBj aGFuZ2UgdGhlIGNvZGVzIHRvIGZpbmlzaCB0aGUgdGVzdCB3aGVuICJ0ZXN0RmluaXNoZWQiIGlz IHRydWUuIAorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2Nv bnRleHRfbWVudS5jcHA6CisgICAgICAgIChFV0syQ29udGV4dE1lbnVUZXN0OjpjaGVja0Jhc2lj Q29udGV4dE1lbnVJdGVtKToKKyAgICAgICAgKEVXSzJDb250ZXh0TWVudVRlc3Q6OnRlc3RDb250 ZXh0TWVudSk6CisgICAgICAgIChURVNUX0YpOgorCiAyMDE2LTA5LTE4ICBNaWNoYWVsIENhdGFu emFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBFbXB0eSByZWZl cmVyIGhlYWRlciBhZnRlciBXZWJLaXQgc2Vzc2lvbiBzdGF0ZSByZXN0b3JhdGlvbiB0cmlwcyBC YWQgQmVoYXZpb3IgV29yZHByZXNzIHBsdWdpbgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2NvbnRleHRfbWVudS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9lZmwvdGVzdHMvdGVzdF9ld2syX2NvbnRl eHRfbWVudS5jcHAJKHJldmlzaW9uIDIwNjA4NSkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb250ZXh0X21lbnUuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC00OSw4ICs0OSw4IEBAIHB1YmxpYzoKICAgICAgICAgRVhQRUNUX0VRKHR5cGUsIGV3a19j b250ZXh0X21lbnVfaXRlbV90eXBlX2dldChpdGVtKSk7CiAgICAgICAgIEVYUEVDVF9FUShhY3Rp b24sIGV3a19jb250ZXh0X21lbnVfaXRlbV9hY3Rpb25fZ2V0KGl0ZW0pKTsKICAgICAgICAgRVhQ RUNUX1NUUkVRKHRpdGxlLCBld2tfY29udGV4dF9tZW51X2l0ZW1fdGl0bGVfZ2V0KGl0ZW0pKTsK LSAgICBFWFBFQ1RfRVEoY2hlY2tlZCwgZXdrX2NvbnRleHRfbWVudV9pdGVtX2NoZWNrZWRfZ2V0 KGl0ZW0pKTsKLSAgICBFWFBFQ1RfRVEoZW5hYmxlZCwgZXdrX2NvbnRleHRfbWVudV9pdGVtX2Vu YWJsZWRfZ2V0KGl0ZW0pKTsKKyAgICAgICAgRVhQRUNUX0VRKGNoZWNrZWQsIGV3a19jb250ZXh0 X21lbnVfaXRlbV9jaGVja2VkX2dldChpdGVtKSk7CisgICAgICAgIEVYUEVDVF9FUShlbmFibGVk LCBld2tfY29udGV4dF9tZW51X2l0ZW1fZW5hYmxlZF9nZXQoaXRlbSkpOwogICAgIH0KIAogICAg IHN0YXRpYyBFaW5hX0Jvb2wgY3VzdG9tSXRlbVNlbGVjdGVkKEV3a19WaWV3X1NtYXJ0X0RhdGEq LCBFd2tfQ29udGV4dF9NZW51X0l0ZW0qIGl0ZW0pCkBAIC05NCw2ICs5NCw4IEBAIHB1YmxpYzoK IAogICAgICAgICBFWFBFQ1RfVFJVRShld2tfY29udGV4dF9tZW51X2l0ZW1fc2VsZWN0KGNvbnRl eHRNZW51LCBpdGVtKSk7CiAKKyAgICAgICAgZXdrX2NvbnRleHRfbWVudV9oaWRlKGNvbnRleHRN ZW51KTsKKwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9CiAKQEAgLTE5NSwxMSArMTk3LDEz IEBAIFRFU1RfRihFV0syQ29udGV4dE1lbnVUZXN0LCBld2tfY29udGV4dF8KICAgICAgICAgIjwv aHRtbD4iOwogCiAgICAgZXdrVmlld0NsYXNzKCktPmNvbnRleHRfbWVudV9zaG93ID0gdGVzdENv bnRleHRNZW51OworICAgIGV3a1ZpZXdDbGFzcygpLT5jb250ZXh0X21lbnVfaGlkZSA9IGZpbmlz aFRlc3Q7CiAKICAgICBld2tfdmlld19odG1sX3N0cmluZ19sb2FkKHdlYlZpZXcoKSwgaXRlbVNl bGVjdEhUTUwsICJmaWxlOi8vLyIsIDApOwogICAgIEFTU0VSVF9UUlVFKHdhaXRVbnRpbExvYWRG aW5pc2hlZCgpKTsKICAgICBzaG93Q29udGV4dE1lbnUoKTsKLSAgICBBU1NFUlRfVFJVRSh3YWl0 VW50aWxMb2FkRmluaXNoZWQoKSk7CisgICAgdGVzdEZpbmlzaGVkID0gZmFsc2U7CisgICAgQVNT RVJUX1RSVUUod2FpdFVudGlsVHJ1ZSh0ZXN0RmluaXNoZWQpKTsKIH0KIAogVEVTVF9GKEVXSzJD b250ZXh0TWVudVRlc3QsIGV3a19jb250ZXh0X21lbnVfY3VzdG9tX2l0ZW1zKQo= 289413 2016-09-20 17:37:30 -0700 2016-09-20 19:36:28 -0700 Patch bug-162143-20160921093442.patch text/plain 2622 hs85.jeong SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjA4OSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE2LTA5LTIwICBIdW5zZW9w IEplb25nICA8aHM4NS5qZW9uZ0BzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBld2tfY29u dGV4dF9tZW51X2l0ZW1fc2VsZWN0IHRlc3QgaGF2ZSBiZWVuIGZhaWxlZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMTQzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgR3l1eW91bmcgS2ltLgorCisgICAgICAgIGV3a19jb250ZXh0X21lbnVfaXRlbV9z ZWxlY3QgaGFzIGJlZW4gd2FpdGVkIHVudGlsIHRlc3QgcGFnZSBsb2FkaW5nIGlzIGZpbmlzaGVk LCBidXQgaXQgaXMKKyAgICAgICAgdW5uZWNlc3NhcnkgdG8gd2FpdCB0aGUgbG9hZGluZyBpcyBm aW5pc2hlZC4gSXQgd291bGQgYmUgZ29vZCB0byBwYXNzIGlmICp0ZXN0RmluaXNoZWQqCisgICAg ICAgIGZsYWcgaXMgdHJ1ZS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rl c3RfZXdrMl9jb250ZXh0X21lbnUuY3BwOgorICAgICAgICAoRVdLMkNvbnRleHRNZW51VGVzdDo6 Y2hlY2tCYXNpY0NvbnRleHRNZW51SXRlbSk6CisgICAgICAgIChFV0syQ29udGV4dE1lbnVUZXN0 Ojp0ZXN0Q29udGV4dE1lbnUpOgorICAgICAgICAoVEVTVF9GKToKKwogMjAxNi0wOS0xOCAgTWlj aGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10g RW1wdHkgcmVmZXJlciBoZWFkZXIgYWZ0ZXIgV2ViS2l0IHNlc3Npb24gc3RhdGUgcmVzdG9yYXRp b24gdHJpcHMgQmFkIEJlaGF2aW9yIFdvcmRwcmVzcyBwbHVnaW4KSW5kZXg6IFNvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3RfZXdrMl9jb250ZXh0X21lbnUuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZWZsL3Rlc3RzL3Rlc3Rf ZXdrMl9jb250ZXh0X21lbnUuY3BwCShyZXZpc2lvbiAyMDYwODUpCisrKyBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvQVBJL2VmbC90ZXN0cy90ZXN0X2V3azJfY29udGV4dF9tZW51LmNwcAkod29y a2luZyBjb3B5KQpAQCAtNDksOCArNDksOCBAQCBwdWJsaWM6CiAgICAgICAgIEVYUEVDVF9FUSh0 eXBlLCBld2tfY29udGV4dF9tZW51X2l0ZW1fdHlwZV9nZXQoaXRlbSkpOwogICAgICAgICBFWFBF Q1RfRVEoYWN0aW9uLCBld2tfY29udGV4dF9tZW51X2l0ZW1fYWN0aW9uX2dldChpdGVtKSk7CiAg ICAgICAgIEVYUEVDVF9TVFJFUSh0aXRsZSwgZXdrX2NvbnRleHRfbWVudV9pdGVtX3RpdGxlX2dl dChpdGVtKSk7Ci0gICAgRVhQRUNUX0VRKGNoZWNrZWQsIGV3a19jb250ZXh0X21lbnVfaXRlbV9j aGVja2VkX2dldChpdGVtKSk7Ci0gICAgRVhQRUNUX0VRKGVuYWJsZWQsIGV3a19jb250ZXh0X21l bnVfaXRlbV9lbmFibGVkX2dldChpdGVtKSk7CisgICAgICAgIEVYUEVDVF9FUShjaGVja2VkLCBl d2tfY29udGV4dF9tZW51X2l0ZW1fY2hlY2tlZF9nZXQoaXRlbSkpOworICAgICAgICBFWFBFQ1Rf RVEoZW5hYmxlZCwgZXdrX2NvbnRleHRfbWVudV9pdGVtX2VuYWJsZWRfZ2V0KGl0ZW0pKTsKICAg ICB9CiAKICAgICBzdGF0aWMgRWluYV9Cb29sIGN1c3RvbUl0ZW1TZWxlY3RlZChFd2tfVmlld19T bWFydF9EYXRhKiwgRXdrX0NvbnRleHRfTWVudV9JdGVtKiBpdGVtKQpAQCAtOTQsNiArOTQsOCBA QCBwdWJsaWM6CiAKICAgICAgICAgRVhQRUNUX1RSVUUoZXdrX2NvbnRleHRfbWVudV9pdGVtX3Nl bGVjdChjb250ZXh0TWVudSwgaXRlbSkpOwogCisgICAgICAgIGV3a19jb250ZXh0X21lbnVfaGlk ZShjb250ZXh0TWVudSk7CisKICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgfQogCkBAIC0xOTUs MTEgKzE5NywxMyBAQCBURVNUX0YoRVdLMkNvbnRleHRNZW51VGVzdCwgZXdrX2NvbnRleHRfCiAg ICAgICAgICI8L2h0bWw+IjsKIAogICAgIGV3a1ZpZXdDbGFzcygpLT5jb250ZXh0X21lbnVfc2hv dyA9IHRlc3RDb250ZXh0TWVudTsKKyAgICBld2tWaWV3Q2xhc3MoKS0+Y29udGV4dF9tZW51X2hp ZGUgPSBmaW5pc2hUZXN0OwogCiAgICAgZXdrX3ZpZXdfaHRtbF9zdHJpbmdfbG9hZCh3ZWJWaWV3 KCksIGl0ZW1TZWxlY3RIVE1MLCAiZmlsZTovLy8iLCAwKTsKICAgICBBU1NFUlRfVFJVRSh3YWl0 VW50aWxMb2FkRmluaXNoZWQoKSk7CiAgICAgc2hvd0NvbnRleHRNZW51KCk7Ci0gICAgQVNTRVJU X1RSVUUod2FpdFVudGlsTG9hZEZpbmlzaGVkKCkpOworICAgIHRlc3RGaW5pc2hlZCA9IGZhbHNl OworICAgIEFTU0VSVF9UUlVFKHdhaXRVbnRpbFRydWUodGVzdEZpbmlzaGVkKSk7CiB9CiAKIFRF U1RfRihFV0syQ29udGV4dE1lbnVUZXN0LCBld2tfY29udGV4dF9tZW51X2N1c3RvbV9pdGVtcykK