162128 2016-09-17 19:13:07 -0700 Web Inspector: ⇧⌘C should highlight node under cursor without re-moving mouse 2016-09-19 04:32:44 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1230902 0 joepeck 2016-09-17 19:13:07 -0700 Summary: ⇧⌘C should highlight node under cursor without re-moving mouse Steps to reproduce: 1. Hover this text 2. Trigger ⇧⌘C => Expected highlight to appear. It never appears until the mouse moves 1230903 1 webkit-bug-importer 2016-09-17 19:13:30 -0700 <rdar://problem/28353187> 1230904 2 289189 joepeck 2016-09-17 19:23:06 -0700 Created attachment 289189 [PATCH] Proposed Fix 1231054 3 289189 bburg 2016-09-19 04:11:40 -0700 Comment on attachment 289189 [PATCH] Proposed Fix r=me 1231058 4 289189 commit-queue 2016-09-19 04:32:41 -0700 Comment on attachment 289189 [PATCH] Proposed Fix Clearing flags on attachment: 289189 Committed r206093: <http://trac.webkit.org/changeset/206093> 1231059 5 commit-queue 2016-09-19 04:32:44 -0700 All reviewed patches have been landed. Closing bug. 289189 2016-09-17 19:23:06 -0700 2016-09-19 04:32:41 -0700 [PATCH] Proposed Fix better-mouse-1.patch text/plain 4073 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmNzU2NDA2Li43MzM5YTlmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTYtMDktMTcgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiDih6fijJhDIHNob3VsZCBoaWdobGlnaHQgbm9kZSB1bmRl ciBjdXJzb3Igd2l0aG91dCByZS1tb3ZpbmcgbW91c2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjEyOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50Lmg6 CisgICAgICAgICogaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Okluc3BlY3RvckRPTUFnZW50Ojp3aWxsRGVzdHJveUZyb250ZW5kQW5kQmFja2VuZCk6 CisgICAgICAgIChXZWJDb3JlOjpJbnNwZWN0b3JET01BZ2VudDo6bW91c2VEaWRNb3ZlT3ZlckVs ZW1lbnQpOgorICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yRE9NQWdlbnQ6OmhpZ2hsaWdodE1v dXNlZE92ZXJOb2RlKToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTUFnZW50OjpzZXRT ZWFyY2hpbmdGb3JOb2RlKToKKyAgICAgICAgV2hlbiB0aGUgaW5zcGVjdG9yIGlzIGNvbm5lY3Rl ZCwgcmVtZW1iZXIgdGhlIGxhc3QgbW91c2VkIG92ZXIgbm9kZS4KKyAgICAgICAgVGhpcyBwcm9k dWNlcyBmYXIgbW9yZSBjb25zaXN0ZW50IHJlc3VsdHMgb2YgaGlnaGxpZ2h0aW5nIHVuZGVyCisg ICAgICAgIHRoZSBjdXJzb3Igd2hlbiBwcmVzc2luZyBhbmQgcmVsZWFzaW5nIHRoZSBrZXlib2Fy ZCBzaG9ydGN1dCBrZXlzLAorICAgICAgICB3aXRob3V0IGhhdmluZyB0byBtb3ZlIHRoZSBtb3Vz ZS4gRXZlbiB3aGVuIHVzaW5nIHRoZSBzaG9ydGN1dCB0bworICAgICAgICBmaXJzdCBjb25uZWN0 IHRoZSBpbnNwZWN0b3IgdGhpcyBwcm9kdWNlcyBmYXIgbW9yZSBjb25zaXN0ZW50CisgICAgICAg IHJlc3VsdHMgYmVjYXVzZSByZWxlYXNpbmcgdGhlIGtleXMgZm9yIHRoZSBzaG9ydGN1dCBwcm9k dWNlIG5ldworICAgICAgICBtb3VzZURpZE1vdmVPdmVyRWxlbWVudCBldmVudHMuCisKIDIwMTYt MDktMTYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBDYW5jZWxs aW5nIG9uZSBmcmFtZSdzIGxvYWQgY2FuY2VscyBsb2FkIGluIG90aGVyIGZyYW1lcyB0aGF0IGhh dmUgdGhlIHNhbWUgVVJMIGFzIHdlbGwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5z cGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IDMxODRlMmYuLjE2N2U1ZmIgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTUFnZW50LmNwcApAQCAtMjQxLDEyICsyNDEs MTMgQEAgdm9pZCBJbnNwZWN0b3JET01BZ2VudDo6d2lsbERlc3Ryb3lGcm9udGVuZEFuZEJhY2tl bmQoSW5zcGVjdG9yOjpEaXNjb25uZWN0UmVhc28KIHsKICAgICBtX2hpc3RvcnkucmVzZXQoKTsK ICAgICBtX2RvbUVkaXRvci5yZXNldCgpOworICAgIG1fbW91c2VkT3Zlck5vZGUgPSBudWxscHRy OwogCiAgICAgRXJyb3JTdHJpbmcgdW51c2VkOwotICAgIHNldFNlYXJjaGluZ0Zvck5vZGUodW51 c2VkLCBmYWxzZSwgMCk7CisgICAgc2V0U2VhcmNoaW5nRm9yTm9kZSh1bnVzZWQsIGZhbHNlLCBu dWxscHRyKTsKICAgICBoaWRlSGlnaGxpZ2h0KHVudXNlZCk7CiAKLSAgICBtX2luc3RydW1lbnRp bmdBZ2VudHMuc2V0SW5zcGVjdG9yRE9NQWdlbnQoMCk7CisgICAgbV9pbnN0cnVtZW50aW5nQWdl bnRzLnNldEluc3BlY3RvckRPTUFnZW50KG51bGxwdHIpOwogICAgIG1fZG9jdW1lbnRSZXF1ZXN0 ZWQgPSBmYWxzZTsKICAgICByZXNldCgpOwogfQpAQCAtMTAwNSwxMCArMTAwNiwxNyBAQCB2b2lk IEluc3BlY3RvckRPTUFnZW50Ojpmb2N1c05vZGUoKQogCiB2b2lkIEluc3BlY3RvckRPTUFnZW50 Ojptb3VzZURpZE1vdmVPdmVyRWxlbWVudChjb25zdCBIaXRUZXN0UmVzdWx0JiByZXN1bHQsIHVu c2lnbmVkKQogeworICAgIG1fbW91c2VkT3Zlck5vZGUgPSByZXN1bHQuaW5uZXJOb2RlKCk7CisK ICAgICBpZiAoIW1fc2VhcmNoaW5nRm9yTm9kZSkKICAgICAgICAgcmV0dXJuOwogCi0gICAgTm9k ZSogbm9kZSA9IHJlc3VsdC5pbm5lck5vZGUoKTsKKyAgICBoaWdobGlnaHRNb3VzZWRPdmVyTm9k ZSgpOworfQorCit2b2lkIEluc3BlY3RvckRPTUFnZW50OjpoaWdobGlnaHRNb3VzZWRPdmVyTm9k ZSgpCit7CisgICAgTm9kZSogbm9kZSA9IG1fbW91c2VkT3Zlck5vZGUuZ2V0KCk7CiAgICAgd2hp bGUgKG5vZGUgJiYgbm9kZS0+bm9kZVR5cGUoKSA9PSBOb2RlOjpURVhUX05PREUpCiAgICAgICAg IG5vZGUgPSBub2RlLT5wYXJlbnROb2RlKCk7CiAgICAgaWYgKG5vZGUgJiYgbV9pbnNwZWN0TW9k ZUhpZ2hsaWdodENvbmZpZykKQEAgLTEwMjYsNiArMTAzNCw3IEBAIHZvaWQgSW5zcGVjdG9yRE9N QWdlbnQ6OnNldFNlYXJjaGluZ0Zvck5vZGUoRXJyb3JTdHJpbmcmIGVycm9yU3RyaW5nLCBib29s IGVuYWJsCiAgICAgICAgIG1faW5zcGVjdE1vZGVIaWdobGlnaHRDb25maWcgPSBoaWdobGlnaHRD b25maWdGcm9tSW5zcGVjdG9yT2JqZWN0KGVycm9yU3RyaW5nLCBoaWdobGlnaHRJbnNwZWN0b3JP YmplY3QpOwogICAgICAgICBpZiAoIW1faW5zcGVjdE1vZGVIaWdobGlnaHRDb25maWcpCiAgICAg ICAgICAgICByZXR1cm47CisgICAgICAgIGhpZ2hsaWdodE1vdXNlZE92ZXJOb2RlKCk7CiAgICAg fSBlbHNlCiAgICAgICAgIGhpZGVIaWdobGlnaHQoZXJyb3JTdHJpbmcpOwogCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaCBiL1NvdXJjZS9X ZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5oCmluZGV4IGU2OGM0NDk5Li5kN2I2 ZDE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdl bnQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuaApA QCAtMjE1LDYgKzIxNSw3IEBAIHB1YmxpYzoKICAgICBJbnNwZWN0b3JQYWdlQWdlbnQqIHBhZ2VB Z2VudCgpIHsgcmV0dXJuIG1fcGFnZUFnZW50OyB9CiAKIHByaXZhdGU6CisgICAgdm9pZCBoaWdo bGlnaHRNb3VzZWRPdmVyTm9kZSgpOwogICAgIHZvaWQgc2V0U2VhcmNoaW5nRm9yTm9kZShFcnJv clN0cmluZyYsIGJvb2wgZW5hYmxlZCwgY29uc3QgSW5zcGVjdG9yOjpJbnNwZWN0b3JPYmplY3Qq IGhpZ2hsaWdodENvbmZpZyk7CiAgICAgc3RkOjp1bmlxdWVfcHRyPEhpZ2hsaWdodENvbmZpZz4g aGlnaGxpZ2h0Q29uZmlnRnJvbUluc3BlY3Rvck9iamVjdChFcnJvclN0cmluZyYsIGNvbnN0IElu c3BlY3Rvcjo6SW5zcGVjdG9yT2JqZWN0KiBoaWdobGlnaHRJbnNwZWN0b3JPYmplY3QpOwogCkBA IC0yNzAsNiArMjcxLDcgQEAgcHJpdmF0ZToKICAgICBTZWFyY2hSZXN1bHRzIG1fc2VhcmNoUmVz dWx0czsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8UmV2YWxpZGF0ZVN0eWxlQXR0cmlidXRlVGFzaz4g bV9yZXZhbGlkYXRlU3R5bGVBdHRyVGFzazsKICAgICBSZWZQdHI8Tm9kZT4gbV9ub2RlVG9Gb2N1 czsKKyAgICBSZWZQdHI8Tm9kZT4gbV9tb3VzZWRPdmVyTm9kZTsKICAgICBib29sIG1fc2VhcmNo aW5nRm9yTm9kZSB7IGZhbHNlIH07CiAgICAgc3RkOjp1bmlxdWVfcHRyPEhpZ2hsaWdodENvbmZp Zz4gbV9pbnNwZWN0TW9kZUhpZ2hsaWdodENvbmZpZzsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8SW5z cGVjdG9ySGlzdG9yeT4gbV9oaXN0b3J5Owo=