162114 2016-09-16 22:58:59 -0700 Web Inspector: Bring the inspected page's window forward when activating element search 2016-09-22 11:46:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1230770 0 joepeck 2016-09-16 22:58:59 -0700 Summary: Bring the inspected page's window forward when activating element search. When using a detached inspector is annoying that after enabling node search you have to make multiple clicks. (1) To focus the window containing the inspected page and (2) to then select the node. We should eliminate click (1) which often confuses people. This would also make ⇧⌘C also bring the inspected page forward for very fast selecting of different elements. 1230771 1 webkit-bug-importer 2016-09-16 22:59:16 -0700 <rdar://problem/28349357> 1230772 2 289162 joepeck 2016-09-16 23:01:10 -0700 Created attachment 289162 [PATCH] Proposed Fix 1231042 3 289162 bburg 2016-09-19 02:20:25 -0700 Comment on attachment 289162 [PATCH] Proposed Fix r=me Does this work correctly from the API / menu item as well? 1231043 4 289162 commit-queue 2016-09-19 02:42:07 -0700 Comment on attachment 289162 [PATCH] Proposed Fix Clearing flags on attachment: 289162 Committed r206091: <http://trac.webkit.org/changeset/206091> 1231044 5 commit-queue 2016-09-19 02:42:11 -0700 All reviewed patches have been landed. Closing bug. 1232558 6 joepeck 2016-09-22 11:46:23 -0700 (In reply to comment #3) > Comment on attachment 289162 [details] > [PATCH] Proposed Fix > > r=me > > Does this work correctly from the API / menu item as well? Yes, in all cases. Menu item, keyboard shortcut, frontend toolbar icon / protocol API. 289162 2016-09-16 23:01:10 -0700 2016-09-19 02:42:07 -0700 [PATCH] Proposed Fix foreground-1.patch text/plain 6333 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwppbmRleCBkNDJhMmVkLi5mYWQyMjc2IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9tYWMvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTYtMDktMTYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFw cGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBCcmluZyB0aGUgaW5zcGVjdGVkIHBh Z2UncyB3aW5kb3cgZm9yd2FyZCB3aGVuIGFjdGl2YXRpbmcgZWxlbWVudCBzZWFyY2gKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjExNAorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMjgzNDkzNTc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQu bW06CisgICAgICAgIChXZWJJbnNwZWN0b3JDbGllbnQ6OmRpZFNldFNlYXJjaGluZ0Zvck5vZGUp OgorICAgICAgICBXaGVuIGVsZW1lbnQgc2VhcmNoIGlzIGFjdGl2YXRlZCBicmluZyB0aGUgd2lu ZG93CisgICAgICAgIGNvbnRhaW5pbmcgdGhlIGluc3BlY3RlZCBwYWdlIHRvIHRoZSBmb3JlZ3Jv dW5kLgorCiAyMDE2LTA5LTE1ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNvbT4KIAog ICAgICAgICBXS1dlYlZpZXcuaGFzT25seVNlY3VyZUNvbnRlbnQgYWx3YXlzIHJldHVybnMgIllF UyIgYWZ0ZXIgZ29pbmcgYmFjayB0byBhIENhY2hlZFBhZ2UgKGV2ZW4gaWYgaXQgaGFzIGh0dHAg cmVzb3VyY2VzKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0 L1dlYkluc3BlY3RvckNsaWVudC5tbSBiL1NvdXJjZS9XZWJLaXQvbWFjL1dlYkNvcmVTdXBwb3J0 L1dlYkluc3BlY3RvckNsaWVudC5tbQppbmRleCA5OWU0ZDU2Li45MDc4N2Q2IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJJbnNwZWN0b3JDbGllbnQubW0K KysrIGIvU291cmNlL1dlYktpdC9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViSW5zcGVjdG9yQ2xpZW50 Lm1tCkBAIC0xNjAsOSArMTYwLDExIEBAIHZvaWQgV2ViSW5zcGVjdG9yQ2xpZW50OjpkaWRTZXRT ZWFyY2hpbmdGb3JOb2RlKGJvb2wgZW5hYmxlZCkKIAogICAgIEFTU0VSVChpc01haW5UaHJlYWQo KSk7CiAKLSAgICBpZiAoZW5hYmxlZCkKKyAgICBpZiAoZW5hYmxlZCkgeworICAgICAgICBbW21f aW5zcGVjdGVkV2ViVmlldyB3aW5kb3ddIG1ha2VLZXlBbmRPcmRlckZyb250Om5pbF07CisgICAg ICAgIFtbbV9pbnNwZWN0ZWRXZWJWaWV3IHdpbmRvd10gbWFrZUZpcnN0UmVzcG9uZGVyOm1faW5z cGVjdGVkV2ViVmlld107CiAgICAgICAgIFtbTlNOb3RpZmljYXRpb25DZW50ZXIgZGVmYXVsdENl bnRlcl0gcG9zdE5vdGlmaWNhdGlvbk5hbWU6V2ViSW5zcGVjdG9yRGlkU3RhcnRTZWFyY2hpbmdG b3JOb2RlIG9iamVjdDppbnNwZWN0b3JdOwotICAgIGVsc2UKKyAgICB9IGVsc2UKICAgICAgICAg W1tOU05vdGlmaWNhdGlvbkNlbnRlciBkZWZhdWx0Q2VudGVyXSBwb3N0Tm90aWZpY2F0aW9uTmFt ZTpXZWJJbnNwZWN0b3JEaWRTdG9wU2VhcmNoaW5nRm9yTm9kZSBvYmplY3Q6aW5zcGVjdG9yXTsK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktp dDIvQ2hhbmdlTG9nCmluZGV4IGEyYTMyMzIuLjhkZjhkNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwyOCBAQAorMjAxNi0wOS0xNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29t PgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEJyaW5nIHRoZSBpbnNwZWN0ZWQgcGFnZSdzIHdp bmRvdyBmb3J3YXJkIHdoZW4gYWN0aXZhdGluZyBlbGVtZW50IHNlYXJjaAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMTE0CisgICAgICAgIDxyZGFy Oi8vcHJvYmxlbS8yODM0OTM1Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oOgorICAgICAgICAq IFVJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYklu c3BlY3RvclByb3h5OjplbGVtZW50U2VsZWN0aW9uQ2hhbmdlZCk6CisgICAgICAgIFdoZW4gZWxl bWVudCBzZWFyY2ggaXMgYWN0aXZhdGVkIGFsbG93IHRoZSBwbGF0Zm9ybSB0byBicmluZworICAg ICAgICB0aGUgd2luZG93IGNvbnRhaW5pbmcgdGhlIGluc3BlY3RlZCBwYWdlIHRvIHRoZSBmb3Jl Z3JvdW5kLgorCisgICAgICAgIChXZWJLaXQ6OldlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUJy aW5nSW5zcGVjdGVkUGFnZVRvRnJvbnQpOgorICAgICAgICAqIFVJUHJvY2Vzcy9lZmwvV2ViSW5z cGVjdG9yUHJveHlFZmwuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJJbnNwZWN0b3JQcm94eTo6 cGxhdGZvcm1CcmluZ0luc3BlY3RlZFBhZ2VUb0Zyb250KToKKyAgICAgICAgKiBVSVByb2Nlc3Mv Z3RrL1dlYkluc3BlY3RvclByb3h5R3RrLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViSW5zcGVj dG9yUHJveHk6OnBsYXRmb3JtQnJpbmdJbnNwZWN0ZWRQYWdlVG9Gcm9udCk6CisgICAgICAgIERl ZmF1bHQgZW1wdHkgaW1wbGVtZW50YXRpb24gZm9yIHBvcnRzLgorCisgICAgICAgICogVUlQcm9j ZXNzL21hYy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViSW5z cGVjdG9yUHJveHk6OnBsYXRmb3JtQnJpbmdJbnNwZWN0ZWRQYWdlVG9Gcm9udCk6CisgICAgICAg IEJyaW5nIHRoZSB3aW5kb3cgY29udGFpbmluZyB0aGUgaW5zcGVjdGVkIHBhZ2UgdG8gdGhlIGZv cmVncm91bmQuCisKIDIwMTYtMDktMTYgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBs ZS5jb20+CiAKICAgICAgICAgV0tXZWJWaWV3Q29uZmlndXJhdGlvbidzIF9pbmNyZW1lbnRhbFJl bmRlcmluZ1N1cHByZXNzaW9uVGltZW91dCBzaG91bGQgYmUgYW4gTlNUaW1lSW50ZXJ2YWwKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5jcHAg Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViSW5zcGVjdG9yUHJveHkuY3BwCmluZGV4IGRj OTAwYTUuLjAxMjhhNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJ bnNwZWN0b3JQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYkluc3Bl Y3RvclByb3h5LmNwcApAQCAtNTk4LDcgKzU5OCw5IEBAIHZvaWQgV2ViSW5zcGVjdG9yUHJveHk6 OmVsZW1lbnRTZWxlY3Rpb25DaGFuZ2VkKGJvb2wgYWN0aXZlKQogICAgICAgICByZXR1cm47CiAg ICAgfQogCi0gICAgaWYgKCFhY3RpdmUgJiYgaXNDb25uZWN0ZWQoKSkKKyAgICBpZiAoYWN0aXZl KQorICAgICAgICBwbGF0Zm9ybUJyaW5nSW5zcGVjdGVkUGFnZVRvRnJvbnQoKTsKKyAgICBlbHNl IGlmIChpc0Nvbm5lY3RlZCgpKQogICAgICAgICBicmluZ1RvRnJvbnQoKTsKIH0KIApAQCAtNjYw LDYgKzY2MiwxMSBAQCB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUJyaW5nVG9Gcm9u dCgpCiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAordm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6 cGxhdGZvcm1CcmluZ0luc3BlY3RlZFBhZ2VUb0Zyb250KCkKK3sKKyAgICBub3RJbXBsZW1lbnRl ZCgpOworfQorCiB2b2lkIFdlYkluc3BlY3RvclByb3h5OjpwbGF0Zm9ybUhpZGUoKQogewogICAg IG5vdEltcGxlbWVudGVkKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv V2ViSW5zcGVjdG9yUHJveHkuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0 b3JQcm94eS5oCmluZGV4IGI2YmFmOTMuLjdmNDEzYWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9XZWJJbnNwZWN0b3JQcm94eS5oCkBAIC0xNzksNiArMTc5LDcgQEAgcHJpdmF0ZToK ICAgICB2b2lkIHBsYXRmb3JtRGlkQ2xvc2VGb3JDcmFzaCgpOwogICAgIHZvaWQgcGxhdGZvcm1J bnZhbGlkYXRlKCk7CiAgICAgdm9pZCBwbGF0Zm9ybUJyaW5nVG9Gcm9udCgpOworICAgIHZvaWQg cGxhdGZvcm1CcmluZ0luc3BlY3RlZFBhZ2VUb0Zyb250KCk7CiAgICAgdm9pZCBwbGF0Zm9ybUhp ZGUoKTsKICAgICBib29sIHBsYXRmb3JtSXNGcm9udCgpOwogICAgIHZvaWQgcGxhdGZvcm1BdHRh Y2hBdmFpbGFiaWxpdHlDaGFuZ2VkKGJvb2wpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2VmbC9XZWJJbnNwZWN0b3JQcm94eUVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9V SVByb2Nlc3MvZWZsL1dlYkluc3BlY3RvclByb3h5RWZsLmNwcAppbmRleCBmNTc0ZTE1Li40Yzdk N2IyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYkluc3BlY3Rv clByb3h5RWZsLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZWZsL1dlYkluc3Bl Y3RvclByb3h5RWZsLmNwcApAQCAtMTY0LDYgKzE2NCwxMSBAQCB2b2lkIFdlYkluc3BlY3RvclBy b3h5OjpwbGF0Zm9ybUJyaW5nVG9Gcm9udCgpCiAgICAgbm90SW1wbGVtZW50ZWQoKTsKIH0KIAor dm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1CcmluZ0luc3BlY3RlZFBhZ2VUb0Zyb250 KCkKK3sKKyAgICBub3RJbXBsZW1lbnRlZCgpOworfQorCiBib29sIFdlYkluc3BlY3RvclByb3h5 OjpwbGF0Zm9ybUlzRnJvbnQoKQogewogICAgIG5vdEltcGxlbWVudGVkKCk7CmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvZ3RrL1dlYkluc3BlY3RvclByb3h5R3RrLmNwcCBi L1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCmlu ZGV4IGFhMjQyYTYuLmI0NmQxMTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vz cy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9ndGsvV2ViSW5zcGVjdG9yUHJveHlHdGsuY3BwCkBAIC0yMzcsNiArMjM3LDExIEBAIHZv aWQgV2ViSW5zcGVjdG9yUHJveHk6OnBsYXRmb3JtQnJpbmdUb0Zyb250KCkKICAgICAgICAgZ3Rr X3dpbmRvd19wcmVzZW50KEdUS19XSU5ET1cocGFyZW50KSk7CiB9CiAKK3ZvaWQgV2ViSW5zcGVj dG9yUHJveHk6OnBsYXRmb3JtQnJpbmdJbnNwZWN0ZWRQYWdlVG9Gcm9udCgpCit7CisgICAgbm90 SW1wbGVtZW50ZWQoKTsKK30KKwogYm9vbCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1Jc0Zy b250KCkKIHsKICAgICBHdGtXaWRnZXQqIHBhcmVudCA9IGd0a193aWRnZXRfZ2V0X3RvcGxldmVs KG1faW5zcGVjdG9yVmlldyk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv bWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21h Yy9XZWJJbnNwZWN0b3JQcm94eU1hYy5tbQppbmRleCBjYjhiN2UzLi4wYTc5OTEzIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkluc3BlY3RvclByb3h5TWFjLm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViSW5zcGVjdG9yUHJveHlNYWMu bW0KQEAgLTM5NCw2ICszOTQsMTEgQEAgdm9pZCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1C cmluZ1RvRnJvbnQoKQogICAgIFttX2luc3BlY3RvclZpZXcuZ2V0KCkud2luZG93IG1ha2VGaXJz dFJlc3BvbmRlcjptX2luc3BlY3RvclZpZXcuZ2V0KCldOwogfQogCit2b2lkIFdlYkluc3BlY3Rv clByb3h5OjpwbGF0Zm9ybUJyaW5nSW5zcGVjdGVkUGFnZVRvRnJvbnQoKQoreworICAgIFtpbnNw ZWN0ZWRQYWdlKCktPnBsYXRmb3JtV2luZG93KCkgbWFrZUtleUFuZE9yZGVyRnJvbnQ6bmlsXTsK K30KKwogYm9vbCBXZWJJbnNwZWN0b3JQcm94eTo6cGxhdGZvcm1Jc0Zyb250KCkKIHsKICAgICAv LyBGSVhNRSA8cmRhcjovL3Byb2JsZW0vMTA5Mzc2ODg+OiB0aGlzIHdpbGwgbm90IHJldHVybiBm YWxzZSBmb3IgYSBiYWNrZ3JvdW5kIHRhYiBpbiBTYWZhcmksIG9ubHkgYSBiYWNrZ3JvdW5kIHdp bmRvdy4K