162096 2016-09-16 15:53:50 -0700 Add size assert for RenderElement 2016-09-19 15:14:25 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 162110 162229 1 koivisto webkit-unassigned commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1230647 0 koivisto 2016-09-16 15:53:50 -0700 prevent accidental growth 1230650 1 289125 koivisto 2016-09-16 15:57:35 -0700 Created attachment 289125 patch 1230679 2 289125 commit-queue 2016-09-16 16:35:42 -0700 Comment on attachment 289125 patch Clearing flags on attachment: 289125 Committed r206055: <http://trac.webkit.org/changeset/206055> 1230680 3 commit-queue 2016-09-16 16:35:47 -0700 All reviewed patches have been landed. Closing bug. 1230743 4 commit-queue 2016-09-16 19:39:44 -0700 Re-opened since this is blocked by bug 162110 1231228 5 289125 koivisto 2016-09-19 12:01:32 -0700 Comment on attachment 289125 patch Trying to land again. 1231232 6 289125 commit-queue 2016-09-19 12:04:08 -0700 Comment on attachment 289125 patch Rejecting attachment 289125 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 289125, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.webkit.org/results/2107071 1231320 7 289255 koivisto 2016-09-19 14:26:56 -0700 Created attachment 289255 patch this should work everywhere 1231363 8 289255 commit-queue 2016-09-19 15:14:20 -0700 Comment on attachment 289255 patch Clearing flags on attachment: 289255 Committed r206121: <http://trac.webkit.org/changeset/206121> 1231364 9 commit-queue 2016-09-19 15:14:25 -0700 All reviewed patches have been landed. Closing bug. 289125 2016-09-16 15:57:35 -0700 2016-09-19 14:26:56 -0700 patch renderelement-size-asert.patch text/plain 2258 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjA1NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTE2ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc2l6ZSBhc3NlcnQgZm9y IFJlbmRlckVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MjA5NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIEFsc28gcmVtb3ZlIHRoZSB1bnVzZWQgbV92aXNpYmxlSW5WaWV3cG9ydFN0YXRlIGZp ZWxkLgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVuZGVyRWxlbWVudDo6dW5yZWdpc3RlckZvclZpc2libGVJblZpZXdwb3J0Q2Fs bGJhY2spOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJFbGVtZW50Lmg6CisKIDIwMTYtMDkt MTYgIEFudHRpIEtvaXZpc3RvICA8YW50dGlAYXBwbGUuY29tPgogCiAgICAgICAgIFRpZ2h0ZW4g cmVnaW9uIHN0eWxlIG1hcCB0byB1c2UgUmVuZGVyRWxlbWVudCBpbnN0ZWFkIG9mIFJlbmRlck9i amVjdApJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcAko cmV2aXNpb24gMjA2MDUzKQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1l bnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03OCw2ICs3OCwxNSBAQAogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKK3N0cnVjdCBTYW1lU2l6ZUFzUmVuZGVyRWxlbWVudCA6IHB1YmxpYyBSZW5kZXJP YmplY3QgeworICAgIHVpbnQzMl90IGJpdGZpZWxkczsKKyAgICB2b2lkKiBmaXJzdENoaWxkOwor ICAgIHZvaWQqIGxhc3RDaGlsZDsKKyAgICBSZW5kZXJTdHlsZSBzdHlsZTsKK307CisKK3N0YXRp Y19hc3NlcnQoc2l6ZW9mKFJlbmRlckVsZW1lbnQpID09IHNpemVvZihTYW1lU2l6ZUFzUmVuZGVy RWxlbWVudCksICJSZW5kZXJFbGVtZW50IHNob3VsZCBzdGF5IHNtYWxsIik7CisKIGJvb2wgUmVu ZGVyRWxlbWVudDo6c19hZmZlY3RzUGFyZW50QmxvY2sgPSBmYWxzZTsKIGJvb2wgUmVuZGVyRWxl bWVudDo6c19ub0xvbmdlckFmZmVjdHNQYXJlbnRCbG9jayA9IGZhbHNlOwogICAgIApAQCAtMTQ4 Myw3ICsxNDkyLDYgQEAgdm9pZCBSZW5kZXJFbGVtZW50Ojp1bnJlZ2lzdGVyRm9yVmlzaWJsZQog ICAgIHNldElzUmVnaXN0ZXJlZEZvclZpc2libGVJblZpZXdwb3J0Q2FsbGJhY2soZmFsc2UpOwog CiAgICAgdmlldygpLnVucmVnaXN0ZXJGb3JWaXNpYmxlSW5WaWV3cG9ydENhbGxiYWNrKCp0aGlz KTsKLSAgICBtX3Zpc2libGVJblZpZXdwb3J0U3RhdGUgPSBWaXNpYmlsaXR5VW5rbm93bjsKIH0K IAogdm9pZCBSZW5kZXJFbGVtZW50Ojp2aXNpYmxlSW5WaWV3cG9ydFN0YXRlQ2hhbmdlZChWaXNp YmxlSW5WaWV3cG9ydFN0YXRlIHN0YXRlKQpJbmRleDogU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckVsZW1lbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyRWxlbWVudC5oCShyZXZpc2lvbiAyMDYwNTMpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRWxlbWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0zNDUsOCArMzQ1LDYgQEAg cHJpdmF0ZToKICAgICB1bnNpZ25lZCBtX3JlbmRlckJsb2NrRmxvd0hhc01hcmt1cFRydW5jYXRp b24gOiAxOwogICAgIHVuc2lnbmVkIG1fcmVuZGVyQmxvY2tGbG93TGluZUxheW91dFBhdGggOiAy OwogCi0gICAgVmlzaWJsZUluVmlld3BvcnRTdGF0ZSBtX3Zpc2libGVJblZpZXdwb3J0U3RhdGUg eyBWaXNpYmlsaXR5VW5rbm93biB9OwotCiAgICAgUmVuZGVyT2JqZWN0KiBtX2ZpcnN0Q2hpbGQ7 CiAgICAgUmVuZGVyT2JqZWN0KiBtX2xhc3RDaGlsZDsKIAo= 289255 2016-09-19 14:26:56 -0700 2016-09-19 15:14:20 -0700 patch renderelement-size-assert-2.patch text/plain 2313 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIwNjExOCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE2LTA5LTE5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgc2l6ZSBhc3NlcnQgZm9y IFJlbmRlckVsZW1lbnQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE2MjA5NgorCisgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4KKworICAg ICAgICBBbHNvIHJlbW92ZSB0aGUgdW51c2VkIG1fdmlzaWJsZUluVmlld3BvcnRTdGF0ZSBmaWVs ZC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OlJlbmRlckVsZW1lbnQ6OnVucmVnaXN0ZXJGb3JWaXNpYmxlSW5WaWV3cG9ydENhbGxi YWNrKToKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5oOgorCiAyMDE2LTA5LTE5 ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgVXBkYXRlIFhIVE1M UGFyc2VyIHRvIHJlY29nbml6ZSAiLS8vVzNDLy9EVEQgTWF0aE1MIDIuMC8vRU4iIHB1YmxpYyBp ZGVudGlmaWVyCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQu Y3BwCShyZXZpc2lvbiAyMDYxMTgpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy RWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTc4LDYgKzc4LDE3IEBACiAKIG5hbWVzcGFj ZSBXZWJDb3JlIHsKIAorc3RydWN0IFNhbWVTaXplQXNSZW5kZXJFbGVtZW50IDogcHVibGljIFJl bmRlck9iamVjdCB7CisgICAgdWludDhfdCBiaXRmaWVsZHMwOworICAgIHVpbnQ4X3QgYml0Zmll bGRzMTsKKyAgICB1aW50OF90IGJpdGZpZWxkczI7CisgICAgdm9pZCogZmlyc3RDaGlsZDsKKyAg ICB2b2lkKiBsYXN0Q2hpbGQ7CisgICAgUmVuZGVyU3R5bGUgc3R5bGU7Cit9OworCitzdGF0aWNf YXNzZXJ0KHNpemVvZihSZW5kZXJFbGVtZW50KSA9PSBzaXplb2YoU2FtZVNpemVBc1JlbmRlckVs ZW1lbnQpLCAiUmVuZGVyRWxlbWVudCBzaG91bGQgc3RheSBzbWFsbCIpOworCiBib29sIFJlbmRl ckVsZW1lbnQ6OnNfYWZmZWN0c1BhcmVudEJsb2NrID0gZmFsc2U7CiBib29sIFJlbmRlckVsZW1l bnQ6OnNfbm9Mb25nZXJBZmZlY3RzUGFyZW50QmxvY2sgPSBmYWxzZTsKICAgICAKQEAgLTE0ODMs NyArMTQ5NCw2IEBAIHZvaWQgUmVuZGVyRWxlbWVudDo6dW5yZWdpc3RlckZvclZpc2libGUKICAg ICBzZXRJc1JlZ2lzdGVyZWRGb3JWaXNpYmxlSW5WaWV3cG9ydENhbGxiYWNrKGZhbHNlKTsKIAog ICAgIHZpZXcoKS51bnJlZ2lzdGVyRm9yVmlzaWJsZUluVmlld3BvcnRDYWxsYmFjaygqdGhpcyk7 Ci0gICAgbV92aXNpYmxlSW5WaWV3cG9ydFN0YXRlID0gVmlzaWJpbGl0eVVua25vd247CiB9CiAK IHZvaWQgUmVuZGVyRWxlbWVudDo6dmlzaWJsZUluVmlld3BvcnRTdGF0ZUNoYW5nZWQoVmlzaWJs ZUluVmlld3BvcnRTdGF0ZSBzdGF0ZSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9S ZW5kZXJFbGVtZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckVsZW1lbnQuaAkocmV2aXNpb24gMjA2MTE4KQorKysgU291cmNlL1dlYkNvcmUvcmVuZGVy aW5nL1JlbmRlckVsZW1lbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzQ1LDggKzM0NSw2IEBAIHBy aXZhdGU6CiAgICAgdW5zaWduZWQgbV9yZW5kZXJCbG9ja0Zsb3dIYXNNYXJrdXBUcnVuY2F0aW9u IDogMTsKICAgICB1bnNpZ25lZCBtX3JlbmRlckJsb2NrRmxvd0xpbmVMYXlvdXRQYXRoIDogMjsK IAotICAgIFZpc2libGVJblZpZXdwb3J0U3RhdGUgbV92aXNpYmxlSW5WaWV3cG9ydFN0YXRlIHsg VmlzaWJpbGl0eVVua25vd24gfTsKLQogICAgIFJlbmRlck9iamVjdCogbV9maXJzdENoaWxkOwog ICAgIFJlbmRlck9iamVjdCogbV9sYXN0Q2hpbGQ7CiAK