162061 2016-09-16 09:41:11 -0700 [GTK] Move the rendering of auth dialog shadow to the auth dialog widget 2016-09-17 01:36:39 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 161530 1 cgarcia webkit-unassigned berto bugs-noreply commit-queue gustavo mcatanzaro mrobinson oldest_to_newest 1230421 0 cgarcia 2016-09-16 09:41:11 -0700 Instead of rendering the shadow in the web view, we can let the auth dialog do it. This fixes the rendering of the shadow in Wayland when using gdk_cairo_draw_from_gl(). 1230424 1 289065 cgarcia 2016-09-16 09:46:11 -0700 Created attachment 289065 Patch 1230428 2 commit-queue 2016-09-16 09:48:20 -0700 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1230448 3 289065 mcatanzaro 2016-09-16 10:28:24 -0700 Comment on attachment 289065 Patch Wait for EWS 1230781 4 cgarcia 2016-09-17 01:36:39 -0700 Committed r206067: <http://trac.webkit.org/changeset/206067> 289065 2016-09-16 09:46:11 -0700 2016-09-16 10:28:24 -0700 Patch wk2-auth-dialog-shadow.diff text/plain 6207 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1YTM5ZWI1Li5iMDg4Yzk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTYtMDktMTYgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtHVEtdIE1vdmUgdGhlIHJlbmRlcmluZyBvZiBhdXRoIGRpYWxvZyBzaGFk b3cgdG8gdGhlIGF1dGggZGlhbG9nIHdpZGdldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMDYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSW5zdGVhZCBvZiByZW5kZXJpbmcgdGhlIHNoYWRvdyBpbiB0 aGUgd2ViIHZpZXcsIHdlIGNhbiBsZXQgdGhlIGF1dGggZGlhbG9nIGRvIGl0LiBUaGlzIGZpeGVz IHRoZSByZW5kZXJpbmcgb2YKKyAgICAgICAgdGhlIHNoYWRvdyBpbiBXYXlsYW5kIHdoZW4gdXNp bmcgZ2RrX2NhaXJvX2RyYXdfZnJvbV9nbCgpLgorCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9n dGsvV2ViS2l0QXV0aGVudGljYXRpb25EaWFsb2cuY3BwOgorICAgICAgICAod2Via2l0QXV0aGVu dGljYXRpb25EaWFsb2dEcmF3KTogRHJhdyB0aGUgc2hhZG93IGJlZm9yZSByZW5kZXJpbmcgdGhl IGNoaWxkLgorICAgICAgICAod2Via2l0QXV0aGVudGljYXRpb25EaWFsb2dTaXplQWxsb2NhdGUp OiBDZW50ZXIgdGhlIGNoaWxkIG9uIHRoZSBhbGxvY2F0ZWQgc3BhY2UuCisgICAgICAgICh3ZWJr aXRfYXV0aGVudGljYXRpb25fZGlhbG9nX2NsYXNzX2luaXQpOiBBZGQgc2l6ZV9hbGxvY2F0ZSBp bXBsZW1lbnRhdGlvbi4KKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRXZWJWaWV3 QmFzZS5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3QmFzZURyYXcpOiBEbyBub3QgZHJhdyB0 aGUgc2hhZG93IHdoZW4gYXV0aCBkaWFsb2cgaXMgcHJlc2VudC4KKyAgICAgICAgKHdlYmtpdFdl YlZpZXdCYXNlU2l6ZUFsbG9jYXRlKTogR2l2ZSB0aGUgd2hvbGUgd2ViIHZpZXcgYWxsb2NhdGlv biB0byB0aGUgYXV0aCBkaWFsb2cuCisKIDIwMTYtMDktMTYgIEd1c3Rhdm8gTm9yb25oYSBTaWx2 YSAgPGd1c3Rhdm8ubm9yb25oYUBjb2xsYWJvcmEuY28udWs+CiAKICAgICAgICAgW0dUS10gU3Rv cCB1c2luZyBnbFJlYWRQaXhlbHMoKSB0byBibGl0IEFDIHN1cmZhY2VzIGluIHRoZSBVSVByb2Nl c3MgdW5kZXIgV2F5bGFuZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQ SS9ndGsvV2ViS2l0QXV0aGVudGljYXRpb25EaWFsb2cuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQ cm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0aGVudGljYXRpb25EaWFsb2cuY3BwCmluZGV4IGZjODU2 ZjYuLmFkYTgwNDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3Rr L1dlYktpdEF1dGhlbnRpY2F0aW9uRGlhbG9nLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvQVBJL2d0ay9XZWJLaXRBdXRoZW50aWNhdGlvbkRpYWxvZy5jcHAKQEAgLTIwNCwxMCAr MjA0LDE5IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRBdXRoZW50aWNhdGlvbkRpYWxvZ0RyYXco R3RrV2lkZ2V0KiB3aWRnZXQsIGNhaXJvX3QqIGNyKQogewogICAgIFdlYktpdEF1dGhlbnRpY2F0 aW9uRGlhbG9nUHJpdmF0ZSogcHJpdiA9IFdFQktJVF9BVVRIRU5USUNBVElPTl9ESUFMT0cod2lk Z2V0KS0+cHJpdjsKIAotICAgIGd0a19zdHlsZV9jb250ZXh0X3NhdmUocHJpdi0+c3R5bGVDb250 ZXh0LmdldCgpKTsKLSAgICBndGtfc3R5bGVfY29udGV4dF9hZGRfY2xhc3MocHJpdi0+c3R5bGVD b250ZXh0LmdldCgpLCBHVEtfU1RZTEVfQ0xBU1NfQkFDS0dST1VORCk7Ci0gICAgZ3RrX3JlbmRl cl9iYWNrZ3JvdW5kKHByaXYtPnN0eWxlQ29udGV4dC5nZXQoKSwgY3IsIDAsIDAsIGd0a193aWRn ZXRfZ2V0X2FsbG9jYXRlZF93aWR0aCh3aWRnZXQpLCBndGtfd2lkZ2V0X2dldF9hbGxvY2F0ZWRf aGVpZ2h0KHdpZGdldCkpOwotICAgIGd0a19zdHlsZV9jb250ZXh0X3Jlc3RvcmUocHJpdi0+c3R5 bGVDb250ZXh0LmdldCgpKTsKKyAgICBjYWlyb19zZXRfb3BlcmF0b3IoY3IsIENBSVJPX09QRVJB VE9SX09WRVIpOworICAgIGNhaXJvX3NldF9zb3VyY2VfcmdiYShjciwgMCwgMCwgMCwgMC41KTsK KyAgICBjYWlyb19wYWludChjcik7CisKKyAgICBpZiAoR3RrV2lkZ2V0KiBjaGlsZCA9IGd0a19i aW5fZ2V0X2NoaWxkKEdUS19CSU4od2lkZ2V0KSkpIHsKKyAgICAgICAgR3RrQWxsb2NhdGlvbiBh bGxvY2F0aW9uOworICAgICAgICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9uKGNoaWxkLCAmYWxs b2NhdGlvbik7CisKKyAgICAgICAgZ3RrX3N0eWxlX2NvbnRleHRfc2F2ZShwcml2LT5zdHlsZUNv bnRleHQuZ2V0KCkpOworICAgICAgICBndGtfc3R5bGVfY29udGV4dF9hZGRfY2xhc3MocHJpdi0+ c3R5bGVDb250ZXh0LmdldCgpLCBHVEtfU1RZTEVfQ0xBU1NfQkFDS0dST1VORCk7CisgICAgICAg IGd0a19yZW5kZXJfYmFja2dyb3VuZChwcml2LT5zdHlsZUNvbnRleHQuZ2V0KCksIGNyLCBhbGxv Y2F0aW9uLngsIGFsbG9jYXRpb24ueSwgYWxsb2NhdGlvbi53aWR0aCwgYWxsb2NhdGlvbi5oZWln aHQpOworICAgICAgICBndGtfc3R5bGVfY29udGV4dF9yZXN0b3JlKHByaXYtPnN0eWxlQ29udGV4 dC5nZXQoKSk7CisgICAgfQogCiAgICAgR1RLX1dJREdFVF9DTEFTUyh3ZWJraXRfYXV0aGVudGlj YXRpb25fZGlhbG9nX3BhcmVudF9jbGFzcyktPmRyYXcod2lkZ2V0LCBjcik7CiAKQEAgLTIyMiw2 ICsyMzEsMjcgQEAgc3RhdGljIHZvaWQgd2Via2l0QXV0aGVudGljYXRpb25EaWFsb2dNYXAoR3Rr V2lkZ2V0KiB3aWRnZXQpCiAgICAgR1RLX1dJREdFVF9DTEFTUyh3ZWJraXRfYXV0aGVudGljYXRp b25fZGlhbG9nX3BhcmVudF9jbGFzcyktPm1hcCh3aWRnZXQpOwogfQogCitzdGF0aWMgdm9pZCB3 ZWJraXRBdXRoZW50aWNhdGlvbkRpYWxvZ1NpemVBbGxvY2F0ZShHdGtXaWRnZXQqIHdpZGdldCwg R3RrQWxsb2NhdGlvbiogYWxsb2NhdGlvbikKK3sKKyAgICBHVEtfV0lER0VUX0NMQVNTKHdlYmtp dF9hdXRoZW50aWNhdGlvbl9kaWFsb2dfcGFyZW50X2NsYXNzKS0+c2l6ZV9hbGxvY2F0ZSh3aWRn ZXQsIGFsbG9jYXRpb24pOworCisgICAgR3RrV2lkZ2V0KiBjaGlsZCA9IGd0a19iaW5fZ2V0X2No aWxkKEdUS19CSU4od2lkZ2V0KSk7CisgICAgaWYgKCFjaGlsZCkKKyAgICAgICAgcmV0dXJuOwor CisgICAgR3RrUmVxdWlzaXRpb24gbmF0dXJhbFNpemU7CisgICAgZ3RrX3dpZGdldF9nZXRfcHJl ZmVycmVkX3NpemUoY2hpbGQsIDAsICZuYXR1cmFsU2l6ZSk7CisKKyAgICBHdGtBbGxvY2F0aW9u IGNoaWxkQWxsb2NhdGlvbjsKKyAgICBndGtfd2lkZ2V0X2dldF9hbGxvY2F0aW9uKGNoaWxkLCAm Y2hpbGRBbGxvY2F0aW9uKTsKKworICAgIGNoaWxkQWxsb2NhdGlvbi54ICs9IChhbGxvY2F0aW9u LT53aWR0aCAtIG5hdHVyYWxTaXplLndpZHRoKSAvIDI7CisgICAgY2hpbGRBbGxvY2F0aW9uLnkg Kz0gKGFsbG9jYXRpb24tPmhlaWdodCAtIG5hdHVyYWxTaXplLmhlaWdodCkgLyAyOworICAgIGNo aWxkQWxsb2NhdGlvbi53aWR0aCA9IG5hdHVyYWxTaXplLndpZHRoOworICAgIGNoaWxkQWxsb2Nh dGlvbi5oZWlnaHQgPSBuYXR1cmFsU2l6ZS5oZWlnaHQ7CisgICAgZ3RrX3dpZGdldF9zaXplX2Fs bG9jYXRlKGNoaWxkLCAmY2hpbGRBbGxvY2F0aW9uKTsKK30KKwogc3RhdGljIHZvaWQgd2Via2l0 QXV0aGVudGljYXRpb25EaWFsb2dDb25zdHJ1Y3RlZChHT2JqZWN0KiBvYmplY3QpCiB7CiAgICAg R19PQkpFQ1RfQ0xBU1Mod2Via2l0X2F1dGhlbnRpY2F0aW9uX2RpYWxvZ19wYXJlbnRfY2xhc3Mp LT5jb25zdHJ1Y3RlZChvYmplY3QpOwpAQCAtMjU0LDYgKzI4NCw3IEBAIHN0YXRpYyB2b2lkIHdl YmtpdF9hdXRoZW50aWNhdGlvbl9kaWFsb2dfY2xhc3NfaW5pdChXZWJLaXRBdXRoZW50aWNhdGlv bkRpYWxvZ0NsCiAgICAgR3RrV2lkZ2V0Q2xhc3MqIHdpZGdldENsYXNzID0gR1RLX1dJREdFVF9D TEFTUyhrbGFzcyk7CiAgICAgd2lkZ2V0Q2xhc3MtPmRyYXcgPSB3ZWJraXRBdXRoZW50aWNhdGlv bkRpYWxvZ0RyYXc7CiAgICAgd2lkZ2V0Q2xhc3MtPm1hcCA9IHdlYmtpdEF1dGhlbnRpY2F0aW9u RGlhbG9nTWFwOworICAgIHdpZGdldENsYXNzLT5zaXplX2FsbG9jYXRlID0gd2Via2l0QXV0aGVu dGljYXRpb25EaWFsb2dTaXplQWxsb2NhdGU7CiB9CiAKIEd0a1dpZGdldCogd2Via2l0QXV0aGVu dGljYXRpb25EaWFsb2dOZXcoV2ViS2l0QXV0aGVudGljYXRpb25SZXF1ZXN0KiByZXF1ZXN0LCBD cmVkZW50aWFsU3RvcmFnZU1vZGUgbW9kZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXdCYXNlLmNwcAppbmRleCBkNzVmOWU2Li41YTgw NTU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRX ZWJWaWV3QmFzZS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2Vi S2l0V2ViVmlld0Jhc2UuY3BwCkBAIC01NDIsMTIgKzU0Miw2IEBAIHN0YXRpYyBnYm9vbGVhbiB3 ZWJraXRXZWJWaWV3QmFzZURyYXcoR3RrV2lkZ2V0KiB3aWRnZXQsIGNhaXJvX3QqIGNyKQogICAg ICAgICBkcmF3aW5nQXJlYS0+cGFpbnQoY3IsIGNsaXBSZWN0LCB1bnBhaW50ZWRSZWdpb24pOwog ICAgIH0KIAotICAgIGlmICh3ZWJWaWV3QmFzZS0+cHJpdi0+YXV0aGVudGljYXRpb25EaWFsb2cp IHsKLSAgICAgICAgY2Fpcm9fc2V0X29wZXJhdG9yKGNyLCBDQUlST19PUEVSQVRPUl9PVkVSKTsK LSAgICAgICAgY2Fpcm9fc2V0X3NvdXJjZV9yZ2JhKGNyLCAwLCAwLCAwLCAwLjUpOwotICAgICAg ICBjYWlyb19wYWludChjcik7Ci0gICAgfQotCiAgICAgR1RLX1dJREdFVF9DTEFTUyh3ZWJraXRf d2ViX3ZpZXdfYmFzZV9wYXJlbnRfY2xhc3MpLT5kcmF3KHdpZGdldCwgY3IpOwogCiAgICAgcmV0 dXJuIEZBTFNFOwpAQCAtNjAyLDE1ICs1OTYsMTAgQEAgc3RhdGljIHZvaWQgd2Via2l0V2ViVmll d0Jhc2VTaXplQWxsb2NhdGUoR3RrV2lkZ2V0KiB3aWRnZXQsIEd0a0FsbG9jYXRpb24qIGFsbG8K ICAgICAvLyBuZXZlciBvdmVybGFwcyB0aGUgd2ViIGluc3BlY3Rvci4gVGh1cywgd2UgbmVlZCB0 byBjYWxjdWxhdGUgdGhlIGFsbG9jYXRpb24gaGVyZQogICAgIC8vIGFmdGVyIGNhbGN1bGF0aW5n IHRoZSBpbnNwZWN0b3IgYWxsb2NhdGlvbi4KICAgICBpZiAocHJpdi0+YXV0aGVudGljYXRpb25E aWFsb2cpIHsKLSAgICAgICAgR3RrUmVxdWlzaXRpb24gbmF0dXJhbFNpemU7Ci0gICAgICAgIGd0 a193aWRnZXRfZ2V0X3ByZWZlcnJlZF9zaXplKHByaXYtPmF1dGhlbnRpY2F0aW9uRGlhbG9nLCAw LCAmbmF0dXJhbFNpemUpOwotCi0gICAgICAgIEd0a0FsbG9jYXRpb24gY2hpbGRBbGxvY2F0aW9u ID0gewotICAgICAgICAgICAgKHZpZXdSZWN0LndpZHRoKCkgLSBuYXR1cmFsU2l6ZS53aWR0aCkg LyAyLAotICAgICAgICAgICAgKHZpZXdSZWN0LmhlaWdodCgpIC0gbmF0dXJhbFNpemUuaGVpZ2h0 KSAvIDIsCi0gICAgICAgICAgICBuYXR1cmFsU2l6ZS53aWR0aCwKLSAgICAgICAgICAgIG5hdHVy YWxTaXplLmhlaWdodAotICAgICAgICB9OworICAgICAgICBHdGtSZXF1aXNpdGlvbiBtaW5pbXVt U2l6ZTsKKyAgICAgICAgZ3RrX3dpZGdldF9nZXRfcHJlZmVycmVkX3NpemUocHJpdi0+YXV0aGVu dGljYXRpb25EaWFsb2csICZtaW5pbXVtU2l6ZSwgbnVsbHB0cik7CisKKyAgICAgICAgR3RrQWxs b2NhdGlvbiBjaGlsZEFsbG9jYXRpb24gPSB7IDAsIDAsIHN0ZDo6bWF4KG1pbmltdW1TaXplLndp ZHRoLCB2aWV3UmVjdC53aWR0aCgpKSwgc3RkOjptYXgobWluaW11bVNpemUuaGVpZ2h0LCB2aWV3 UmVjdC5oZWlnaHQoKSkgfTsKICAgICAgICAgZ3RrX3dpZGdldF9zaXplX2FsbG9jYXRlKHByaXYt PmF1dGhlbnRpY2F0aW9uRGlhbG9nLCAmY2hpbGRBbGxvY2F0aW9uKTsKICAgICB9CiAK