162027 2016-09-15 12:03:51 -0700 Web Inspector: Include JavaScript completion for ES6 keywords and global variables 2016-09-20 10:41:28 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue joepeck mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1230124 0 joepeck 2016-09-15 12:03:51 -0700 Summary: Include JavaScript completion for ES6 keywords and global variables. Typing "cl" in the console should suggest "class" as an autocompletion suggestion. Same for a bunch of other ES6 keywords (yield, static, extends, super). Steps to Reproduce: 1. js> cl| => expected "class" 2. js> var myGlobalVariable; my| => expected "myGlobalVariable" 1230125 1 288983 joepeck 2016-09-15 12:06:38 -0700 Created attachment 288983 [PATCH] Proposed Fix Heh, `let` is another one we aren't completing! 1230247 2 288983 bburg 2016-09-15 16:54:24 -0700 Comment on attachment 288983 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=288983&action=review r=me > Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js:603 > + var allKeywords = [ Nit: let 1230261 3 288983 commit-queue 2016-09-15 17:22:19 -0700 Comment on attachment 288983 [PATCH] Proposed Fix Rejecting attachment 288983 from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 288983, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: ing rebase: :040000 040000 77907c2c86f9eda38945095760db12aafb727120 009c246b407568eae12025fa3be9896237e78514 M Source Current branch master is up to date. ERROR: Not all changes have been committed into SVN, however the committed ones (if any) seem to be successfully integrated into the working tree. Please see the above messages for details. Failed to run "['git', 'svn', 'dcommit', '--rmdir']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Updating OpenSource Current branch master is up to date. Full output: http://webkit-queues.webkit.org/results/2083111 1231758 4 joepeck 2016-09-20 10:41:28 -0700 <https://trac.webkit.org/changeset/206015> 288983 2016-09-15 12:06:38 -0700 2016-09-15 17:22:19 -0700 [PATCH] Proposed Fix global-vars-1.patch text/plain 5406 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGE5NGRmYjcuLjQ4NzM3MjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE2LTA5LTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSW5jbHVk ZSBKYXZhU2NyaXB0IGNvbXBsZXRpb24gZm9yIEVTNiBrZXl3b3JkcyBhbmQgZ2xvYmFsIHZhcmlh YmxlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYy MDI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBV c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlci5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Db2RlTWlycm9yQ29tcGxldGlvbkNvbnRyb2xsZXIu cHJvdG90eXBlLl9nZW5lcmF0ZUphdmFTY3JpcHRDb21wbGV0aW9ucyk6CisgICAgICAgIEluY2x1 ZGUgRVM2IGtleXdvcmRzIGFuZCBwcm92aWRlIHRoZW0gd2hlbiB0aGV5IG1heSBiZSBhdmFpbGFi bGUuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVQcm9tcHQuanM6Cisg ICAgICAgIChXZWJJbnNwZWN0b3IuQ29uc29sZVByb21wdCk6CisgICAgICAgICogVXNlckludGVy ZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRleHRFZGl0 b3IucHJvdG90eXBlLnNldCBtaW1lVHlwZSk6CisgICAgICAgIEZvciBlZGl0b3JzIHRoYXQgbWln aHQgd2FudCB0byBwcm92aWRlIGNvbXBsZXRpb24gZm9yIGdsb2JhbCB2YXJpYWJsZXMKKyAgICAg ICAgdXNlIHRoZSBtb2RlIHdpdGggb3B0aW9ucyB3YXkgb2Ygc2V0dGluZyB0aGUgbW9kZSBmb3Ig Q29kZU1pcnJvci4gVGhlCisgICAgICAgIG9ubHkgbW9kZSB0aGF0IGNhcmVzIGFib3V0ICJnbG9i YWxWYXJzIiBhcmUgdGhlIEphdmFTY3JpcHQgdmFyaWFudHMuCisKIDIwMTYtMDktMTQgIE1hdHQg QmFrZXIgIDxtYXR0YmFrZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IENh bGwgU3RhY2sgdHJlZSBpbiB0aGUgRGVidWdnZXIgc2lkZWJhciBzaG91bGQgbWFyayB0aGUgYWN0 aXZlIGNhbGwgZnJhbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlci5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0NvZGVNaXJyb3JD b21wbGV0aW9uQ29udHJvbGxlci5qcwppbmRleCA3NjZlZTQ5Li5lNjAzMDE5IDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9Db2RlTWly cm9yQ29tcGxldGlvbkNvbnRyb2xsZXIuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvQ29kZU1pcnJvckNvbXBsZXRpb25Db250cm9sbGVyLmpz CkBAIC01OTcsMTMgKzU5NywyMSBAQCBXZWJJbnNwZWN0b3IuQ29kZU1pcnJvckNvbXBsZXRpb25D b250cm9sbGVyID0gY2xhc3MgQ29kZU1pcnJvckNvbXBsZXRpb25Db250cm9sbAogICAgICAgICB2 YXIgaW5zaWRlUGFyZW50aGVzaXMgPSBsb2NhbFN0YXRlLmxleGljYWwudHlwZSA9PT0gIikiOwog ICAgICAgICB2YXIgaW5zaWRlQnJhY2tldHMgPSBsb2NhbFN0YXRlLmxleGljYWwudHlwZSA9PT0g Il0iOwogCi0gICAgICAgIHZhciBhbGxLZXl3b3JkcyA9IFsiYnJlYWsiLCAiY2FzZSIsICJjYXRj aCIsICJjb25zdCIsICJjb250aW51ZSIsICJkZWJ1Z2dlciIsICJkZWZhdWx0IiwgImRlbGV0ZSIs ICJkbyIsICJlbHNlIiwgImZhbHNlIiwgImZpbmFsbHkiLCAiZm9yIiwgImZ1bmN0aW9uIiwgImlm IiwgImluIiwKLSAgICAgICAgICAgICJJbmZpbml0eSIsICJpbnN0YW5jZW9mIiwgIk5hTiIsICJu ZXciLCAibnVsbCIsICJyZXR1cm4iLCAic3dpdGNoIiwgInRoaXMiLCAidGhyb3ciLCAidHJ1ZSIs ICJ0cnkiLCAidHlwZW9mIiwgInVuZGVmaW5lZCIsICJ2YXIiLCAidm9pZCIsICJ3aGlsZSIsICJ3 aXRoIl07CisgICAgICAgIC8vIEZJWE1FOiBJbmNsdWRlIG1vZHVsZSBrZXl3b3JkcyBpZiB3ZSBr bm93IHRoaXMgaXMgYSBtb2R1bGUgZW52aXJvbm1lbnQuCisgICAgICAgIC8vIHZhciBtb2R1bGVL ZXl3b3JkcyA9IFsiZGVmYXVsdCIsICJleHBvcnQiLCAiaW1wb3J0Il07CisKKyAgICAgICAgdmFy IGFsbEtleXdvcmRzID0gWworICAgICAgICAgICAgImJyZWFrIiwgImNhc2UiLCAiY2F0Y2giLCAi Y2xhc3MiLCAiY29uc3QiLCAiY29udGludWUiLCAiZGVidWdnZXIiLCAiZGVmYXVsdCIsCisgICAg ICAgICAgICAiZGVsZXRlIiwgImRvIiwgImVsc2UiLCAiZXh0ZW5kcyIsICJmYWxzZSIsICJmaW5h bGx5IiwgImZvciIsICJmdW5jdGlvbiIsCisgICAgICAgICAgICAiaWYiLCAiaW4iLCAiSW5maW5p dHkiLCAiaW5zdGFuY2VvZiIsICJsZXQiLCAiTmFOIiwgIm5ldyIsICJudWxsIiwgIm9mIiwKKyAg ICAgICAgICAgICJyZXR1cm4iLCAic3RhdGljIiwgInN1cGVyIiwgInN3aXRjaCIsICJ0aGlzIiwg InRocm93IiwgInRydWUiLCAidHJ5IiwKKyAgICAgICAgICAgICJ0eXBlb2YiLCAidW5kZWZpbmVk IiwgInZhciIsICJ2b2lkIiwgIndoaWxlIiwgIndpdGgiLCAieWllbGQiCisgICAgICAgIF07CiAg ICAgICAgIHZhciB2YWx1ZUtleXdvcmRzID0gWyJmYWxzZSIsICJJbmZpbml0eSIsICJOYU4iLCAi bnVsbCIsICJ0aGlzIiwgInRydWUiLCAidW5kZWZpbmVkIl07CiAKICAgICAgICAgdmFyIGFsbG93 ZWRLZXl3b3Jkc0luc2lkZUJsb2NrcyA9IGFsbEtleXdvcmRzLmtleVNldCgpOwogICAgICAgICB2 YXIgYWxsb3dlZEtleXdvcmRzV2hlbkRlY2xhcmluZ1ZhcmlhYmxlID0gdmFsdWVLZXl3b3Jkcy5r ZXlTZXQoKTsKLSAgICAgICAgdmFyIGFsbG93ZWRLZXl3b3Jkc0luc2lkZVBhcmVudGhlc2lzID0g dmFsdWVLZXl3b3Jkcy5jb25jYXQoWyJmdW5jdGlvbiJdKS5rZXlTZXQoKTsKKyAgICAgICAgdmFy IGFsbG93ZWRLZXl3b3Jkc0luc2lkZVBhcmVudGhlc2lzID0gdmFsdWVLZXl3b3Jkcy5jb25jYXQo WyJjbGFzcyIsICJmdW5jdGlvbiJdKS5rZXlTZXQoKTsKICAgICAgICAgdmFyIGFsbG93ZWRLZXl3 b3Jkc0luc2lkZUJyYWNrZXRzID0gYWxsb3dlZEtleXdvcmRzSW5zaWRlUGFyZW50aGVzaXM7CiAg ICAgICAgIHZhciBhbGxvd2VkS2V5d29yZHNPbmx5SW5zaWRlU3dpdGNoID0gWyJjYXNlIiwgImRl ZmF1bHQiXS5rZXlTZXQoKTsKIApAQCAtNjY3LDExICs2NzUsMTEgQEAgV2ViSW5zcGVjdG9yLkNv ZGVNaXJyb3JDb21wbGV0aW9uQ29udHJvbGxlciA9IGNsYXNzIENvZGVNaXJyb3JDb21wbGV0aW9u Q29udHJvbGwKIAogICAgICAgICBjYXNlICIoIjoKICAgICAgICAgICAgIG1hdGNoVmFyaWFibGVz KCk7Ci0gICAgICAgICAgICBtYXRjaEtleXdvcmRzKFsiY2F0Y2giLCAiZWxzZSIsICJmb3IiLCAi ZnVuY3Rpb24iLCAiaWYiLCAicmV0dXJuIiwgInN3aXRjaCIsICJ0aHJvdyIsICJ3aGlsZSIsICJ3 aXRoIl0pOworICAgICAgICAgICAgbWF0Y2hLZXl3b3JkcyhbImNhdGNoIiwgImVsc2UiLCAiZm9y IiwgImZ1bmN0aW9uIiwgImlmIiwgInJldHVybiIsICJzd2l0Y2giLCAidGhyb3ciLCAid2hpbGUi LCAid2l0aCIsICJ5aWVsZCJdKTsKICAgICAgICAgICAgIGJyZWFrOwogCiAgICAgICAgIGNhc2Ug InsiOgotICAgICAgICAgICAgbWF0Y2hLZXl3b3JkcyhbImRvIiwgImVsc2UiLCAiZmluYWxseSIs ICJyZXR1cm4iLCAidHJ5Il0pOworICAgICAgICAgICAgbWF0Y2hLZXl3b3JkcyhbImRvIiwgImVs c2UiLCAiZmluYWxseSIsICJyZXR1cm4iLCAidHJ5IiwgInlpZWxkIl0pOwogICAgICAgICAgICAg YnJlYWs7CiAKICAgICAgICAgY2FzZSAiOiI6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Db25zb2xlUHJvbXB0LmpzIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29uc29sZVByb21wdC5qcwppbmRleCAyMDEw ZjliLi40MzE3OTc5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Db25zb2xlUHJvbXB0LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NvbnNvbGVQcm9tcHQuanMKQEAgLTM3LDcgKzM3LDcgQEAgV2Vi SW5zcGVjdG9yLkNvbnNvbGVQcm9tcHQgPSBjbGFzcyBDb25zb2xlUHJvbXB0IGV4dGVuZHMgV2Vi SW5zcGVjdG9yLlZpZXcKIAogICAgICAgICB0aGlzLl9jb2RlTWlycm9yID0gV2ViSW5zcGVjdG9y LkNvZGVNaXJyb3JFZGl0b3IuY3JlYXRlKHRoaXMuZWxlbWVudCwgewogICAgICAgICAgICAgbGlu ZVdyYXBwaW5nOiB0cnVlLAotICAgICAgICAgICAgbW9kZTogbWltZVR5cGUsCisgICAgICAgICAg ICBtb2RlOiB7bmFtZTogbWltZVR5cGUsIGdsb2JhbFZhcnM6IHRydWV9LAogICAgICAgICAgICAg aW5kZW50V2l0aFRhYnM6IHRydWUsCiAgICAgICAgICAgICBpbmRlbnRVbml0OiA0LAogICAgICAg ICAgICAgbWF0Y2hCcmFja2V0czogdHJ1ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKaW5kZXggYjgyYTYzNi4uZjUz OGIxNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9UZXh0RWRpdG9yLmpzCkBAIC0xOTgsNyArMTk4LDcgQEAgV2ViSW5zcGVjdG9yLlRl eHRFZGl0b3IgPSBjbGFzcyBUZXh0RWRpdG9yIGV4dGVuZHMgV2ViSW5zcGVjdG9yLlZpZXcKICAg ICAgICAgbmV3TUlNRVR5cGUgPSBwYXJzZU1JTUVUeXBlKG5ld01JTUVUeXBlKS50eXBlOwogCiAg ICAgICAgIHRoaXMuX21pbWVUeXBlID0gbmV3TUlNRVR5cGU7Ci0gICAgICAgIHRoaXMuX2NvZGVN aXJyb3Iuc2V0T3B0aW9uKCJtb2RlIiwgbmV3TUlNRVR5cGUpOworICAgICAgICB0aGlzLl9jb2Rl TWlycm9yLnNldE9wdGlvbigibW9kZSIsIHtuYW1lOiBuZXdNSU1FVHlwZSwgZ2xvYmFsVmFyczog dHJ1ZX0pOwogICAgIH0KIAogICAgIGdldCBleGVjdXRpb25MaW5lTnVtYmVyKCkK