162020 2016-09-15 09:38:27 -0700 [TextureMapper] Scrolling through 01.org/dleyna crashes WebKitWebProcess 2016-09-16 03:02:11 -0700 1 1 1 Unclassified WebKit Platform WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugzilla.gnome.org/show_bug.cgi?id=771474 Gtk P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply cmarcelo commit-queue kondapallykalyan luiz noam rishi.is oldest_to_newest 1230030 0 cgarcia 2016-09-15 09:38:27 -0700 Bug forwarded from GNOME bugzilla: "Scrolling through https://01.org/dleyna/ once it has finished loading crashes WebKitWebProcess. Unfortunately, coredumpctl is unable to show the backtrace. I have: epiphany-3.20.3-1.fc24.x86_64 gtk3-3.20.9-1.fc24.x86_64 webkitgtk4-2.12.4-1.fc24.x86_64" The problem is that we are trying to clone a ReferenceFilterOperation: PassRefPtr<FilterOperation> clone() const override { // Reference filters cannot be cloned. ASSERT_NOT_REACHED(); return nullptr; } That's from FilterAnimationValue copy constructor, and FilterOperations are never expected to be nullptr, so we end up crashing. Thread 1 (Thread 0x7fc129322a80 (LWP 6125)): #0 0x00007fc127c8e74a in WebCore::FilterAnimationValue::clone() const () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #1 0x00007fc127fd118e in WebCore::TextureMapperAnimation::TextureMapperAnimation(WebCore::TextureMapperAnimation const&) () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #2 0x00007fc127fd217a in WebCore::TextureMapperAnimations::add(WebCore::TextureMapperAnimation const&) () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #3 0x00007fc127fe4d83 in WebCore::CoordinatedGraphicsLayer::addAnimation(WebCore::KeyframeValueList const&, WebCore::FloatSize const&, WebCore::Animation const*, WTF::String const&, double) () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #4 0x00007fc127c87e5a in WebCore::RenderLayerBacking::startTransition(double, WebCore::CSSPropertyID, WebCore::RenderStyle const*, WebCore::RenderStyle const*) () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #5 0x00007fc1279c657c in WebCore::AnimationBase::updateStateMachine(WebCore::AnimationBase::AnimationStateInput, double) () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #6 0x00007fc1279c90ed in WebCore::AnimationControllerPrivate::styleAvailable() () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #7 0x00007fc1279c92c5 in WebCore::AnimationControllerPrivate::endAnimationUpdate() () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #8 0x00007fc1274cc130 in WebCore::Document::recalcStyle(WebCore::Style::Change) () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #9 0x00007fc1274cb359 in WebCore::Document::updateLayout() () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #10 0x00007fc1274cdf12 in WebCore::Document::updateLayoutIgnorePendingStylesheets(WebCore::Document::RunPostLayoutTasks) () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #11 0x00007fc127942d42 in WebCore::DOMWindow::scrollY() const () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #12 0x00007fc128335fe4 in WebCore::jsDOMWindowPageYOffset(JSC::ExecState*, long, JSC::PropertyName) () from /home/cgarcia/gnome/lib/libwebkit2gtk-4.0.so.37 #13 0x00007fc1258b43e7 in JSC::PropertySlot::customGetter(JSC::ExecState*, JSC::PropertyName) const () from /home/cgarcia/gnome/lib/libjavascriptcoregtk-4.0.so.18 #14 0x00007fc125617f41 in llint_slow_path_get_by_val () from /home/cgarcia/gnome/lib/libjavascriptcoregtk-4.0.so.18 #15 0x00007fc125626b08 in llint_entry () from /home/cgarcia/gnome/lib/libjavascriptcoregtk-4.0.so.18 We just need to validate the filters before setting then and before creating a TextureMapperAnimation for them. 1230032 1 288957 cgarcia 2016-09-15 09:43:41 -0700 Created attachment 288957 Patch 1230035 2 cgarcia 2016-09-15 09:46:09 -0700 This is for CoordinatedGraphicsLayer only, but I guess we need to do the same in GraphicsLayerTextureMapper 1230050 3 288965 cgarcia 2016-09-15 10:01:19 -0700 Created attachment 288965 Updated patch Same changes in GraphicsLayerTextureMapper (untested I would need to recompile without threaded compositor). It really sucks there's so much code duplicated in GraphicsLayerTextureMapper and CoordinatedGraphicsLayer 1230365 4 cgarcia 2016-09-16 03:02:11 -0700 Committed r206019: <http://trac.webkit.org/changeset/206019> 288957 2016-09-15 09:43:41 -0700 2016-09-15 10:01:19 -0700 Patch wk2-filters-crash.diff text/plain 4666 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlY2U3NDkyLi4zM2YwNWY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMg QEAKKzIwMTYtMDktMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtDb29yZGluYXRlZCBHcmFwaGljc10gU2Nyb2xsaW5nIHRocm91Z2ggMDEu b3JnL2RsZXluYSBjcmFzaGVzIFdlYktpdFdlYlByb2Nlc3MKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE2MjAyMAorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBwcm9ibGVtIGlzIHRoYXQgd2UgYXJlIHRy eWluZyB0byBjbG9uZSBhIFJlZmVyZW5jZUZpbHRlck9wZXJhdGlvbiwgd2hpY2ggaXMgbm90IGV4 cGVjdGVkIHRvIGJlIGNsb25lZCwgZnJvbQorICAgICAgICBGaWx0ZXJBbmltYXRpb25WYWx1ZSBj b3B5IGNvbnN0cnVjdG9yLCBhbmQgRmlsdGVyT3BlcmF0aW9ucyBhcmUgbmV2ZXIgZXhwZWN0ZWQg dG8gYmUgbnVsbHB0ciwgc28gd2UgZW5kIHVwCisgICAgICAgIGNyYXNoaW5nLiBXZSBqdXN0IG5l ZWQgdG8gdmFsaWRhdGUgdGhlIGZpbHRlcnMgYmVmb3JlIHNldHRpbmcgdGhlbiBhbmQgYmVmb3Jl IGNyZWF0aW5nIGEgVGV4dHVyZU1hcHBlckFuaW1hdGlvbgorICAgICAgICBmb3IgdGhlbS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRl ZEdyYXBoaWNzTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q29vcmRpbmF0ZWRHcmFwaGlj c0xheWVyOjpmaWx0ZXJzQ2FuQmVDb21wb3NpdGVkKTogUmV0dXJuIGZhbHNlIGlmIHRoZXJlIGFy ZSByZWZlcmVuY2UgZmlsdGVycyBvciBubworICAgICAgICBmaWx0ZXJzIGF0IGFsbC4gSSBkb24n dCBrbm93IGlmIHdlIHJlYWxseSBzdXBwb3J0IG90aGVyIGZpbHRlcnMsIGJ1dCBhdCBsZWFzdCB3 ZSB3b24ndCBjcmFzaCBmb3IgdGhlIG90aGVycy4KKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5h dGVkR3JhcGhpY3NMYXllcjo6c2V0RmlsdGVycyk6IENoZWNrIGlmIGZpbHRlcnMgY2FuIGJlIGNv bXBvc2l0ZWQgYmVmb3JlIHNldHRpbmcgdGhlbS4KKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5h dGVkR3JhcGhpY3NMYXllcjo6YWRkQW5pbWF0aW9uKTogQ2hlY2sgaWYgZmlsdGVycyBjYW4gYmUg Y29tcG9zaXRlZCBiZWZvcmUgY3JlYXRpbmcgYQorICAgICAgICBUZXh0dXJlTWFwcGVyQW5pbWF0 aW9uLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29y ZGluYXRlZEdyYXBoaWNzTGF5ZXIuaDogQWRkIGhlbHBlciBmaWx0ZXJzQ2FuQmVDb21wb3NpdGVk KCkuCisKIDIwMTYtMDktMTUgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAg ICAgICAgIFJlYmFzZSBiaW5kaW5nIHRlc3RzIGFmdGVyIHIyMDU5NTMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGlu YXRlZEdyYXBoaWNzTGF5ZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKaW5kZXggNzM1 MTBhYy4uNTU2MTE3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3Jk aW5hdGVkR3JhcGhpY3NMYXllci5jcHAKQEAgLTQyNiwxOCArNDI2LDM3IEBAIHZvaWQgQ29vcmRp bmF0ZWRHcmFwaGljc0xheWVyOjpzZXRDb250ZW50c1RvUGxhdGZvcm1MYXllcihQbGF0Zm9ybUxh eWVyKiBwbGF0Zm9yCiAjZW5kaWYKIH0KIAotYm9vbCBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXI6 OnNldEZpbHRlcnMoY29uc3QgRmlsdGVyT3BlcmF0aW9ucyYgbmV3RmlsdGVycykKK2Jvb2wgQ29v cmRpbmF0ZWRHcmFwaGljc0xheWVyOjpmaWx0ZXJzQ2FuQmVDb21wb3NpdGVkKGNvbnN0IEZpbHRl ck9wZXJhdGlvbnMmIGZpbHRlcnMpCiB7Ci0gICAgaWYgKGZpbHRlcnMoKSA9PSBuZXdGaWx0ZXJz KQotICAgICAgICByZXR1cm4gdHJ1ZTsKLQotICAgIGlmICghR3JhcGhpY3NMYXllcjo6c2V0Rmls dGVycyhuZXdGaWx0ZXJzKSkKKyAgICBpZiAoIWZpbHRlcnMuc2l6ZSgpKQogICAgICAgICByZXR1 cm4gZmFsc2U7CiAKLSAgICBkaWRDaGFuZ2VGaWx0ZXJzKCk7CisgICAgZm9yIChjb25zdCBhdXRv JiBmaWx0ZXJPcGVyYXRpb24gOiBmaWx0ZXJzLm9wZXJhdGlvbnMoKSkgeworICAgICAgICBpZiAo ZmlsdGVyT3BlcmF0aW9uLT50eXBlKCkgPT0gRmlsdGVyT3BlcmF0aW9uOjpSRUZFUkVOQ0UpCisg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgfQorCiAgICAgcmV0dXJuIHRydWU7CiB9CiAK K2Jvb2wgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpzZXRGaWx0ZXJzKGNvbnN0IEZpbHRlck9w ZXJhdGlvbnMmIG5ld0ZpbHRlcnMpCit7CisgICAgYm9vbCBjYW5Db21wb3NpdGVGaWx0ZXJzID0g ZmlsdGVyc0NhbkJlQ29tcG9zaXRlZChuZXdGaWx0ZXJzKTsKKyAgICBpZiAoZmlsdGVycygpID09 IG5ld0ZpbHRlcnMpCisgICAgICAgIHJldHVybiBjYW5Db21wb3NpdGVGaWx0ZXJzOworCisgICAg aWYgKGNhbkNvbXBvc2l0ZUZpbHRlcnMpIHsKKyAgICAgICAgaWYgKCFHcmFwaGljc0xheWVyOjpz ZXRGaWx0ZXJzKG5ld0ZpbHRlcnMpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAg ICBkaWRDaGFuZ2VGaWx0ZXJzKCk7CisgICAgfSBlbHNlIGlmIChmaWx0ZXJzKCkuc2l6ZSgpKSB7 CisgICAgICAgIGNsZWFyRmlsdGVycygpOworICAgICAgICBkaWRDaGFuZ2VGaWx0ZXJzKCk7Cisg ICAgfQorCisgICAgcmV0dXJuIGNhbkNvbXBvc2l0ZUZpbHRlcnM7Cit9CisKIHZvaWQgQ29vcmRp bmF0ZWRHcmFwaGljc0xheWVyOjpzZXRDb250ZW50c1RvU29saWRDb2xvcihjb25zdCBDb2xvciYg Y29sb3IpCiB7CiAgICAgaWYgKG1fbGF5ZXJTdGF0ZS5zb2xpZENvbG9yID09IGNvbG9yKQpAQCAt MTE2Myw2ICsxMTgyLDE2IEBAIGJvb2wgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjphZGRBbmlt YXRpb24oY29uc3QgS2V5ZnJhbWVWYWx1ZUxpc3QmIHZhbHVlTGlzdCwKICAgICBpZiAoIWFuaW0g fHwgYW5pbS0+aXNFbXB0eU9yWmVyb0R1cmF0aW9uKCkgfHwgdmFsdWVMaXN0LnNpemUoKSA8IDIg fHwgKHZhbHVlTGlzdC5wcm9wZXJ0eSgpICE9IEFuaW1hdGVkUHJvcGVydHlUcmFuc2Zvcm0gJiYg dmFsdWVMaXN0LnByb3BlcnR5KCkgIT0gQW5pbWF0ZWRQcm9wZXJ0eU9wYWNpdHkgJiYgdmFsdWVM aXN0LnByb3BlcnR5KCkgIT0gQW5pbWF0ZWRQcm9wZXJ0eUZpbHRlcikpCiAgICAgICAgIHJldHVy biBmYWxzZTsKIAorICAgIGlmICh2YWx1ZUxpc3QucHJvcGVydHkoKSA9PSBBbmltYXRlZFByb3Bl cnR5RmlsdGVyKSB7CisgICAgICAgIGludCBsaXN0SW5kZXggPSB2YWxpZGF0ZUZpbHRlck9wZXJh dGlvbnModmFsdWVMaXN0KTsKKyAgICAgICAgaWYgKGxpc3RJbmRleCA8IDApCisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgY29uc3QgYXV0byYgZmlsdGVycyA9IHN0YXRpY19j YXN0PGNvbnN0IEZpbHRlckFuaW1hdGlvblZhbHVlJj4odmFsdWVMaXN0LmF0KGxpc3RJbmRleCkp LnZhbHVlKCk7CisgICAgICAgIGlmICghZmlsdGVyc0NhbkJlQ29tcG9zaXRlZChmaWx0ZXJzKSkK KyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKICAgICBib29sIGxpc3RzTWF0Y2gg PSBmYWxzZTsKICAgICBib29sIGlnbm9yZWRIYXNCaWdSb3RhdGlvbjsKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3Jk aW5hdGVkR3JhcGhpY3NMYXllci5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv dGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXllci5oCmluZGV4IGFlYWMx OTguLmQxMWJmOTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0 ZWRHcmFwaGljc0xheWVyLmgKQEAgLTIwNyw2ICsyMDcsOCBAQCBwcml2YXRlOgogCiAgICAgdm9p ZCBhbmltYXRpb25TdGFydGVkVGltZXJGaXJlZCgpOwogCisgICAgYm9vbCBmaWx0ZXJzQ2FuQmVD b21wb3NpdGVkKGNvbnN0IEZpbHRlck9wZXJhdGlvbnMmKTsKKwogICAgIENvb3JkaW5hdGVkTGF5 ZXJJRCBtX2lkOwogICAgIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllclN0YXRlIG1fbGF5ZXJTdGF0 ZTsKICAgICBHcmFwaGljc0xheWVyVHJhbnNmb3JtIG1fbGF5ZXJUcmFuc2Zvcm07Cg== 288965 2016-09-15 10:01:19 -0700 2016-09-16 01:58:24 -0700 Updated patch wk2-filters-crash.diff text/plain 8705 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBlY2U3NDkyLi4yNTZkMmQwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzAg QEAKKzIwMTYtMDktMTUgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtUZXh0dXJlTWFwcGVyXSBTY3JvbGxpbmcgdGhyb3VnaCAwMS5vcmcvZGxl eW5hIGNyYXNoZXMgV2ViS2l0V2ViUHJvY2VzcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTYyMDIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIHByb2JsZW0gaXMgdGhhdCB3ZSBhcmUgdHJ5aW5nIHRv IGNsb25lIGEgUmVmZXJlbmNlRmlsdGVyT3BlcmF0aW9uLCB3aGljaCBpcyBub3QgZXhwZWN0ZWQg dG8gYmUgY2xvbmVkLCBmcm9tCisgICAgICAgIEZpbHRlckFuaW1hdGlvblZhbHVlIGNvcHkgY29u c3RydWN0b3IsIGFuZCBGaWx0ZXJPcGVyYXRpb25zIGFyZSBuZXZlciBleHBlY3RlZCB0byBiZSBu dWxscHRyLCBzbyB3ZSBlbmQgdXAKKyAgICAgICAgY3Jhc2hpbmcuIFdlIGp1c3QgbmVlZCB0byB2 YWxpZGF0ZSB0aGUgZmlsdGVycyBiZWZvcmUgc2V0dGluZyB0aGVuIGFuZCBiZWZvcmUgY3JlYXRp bmcgYSBUZXh0dXJlTWFwcGVyQW5pbWF0aW9uCisgICAgICAgIGZvciB0aGVtLgorCisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpmaWx0ZXJz Q2FuQmVDb21wb3NpdGVkKTogUmV0dXJuIGZhbHNlIGlmIHRoZXJlIGFyZSByZWZlcmVuY2UgZmls dGVycyBvciBubworICAgICAgICBmaWx0ZXJzIGF0IGFsbC4gSSBkb24ndCBrbm93IGlmIHdlIHJl YWxseSBzdXBwb3J0IG90aGVyIGZpbHRlcnMsIGJ1dCBhdCBsZWFzdCB3ZSB3b24ndCBjcmFzaCBm b3IgdGhlIG90aGVycy4KKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFw cGVyOjphZGRBbmltYXRpb24pOiBDaGVjayBpZiBmaWx0ZXJzIGNhbiBiZSBjb21wb3NpdGVkIGJl Zm9yZSBjcmVhdGluZyBhCisgICAgICAgIFRleHR1cmVNYXBwZXJBbmltYXRpb24uCisgICAgICAg IChXZWJDb3JlOjpHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6c2V0RmlsdGVycyk6IENoZWNr IGlmIGZpbHRlcnMgY2FuIGJlIGNvbXBvc2l0ZWQgYmVmb3JlIHNldHRpbmcgdGhlbS4KKyAgICAg ICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIu aDoKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRp bmF0ZWRHcmFwaGljc0xheWVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNvb3JkaW5hdGVkR3Jh cGhpY3NMYXllcjo6ZmlsdGVyc0NhbkJlQ29tcG9zaXRlZCk6IFJldHVybiBmYWxzZSBpZiB0aGVy ZSBhcmUgcmVmZXJlbmNlIGZpbHRlcnMgb3Igbm8KKyAgICAgICAgZmlsdGVycyBhdCBhbGwuIEkg ZG9uJ3Qga25vdyBpZiB3ZSByZWFsbHkgc3VwcG9ydCBvdGhlciBmaWx0ZXJzLCBidXQgYXQgbGVh c3Qgd2Ugd29uJ3QgY3Jhc2ggZm9yIHRoZSBvdGhlcnMuCisgICAgICAgIChXZWJDb3JlOjpDb29y ZGluYXRlZEdyYXBoaWNzTGF5ZXI6OnNldEZpbHRlcnMpOiBDaGVjayBpZiBmaWx0ZXJzIGNhbiBi ZSBjb21wb3NpdGVkIGJlZm9yZSBzZXR0aW5nIHRoZW0uCisgICAgICAgIChXZWJDb3JlOjpDb29y ZGluYXRlZEdyYXBoaWNzTGF5ZXI6OmFkZEFuaW1hdGlvbik6IENoZWNrIGlmIGZpbHRlcnMgY2Fu IGJlIGNvbXBvc2l0ZWQgYmVmb3JlIGNyZWF0aW5nIGEKKyAgICAgICAgVGV4dHVyZU1hcHBlckFu aW1hdGlvbi4KKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQv Q29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmg6CisKIDIwMTYtMDktMTUgIFlvdWVubiBGYWJsZXQg IDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlYmFzZSBiaW5kaW5nIHRlc3RzIGFmdGVy IHIyMDU5NTMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3Rl eG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuY3BwCmluZGV4 IDczOGE5M2YuLmM3MjIyYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL3RleG1hcC9HcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dyYXBoaWNzTGF5ZXJUZXh0dXJlTWFw cGVyLmNwcApAQCAtNTYwLDYgKzU2MCwxOSBAQCBib29sIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFw cGVyOjpzaG91bGRIYXZlQmFja2luZ1N0b3JlKCkgY29uc3QKICAgICByZXR1cm4gZHJhd3NDb250 ZW50KCkgJiYgY29udGVudHNBcmVWaXNpYmxlKCkgJiYgIW1fc2l6ZS5pc0VtcHR5KCk7CiB9CiAK K2Jvb2wgR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OmZpbHRlcnNDYW5CZUNvbXBvc2l0ZWQo Y29uc3QgRmlsdGVyT3BlcmF0aW9ucyYgZmlsdGVycykgY29uc3QKK3sKKyAgICBpZiAoIWZpbHRl cnMuc2l6ZSgpKQorICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICBmb3IgKGNvbnN0IGF1dG8m IGZpbHRlck9wZXJhdGlvbiA6IGZpbHRlcnMub3BlcmF0aW9ucygpKSB7CisgICAgICAgIGlmIChm aWx0ZXJPcGVyYXRpb24tPnR5cGUoKSA9PSBGaWx0ZXJPcGVyYXRpb246OlJFRkVSRU5DRSkKKyAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKKyAgICByZXR1cm4gdHJ1ZTsKK30KKwog Ym9vbCBHcmFwaGljc0xheWVyVGV4dHVyZU1hcHBlcjo6YWRkQW5pbWF0aW9uKGNvbnN0IEtleWZy YW1lVmFsdWVMaXN0JiB2YWx1ZUxpc3QsIGNvbnN0IEZsb2F0U2l6ZSYgYm94U2l6ZSwgY29uc3Qg QW5pbWF0aW9uKiBhbmltLCBjb25zdCBTdHJpbmcmIGtleWZyYW1lc05hbWUsIGRvdWJsZSB0aW1l T2Zmc2V0KQogewogICAgIEFTU0VSVCgha2V5ZnJhbWVzTmFtZS5pc0VtcHR5KCkpOwpAQCAtNTY3 LDYgKzU4MCwxNiBAQCBib29sIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjphZGRBbmltYXRp b24oY29uc3QgS2V5ZnJhbWVWYWx1ZUxpc3QmIHZhbHVlTGlzdAogICAgIGlmICghYW5pbSB8fCBh bmltLT5pc0VtcHR5T3JaZXJvRHVyYXRpb24oKSB8fCB2YWx1ZUxpc3Quc2l6ZSgpIDwgMiB8fCAo dmFsdWVMaXN0LnByb3BlcnR5KCkgIT0gQW5pbWF0ZWRQcm9wZXJ0eVRyYW5zZm9ybSAmJiB2YWx1 ZUxpc3QucHJvcGVydHkoKSAhPSBBbmltYXRlZFByb3BlcnR5T3BhY2l0eSkpCiAgICAgICAgIHJl dHVybiBmYWxzZTsKIAorICAgIGlmICh2YWx1ZUxpc3QucHJvcGVydHkoKSA9PSBBbmltYXRlZFBy b3BlcnR5RmlsdGVyKSB7CisgICAgICAgIGludCBsaXN0SW5kZXggPSB2YWxpZGF0ZUZpbHRlck9w ZXJhdGlvbnModmFsdWVMaXN0KTsKKyAgICAgICAgaWYgKGxpc3RJbmRleCA8IDApCisgICAgICAg ICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgY29uc3QgYXV0byYgZmlsdGVycyA9IHN0YXRp Y19jYXN0PGNvbnN0IEZpbHRlckFuaW1hdGlvblZhbHVlJj4odmFsdWVMaXN0LmF0KGxpc3RJbmRl eCkpLnZhbHVlKCk7CisgICAgICAgIGlmICghZmlsdGVyc0NhbkJlQ29tcG9zaXRlZChmaWx0ZXJz KSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CisKICAgICBib29sIGxpc3RzTWF0 Y2ggPSBmYWxzZTsKICAgICBib29sIGhhc0JpZ1JvdGF0aW9uOwogCkBAIC02MDQsMTEgKzYyNywy MyBAQCB2b2lkIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyOjpyZW1vdmVBbmltYXRpb24oY29u c3QgU3RyaW5nJiBhbmltYXRpb25OYW1lKQogCiBib29sIEdyYXBoaWNzTGF5ZXJUZXh0dXJlTWFw cGVyOjpzZXRGaWx0ZXJzKGNvbnN0IEZpbHRlck9wZXJhdGlvbnMmIGZpbHRlcnMpCiB7Ci0gICAg VGV4dHVyZU1hcHBlciogdGV4dHVyZU1hcHBlciA9IG1fbGF5ZXIudGV4dHVyZU1hcHBlcigpOwot ICAgIGlmICghdGV4dHVyZU1hcHBlcikKKyAgICBpZiAoIW1fbGF5ZXIudGV4dHVyZU1hcHBlcigp KQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgbm90aWZ5Q2hhbmdlKEZpbHRlckNoYW5nZSk7 Ci0gICAgcmV0dXJuIEdyYXBoaWNzTGF5ZXI6OnNldEZpbHRlcnMoZmlsdGVycyk7CisKKyAgICBi b29sIGNhbkNvbXBvc2l0ZUZpbHRlcnMgPSBmaWx0ZXJzQ2FuQmVDb21wb3NpdGVkKGZpbHRlcnMp OworICAgIGlmIChHcmFwaGljc0xheWVyOjpmaWx0ZXJzKCkgPT0gZmlsdGVycykKKyAgICAgICAg cmV0dXJuIGNhbkNvbXBvc2l0ZUZpbHRlcnM7CisKKyAgICBpZiAoY2FuQ29tcG9zaXRlRmlsdGVy cykgeworICAgICAgICBpZiAoIUdyYXBoaWNzTGF5ZXI6OnNldEZpbHRlcnMoZmlsdGVycykpCisg ICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgICAgIG5vdGlmeUNoYW5nZShGaWx0ZXJDaGFu Z2UpOworICAgIH0gZWxzZSBpZiAoR3JhcGhpY3NMYXllcjo6ZmlsdGVycygpLnNpemUoKSkgewor ICAgICAgICBjbGVhckZpbHRlcnMoKTsKKyAgICAgICAgbm90aWZ5Q2hhbmdlKEZpbHRlckNoYW5n ZSk7CisgICAgfQorCisgICAgcmV0dXJuIGNhbkNvbXBvc2l0ZUZpbHRlcnM7CiB9CiAKIHZvaWQg R3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXI6OnNldEZpeGVkVG9WaWV3cG9ydChib29sIGZpeGVk KQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL0dy YXBoaWNzTGF5ZXJUZXh0dXJlTWFwcGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuaAppbmRleCA0Y2NkMzhlLi42 YzFlY2Y5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXht YXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy90ZXhtYXAvR3JhcGhpY3NMYXllclRleHR1cmVNYXBwZXIuaApAQCAtMTE3 LDYgKzExNyw4IEBAIHByaXZhdGU6CiAgICAgdm9pZCBwcmVwYXJlQmFja2luZ1N0b3JlSWZOZWVk ZWQoKTsKICAgICBib29sIHNob3VsZEhhdmVCYWNraW5nU3RvcmUoKSBjb25zdDsKIAorICAgIGJv b2wgZmlsdGVyc0NhbkJlQ29tcG9zaXRlZChjb25zdCBGaWx0ZXJPcGVyYXRpb25zJikgY29uc3Q7 CisKICAgICAvLyBUaGlzIHNldCBvZiBmbGFncyBoZWxwIHVzIGRlZmVyIHdoaWNoIHByb3BlcnRp ZXMgb2YgdGhlIGxheWVyIGhhdmUgYmVlbgogICAgIC8vIG1vZGlmaWVkIGJ5IHRoZSBjb21wb3Np dG9yLCBzbyB3ZSBjYW4ga25vdyB3aGF0IHRvIGxvb2sgZm9yIGluIHRoZSBuZXh0IGZsdXNoLgog ICAgIGVudW0gQ2hhbmdlTWFzayB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy90ZXhtYXAvY29vcmRpbmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9D b29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCmluZGV4IDczNTEwYWMuLjc0OGFkOGUgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRl ZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIu Y3BwCkBAIC00MjYsMTggKzQyNiwzNyBAQCB2b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6 c2V0Q29udGVudHNUb1BsYXRmb3JtTGF5ZXIoUGxhdGZvcm1MYXllciogcGxhdGZvcgogI2VuZGlm CiB9CiAKLWJvb2wgQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyOjpzZXRGaWx0ZXJzKGNvbnN0IEZp bHRlck9wZXJhdGlvbnMmIG5ld0ZpbHRlcnMpCitib29sIENvb3JkaW5hdGVkR3JhcGhpY3NMYXll cjo6ZmlsdGVyc0NhbkJlQ29tcG9zaXRlZChjb25zdCBGaWx0ZXJPcGVyYXRpb25zJiBmaWx0ZXJz KSBjb25zdAogewotICAgIGlmIChmaWx0ZXJzKCkgPT0gbmV3RmlsdGVycykKLSAgICAgICAgcmV0 dXJuIHRydWU7Ci0KLSAgICBpZiAoIUdyYXBoaWNzTGF5ZXI6OnNldEZpbHRlcnMobmV3RmlsdGVy cykpCisgICAgaWYgKCFmaWx0ZXJzLnNpemUoKSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0g ICAgZGlkQ2hhbmdlRmlsdGVycygpOworICAgIGZvciAoY29uc3QgYXV0byYgZmlsdGVyT3BlcmF0 aW9uIDogZmlsdGVycy5vcGVyYXRpb25zKCkpIHsKKyAgICAgICAgaWYgKGZpbHRlck9wZXJhdGlv bi0+dHlwZSgpID09IEZpbHRlck9wZXJhdGlvbjo6UkVGRVJFTkNFKQorICAgICAgICAgICAgcmV0 dXJuIGZhbHNlOworICAgIH0KKwogICAgIHJldHVybiB0cnVlOwogfQogCitib29sIENvb3JkaW5h dGVkR3JhcGhpY3NMYXllcjo6c2V0RmlsdGVycyhjb25zdCBGaWx0ZXJPcGVyYXRpb25zJiBuZXdG aWx0ZXJzKQoreworICAgIGJvb2wgY2FuQ29tcG9zaXRlRmlsdGVycyA9IGZpbHRlcnNDYW5CZUNv bXBvc2l0ZWQobmV3RmlsdGVycyk7CisgICAgaWYgKGZpbHRlcnMoKSA9PSBuZXdGaWx0ZXJzKQor ICAgICAgICByZXR1cm4gY2FuQ29tcG9zaXRlRmlsdGVyczsKKworICAgIGlmIChjYW5Db21wb3Np dGVGaWx0ZXJzKSB7CisgICAgICAgIGlmICghR3JhcGhpY3NMYXllcjo6c2V0RmlsdGVycyhuZXdG aWx0ZXJzKSkKKyAgICAgICAgICAgIHJldHVybiBmYWxzZTsKKyAgICAgICAgZGlkQ2hhbmdlRmls dGVycygpOworICAgIH0gZWxzZSBpZiAoZmlsdGVycygpLnNpemUoKSkgeworICAgICAgICBjbGVh ckZpbHRlcnMoKTsKKyAgICAgICAgZGlkQ2hhbmdlRmlsdGVycygpOworICAgIH0KKworICAgIHJl dHVybiBjYW5Db21wb3NpdGVGaWx0ZXJzOworfQorCiB2b2lkIENvb3JkaW5hdGVkR3JhcGhpY3NM YXllcjo6c2V0Q29udGVudHNUb1NvbGlkQ29sb3IoY29uc3QgQ29sb3ImIGNvbG9yKQogewogICAg IGlmIChtX2xheWVyU3RhdGUuc29saWRDb2xvciA9PSBjb2xvcikKQEAgLTExNjMsNiArMTE4Miwx NiBAQCBib29sIENvb3JkaW5hdGVkR3JhcGhpY3NMYXllcjo6YWRkQW5pbWF0aW9uKGNvbnN0IEtl eWZyYW1lVmFsdWVMaXN0JiB2YWx1ZUxpc3QsCiAgICAgaWYgKCFhbmltIHx8IGFuaW0tPmlzRW1w dHlPclplcm9EdXJhdGlvbigpIHx8IHZhbHVlTGlzdC5zaXplKCkgPCAyIHx8ICh2YWx1ZUxpc3Qu cHJvcGVydHkoKSAhPSBBbmltYXRlZFByb3BlcnR5VHJhbnNmb3JtICYmIHZhbHVlTGlzdC5wcm9w ZXJ0eSgpICE9IEFuaW1hdGVkUHJvcGVydHlPcGFjaXR5ICYmIHZhbHVlTGlzdC5wcm9wZXJ0eSgp ICE9IEFuaW1hdGVkUHJvcGVydHlGaWx0ZXIpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAKKyAg ICBpZiAodmFsdWVMaXN0LnByb3BlcnR5KCkgPT0gQW5pbWF0ZWRQcm9wZXJ0eUZpbHRlcikgewor ICAgICAgICBpbnQgbGlzdEluZGV4ID0gdmFsaWRhdGVGaWx0ZXJPcGVyYXRpb25zKHZhbHVlTGlz dCk7CisgICAgICAgIGlmIChsaXN0SW5kZXggPCAwKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNl OworCisgICAgICAgIGNvbnN0IGF1dG8mIGZpbHRlcnMgPSBzdGF0aWNfY2FzdDxjb25zdCBGaWx0 ZXJBbmltYXRpb25WYWx1ZSY+KHZhbHVlTGlzdC5hdChsaXN0SW5kZXgpKS52YWx1ZSgpOworICAg ICAgICBpZiAoIWZpbHRlcnNDYW5CZUNvbXBvc2l0ZWQoZmlsdGVycykpCisgICAgICAgICAgICBy ZXR1cm4gZmFsc2U7CisgICAgfQorCiAgICAgYm9vbCBsaXN0c01hdGNoID0gZmFsc2U7CiAgICAg Ym9vbCBpZ25vcmVkSGFzQmlnUm90YXRpb247CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGluYXRlZC9Db29yZGluYXRlZEdyYXBoaWNz TGF5ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9jb29yZGlu YXRlZC9Db29yZGluYXRlZEdyYXBoaWNzTGF5ZXIuaAppbmRleCBhZWFjMTk4Li4zNzk5OTM5IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvY29vcmRp bmF0ZWQvQ29vcmRpbmF0ZWRHcmFwaGljc0xheWVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvdGV4bWFwL2Nvb3JkaW5hdGVkL0Nvb3JkaW5hdGVkR3JhcGhpY3NMYXll ci5oCkBAIC0yMDcsNiArMjA3LDggQEAgcHJpdmF0ZToKIAogICAgIHZvaWQgYW5pbWF0aW9uU3Rh cnRlZFRpbWVyRmlyZWQoKTsKIAorICAgIGJvb2wgZmlsdGVyc0NhbkJlQ29tcG9zaXRlZChjb25z dCBGaWx0ZXJPcGVyYXRpb25zJikgY29uc3Q7CisKICAgICBDb29yZGluYXRlZExheWVySUQgbV9p ZDsKICAgICBDb29yZGluYXRlZEdyYXBoaWNzTGF5ZXJTdGF0ZSBtX2xheWVyU3RhdGU7CiAgICAg R3JhcGhpY3NMYXllclRyYW5zZm9ybSBtX2xheWVyVHJhbnNmb3JtOwo=