162015 2016-09-15 04:45:38 -0700 [Win] run-api-tests is failing. 2016-09-15 08:49:10 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pvollan pvollan achristensen bfulgham commit-queue lforschler oldest_to_newest 1229983 0 pvollan 2016-09-15 04:45:38 -0700 This is caused by MSVC not interpreting C++ string literals with unicode characters correctly when the source file does not contain encoding information. 1229984 1 288951 pvollan 2016-09-15 04:52:34 -0700 Created attachment 288951 Patch 1229985 2 commit-queue 2016-09-15 04:55:03 -0700 Attachment 288951 did not pass style-queue: ERROR: Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:1: Missing spaces around / [whitespace/operators] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1229997 3 288951 bfulgham 2016-09-15 07:15:28 -0700 Comment on attachment 288951 Patch R=me 1230014 4 pvollan 2016-09-15 08:46:20 -0700 Thanks for reviewing! 1230015 5 288951 commit-queue 2016-09-15 08:49:07 -0700 Comment on attachment 288951 Patch Clearing flags on attachment: 288951 Committed r205971: <http://trac.webkit.org/changeset/205971> 1230016 6 commit-queue 2016-09-15 08:49:10 -0700 All reviewed patches have been landed. Closing bug. 288951 2016-09-15 04:52:34 -0700 2016-09-15 08:49:07 -0700 Patch bug-162015-20160915044957.patch text/plain 1182 pvollan SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIwNTk2NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE2LTA5LTE1ICBQZXIgQXJuZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNv bT4KKworICAgICAgICBbV2luXSBydW4tYXBpLXRlc3RzIGlzIGZhaWxpbmcuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNjIwMTUKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBNU1ZDIGlzIG5vdCBpbnRlcnBy ZXRpbmcgQysrIHN0cmluZyBsaXRlcmFscyB3aXRoIHVuaWNvZGUgY2hhcmFjdGVycyBjb3JyZWN0 bHkgd2hlbiB0aGUgc291cmNlIGZpbGUKKyAgICAgICAgZG9lc24ndCBjb250YWluIGVuY29kaW5n IGluZm9ybWF0aW9uLiBTYXZlIHRoZSBmaWxlIHdpdGggdXRmOCBlbmNvZGluZyB3aXRoIHNpZ25h dHVyZS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIu Y3BwOgorCiAyMDE2LTA5LTE1ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+ CiAKICAgICAgICAganMvc3RyaW5naW1wbC10by1qc3N0cmluZy1vbi1sYXJnZS1zdHJpbmdzIHRl c3RzIGNvbnN1bWUgaHVnZSBtZW1vcnkKSW5kZXg6IFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMv V2ViQ29yZS9VUkxQYXJzZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RXZWJLaXRBUEkv VGVzdHMvV2ViQ29yZS9VUkxQYXJzZXIuY3BwCShyZXZpc2lvbiAyMDU4NTYpCisrKyBUb29scy9U ZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYkNvcmUvVVJMUGFyc2VyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMSw0ICsxLDQgQEAKLS8qCivvu78vKgogICogQ29weXJpZ2h0IChDKSAyMDE2IEFwcGxlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGlu IHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQK